@carecard/validate 3.18.0 → 3.19.0

package/.github/workflows/auto-draft-pr.yml

@@ -20,158 +20,180 @@ name: Auto Draft PR
 # names such as `feature/foo/bar`, `fix/bug-1`, `hotfix/...`, etc.
 
 on:
-    push:
-        branches:
-            - 'feature/**'
-            - 'feat/**'
-            - 'improvement/**'
-            - 'releases/**'
-            - 'release*'
-            - 'hotfix/**'
-            - 'iss/**'
-            - 'fix/**'
-            - 'main-*'
-            - 'main-**'
-            - 'data**'
-            - 'data/**'
-        paths-ignore:
-            - '**.md'
-    workflow_dispatch:
+  push:
+    branches:
+      - 'feature/**'
+      - 'feat/**'
+      - 'improvement/**'
+      - 'releases/**'
+      - 'release*'
+      - 'hotfix/**'
+      - 'iss/**'
+      - 'fix/**'
+      - 'main-*'
+      - 'main-**'
+      - 'data**'
+      - 'data/**'
+    paths-ignore:
+      - '**.md'
+  workflow_dispatch:
 
 permissions:
-    contents: read
-    issues: write
-    pull-requests: write
+  contents: read
+  issues: write
+  pull-requests: write
 
 jobs:
-    open-draft-pr:
-        runs-on: ubuntu-latest
-
-        steps:
-            - name: Determine target base branch
-              id: target
-              env:
-                  HEAD_BRANCH: ${{ github.ref_name }}
-              run: |
-                  set -euo pipefail
-                  echo "Head branch: $HEAD_BRANCH"
-
-                  # Skip protected/base branches – we never open a PR from them to themselves.
-                  case "$HEAD_BRANCH" in
-                    main|master|development|develop)
-                      echo "Branch '$HEAD_BRANCH' is a base branch – skipping PR creation."
-                      echo "skip=true" >> "$GITHUB_OUTPUT"
-                      exit 0
-                      ;;
-                  esac
-
-                  if [[ "$HEAD_BRANCH" == main-* ]]; then
-                    BASE="main"
-                  else
-                    BASE="development"
-                  fi
-
-                  echo "Target base branch: $BASE"
-                  echo "base=$BASE"          >> "$GITHUB_OUTPUT"
-                  echo "head=$HEAD_BRANCH"   >> "$GITHUB_OUTPUT"
-                  echo "skip=false"          >> "$GITHUB_OUTPUT"
-
-            - name: Checkout repository
-              if: steps.target.outputs.skip == 'false'
-              uses: actions/checkout@v7
-              with:
-                  fetch-depth: 0
-
-            - name: Create draft Pull Request (if missing)
-              if: steps.target.outputs.skip == 'false'
-              env:
-                  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-                  HEAD: ${{ steps.target.outputs.head }}
-                  BASE: ${{ steps.target.outputs.base }}
-                  REPO: ${{ github.repository }}
-                  PR_ASSIGNEE: ${{ github.actor }}
-                  PR_REVIEWER: singh-pankaj-k
-              run: |
-                  set -euo pipefail
-
-                  # Avoid creating duplicates: check for an existing open PR for this head -> base.
-                  # `gh pr list --head` expects the branch name (without owner prefix) for same-repo PRs.
-                  EXISTING=$(gh pr list \
-                    --repo "$REPO" \
-                    --state open \
-                    --head "$HEAD" \
-                    --base "$BASE" \
-                    --json number \
-                    --jq '.[0].number')
-
-                  if [[ -n "${EXISTING:-}" ]]; then
-                    echo "An open PR already exists for $HEAD -> $BASE (#$EXISTING). Updating PR metadata."
-                    PR_NUMBER="$EXISTING"
-                  else
-                    TITLE="Draft: merge \`$HEAD\` into \`$BASE\`"
-                    BODY=$'Auto-created draft PR for branch `'"$HEAD"$'`.\n\nTarget base: `'"$BASE"$'`\n\nMark this PR as ready for review when you want it to be reviewed/merged.'
-
-                    gh pr create \
-                      --repo "$REPO" \
-                      --draft \
-                      --base "$BASE" \
-                      --head "$HEAD" \
-                      --title "$TITLE" \
-                      --body  "$BODY"
-
-                    PR_NUMBER=$(gh pr list \
-                      --repo "$REPO" \
-                      --state open \
-                      --head "$HEAD" \
-                      --base "$BASE" \
-                      --json number \
-                      --jq '.[0].number')
-                  fi
-
-                  gh pr edit "$PR_NUMBER" \
-                    --repo "$REPO" \
-                    --add-assignee "$PR_ASSIGNEE"
-
-                  PR_AUTHOR=$(gh pr view "$PR_NUMBER" \
-                    --repo "$REPO" \
-                    --json author \
-                    --jq '.author.login')
-
-                  if [[ "$PR_AUTHOR" == "$PR_REVIEWER" ]]; then
-                    echo "Skipping reviewer request because $PR_REVIEWER is the PR author."
-                  else
-                    gh pr edit "$PR_NUMBER" \
-                      --repo "$REPO" \
-                      --add-reviewer "$PR_REVIEWER"
-                  fi
-
-            - name: Assign matching issue ticket (best effort)
-              if: steps.target.outputs.skip == 'false'
-              env:
-                  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-                  HEAD: ${{ steps.target.outputs.head }}
-                  REPO: ${{ github.repository }}
-                  PR_ASSIGNEE: ${{ github.actor }}
-              run: |
-                  set -euo pipefail
-
-                  TICKET_NUMBER=""
-                  if [[ "$HEAD" =~ (^|/)(iss|issue|issues)[/-]?#?([0-9]+)([^0-9]|$) ]]; then
-                    TICKET_NUMBER="${BASH_REMATCH[3]}"
-                  fi
-
-                  if [[ -z "$TICKET_NUMBER" ]]; then
-                    echo "No GitHub issue ticket number found in branch '$HEAD'. Skipping ticket assignment."
-                    exit 0
-                  fi
-
-                  if ! gh issue view "$TICKET_NUMBER" --repo "$REPO" --json number; then
-                    echo "GitHub issue #$TICKET_NUMBER was not found. Skipping ticket assignment."
-                    exit 0
-                  fi
-
-                  if gh issue edit "$TICKET_NUMBER" --repo "$REPO" --add-assignee "$PR_ASSIGNEE"; then
-                    echo "Assigned issue ticket #$TICKET_NUMBER to $PR_ASSIGNEE."
-                  else
-                    echo "::warning::Could not assign issue ticket #$TICKET_NUMBER to $PR_ASSIGNEE."
-                  fi
+  open-draft-pr:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Determine target base branch
+        id: target
+        env:
+          HEAD_BRANCH: ${{ github.ref_name }}
+        run: |
+          set -euo pipefail
+          echo "Head branch: $HEAD_BRANCH"
+
+          # Skip protected/base branches – we never open a PR from them to themselves.
+          case "$HEAD_BRANCH" in
+            main|master|development|develop)
+              echo "Branch '$HEAD_BRANCH' is a base branch – skipping PR creation."
+              echo "skip=true" >> "$GITHUB_OUTPUT"
+              exit 0
+              ;;
+          esac
+
+          if [[ "$HEAD_BRANCH" == main-* ]]; then
+            BASE="main"
+          else
+            BASE="development"
+          fi
+
+          echo "Target base branch: $BASE"
+          echo "base=$BASE"          >> "$GITHUB_OUTPUT"
+          echo "head=$HEAD_BRANCH"   >> "$GITHUB_OUTPUT"
+          echo "skip=false"          >> "$GITHUB_OUTPUT"
+
+      - name: Checkout repository
+        if: steps.target.outputs.skip == 'false'
+        uses: actions/checkout@v7
+        with:
+          fetch-depth: 0
+
+      - name: Create draft Pull Request (if missing)
+        if: steps.target.outputs.skip == 'false'
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          HEAD: ${{ steps.target.outputs.head }}
+          BASE: ${{ steps.target.outputs.base }}
+          REPO: ${{ github.repository }}
+          PR_ASSIGNEE: ${{ github.actor }}
+          PR_REVIEWER: singh-pankaj-k
+        run: |
+          set -euo pipefail
+
+          # Pattern: Query Object - resolves the exact open PR for this head and base.
+          find_open_pull_request() {
+            gh pr list \
+              --repo "$REPO" \
+              --state open \
+              --head "$HEAD" \
+              --base "$BASE" \
+              --json number \
+              --jq '.[0].number // empty'
+          }
+
+          PR_NUMBER="$(find_open_pull_request)"
+          if [[ -n "$PR_NUMBER" ]]; then
+            echo "An open PR already exists for $HEAD -> $BASE (#$PR_NUMBER). Updating PR metadata."
+          else
+            TITLE="Draft: merge \`$HEAD\` into \`$BASE\`"
+            BODY=$'Auto-created draft PR for branch `'"$HEAD"$'`.\n\nTarget base: `'"$BASE"$'`\n\nMark this PR as ready for review when you want it to be reviewed/merged.'
+
+            CREATE_OUTPUT=""
+            if CREATE_OUTPUT="$(gh pr create \
+              --repo "$REPO" \
+              --draft \
+              --base "$BASE" \
+              --head "$HEAD" \
+              --title "$TITLE" \
+              --body "$BODY" 2>&1)"; then
+              printf '%s\n' "$CREATE_OUTPUT"
+            else
+              CREATE_STATUS=$?
+              if PR_NUMBER="$(find_open_pull_request)"; then
+                :
+              else
+                RECOVERY_STATUS=$?
+                printf '%s\n' "$CREATE_OUTPUT" >&2
+                exit "$RECOVERY_STATUS"
+              fi
+
+              if [[ -z "$PR_NUMBER" ]]; then
+                printf '%s\n' "$CREATE_OUTPUT" >&2
+                exit "$CREATE_STATUS"
+              fi
+
+              echo "Another workflow run created PR #$PR_NUMBER for $HEAD -> $BASE."
+            fi
+
+            if [[ -z "$PR_NUMBER" ]]; then
+              PR_NUMBER="$(find_open_pull_request)"
+            fi
+          fi
+
+          if [[ ! "$PR_NUMBER" =~ ^[1-9][0-9]*$ ]]; then
+            printf 'Expected an open PR number for %s -> %s, got %q\n' \
+              "$HEAD" "$BASE" "$PR_NUMBER" >&2
+            exit 1
+          fi
+
+          gh pr edit "$PR_NUMBER" \
+            --repo "$REPO" \
+            --add-assignee "$PR_ASSIGNEE"
+
+          PR_AUTHOR=$(gh pr view "$PR_NUMBER" \
+            --repo "$REPO" \
+            --json author \
+            --jq '.author.login')
+
+          if [[ "$PR_AUTHOR" == "$PR_REVIEWER" ]]; then
+            echo "Skipping reviewer request because $PR_REVIEWER is the PR author."
+          else
+            gh pr edit "$PR_NUMBER" \
+              --repo "$REPO" \
+              --add-reviewer "$PR_REVIEWER"
+          fi
+
+      - name: Assign matching issue ticket (best effort)
+        if: steps.target.outputs.skip == 'false'
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          HEAD: ${{ steps.target.outputs.head }}
+          REPO: ${{ github.repository }}
+          PR_ASSIGNEE: ${{ github.actor }}
+        run: |
+          set -euo pipefail
+
+          TICKET_NUMBER=""
+          if [[ "$HEAD" =~ (^|/)(iss|issue|issues)[/-]?#?([0-9]+)([^0-9]|$) ]]; then
+            TICKET_NUMBER="${BASH_REMATCH[3]}"
+          fi
+
+          if [[ -z "$TICKET_NUMBER" ]]; then
+            echo "No GitHub issue ticket number found in branch '$HEAD'. Skipping ticket assignment."
+            exit 0
+          fi
+
+          if ! gh issue view "$TICKET_NUMBER" --repo "$REPO" --json number; then
+            echo "GitHub issue #$TICKET_NUMBER was not found. Skipping ticket assignment."
+            exit 0
+          fi
+
+          if gh issue edit "$TICKET_NUMBER" --repo "$REPO" --add-assignee "$PR_ASSIGNEE"; then
+            echo "Assigned issue ticket #$TICKET_NUMBER to $PR_ASSIGNEE."
+          else
+            echo "::warning::Could not assign issue ticket #$TICKET_NUMBER to $PR_ASSIGNEE."
+          fi

package/.github/workflows/ci.yml

@@ -1,42 +1,45 @@
 name: CI_Tests
 
 on:
-    push:
-        branches:
-            - development
-            - main
-    pull_request:
-        branches:
-            - development
-            - main
-        types:
-            - opened
-            - reopened
-            - synchronize
-            - ready_for_review
-        paths-ignore:
-            - '**.md'
+  push:
+    branches:
+      - development
+      - main
+  pull_request:
+    branches:
+      - development
+      - main
+    types:
+      - opened
+      - reopened
+      - synchronize
+      - ready_for_review
+    paths-ignore:
+      - '**.md'
 
 jobs:
-    test:
-        name: CI_Tests
-        runs-on: ubuntu-latest
+  test:
+    name: CI_Tests
+    runs-on: ubuntu-latest
 
-        steps:
-            - name: Checkout repository
-              uses: actions/checkout@v7
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v7
 
-            - name: Set up Node.js
-              uses: actions/setup-node@v6
-              with:
-                  node-version: 24.18.0
-                  cache: 'npm'
+      - name: Set up Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: 24.18.0
+          cache: 'npm'
 
-            - name: Install dependencies
-              run: npm ci
+      - name: Install dependencies
+        run: npm ci
 
-            - name: Run tests
-              run: npm run test:All
+      - name: Run lint
+        run: npm run lint
 
-            - name: Run tests with coverage
-              run: npm run test:coverage
+      - name: Check formatting
+        run: npm run format:check
+
+      - name: Run complete test suite
+        run: npm test

package/.husky/pre-commit

@@ -3,8 +3,8 @@ set -eu
 repository_root="$(CDPATH= cd -- "$(dirname -- "$0")/.." && pwd)"
 cd "$repository_root"
 
-npm run lint:fix
-npm run format
+npm run lint-staged
+npm run lint
+npm run format:check
 
-# Run tests
-npm run test:All
+npm test

package/.prettierrc.js

@@ -1,11 +1,12 @@
 module.exports = {
-    arrowParens: 'avoid',
-    bracketSameLine: true,
-    bracketSpacing: true,
-    singleQuote: true,
-    trailingComma: 'all',
-    printWidth: 140,
-    tabWidth: 4,
-    useTabs: false,
-    endOfLine: 'auto',
+  arrowParens: 'avoid',
+  bracketSameLine: true,
+  bracketSpacing: true,
+  singleQuote: true,
+  trailingComma: 'all',
+  printWidth: 100,
+  semi: true,
+  tabWidth: 2,
+  useTabs: false,
+  endOfLine: 'lf',
 };

package/AGENTS.md

@@ -13,3 +13,22 @@
 Non-negotiable repository isolation rule: Every repository must run its Husky hooks and tests using only files, code, fixtures, dependencies, and services contained within that repository. Tests and Husky scripts must not import, require, read, execute, or otherwise depend on sibling repositories or paths outside the repository root. app-e2e-tests is the only exception because cross-repository end-to-end testing is its explicit responsibility.
 
 Non-negotiable code organization rule: Functions with the same or equivalent behavior must use the same or clearly corresponding descriptive names across CareCard repositories, and equivalent functionality must live in files with the same names within each repository's established architecture. No backward compatibility names, aliases, or duplicate locations are allowed.
+
+## TDD And Validation
+
+Test Driven Development is a non-negotiable requirement.
+
+The sole purpose of automated tests is to verify observable functionality and externally visible behavior.
+Tests must validate what the system does through its public interfaces and expected outcomes.
+
+Tests must not assert, inspect, or depend on implementation details, including but not limited to:
+
+- The existence of specific lines of code, statements, functions, classes, files, or modules.
+- Specific algorithms, control flow, variable names, method calls, code snippets, or internal implementation choices.
+- Any internal structure that can change without changing externally observable behavior.
+
+A correct implementation may be completely rewritten or refactored without requiring changes to functional tests, provided its externally observable behavior remains unchanged.
+
+Any test that fails solely because the implementation changed while the externally observable behavior remained correct is incorrectly designed and must be rewritten or removed.
+
+This requirement is mandatory for all new tests and must be applied whenever existing tests are modified.

package/eslint.config.mjs

@@ -1,14 +1,66 @@
+import js from '@eslint/js';
+import tsParser from '@typescript-eslint/parser';
 import { defineConfig, globalIgnores } from 'eslint/config';
+import globals from 'globals';
 
 const eslintConfig = defineConfig([
-    globalIgnores([
-        // Default ignores of eslint-config-next:
-        '.next/**',
-        'out/**',
-        'build/**',
-        'next-env.d.ts',
-        'node_modules/**',
-    ]),
+  globalIgnores([
+    // Default ignores of eslint-config-next:
+    '.next/**',
+    'out/**',
+    'build/**',
+    'next-env.d.ts',
+    'node_modules/**',
+    'coverage/**',
+    'dist/**',
+  ]),
+  {
+    name: 'carecard/braced-control-flow',
+    files: ['**/*.{js,jsx,mjs,cjs,ts,tsx,mts,cts}'],
+    languageOptions: {
+      ecmaVersion: 'latest',
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+    },
+    rules: {
+      curly: ['error', 'all'],
+    },
+  },
+  {
+    name: 'carecard/javascript-recommended',
+    files: ['**/*.{js,jsx,mjs,cjs}'],
+    languageOptions: {
+      ecmaVersion: 'latest',
+      sourceType: 'commonjs',
+      globals: {
+        ...globals.node,
+        ...globals.mocha,
+      },
+    },
+    rules: {
+      ...js.configs.recommended.rules,
+      eqeqeq: ['error', 'smart'],
+      'no-unused-vars': ['error', { argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' }],
+      'no-var': 'error',
+    },
+  },
+  {
+    name: 'carecard/esm-source-type',
+    files: ['**/*.mjs'],
+    languageOptions: {
+      sourceType: 'module',
+    },
+  },
+  {
+    name: 'carecard/typescript-parser',
+    files: ['**/*.{ts,tsx,mts,cts}'],
+    languageOptions: {
+      parser: tsParser,
+    },
+  },
 ]);
 
 export default eslintConfig;