@carecard/validate 3.12.0 → 3.13.0

package/.agents/skills/carecard-workspace-standards/SKILL.md

@@ -7,6 +7,10 @@ Non-negotiable root-cause solution rule: Always identify and solve the verified
 
 # CareCard Workspace Standards
 
+Non-negotiable test order invariance rule: Every test must pass independently of which tests run before or after it, and the suite must pass in every execution order. Each test must establish the state it needs, isolate mutable state, and clean up state it owns; it must never rely on another test's setup, mutations, or cleanup. Default test, CI, and Husky commands must use the test framework's ordinary ordering and must not force randomized ordering. Random-order execution is an explicit diagnostic only, and every failure it exposes must be fixed at the root cause.
+
+Non-negotiable parallel test execution rule: Run independent test files in parallel with repository-native worker support wherever resource isolation makes parallel execution safe. Tests that share a mutable database, application server, browser state, filesystem fixture, port, or cluster resource must remain in an explicitly isolated serial group until every worker owns a separate resource. Parallel execution must preserve ordinary test selection and must never use randomized ordering, retries, locks, or error suppression to conceal coupling.
+
 Non-negotiable TDD rule: Always write the failing test first, run it to confirm it fails for the intended reason, then implement the code and rerun the test until it passes. Test Driven Development is required for all coding work and must not be skipped. For documentation- or skill-only edits, add or update the relevant validation check before changing the prose.
 
 This requirement is non-negotiable and may be overridden only with the user's
@@ -26,6 +30,8 @@ Non-negotiable repository isolation rule: Every repository must run its Husky ho
 
 Non-negotiable error and warning rule: Never suppress, silence, hide, downgrade, filter, ignore, skip, or bypass errors or warnings from code, tests, tools, compilers, linters, or validation. Fix the root cause, then rerun the affected check and require a clean result. Expected error-path tests may assert errors, but must not conceal unexpected failures.
 
+Non-negotiable TypeScript type rule: Never use the TypeScript type `any`; always use specific domain types, generics, existing project types, or `unknown` with explicit narrowing in all TypeScript-family files (`.ts`, `.tsx`, `.mts`, `.cts`, and `.d.ts`).
+
 Non-negotiable code organization rule: Functions with the same or equivalent behavior must use the same or clearly corresponding descriptive names across CareCard repositories, and equivalent functionality must live in files with the same names within each repository's established architecture. No backward compatibility names, aliases, or duplicate locations are allowed.
 
 ## Purpose

package/.agents/skills/pkg-validate-validation-library/SKILL.md

@@ -13,6 +13,8 @@ Non-negotiable repository isolation rule: Every repository must run its Husky ho
 
 Non-negotiable error and warning rule: Never suppress, silence, hide, downgrade, filter, ignore, skip, or bypass errors or warnings from code, tests, tools, compilers, linters, or validation. Fix the root cause, then rerun the affected check and require a clean result. Expected error-path tests may assert errors, but must not conceal unexpected failures.
 
+Non-negotiable TypeScript type rule: Never use the TypeScript type `any`; always use specific domain types, generics, existing project types, or `unknown` with explicit narrowing in all TypeScript-family files (`.ts`, `.tsx`, `.mts`, `.cts`, and `.d.ts`).
+
 Non-negotiable code organization rule: Functions with the same or equivalent behavior must use the same or clearly corresponding descriptive names across CareCard repositories, and equivalent functionality must live in files with the same names within each repository's established architecture. No backward compatibility names, aliases, or duplicate locations are allowed.
 
 ## Purpose
@@ -208,3 +210,21 @@ repository's agents-only Git workflow:
 Do not commit or push `.agents` guidance changes directly from `development`
 or `main`. Do not stage unrelated files, generated output, dependency folders,
 build artifacts, logs, or `.DS_Store`.
+
+## Fail-Closed Test Lifecycle Audit
+
+The current package tests own no HTTP listener, database pool, Kafka client,
+background timer, or child process after completion. Mocha's test timeout fails
+a stalled async test, the suites run without bail or forced exit, and npm
+preserves each command's nonzero status. Keep natural process exit as the open
+handle regression check; validation must not hide failures with retries, forced
+success, skipped tests, or output suppression.
+
+Do not add unpublished executable validation code to a `pkg-*` repository. If a
+future test owns a long-lived resource or demonstrates a post-suite hang, add a
+contract-tested process watchdog through the coordinated package version,
+publish, and consumer propagation workflow. That watchdog must return
+immediately when no helper remains, allow only a bounded 250 ms settlement
+window for already-stopping helpers, fail persistent descendants, preserve
+failures and output, use exit code `124` only for a real outer deadline, and
+remain a final guard rather than a substitute for explicit cleanup.

package/.agents/skills/software-design-patterns-and-clean-code/SKILL.md

@@ -13,6 +13,8 @@ Non-negotiable repository isolation rule: Every repository must run its Husky ho
 
 Non-negotiable error and warning rule: Never suppress, silence, hide, downgrade, filter, ignore, skip, or bypass errors or warnings from code, tests, tools, compilers, linters, or validation. Fix the root cause, then rerun the affected check and require a clean result. Expected error-path tests may assert errors, but must not conceal unexpected failures.
 
+Non-negotiable TypeScript type rule: Never use the TypeScript type `any`; always use specific domain types, generics, existing project types, or `unknown` with explicit narrowing in all TypeScript-family files (`.ts`, `.tsx`, `.mts`, `.cts`, and `.d.ts`).
+
 Non-negotiable code organization rule: Functions with the same or equivalent behavior must use the same or clearly corresponding descriptive names across CareCard repositories, and equivalent functionality must live in files with the same names within each repository's established architecture. No backward compatibility names, aliases, or duplicate locations are allowed.
 
 ## Purpose

package/.codex/AGENTS.md

@@ -1,5 +1,7 @@
 # Codex Instructions For pkg-validate
 
+Non-negotiable test order invariance rule: Every test must pass independently of which tests run before or after it, and the suite must pass in every execution order. Each test must establish the state it needs, isolate mutable state, and clean up state it owns; it must never rely on another test's setup, mutations, or cleanup. Default test, CI, and Husky commands must use the test framework's ordinary ordering and must not force randomized ordering. Random-order execution is an explicit diagnostic only, and every failure it exposes must be fixed at the root cause.
+
 Non-negotiable code organization rule: Functions with the same or equivalent behavior must use the same or clearly corresponding descriptive names across CareCard repositories, and equivalent functionality must live in files with the same names within each repository's established architecture. No backward compatibility names, aliases, or duplicate locations are allowed.
 
 Non-negotiable repository isolation rule: Every repository must run its Husky hooks and tests using only files, code, fixtures, dependencies, and services contained within that repository. Tests and Husky scripts must not import, require, read, execute, or otherwise depend on sibling repositories or paths outside the repository root. app-e2e-tests is the only exception because cross-repository end-to-end testing is its explicit responsibility.

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@carecard/validate",
-    "version": "3.12.0",
+    "version": "3.13.0",
     "repository": {
         "type": "git",
         "url": "git+https://github.com/CareCard-ca/pkg-validate.git"
@@ -9,9 +9,10 @@
     "main": "index.js",
     "types": "index.d.ts",
     "scripts": {
-        "test": "mocha --recursive",
+        "test": "npm run test:order && node test/index.test.js",
+        "test:order": "node --test scripts/testOrder/randomizeTestOrder.test.mjs scripts/testOrder/testOrderPolicy.test.mjs scripts/testParallel/runIndexedMochaTests.test.mjs scripts/testParallel/parallelTestPolicy.test.mjs",
         "test:types": "tsc --noEmit && echo \"\\n  ✔ Type tests passed: tsc --noEmit reported 0 errors across index.d.ts and test/**/*.ts\\n\"",
-        "test:coverage": "tsc --noEmit && export NODE_ENV=test && nyc mocha --recursive",
+        "test:coverage": "npm run test:order && tsc --noEmit && nyc node test/index.test.js",
         "test:All": "npm run test:coverage && npm run test:types",
         "format": "prettier --write .",
         "format:check": "prettier --check .",
@@ -38,7 +39,7 @@
         "typescript": "6.0.3"
     },
     "dependencies": {
-        "@carecard/common-util": "3.12.0"
+        "@carecard/common-util": "3.13.0"
     },
     "nyc": {
         "all": true,
@@ -55,7 +56,8 @@
     "overrides": {
         "diff": "8.0.4",
         "glob": "13.0.6",
+        "minimatch": "10.2.5",
         "serialize-javascript": "7.0.5",
-        "js-yaml": "4.2.0"
+        "js-yaml": "4.3.0"
     }
 }

package/readme.md

@@ -1,5 +1,7 @@
 # @carecard/validate
 
+Non-negotiable test order invariance rule: Every test must pass independently of which tests run before or after it, and the suite must pass in every execution order. Each test must establish the state it needs, isolate mutable state, and clean up state it owns; it must never rely on another test's setup, mutations, or cleanup. Default test, CI, and Husky commands must use the test framework's ordinary ordering and must not force randomized ordering. Random-order execution is an explicit diagnostic only, and every failure it exposes must be fixed at the root cause.
+
 Non-negotiable root-cause solution rule: Always identify and solve the verified root cause, use the stronger solution, and deliver a correct, durable, production-quality result. Never treat a temporary workaround, resource increase, retry, suppression, bypass, or symptom-only patch as completion. Validate the root-cause fix against the real failing workflow and prove the end state.
 
 `@carecard/validate` is a small CommonJS validation package for CareCard
@@ -19,6 +21,8 @@ Non-negotiable repository isolation rule: Every repository must run its Husky ho
 
 Non-negotiable error and warning rule: Never suppress, silence, hide, downgrade, filter, ignore, skip, or bypass errors or warnings from code, tests, tools, compilers, linters, or validation. Fix the root cause, then rerun the affected check and require a clean result. Expected error-path tests may assert errors, but must not conceal unexpected failures.
 
+Non-negotiable TypeScript type rule: Never use the TypeScript type `any`; always use specific domain types, generics, existing project types, or `unknown` with explicit narrowing in all TypeScript-family files (`.ts`, `.tsx`, `.mts`, `.cts`, and `.d.ts`).
+
 Non-negotiable code organization rule: Functions with the same or equivalent behavior must use the same or clearly corresponding descriptive names across CareCard repositories, and equivalent functionality must live in files with the same names within each repository's established architecture. No backward compatibility names, aliases, or duplicate locations are allowed.
 
 ## Installation
@@ -394,3 +398,21 @@ Docs that mention `ms-auth` controller internals should use concise action
 names such as `loginUser`, `registerUser`, `getUserDetail`, and `renewJwt`.
 Access level is conveyed by route middleware and endpoint placement, not by
 `public`/`protected`/`admin`/`Handler` suffixes.
+
+## Fail-Closed Test Lifecycle Audit
+
+The current package tests own no HTTP listener, database pool, Kafka client,
+background timer, or child process after completion. Mocha's test timeout fails
+a stalled async test, the suites run without bail or forced exit, and npm
+preserves each command's nonzero status. Keep natural process exit as the open
+handle regression check; validation must not hide failures with retries, forced
+success, skipped tests, or output suppression.
+
+Do not add unpublished executable validation code to a `pkg-*` repository. If a
+future test owns a long-lived resource or demonstrates a post-suite hang, add a
+contract-tested process watchdog through the coordinated package version,
+publish, and consumer propagation workflow. That watchdog must return
+immediately when no helper remains, allow only a bounded 250 ms settlement
+window for already-stopping helpers, fail persistent descendants, preserve
+failures and output, use exit code `124` only for a real outer deadline, and
+remain a final guard rather than a substitute for explicit cleanup.

package/scripts/testOrder/randomizeTestOrder.cjs

@@ -0,0 +1,40 @@
+'use strict';
+
+const MAX_TEST_ORDER_SEED = 2_147_483_647;
+
+function resolveTestOrderSeed(configuredSeed) {
+    if (configuredSeed === undefined) return undefined;
+    if (!/^[1-9]\d*$/.test(configuredSeed)) throw new Error('TEST_ORDER_SEED must be a positive 32-bit integer.');
+    const seed = Number(configuredSeed);
+    if (!Number.isSafeInteger(seed) || seed > MAX_TEST_ORDER_SEED) throw new Error('TEST_ORDER_SEED must be a positive 32-bit integer.');
+    return seed;
+}
+function createSeededRandom(seed) {
+    let state = seed;
+    return function nextRandomValue() {
+        state = (state + 0x6d2b79f5) | 0;
+        let value = Math.imul(state ^ (state >>> 15), 1 | state);
+        value = (value + Math.imul(value ^ (value >>> 7), 61 | value)) ^ value;
+        return ((value ^ (value >>> 14)) >>> 0) / 4_294_967_296;
+    };
+}
+function shuffleValues(values, random) {
+    for (let index = values.length - 1; index > 0; index -= 1) {
+        const replacementIndex = Math.floor(random() * (index + 1));
+        [values[index], values[replacementIndex]] = [values[replacementIndex], values[index]];
+    }
+}
+function shuffleSuiteTree(suite, random) {
+    for (const childSuite of suite.suites) shuffleSuiteTree(childSuite, random);
+    shuffleValues(suite.tests, random);
+    shuffleValues(suite.suites, random);
+}
+const mochaHooks = {
+    beforeAll() {
+        const seed = resolveTestOrderSeed(process.env.TEST_ORDER_SEED);
+        if (seed === undefined) return;
+        console.log(`Test order seed: ${seed} (reproduce with TEST_ORDER_SEED=${seed})`);
+        shuffleSuiteTree(this.test.parent, createSeededRandom(seed));
+    },
+};
+module.exports = { createSeededRandom, mochaHooks, resolveTestOrderSeed, shuffleSuiteTree };

package/scripts/testOrder/randomizeTestOrder.test.mjs

@@ -0,0 +1,36 @@
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+
+import testOrderRandomizer from './randomizeTestOrder.cjs';
+
+const { createSeededRandom, resolveTestOrderSeed, shuffleSuiteTree } = testOrderRandomizer;
+
+function createSuiteTree() {
+    return {
+        suites: [
+            { title: 'alpha', suites: [], tests: [{ title: 'one' }, { title: 'two' }] },
+            { title: 'beta', suites: [], tests: [{ title: 'three' }, { title: 'four' }] },
+            { title: 'gamma', suites: [], tests: [{ title: 'five' }, { title: 'six' }] },
+        ],
+        tests: [{ title: 'root one' }, { title: 'root two' }, { title: 'root three' }],
+    };
+}
+
+test('uses ordinary ordering unless TEST_ORDER_SEED is explicitly supplied', () => {
+    assert.strictEqual(resolveTestOrderSeed(undefined), undefined);
+    assert.strictEqual(resolveTestOrderSeed('314159'), 314159);
+    for (const invalidSeed of ['', '0', '-1', '1.5', 'seed', '2147483648']) {
+        assert.throws(() => resolveTestOrderSeed(invalidSeed), /TEST_ORDER_SEED/);
+    }
+});
+
+test('shuffles nested suites and tests reproducibly', () => {
+    const firstTree = createSuiteTree();
+    const secondTree = createSuiteTree();
+
+    shuffleSuiteTree(firstTree, createSeededRandom(314159));
+    shuffleSuiteTree(secondTree, createSeededRandom(314159));
+
+    assert.deepStrictEqual(firstTree, secondTree);
+    assert.notDeepStrictEqual(firstTree, createSuiteTree());
+});

package/scripts/testOrder/testOrderPolicy.test.mjs

@@ -0,0 +1,48 @@
+import assert from 'node:assert/strict';
+import { execFileSync } from 'node:child_process';
+import { readFileSync } from 'node:fs';
+import { test } from 'node:test';
+
+const TEST_ORDER_INVARIANCE_RULE =
+    "Non-negotiable test order invariance rule: Every test must pass independently of which tests run before or after it, and the suite must pass in every execution order. Each test must establish the state it needs, isolate mutable state, and clean up state it owns; it must never rely on another test's setup, mutations, or cleanup. Default test, CI, and Husky commands must use the test framework's ordinary ordering and must not force randomized ordering. Random-order execution is an explicit diagnostic only, and every failure it exposes must be fixed at the root cause.";
+
+function listRepositoryFiles() {
+    return execFileSync('git', ['ls-files', '--cached', '--others', '--exclude-standard'], { encoding: 'utf8' })
+        .trim()
+        .split('\n')
+        .filter(Boolean);
+}
+
+function isRequiredTestGuidance(filePath) {
+    return (
+        /^readme\.md$/i.test(filePath) ||
+        filePath === '.codex/AGENTS.md' ||
+        filePath === '.junie/guidelines.md' ||
+        filePath === '.agents/skills/carecard-workspace-standards/SKILL.md' ||
+        /^\.agents\/skills\/[^/]*(?:test|testing)[^/]*\/(?:SKILL\.md|references\/[^/]*(?:test|testing|coding-principles)[^/]*\.md)$/i.test(
+            filePath,
+        )
+    );
+}
+
+test('keeps the non-negotiable test order rule in repository guidance', () => {
+    const guidanceFiles = listRepositoryFiles().filter(isRequiredTestGuidance);
+    assert.ok(guidanceFiles.length > 0, 'No repository test guidance was found.');
+
+    for (const guidanceFile of guidanceFiles) {
+        const normalizedGuidance = readFileSync(guidanceFile, 'utf8').replace(/\s+/g, ' ').trim();
+        assert.ok(
+            normalizedGuidance.includes(TEST_ORDER_INVARIANCE_RULE),
+            `${guidanceFile} must document the non-negotiable test order invariance rule.`,
+        );
+    }
+});
+
+test('keeps default package scripts on the test framework ordinary ordering', () => {
+    const packageJson = JSON.parse(readFileSync('package.json', 'utf8'));
+
+    for (const [scriptName, command] of Object.entries(packageJson.scripts ?? {})) {
+        assert.equal(typeof command, 'string', `${scriptName} must be a string command.`);
+        assert.doesNotMatch(command, /--test-randomize|--test-random-seed/, `${scriptName} must not force randomized test ordering.`);
+    }
+});

package/scripts/testParallel/parallelTestPolicy.test.mjs

@@ -0,0 +1,39 @@
+import assert from 'node:assert/strict';
+import { readdirSync, readFileSync } from 'node:fs';
+import { createRequire } from 'node:module';
+import { join, relative, resolve } from 'node:path';
+import test from 'node:test';
+
+const require = createRequire(import.meta.url);
+const repositoryRoot = resolve(import.meta.dirname, '../..');
+const packageJson = JSON.parse(readFileSync(new URL('../../package.json', import.meta.url), 'utf8'));
+const testIndexSource = readFileSync(new URL('../../test/index.test.js', import.meta.url), 'utf8');
+const { parallelTestFiles } = require('../../test/index.test.js');
+
+function listRuntimeTestFiles(directoryPath) {
+    return readdirSync(directoryPath, { withFileTypes: true }).flatMap(entry => {
+        const entryPath = join(directoryPath, entry.name);
+        if (entry.isDirectory()) return listRuntimeTestFiles(entryPath);
+        if (!/\.test\.(?:js|mjs)$/.test(entry.name) || entry.name === 'index.test.js') {
+            return [];
+        }
+        return [relative(repositoryRoot, entryPath)];
+    });
+}
+
+test('keeps runtime test selection in the index and package scripts short', () => {
+    assert.equal(packageJson.scripts.test, 'npm run test:order && node test/index.test.js');
+    assert.match(packageJson.scripts['test:coverage'], /nyc node test\/index\.test\.js$/);
+    assert.match(testIndexSource, /parallelTestFiles/);
+    assert.match(testIndexSource, /runIndexedMochaTests/);
+    assert.match(testIndexSource, /if \(require\.main === module\)/);
+});
+
+test('runs the parallel execution contract in the test-order gate', () => {
+    assert.match(packageJson.scripts['test:order'], /scripts\/testParallel\/parallelTestPolicy\.test\.mjs/);
+    assert.match(packageJson.scripts['test:order'], /scripts\/testParallel\/runIndexedMochaTests\.test\.mjs/);
+});
+
+test('selects every runtime test file exactly once', () => {
+    assert.deepEqual([...parallelTestFiles].sort(), listRuntimeTestFiles(resolve(repositoryRoot, 'test')).sort());
+});

package/scripts/testParallel/runIndexedMochaTests.cjs

@@ -0,0 +1,71 @@
+'use strict';
+
+const { spawn } = require('node:child_process');
+const { createRequire } = require('node:module');
+const { availableParallelism } = require('node:os');
+const { resolve } = require('node:path');
+
+const DEFAULT_MAX_PARALLEL_JOBS = 4;
+
+// Pattern: Configuration Boundary - bounds workers without accepting invalid input.
+function resolveParallelJobCount(
+    configuredJobCount,
+    testFileCount,
+    defaultMaximum = DEFAULT_MAX_PARALLEL_JOBS,
+    availableJobCount = availableParallelism(),
+) {
+    const requestedJobCount =
+        configuredJobCount === undefined ? Math.min(availableJobCount, defaultMaximum) : Number.parseInt(configuredJobCount, 10);
+
+    if (!Number.isInteger(requestedJobCount) || requestedJobCount < 1) {
+        throw new Error('TEST_PARALLEL_JOBS must be a positive integer.');
+    }
+    return Math.min(requestedJobCount, testFileCount);
+}
+
+// Pattern: Command Builder - keeps Mocha worker details out of package metadata.
+function buildMochaArguments(testFiles, jobCount) {
+    const requireFromRunner = createRequire(__filename);
+    return [
+        requireFromRunner.resolve('mocha/bin/mocha.js'),
+        '--parallel',
+        '--jobs',
+        String(jobCount),
+        '--require',
+        resolve('scripts/testOrder/randomizeTestOrder.cjs'),
+        ...testFiles,
+    ];
+}
+
+// Pattern: Process Adapter - returns the exact test process result to the index.
+function runIndexedMochaTests(testFiles) {
+    if (testFiles.length === 0) {
+        throw new Error('The package test index must select at least one test file.');
+    }
+
+    const jobCount = resolveParallelJobCount(process.env.TEST_PARALLEL_JOBS, testFiles.length);
+    const child = spawn(process.execPath, buildMochaArguments(testFiles, jobCount), {
+        env: {
+            ...process.env,
+            NODE_ENV: 'test',
+        },
+        stdio: 'inherit',
+    });
+
+    return new Promise((resolveExit, rejectExit) => {
+        child.once('error', rejectExit);
+        child.once('exit', (code, signal) => {
+            if (signal) {
+                rejectExit(new Error(`Mocha exited from signal ${signal}.`));
+                return;
+            }
+            resolveExit(code ?? 1);
+        });
+    });
+}
+
+module.exports = {
+    buildMochaArguments,
+    resolveParallelJobCount,
+    runIndexedMochaTests,
+};

package/scripts/testParallel/runIndexedMochaTests.test.mjs

@@ -0,0 +1,21 @@
+import assert from 'node:assert/strict';
+import { createRequire } from 'node:module';
+import test from 'node:test';
+
+const require = createRequire(import.meta.url);
+const { buildMochaArguments, resolveParallelJobCount } = require('./runIndexedMochaTests.cjs');
+
+test('uses bounded Mocha file workers without randomized default ordering', () => {
+    assert.equal(resolveParallelJobCount(undefined, 8, 4, 12), 4);
+    assert.equal(resolveParallelJobCount('2', 8, 4, 12), 2);
+
+    const argumentsList = buildMochaArguments(['test/example.test.js'], 2);
+
+    assert.ok(argumentsList.includes('--parallel'));
+    assert.deepEqual(argumentsList.slice(argumentsList.indexOf('--jobs'), argumentsList.indexOf('--jobs') + 2), ['--jobs', '2']);
+    assert.ok(argumentsList.includes('test/example.test.js'));
+});
+
+test('rejects invalid worker configuration instead of changing execution silently', () => {
+    assert.throws(() => resolveParallelJobCount('0', 8, 4, 12), /TEST_PARALLEL_JOBS must be a positive integer/);
+});