@carbonorm/carbonnode 3.7.15 → 3.7.17

package/src/api/executors/HttpExecutor.ts

@@ -19,7 +19,6 @@ import {apiRequestCache, checkCache, userCustomClearCache} from "../utils/cacheM
 import {sortAndSerializeQueryObject} from "../utils/sortAndSerializeQueryObject";
 import {Executor} from "./Executor";
 import {toastOptions, toastOptionsDevs} from "variables/toastOptions";
-import {normalizeSingularRequest} from "../utils/normalizeSingularRequest";
 
 export class HttpExecutor<
     G extends OrmGenerics
@@ -334,9 +333,6 @@ export class HttpExecutor<
 
             }
 
-            let addBackPK: (() => void) | undefined;
-            let removedPrimaryKV: { key: string; value: any } | undefined;
-
             let apiResponse: G['RestTableInterface'][G['PrimaryKey']] | string | boolean | number | undefined;
 
             let returnGetNextPageFunction = false;
@@ -410,22 +406,7 @@ export class HttpExecutor<
 
                 restRequestUri += query[primaryKey] + '/'
 
-                const removedPkValue = query[primaryKey];
-                removedPrimaryKV = { key: primaryKey, value: removedPkValue };
-
-                addBackPK = () => {
-                    query ??= {} as RequestQueryBody<
-                        G['RequestMethod'],
-                        G['RestTableInterface'],
-                        G['CustomAndRequiredFields'],
-                        G['RequestTableOverrides']
-                    >;
-                    query[primaryKey] = removedPkValue;
-                }
-
-                delete query[primaryKey]
-
-                console.log('query', query, 'primaryKey', primaryKey, 'removedPkValue', removedPkValue)
+                console.log('query', query, 'primaryKey', primaryKey)
 
             } else {
 
@@ -473,19 +454,11 @@ export class HttpExecutor<
                             withCredentials: withCredentials,
                         };
 
-                        // Normalize singular request (GET/PUT/DELETE) into complex ORM shape
-                        const normalizedQuery = normalizeSingularRequest(
-                            requestMethod as any,
-                            query as any,
-                            restModel as any,
-                            removedPrimaryKV
-                        ) as typeof query;
-
                         switch (requestMethod) {
                             case GET:
                                 return [{
                                     ...baseConfig,
-                                    params: normalizedQuery
+                                    params: query
                                 }];
 
                             case POST:
@@ -498,12 +471,12 @@ export class HttpExecutor<
                                 return [convert(query), baseConfig];
 
                             case PUT:
-                                return [convert(normalizedQuery), baseConfig];
+                                return [convert(query), baseConfig];
 
                             case DELETE:
                                 return [{
                                     ...baseConfig,
-                                    data: convert(normalizedQuery)
+                                    data: convert(query)
                                 }];
 
                             default:
@@ -523,10 +496,6 @@ export class HttpExecutor<
 
                 }
 
-                // todo - wip verify this works
-                // we had removed the value from the request to add to the URI.
-                addBackPK?.();  // adding back so post-processing methods work
-
                 // returning the promise with this then is important for tests. todo - we could make that optional.
                 // https://rapidapi.com/guides/axios-async-await
                 return axiosActiveRequest.then(async (response: AxiosResponse<ResponseDataType, any>): Promise<AxiosResponse<ResponseDataType, any>> => {

package/src/api/handlers/ExpressHandler.ts

@@ -36,27 +36,16 @@ export function ExpressHandler({C6, mysqlPool}: { C6: iC6Object, mysqlPool: Pool
 
             const primaryKeyName = primaryKeys[0];
 
-            if (!(payload[C6C.WHERE]?.[primaryKeyName] ?? undefined)) {
-                // 👇 Call restRequest for the resolved method
-                switch (method) {
-                    case 'GET':
-                        if (primary) {
-                            payload[C6C.WHERE][primaryKeyName] = primary;
-                        }
-                        break;
-                    case 'PUT':
-                    case 'DELETE':
-                        if (primary) {
-                            payload[C6C.WHERE][primaryKeyName] = primary;
-                        } else {
-                            res.status(400).json({error: `Invalid request: ${method} requires a primary key (${primaryKeyName}).`});
-                        }
-                        break;
-                    case 'POST':
-                        break;
-                    default:
-                        res.status(405).json({error: `Method ${method} not allowed`});
-                        return;
+            // If a primary key was provided in the URL, merge it into the payload.
+            // Support both complex requests using WHERE and singular requests
+            // where the primary key lives at the root of the payload.
+            if (primary) {
+                if (payload[C6C.WHERE]) {
+                    payload[C6C.WHERE][primaryKeyName] =
+                        payload[C6C.WHERE][primaryKeyName] ?? primary;
+                } else {
+                    (payload as any)[primaryKeyName] =
+                        (payload as any)[primaryKeyName] ?? primary;
                 }
             }
 

package/src/api/utils/normalizeSingularRequest.ts

@@ -60,7 +60,9 @@ export function normalizeSingularRequest<
     if (value === undefined) {
       // 2) fully-qualified key matching this short key (from PRIMARY list or by concatenation)
       const fqCandidate = `${restModel.TABLE_NAME}.${pkShort}`;
-      const fqKey = pkFulls.find(fq => fq === fqCandidate || fq.endsWith(`.${pkShort}`)) ?? fqCandidate;
+      const fqKey = pkFulls.find(
+        fq => fq === fqCandidate || fq.endsWith(`.${pkShort}`)
+      ) ?? fqCandidate;
       value = requestObj[fqKey];
     }
     if (value === undefined && removedPrimary) {
@@ -93,9 +95,18 @@ export function normalizeSingularRequest<
     ...rest
   } = request as any;
 
+  // Map short primary keys to fully-qualified column names
+  const shortToFull: Record<string, string> = {};
+  for (const [full, short] of Object.entries(restModel.COLUMNS || {})) {
+    shortToFull[short as string] = full;
+  }
+  const pkFullValues = Object.fromEntries(
+    Object.entries(pkValues).map(([k, v]) => [shortToFull[k] ?? k, v])
+  );
+
   if (requestMethod === C6C.GET) {
     const normalized: any = {
-      WHERE: { ...pkValues },
+      WHERE: { ...pkFullValues },
     };
     // Preserve pagination if any was added previously
     if ((request as any)[C6C.PAGINATION]) {
@@ -115,7 +126,7 @@ export function normalizeSingularRequest<
   if (requestMethod === C6C.DELETE) {
     const normalized: any = {
       [C6C.DELETE]: true,
-      WHERE: { ...pkValues },
+      WHERE: { ...pkFullValues },
     };
     return {
       ...normalized,
@@ -143,7 +154,7 @@ export function normalizeSingularRequest<
 
   const normalized: any = {
     [C6C.UPDATE]: updateBody,
-    WHERE: { ...pkValues },
+    WHERE: { ...pkFullValues },
   };
 
   return {