@carbon/ibm-products 1.5.0 → 1.6.0

package/lib/components/BreadcrumbWithOverflow/BreadcrumbWithOverflow.js

@@ -360,9 +360,12 @@ BreadcrumbWithOverflow.propTypes = {
   noTrailingSlash: _propTypes.default.bool,
 
   /**
-   * overflowAriaLabel label for open close button overflow used for action bar items that do nto fit.
+   * overflowAriaLabel label for open close button overflow used for breadcrumb items that do not fit.
    */
-  overflowAriaLabel: _propTypes.default.string.isRequired
+  overflowAriaLabel: _propTypes.default.string.isRequired.if(function (_ref6) {
+    var breadcrumbs = _ref6.breadcrumbs;
+    return breadcrumbs.length > 1;
+  })
 };
 BreadcrumbWithOverflow.defaultProps = {
   noTrailingSlash: false

package/lib/components/CancelableTextEdit/CancelableTextEdit.js

@@ -149,7 +149,7 @@ var CancelableTextEdit = /*#__PURE__*/_react.default.forwardRef(function (_ref,
     hasIconOnly: true,
     iconDescription: revertDescription,
     onClick: handleRevert,
-    renderIcon: _iconsReact.Reset16
+    renderIcon: _iconsReact.Close16
   }), /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Button, {
     className: "".concat(blockClass, "__save"),
     kind: "ghost",

package/lib/components/Card/Card.js

@@ -30,7 +30,8 @@ var _CardFooter = require("./CardFooter");
 var _settings = require("../../settings");
 
 var _excluded = ["actionIcons", "actionsPlacement", "children", "className", "clickZone", "description", "label", "media", "mediaPosition", "onClick", "onKeyDown", "onPrimaryButtonClick", "overflowActions", "onSecondaryButtonClick", "pictogram", "primaryButtonHref", "primaryButtonIcon", "primaryButtonKind", "primaryButtonText", "productive", "secondaryButtonHref", "secondaryButtonIcon", "secondaryButtonKind", "secondaryButtonText", "title", "titleSize"],
-    _excluded2 = ["id"];
+    _excluded2 = ["id"],
+    _excluded3 = ["id", "icon", "onClick", "iconDescription", "onKeyDown", "href"];
 
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 
@@ -105,10 +106,11 @@ var Card = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref) {
           onClick = _ref3.onClick,
           iconDescription = _ref3.iconDescription,
           onKeyDown = _ref3.onKeyDown,
-          href = _ref3.href;
+          href = _ref3.href,
+          rest = (0, _objectWithoutProperties2.default)(_ref3, _excluded3);
 
       if (productive) {
-        return /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Button, {
+        return /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Button, (0, _extends2.default)({}, rest, {
           key: id,
           renderIcon: Icon,
           hasIconOnly: true,
@@ -117,7 +119,7 @@ var Card = /*#__PURE__*/(0, _react.forwardRef)(function (_ref, ref) {
           iconDescription: iconDescription,
           kind: "ghost",
           href: href
-        });
+        }));
       }
 
       if (href) {

package/lib/components/InlineEdit/InlineEdit.js

@@ -27,22 +27,16 @@ var _devtools = require("../../global/js/utils/devtools");
 
 var _settings = require("../../settings");
 
-var _ = require("../");
-
 var _carbonComponentsReact = require("carbon-components-react");
 
 var _iconsReact = require("@carbon/icons-react");
 
-var _excluded = ["className", "disabled", "editDescription", "id", "inline", "invalid", "invalidText", "labelText", "onChange", "onInput", "onRevert", "revertDescription", "saveDescription", "saveDisabled", "size", "value", "warn", "warnText"];
+var _excluded = ["cancelDescription", "className", "disabled", "editDescription", "editVisibleOnHoverOnly", "id", "invalid", "invalidText", "labelText", "light", "onCancel", "onSave", "onChange", "saveDescription", "saveDisabled", "size", "value", "warn", "warnText"];
 
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 
-function ownKeys(object, enumerableOnly) { var keys = Object.keys(object); if (Object.getOwnPropertySymbols) { var symbols = Object.getOwnPropertySymbols(object); enumerableOnly && (symbols = symbols.filter(function (sym) { return Object.getOwnPropertyDescriptor(object, sym).enumerable; })), keys.push.apply(keys, symbols); } return keys; }
-
-function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = null != arguments[i] ? arguments[i] : {}; i % 2 ? ownKeys(Object(source), !0).forEach(function (key) { (0, _defineProperty2.default)(target, key, source[key]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(target, Object.getOwnPropertyDescriptors(source)) : ownKeys(Object(source)).forEach(function (key) { Object.defineProperty(target, key, Object.getOwnPropertyDescriptor(source, key)); }); } return target; }
-
 // The block part of our conventional BEM class names (blockClass__E--M).
 var blockClass = "".concat(_settings.pkg.prefix, "--inline-edit");
 var componentName = 'InlineEdit'; // NOTE: the component SCSS is not imported here: it is rolled up separately.
@@ -51,19 +45,22 @@ var componentName = 'InlineEdit'; // NOTE: the component SCSS is not imported he
  * TODO: A description of the component.
  */
 
-var InlineEdit = /*#__PURE__*/_react.default.forwardRef(function (_ref, ref) {
-  var className = _ref.className,
+var InlineEdit = /*#__PURE__*/_react.default.forwardRef(function (_ref, refIn) {
+  var _cx, _cx2;
+
+  var cancelDescription = _ref.cancelDescription,
+      className = _ref.className,
       disabled = _ref.disabled,
       editDescription = _ref.editDescription,
+      editVisibleOnHoverOnly = _ref.editVisibleOnHoverOnly,
       id = _ref.id,
-      inline = _ref.inline,
       invalid = _ref.invalid,
       invalidText = _ref.invalidText,
       labelText = _ref.labelText,
+      light = _ref.light,
+      onCancel = _ref.onCancel,
+      onSave = _ref.onSave,
       onChange = _ref.onChange,
-      onInput = _ref.onInput,
-      onRevert = _ref.onRevert,
-      revertDescription = _ref.revertDescription,
       saveDescription = _ref.saveDescription,
       saveDisabled = _ref.saveDisabled,
       size = _ref.size,
@@ -71,63 +68,208 @@ var InlineEdit = /*#__PURE__*/_react.default.forwardRef(function (_ref, ref) {
       warn = _ref.warn,
       warnText = _ref.warnText,
       rest = (0, _objectWithoutProperties2.default)(_ref, _excluded);
+  var refInput = (0, _react.useRef)(null);
+  var localRef = (0, _react.useRef)(null);
+  var ref = refIn || localRef;
 
   var _useState = (0, _react.useState)(false),
       _useState2 = (0, _slicedToArray2.default)(_useState, 2),
       editing = _useState2[0],
       setEditing = _useState2[1];
 
-  var handleEdit = function handleEdit() {
-    return setEditing(function (prev) {
-      return !prev;
-    });
+  var _useState3 = (0, _react.useState)(value),
+      _useState4 = (0, _slicedToArray2.default)(_useState3, 2),
+      internalValue = _useState4[0],
+      setInternalValue = _useState4[1];
+
+  var showValidationText = invalid || warn;
+  var validationText = invalidText || warnText;
+  var validationIcon = showValidationText ? invalid ? /*#__PURE__*/_react.default.createElement(_iconsReact.WarningFilled16, null) : /*#__PURE__*/_react.default.createElement(_iconsReact.WarningAltFilled16, null) : null;
+
+  var handleEdit = function handleEdit(ev) {
+    if (!disabled) {
+      var rightOfInput = ev.currentTarget.classList.contains("".concat(blockClass, "__edit")) || ev.target.classList.contains("".concat(blockClass, "__controls"));
+      var leftOfInput = ev.currentTarget = ev.target.classList.contains("".concat(blockClass)); // clicking on the content editable element should not set either of these to true
+
+      if (rightOfInput || leftOfInput) {
+        setEditing(true);
+        setTimeout(function () {
+          refInput.current.focus(); // select all the content
+
+          document.getSelection().selectAllChildren(refInput.current);
+
+          if (rightOfInput) {
+            document.getSelection().collapseToEnd();
+            refInput.current.scrollLeft = 9999; // never going to get there but ensures at end.
+          } else {
+            document.getSelection().collapseToStart();
+            refInput.current.scrollLeft = 0; // scroll to start
+          }
+        }, 0);
+      }
+    }
+  };
+
+  var handleFocus = function handleFocus(ev) {
+    if (!editing && ev.target.classList.contains("".concat(blockClass, "__input"))) {
+      // console.log(editing);
+      setEditing(true);
+    }
   };
 
-  var handleChange = function handleChange(val) {
+  var handleSave = function handleSave() {
     setEditing(false);
-    onChange(val);
+    document.getSelection().removeAllRanges();
+
+    if (onSave) {
+      onSave(refInput.current.innerText);
+    }
+  };
+
+  var handlePaste = function handlePaste(ev) {
+    ev.preventDefault(); // Get clipboard as plain text
+
+    var text = (ev.clipboardData || window.clipboardData).getData('text/plain'); // remove \n
+
+    var sanitizedText = text.replaceAll(/\n/g, '') // remove carriage returns
+    .replaceAll(/\t/g, '  '); // replace tab with two spaces
+
+    if (document.queryCommandSupported('insertText')) {
+      document.execCommand('insertText', false, sanitizedText);
+    } else {
+      // Insert text at the current position of caret
+      var range = document.getSelection().getRangeAt(0);
+      range.deleteContents();
+      var textNode = document.createTextNode(sanitizedText);
+      range.insertNode(textNode); // move selection end of textNode
+
+      range.selectNodeContents(textNode);
+      range.collapse(false); // remove existing range
+
+      var selection = document.getSelection();
+      selection.removeAllRanges(); // set the new range
+
+      selection.addRange(range);
+    }
   };
 
-  var handleRevert = function handleRevert() {
+  var handleInput = function handleInput() {
+    setInternalValue(refInput.current.innerText);
+
+    if (onChange) {
+      onChange(refInput.current.innerText);
+    }
+  };
+
+  var handleCancel = function handleCancel() {
+    refInput.current.innerText = value;
+    handleInput(value);
     setEditing(false);
-    onRevert(value);
+    document.getSelection().removeAllRanges();
+
+    if (onCancel) {
+      onCancel(value);
+    }
   };
 
-  var stdProps = _objectSpread(_objectSpread({}, rest), {}, {
-    className: (0, _classnames.default)(blockClass, // Apply the block class to the main HTML element
-    className, // Apply any supplied class names to the main HTML element.
-    (0, _defineProperty2.default)({}, "".concat(blockClass, "--editing"), editing)),
-    id: id,
-    size: size,
-    ref: ref
-  }, (0, _devtools.getDevtoolsProps)(componentName));
-
-  return editing ? /*#__PURE__*/_react.default.createElement(_.CancelableTextEdit, (0, _extends2.default)({}, stdProps, {
-    hideLabel: true,
-    inline: inline,
-    invalid: invalid,
-    invalidText: invalidText,
-    labelText: labelText,
-    onChange: handleChange,
-    onInput: onInput,
-    onRevert: handleRevert,
-    revertDescription: revertDescription,
-    saveDescription: saveDescription,
-    saveDisabled: saveDisabled,
-    value: value,
-    warn: warn,
-    warnText: warnText
-  })) : /*#__PURE__*/_react.default.createElement("div", stdProps, /*#__PURE__*/_react.default.createElement("div", {
-    className: "".concat(blockClass, "__value")
-  }, value), /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Button, {
-    className: "".concat(blockClass, "__button ").concat(_settings.carbon.prefix, "--btn--md"),
-    kind: "ghost",
-    hasIconOnly: true,
-    iconDescription: editDescription,
-    onClick: handleEdit,
-    renderIcon: disabled ? _iconsReact.EditOff16 : _iconsReact.Edit16,
-    disabled: disabled
-  }));
+  var handleBlur = function handleBlur(ev) {
+    if (!ref.current.contains(ev.relatedTarget)) {
+      setEditing(false);
+      handleSave();
+    }
+  };
+
+  var handleKeyDown = function handleKeyDown(ev) {
+    if (ev.key === 'Enter') {
+      ev.preventDefault();
+      refInput.current.blur(); // will cause save
+    }
+  };
+  /*
+    The HTML is structured as follows:
+   <container>
+    <!-- margin left of input to match Carbon -->
+    <content-editable>
+    <-- margin right of input space for controls -->
+    <controls>
+  </container>
+    NOTE:
+   - An input is not used as this would not permit a heading tag e.g. <h2>.
+   - Some padding is added to the left 16px standard for a Carbon text input
+   - The controls are position absolute with a margin to on the input to reserve space. Using inline-flex
+   - does not measure space properly for the input otherwise.
+   - The content editable is not expected to change size when buttons are added, to ensure the text does not move space
+    is reserved up front for buttons and invalid icon. Mostly this is only noticed if the width of the component is not 100%.
+    which can be shown by setting inlineEditFullWidth to false in storybook.
+    In making content-editable behave like an input of type text we have to account for.
+   - Enforcing a single line
+   - Pasting of non-text e.g. html or text with carriage returns
+   - The padding and border not hiding typed in text.
+   - Placing the cursor at the start or end depending on area clicked (before for left-padding)
+  */
+
+
+  var controlsAnimation = true;
+  return (
+    /*#__PURE__*/
+    // eslint-disable-next-line
+    _react.default.createElement("div", {
+      className: (0, _classnames.default)(blockClass, // Apply the block class to the main HTML element
+      className, // Apply any supplied class names to the main HTML element.
+      "".concat(blockClass, "--").concat(size), (_cx = {}, (0, _defineProperty2.default)(_cx, "".concat(blockClass, "--editing"), editing), (0, _defineProperty2.default)(_cx, "".concat(blockClass, "--invalid"), invalid), (0, _defineProperty2.default)(_cx, "".concat(blockClass, "--light"), light), _cx)),
+      onClick: handleEdit // disabled eslint for click handler
+      ,
+      onBlur: handleBlur,
+      ref: ref
+    }, /*#__PURE__*/_react.default.createElement("div", (0, _extends2.default)({}, rest, (0, _devtools.getDevtoolsProps)(componentName), {
+      id: id,
+      size: size,
+      className: "".concat(blockClass, "__input"),
+      contentEditable: true,
+      "aria-label": labelText,
+      role: "textbox",
+      tabIndex: "0",
+      onFocus: handleFocus,
+      onInput: handleInput,
+      onKeyDown: handleKeyDown,
+      onPaste: handlePaste,
+      suppressContentEditableWarning: true,
+      ref: refInput
+    }), value), refInput.current && refInput.current.innerText.length === 0 && /*#__PURE__*/_react.default.createElement("div", {
+      className: "".concat(blockClass, "__placeholder")
+    }, labelText), showValidationText && validationText.length > 0 && /*#__PURE__*/_react.default.createElement("div", {
+      className: "".concat(blockClass, "__validation-text")
+    }, validationText), /*#__PURE__*/_react.default.createElement("div", {
+      className: "".concat(blockClass, "__validation-icon")
+    }, validationIcon), /*#__PURE__*/_react.default.createElement("div", {
+      className: (0, _classnames.default)("".concat(blockClass, "__controls"), (_cx2 = {}, (0, _defineProperty2.default)(_cx2, "".concat(blockClass, "__controls--animation"), controlsAnimation), (0, _defineProperty2.default)(_cx2, "".concat(blockClass, "__controls--saveable"), invalid || saveDisabled || refInput.current && value !== internalValue), _cx2))
+    }, editing ? /*#__PURE__*/_react.default.createElement(_react.default.Fragment, null, /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Button, {
+      className: "".concat(blockClass, "__cancel"),
+      kind: "ghost",
+      hasIconOnly: true,
+      iconDescription: cancelDescription,
+      onClick: handleCancel,
+      renderIcon: _iconsReact.Close16
+    }), /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Button, {
+      className: "".concat(blockClass, "__save"),
+      kind: "ghost",
+      hasIconOnly: true,
+      iconDescription: saveDescription,
+      onClick: handleSave,
+      renderIcon: _iconsReact.Checkmark16,
+      disabled: invalid || saveDisabled || value === internalValue
+    })) : /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Button, {
+      "aria-hidden": "true",
+      className: (0, _classnames.default)("".concat(blockClass, "__edit"), (0, _defineProperty2.default)({}, "".concat(blockClass, "__edit--hover-visible"), editVisibleOnHoverOnly)),
+      kind: "ghost",
+      hasIconOnly: true,
+      iconDescription: editDescription,
+      onClick: handleEdit,
+      renderIcon: disabled ? _iconsReact.EditOff16 : _iconsReact.Edit16,
+      disabled: disabled,
+      tabIndex: -1
+    })))
+  );
 }); // Return a placeholder if not released and not enabled by feature flag
 
 
@@ -140,6 +282,11 @@ InlineEdit.displayName = componentName; // The types and DocGen commentary for t
 // See https://www.npmjs.com/package/prop-types#usage.
 
 InlineEdit.propTypes = {
+  /**
+   * label for cancel button
+   */
+  cancelDescription: _propTypes.default.string.isRequired,
+
   /**
    * Provide an optional class to be applied to the containing node.
    */
@@ -156,16 +303,15 @@ InlineEdit.propTypes = {
   editDescription: _propTypes.default.string.isRequired,
 
   /**
-   * ID for inline edit
+   * In some scenarios the edit icon only needs to be shown on hover. These cases are where continual visibility of
+   * the edit icon is redundant. E.g. a spreadsheet a property panel.
    */
-  id: _propTypes.default.string,
-
-  /* TODO: add types and DocGen for all props. */
+  editVisibleOnHoverOnly: _propTypes.default.bool,
 
   /**
-  * inline variant
-  */
-  inline: _propTypes.default.bool,
+   * ID for inline edit
+   */
+  id: _propTypes.default.string,
 
   /**
    * set invalid state for input
@@ -183,24 +329,24 @@ InlineEdit.propTypes = {
   labelText: _propTypes.default.string,
 
   /**
-   * method called on change event
+   * change background to light version (mimic React TextInput)
    */
-  onChange: _propTypes.default.func,
+  light: _propTypes.default.bool,
 
   /**
-   * method called on input event
+   * method called on cancel event
    */
-  onInput: _propTypes.default.func,
+  onCancel: _propTypes.default.func,
 
   /**
-   * method called on revert event
+   * method called on input event (it's a React thing onChange behaves like on input)
    */
-  onRevert: _propTypes.default.func,
+  onChange: _propTypes.default.func,
 
   /**
-   * label for revert button
+   * method called on change event
    */
-  revertDescription: _propTypes.default.string.isRequired,
+  onSave: _propTypes.default.func,
 
   /**
    * label for save button
@@ -237,6 +383,7 @@ InlineEdit.propTypes = {
 // component needs to make a choice or assumption when a prop is not supplied.
 
 InlineEdit.defaultProps = {
-  /* TODO: add defaults for relevant props. */
+  light: true,
+  // defaults to true to reflect design
   size: 'md'
 };

package/lib/components/NotificationsPanel/NotificationsPanel.js

@@ -95,6 +95,12 @@ var NotificationsPanel = /*#__PURE__*/_react.default.forwardRef(function (_ref,
       allNotifications = _useState4[0],
       setAllNotifications = _useState4[1];
 
+  var previousState = (0, _hooks.usePreviousValue)({
+    open: open
+  });
+  var reducedMotion = window && window.matchMedia ? window.matchMedia('(prefers-reduced-motion: reduce)') : {
+    matches: true
+  };
   (0, _react.useEffect)(function () {
     // Set the notifications passed to the state within this component
     setAllNotifications(data);
@@ -114,6 +120,12 @@ var NotificationsPanel = /*#__PURE__*/_react.default.forwardRef(function (_ref,
     !open && setRender(false);
   };
 
+  (0, _react.useEffect)(function () {
+    if (!open && previousState !== null && previousState !== void 0 && previousState.open && reducedMotion.matches) {
+      setRender(false);
+    }
+  }, [open, reducedMotion.matches, previousState === null || previousState === void 0 ? void 0 : previousState.open]);
+
   var sortChronologically = function sortChronologically(arr) {
     if (!arr || arr && !arr.length) {
       return;
@@ -253,7 +265,7 @@ var NotificationsPanel = /*#__PURE__*/_react.default.forwardRef(function (_ref,
     id: blockClass,
     className: (0, _classnames.default)(blockClass, className, "".concat(blockClass, "__container")),
     style: {
-      animation: "".concat(open ? 'fadeIn 250ms' : 'fadeOut 250ms')
+      animation: !reducedMotion.matches ? "".concat(open ? 'fade-in 250ms' : 'fade-out 250ms') : null
     },
     onAnimationEnd: onAnimationEnd,
     ref: ref || notificationPanelRef

package/lib/components/PageHeader/PageHeader.js

@@ -391,16 +391,17 @@ var PageHeader = /*#__PURE__*/_react.default.forwardRef(function (_ref, ref) {
   }, /*#__PURE__*/_react.default.createElement("div", {
     className: "".concat(_PageHeaderUtils.blockClass, "__non-navigation-row-content")
   }, hasBreadcrumbRow ? /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Row, {
-    className: (0, _classnames.default)("".concat(_PageHeaderUtils.blockClass, "__breadcrumb-row"), (_cx2 = {}, (0, _defineProperty2.default)(_cx2, "".concat(_PageHeaderUtils.blockClass, "__breadcrumb-row--next-to-tabs"), nextToTabsCheck()), (0, _defineProperty2.default)(_cx2, "".concat(_PageHeaderUtils.blockClass, "__breadcrumb-row--has-breadcrumbs"), breadcrumbs), (0, _defineProperty2.default)(_cx2, "".concat(_PageHeaderUtils.blockClass, "__breadcrumb-row--has-action-bar"), hasActionBar || widthIsNarrow), (0, _defineProperty2.default)(_cx2, "".concat(_PageHeaderUtils.blockClass, "__has-page-actions-without-action-bar"), !hasActionBar && !widthIsNarrow && pageActions), _cx2))
+    className: (0, _classnames.default)("".concat(_PageHeaderUtils.blockClass, "__breadcrumb-row"), (_cx2 = {}, (0, _defineProperty2.default)(_cx2, "".concat(_PageHeaderUtils.blockClass, "__breadcrumb-row--next-to-tabs"), nextToTabsCheck()), (0, _defineProperty2.default)(_cx2, "".concat(_PageHeaderUtils.blockClass, "__breadcrumb-row--has-breadcrumbs"), breadcrumbs || breadcrumbItemForTitle), (0, _defineProperty2.default)(_cx2, "".concat(_PageHeaderUtils.blockClass, "__breadcrumb-row--has-action-bar"), hasActionBar || widthIsNarrow), (0, _defineProperty2.default)(_cx2, "".concat(_PageHeaderUtils.blockClass, "__has-page-actions-without-action-bar"), !hasActionBar && !widthIsNarrow && pageActions), _cx2))
   }, /*#__PURE__*/_react.default.createElement("div", {
     className: "".concat(_PageHeaderUtils.blockClass, "__breadcrumb-row--container")
   }, /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Column, {
     className: (0, _classnames.default)("".concat(_PageHeaderUtils.blockClass, "__breadcrumb-column"), (0, _defineProperty2.default)({}, "".concat(_PageHeaderUtils.blockClass, "__breadcrumb-column--background"), !!breadcrumbs || hasActionBar || widthIsNarrow))
-  }, breadcrumbs ? /*#__PURE__*/_react.default.createElement(_BreadcrumbWithOverflow.BreadcrumbWithOverflow, {
+  }, breadcrumbs || breadcrumbItemForTitle ? /*#__PURE__*/_react.default.createElement(_BreadcrumbWithOverflow.BreadcrumbWithOverflow, {
     className: "".concat(_PageHeaderUtils.blockClass, "__breadcrumb"),
     noTrailingSlash: !!title,
     overflowAriaLabel: breadcrumbOverflowAriaLabel,
-    breadcrumbs: breadcrumbs ? breadcrumbItemForTitle ? breadcrumbs.concat(breadcrumbItemForTitle) : breadcrumbs : null
+    breadcrumbs: breadcrumbs && breadcrumbItemForTitle ? breadcrumbs.concat(breadcrumbItemForTitle) : breadcrumbItemForTitle ? [breadcrumbItemForTitle] : breadcrumbs // breadcrumbs may be null or undefined
+
   }) : null), /*#__PURE__*/_react.default.createElement(_carbonComponentsReact.Column, {
     className: (0, _classnames.default)(["".concat(_PageHeaderUtils.blockClass, "__action-bar-column ").concat(_PageHeaderUtils.blockClass, "__action-bar-column--background"), (_ref7 = {}, (0, _defineProperty2.default)(_ref7, "".concat(_PageHeaderUtils.blockClass, "__action-bar-column--has-page-actions"), pageActions), (0, _defineProperty2.default)(_ref7, "".concat(_PageHeaderUtils.blockClass, "__action-bar-column--influenced-by-collapse-button"), spaceForCollapseButton), _ref7)])
   }, /*#__PURE__*/_react.default.createElement("div", {
@@ -799,7 +800,8 @@ PageHeader.propTypes = _objectSpread({
    *    - text: title string
    *    - icon: optional icon
    *    - loading: boolean shows loading indicator if true
-   *    - onChange: function to process edits only supply if in place edit is desired
+   *    - onChange: function to process the live value (React change === HTML Input)
+   *    - onSave: function to process a confirmed change
    *    - editableLabel: label for edit required if onChange supplied
    *    - revertDescription: label for edit revert button
    *    - saveDescription: label for edit save button
@@ -819,6 +821,7 @@ PageHeader.propTypes = _objectSpread({
     id: _propTypes.default.string,
     // .isRequired.if(inlineEditRequired),
     onChange: _propTypes.default.func,
+    onSave: _propTypes.default.func,
     revertDescription: _propTypes.default.string,
     //.isRequired.if(inlineEditRequired),
     saveDescription: _propTypes.default.string //.isRequired.if(inlineEditRequired),

package/lib/components/PageHeader/PageHeaderTitle.js

@@ -23,7 +23,7 @@ var _carbonComponentsReact = require("carbon-components-react");
 
 var _ = require("../");
 
-var _excluded = ["text", "content", "loading", "icon", "asText", "onChange", "editDescription", "editableLabel", "revertDescription", "saveDescription"];
+var _excluded = ["text", "content", "loading", "icon", "asText", "onChange", "onSave", "editDescription", "editableLabel", "revertDescription", "saveDescription"];
 
 /**
  *
@@ -43,13 +43,14 @@ var PageHeaderTitle = function PageHeaderTitle(_ref) {
       icon = title.icon,
       asText = title.asText,
       onChange = title.onChange,
+      onSave = title.onSave,
       editDescription = title.editDescription,
       editableLabel = title.editableLabel,
       revertDescription = title.revertDescription,
       saveDescription = title.saveDescription,
       rest = (0, _objectWithoutProperties2.default)(title, _excluded);
   var titleText;
-  var isEditable = !!onChange;
+  var isEditable = !!onSave;
 
   if (text || !content) {
     if (text === undefined && typeof title === 'string') {
@@ -67,6 +68,7 @@ var PageHeaderTitle = function PageHeaderTitle(_ref) {
       value: text,
       editDescription: editDescription,
       onChange: onChange,
+      onSave: onSave,
       labelText: editableLabel,
       revertDescription: revertDescription,
       saveDescription: saveDescription
@@ -87,8 +89,8 @@ var PageHeaderTitle = function PageHeaderTitle(_ref) {
 exports.PageHeaderTitle = PageHeaderTitle;
 
 var inlineEditRequired = function inlineEditRequired(_ref2) {
-  var onChange = _ref2.onChange;
-  return !!onChange;
+  var onSave = _ref2.onSave;
+  return !!onSave;
 };
 
 exports.inlineEditRequired = inlineEditRequired;
@@ -110,9 +112,10 @@ PageHeaderTitle.propTypes = {
    *    - text: title string
    *    - icon: optional icon
    *    - loading: boolean shows loading indicator if true
-   *    - onChange: function to process edits only supply if in place edit is desired
+   *    - onChange: function to process the live value (React change === HTML Input)
+   *    - onSave: function to process a confirmed change
    *    - editDescription: description for edit button
-   *    - editableLabel: label for edit required if onChange supplied
+   *    - editableLabel: label for edit required if onSave supplied
    *    - revertDescription: description for edit revert button
    *    - saveDescription: description for edit save button
    * - Object containing user defined contents. These must fit within the area defined for the title in both main part of the header and the breadcrumb.
@@ -130,6 +133,7 @@ PageHeaderTitle.propTypes = {
     editableLabel: _propTypes.default.string.isRequired.if(inlineEditRequired),
     id: _propTypes.default.string.isRequired.if(inlineEditRequired),
     onChange: _propTypes.default.func,
+    onSave: _propTypes.default.func,
     revertDescription: _propTypes.default.string.isRequired.if(inlineEditRequired),
     saveDescription: _propTypes.default.string.isRequired.if(inlineEditRequired) // Update docgen if changed