@capillarytech/creatives-library 9.0.57-alpha.1 → 9.0.57-alpha.2

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@capillarytech/creatives-library",
   "author": "meharaj",
-  "version": "9.0.57-alpha.1",
+  "version": "9.0.57-alpha.2",
   "description": "Capillary creatives ui",
   "main": "./index.js",
   "module": "./index.es.js",

package/v2Components/FormBuilder/Functional/FormBuilderShell.js

@@ -275,8 +275,14 @@ const FormBuilderShell = (props) => {
     const isEcho = isEqual(parentFormData, lastEmittedRef.current) || isEqual(parentFormData, current);
     if (!isEcho) {
       dispatch(hydrate(fromLegacy(parentFormData, { channel })));
-      // Classic mirrors the tabCount prop only alongside a parent formData sync.
-      emittedTabCountRef.current = propsRef.current.tabCount || emittedTabCountRef.current;
+      // Classic mirrors the tabCount prop on a formData sync only in EDIT mode
+      // (Classic.js:446-447); its generic mirror (415) needs the prop VALUE to
+      // change, which never happens with the containers' hardcoded tabCount={2}.
+      // Adopting 2 in the create flow makes the containers' content-emptiness
+      // check (CAP-189913) scan the untouched iOS tab -> Done/Preview stuck disabled.
+      if (propsRef.current.isEdit) {
+        emittedTabCountRef.current = propsRef.current.tabCount || emittedTabCountRef.current;
+      }
       // Classic validates on every deep-unequal parent push (Classic.js:516-537) —
       // this is what turns the container's isFormValid true before Create/Done.
       if (validateOnExternalChange) {
@@ -626,6 +632,7 @@ FormBuilderShell.propTypes = {
   tagModule: PropTypes.string,
   tags: PropTypes.array,
   checkValidation: PropTypes.bool,
+  isEdit: PropTypes.bool,
   injectedTags: PropTypes.object,
   onContextChange: PropTypes.func,
   // Shapes match TagList's own contract (array of offer objects / keyed-by-blockId map).

package/v2Components/FormBuilder/Functional/tests/mpush.libraryValidity.parity.test.js

@@ -122,6 +122,28 @@ describe.each([
     const contentCalls = props.onContentValidityChange.mock.calls.map((c) => c[0]);
     expect(contentCalls[contentCalls.length - 1]).toEqual({ isContentEmpty: false });
 
+    // user repro: image-upload write-back (a genuine parent push) then CTA check/uncheck.
+    // The shell must NOT adopt the hardcoded tabCount={2} prop in the create flow
+    // (Classic.js:415/446-447), or the content check scans the empty iOS tab and
+    // Done/Preview stick disabled.
+    act(() => {
+      containerRef.setState((prev) => ({
+        formData: { ...prev.formData, 0: { ...prev.formData[0], image: 'blob:uploaded' } },
+      }));
+    });
+    act(() => { jest.advanceTimersByTime(1000); });
+    const pane = document.querySelectorAll('.ant-tabs-tabpane')[0] || document;
+    const label = Array.from(pane.querySelectorAll('label')).find((l) => /action link/i.test(l.textContent || ''));
+    const cta = (label && label.querySelector('input[type="checkbox"]')) || pane.querySelector('input[type="checkbox"]');
+    act(() => { fireEvent.click(cta); });
+    act(() => { jest.advanceTimersByTime(1000); });
+    act(() => { fireEvent.click(cta); });
+    act(() => { jest.advanceTimersByTime(1000); });
+
+    expect(containerRef.state.tabCount).toBe(1); // create flow never adopts the prop
+    const finalCalls = props.onContentValidityChange.mock.calls.map((c) => c[0]);
+    expect(finalCalls[finalCalls.length - 1]).toEqual({ isContentEmpty: false }); // buttons stay enabled
+
     utils.unmount();
   });
 });

package/v2Components/FormBuilder/Functional/tests/mpush.shellEvents.test.js

@@ -161,4 +161,43 @@ describe('MPUSH shell event bridge', () => {
     expect(legacy[0]).toEqual(expect.objectContaining({ 'message-title': '' }));
     expect(legacy[1]).toEqual(expect.objectContaining({ 'message-title2': '' }));
   });
+
+  // Classic mirrors the tabCount prop on a formData push only in EDIT mode
+  // (Classic.js:446-447; the generic mirror at 415 needs the prop VALUE to change,
+  // never true with the containers' hardcoded tabCount={2}). Adopting 2 in the
+  // create flow made getMobilePushEmbeddedContentValidity (CAP-189913) scan the
+  // untouched iOS tab after an image-upload write-back push -> Done/Preview stuck.
+  it('create flow keeps emitting tabCount 1 after a genuine parent push (image write-back); edit adopts the prop', () => {
+    const writeBack = (base) => ({
+      ...base,
+      0: { ...base[0], image: 'blob:uploaded' }, // container's in-place upload write-back
+    });
+
+    const typeTitle = (value) => {
+      const el = document.getElementById('message-title');
+      fireEvent.change(el, { target: { value } });
+    };
+
+    // CREATE (no isEdit): tabCount must stay 1
+    const createProps = buildProps(buildSchema(), { formData: {} });
+    const createMount = mount(createProps);
+    act(() => {
+      createMount.rerender(createMount.ui({ ...createProps, formData: writeBack(buildFormData()) }));
+    });
+    act(() => { typeTitle('after push'); }); // next emission carries the tabCount
+    const createEmit = createProps.onChange.mock.calls[createProps.onChange.mock.calls.length - 1];
+    expect(createEmit[1]).toBe(1);
+    createMount.unmount();
+
+    // EDIT: Classic adopts the prop on the data sync (Classic.js:447)
+    const editProps = buildProps(buildSchema(), { formData: {}, isEdit: true });
+    const editMount = mount(editProps);
+    act(() => {
+      editMount.rerender(editMount.ui({ ...editProps, formData: writeBack(buildFormData()) }));
+    });
+    act(() => { typeTitle('after push'); });
+    const editEmit = editProps.onChange.mock.calls[editProps.onChange.mock.calls.length - 1];
+    expect(editEmit[1]).toBe(2);
+    editMount.unmount();
+  });
 });