@capillarytech/creatives-library 9.0.56-alpha.7 → 9.0.56-betaa.0

package/v2Containers/CommunicationFlow/steps/DeliverySettingsStep/Tests/SenderDetails.test.js

@@ -83,7 +83,6 @@ const ENTITIES = {
   emailTwoDomains: {
     EMAIL: [
       {
-        id: 'gwmap-a',
         domainProperties: {
           id: 'em-a',
           domainName: 'Mail Alpha',
@@ -102,7 +101,6 @@ const ENTITIES = {
         },
       },
       {
-        id: 'gwmap-b',
         domainProperties: {
           id: 'em-b',
           domainName: 'Mail Beta',
@@ -324,29 +322,6 @@ describe('SenderDetails', () => {
     });
   });
 
-  it('persists emailDomainGatewayMapId derived from the selected email domain on save', async () => {
-    const { onSave } = renderSenderDetails({
-      channels: ['EMAIL'],
-      preloadedDomainProperties: ENTITIES.emailTwoDomains,
-    });
-    const root = document.querySelector('.sender-details');
-    await waitFor(() => expect(within(root).getByText('Mail Alpha')).toBeInTheDocument());
-
-    await openSelectAndChoose(root, 0, 'Mail Beta');
-    await waitFor(() => expect(within(root).getByText('beta@other.com')).toBeInTheDocument());
-
-    const saveBtn = within(root).getByRole('button', { name: /save changes/i });
-    await waitFor(() => expect(saveBtn).not.toBeDisabled());
-    fireEvent.click(saveBtn);
-
-    expect(onSave).toHaveBeenCalledWith(
-      expect.objectContaining({
-        emailDomain: 'em-b',
-        emailDomainGatewayMapId: 'gwmap-b',
-      }),
-    );
-  });
-
   it('resets email domain row back to the first gateway', async () => {
     renderSenderDetails({
       channels: ['EMAIL'],

package/v2Containers/CommunicationFlow/steps/DeliverySettingsStep/Tests/deliverySettingsConfig.test.js

@@ -438,7 +438,6 @@ describe('deliverySettingsConfig — user-facing flows', () => {
         smsDomain: 'd1',
         smsSenderId: 'g1',
         emailDomain: 'ed',
-        emailDomainGatewayMapId: 'gwmap-1',
         emailSenderId: 'mail@x.com',
         emailSenderName: 'N',
         emailReplyToId: 'r@x.com',
@@ -456,10 +455,9 @@ describe('deliverySettingsConfig — user-facing flows', () => {
         SMS: { domainId: 'd1', gsmSenderId: 'g1' },
         EMAIL: {
           domainId: 'ed',
-          domainGatewayMapId: 'gwmap-1',
-          senderId: 'mail@x.com',
+          senderEmail: 'mail@x.com',
           senderLabel: 'N',
-          replyToId: 'r@x.com',
+          senderReplyTo: 'r@x.com',
         },
         WHATSAPP: { domainId: 'wd', senderMobNum: '+w' },
         RCS: { senderMobNum: '+r', rcsSender: '+r' },
@@ -474,10 +472,9 @@ describe('deliverySettingsConfig — user-facing flows', () => {
         SMS: { domainId: 'd', gsmSenderId: 'g' },
         EMAIL: {
           domainId: 'ed',
-          domainGatewayMapId: 'gwmap-2',
-          senderId: 'e@e.com',
+          senderEmail: 'e@e.com',
           senderLabel: 'L',
-          replyToId: 'r@e.com',
+          senderReplyTo: 'r@e.com',
         },
         WHATSAPP: { senderMobNum: '+w', domainId: 'wid' },
         RCS: { rcsSender: '+r' },
@@ -489,10 +486,6 @@ describe('deliverySettingsConfig — user-facing flows', () => {
         smsDomain: 'd',
         smsSenderId: 'g',
         emailDomain: 'ed',
-        emailDomainGatewayMapId: 'gwmap-2',
-        emailSenderId: 'e@e.com',
-        emailSenderName: 'L',
-        emailReplyToId: 'r@e.com',
         whatsappDomainId: 'wid',
         viberSenderId: 'vx',
       });

package/v2Containers/CommunicationFlow/steps/DeliverySettingsStep/deliverySettingsConfig.js

@@ -181,12 +181,6 @@ const getEmailDomainValue = (entity) => {
   return emailData.domainProperties?.id ?? emailData.domainId ?? emailData.id ?? '';
 };
 
-// CCS domainGatewayMapId is the domainProperties API's outer id, not domainProperties.id; it identifies the selected domain's gateway mapping.
-const getEmailDomainGatewayMapIdByDomainId = (entity, domainId) => {
-  const domainEntry = getEmailDomainById(entity, domainId);
-  return domainEntry?.id ?? '';
-};
-
 /** Domain name for summary display (parseEntityForDisplay) */
 const getEmailDomainNameForDisplay = (entity) => {
   const emailData = getEmailData(entity);
@@ -268,8 +262,6 @@ const getEmailDefaultsForDomain = (domainData) => {
  * context.fieldValues has current form state (e.g. selected emailDomain)
  * Aligned with adiona-ui/cap-campaigns-v2: default = contactInfo item with default:true, or first
  */
-export { getEmailDomainGatewayMapIdByDomainId };
-
 export const getDefaultValueForField = (fieldKey, entity, context = {}) => {
   if (!entity) return '';
   const fieldValues = context?.fieldValues || {};
@@ -582,10 +574,7 @@ export const parseEntityForDisplay = (entity, context = {}) => {
     senderDetails: entity,
     smsSenderId: getSmsSenderIdValue(entity),
     smsDomain: getSmsDomainValue(entity),
-    // emailDomain is the display-only domain name; buildChannelSettingFromFieldValues needs the numeric domainId/domainGatewayMapId sourced separately.
     emailDomain: getEmailDomainNameForDisplay(entity),
-    emailDomainId: getEmailDomainValue(entity),
-    emailDomainGatewayMapId: getEmailDomainGatewayMapIdByDomainId(entity, getEmailDomainValue(entity)),
     emailSenderId: getEmailSenderIdValue(entity),
     viberSenderId: getSenderIdFromContactInfo(entity, 'VIBER'),
     zaloSenderId: getSenderIdFromContactInfo(entity, 'ZALO'),
@@ -611,12 +600,10 @@ export const buildChannelSettingFromFieldValues = (fieldValues = {}) => {
   }
   if (fieldValues.emailDomain != null || fieldValues.emailSenderId != null || fieldValues.emailSenderName != null || fieldValues.emailReplyToId != null) {
     channelSetting.EMAIL = {
-      // Prefer numeric emailDomainId from auto-save defaults; emailDomain may be either a SenderDetails ID or display name.
-      domainId: fieldValues.emailDomainId ?? fieldValues.emailDomain,
-      domainGatewayMapId: fieldValues.emailDomainGatewayMapId,
-      senderId: fieldValues.emailSenderId,
+      domainId: fieldValues.emailDomain,
+      senderEmail: fieldValues.emailSenderId,
       senderLabel: fieldValues.emailSenderName,
-      replyToId: fieldValues.emailReplyToId,
+      senderReplyTo: fieldValues.emailReplyToId,
     };
   }
   if (fieldValues.whatsappSenderNumber != null || fieldValues.whatsappAccount != null) {
@@ -686,10 +673,9 @@ export const parseChannelSettingForDisplay = (channelSetting = {}) => {
   }
   if (channelSetting.EMAIL) {
     out.emailDomain = channelSetting.EMAIL.domainId;
-    out.emailDomainGatewayMapId = channelSetting.EMAIL.domainGatewayMapId;
-    out.emailSenderId = channelSetting.EMAIL.senderId;
+    out.emailSenderId = channelSetting.EMAIL.senderEmail;
     out.emailSenderName = channelSetting.EMAIL.senderLabel;
-    out.emailReplyToId = channelSetting.EMAIL.replyToId;
+    out.emailReplyToId = channelSetting.EMAIL.senderReplyTo;
   }
   if (channelSetting.WHATSAPP) {
     out.whatsappSenderNumber = channelSetting.WHATSAPP.senderMobNum;

package/v2Containers/CreativesContainer/index.js

@@ -164,6 +164,7 @@ export class Creatives extends React.Component {
       isFullMode: props.isFullMode,
       useLocalTemplates,
     });
+
     this.state = {
       isLoadingContent: true,
       templateStep: 1, //modeSelection: for template name and (for email selecting upload or editor), and createTemplate to create template create based on modeSelection
@@ -412,7 +413,7 @@ export class Creatives extends React.Component {
     this.setState({ isGetFormData: false });
   };
 
-  mapCarouselDataToCreatives = (cards) => (cards || []).map((card) => {
+  mapCarouselDataToCreatives = (cards) => cards.map((card) => {
     const {
       cardVarMapped, bodyTemplate, media, buttons, mediaType,
     } = card || {};
@@ -2461,7 +2462,7 @@ export class Creatives extends React.Component {
           )}
           handleClose={this.handleCloseSlideBox}
           show={showSlideBox}
-          size="size-l"
+          size="size-xl"
         />
       </SlideBoxWrapper>
     );

package/v2Containers/CreativesContainer/tests/__snapshots__/index.test.js.snap

@@ -89,7 +89,7 @@ exports[`Test SlideBoxContent container campaign message, add creative click rcs
       />
     }
     show={true}
-    size="size-l"
+    size="size-xl"
   />
 </CreativesSlideBoxWrapper>
 `;
@@ -183,7 +183,7 @@ exports[`Test SlideBoxContent container campaign message, add creative click wha
       />
     }
     show={true}
-    size="size-l"
+    size="size-xl"
   />
 </CreativesSlideBoxWrapper>
 `;
@@ -320,7 +320,7 @@ exports[`Test SlideBoxContent container campaign message, whatsapp edit all data
       />
     }
     show={false}
-    size="size-l"
+    size="size-xl"
   />
 </CreativesSlideBoxWrapper>
 `;
@@ -457,7 +457,7 @@ exports[`Test SlideBoxContent container campaign message, whatsapp edit min data
       />
     }
     show={false}
-    size="size-l"
+    size="size-xl"
   />
 </CreativesSlideBoxWrapper>
 `;
@@ -594,7 +594,7 @@ exports[`Test SlideBoxContent container it should clear the url, on channel chan
       />
     }
     show={false}
-    size="size-l"
+    size="size-xl"
   />
 </CreativesSlideBoxWrapper>
 `;

package/v2Containers/CreativesContainer/tests/index.test.js

@@ -10,7 +10,6 @@ const {
   whatsappGetCreativeData2,
   whatsappGetTemplateData1,
   whatsappGetTemplateData2,
-  whatsappGetTemplateDataNullCards,
   rcsTemplates,
   rcsEditTemplateData,
   smsEditTemplateData,
@@ -78,17 +77,6 @@ describe('Test SlideBoxContent container', () => {
     expect(handleCloseCreatives).toHaveBeenCalledWith(true);
   });
 
-  it('does not throw when templateConfigs.cards is explicitly null (regression: CCS sends null rather than omitting the field on non-carousel WhatsApp templates, and mapCarouselDataToCreatives called .map() straight off it)', () => {
-    expect(() =>
-      renderFunction(
-        'WHATSAPP',
-        'editTemplate',
-        whatsappTemplates,
-        whatsappGetTemplateDataNullCards,
-      ),
-    ).not.toThrow();
-  });
-
   it('it should clear the url, on channel change from new whatsapp to another', () => {
     renderFunction(
       'WHATSAPP',