@capillarytech/creatives-library 9.0.54-alpha.3 → 9.0.54-alpha.4

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@capillarytech/creatives-library",
   "author": "meharaj",
-  "version": "9.0.54-alpha.3",
+  "version": "9.0.54-alpha.4",
   "description": "Capillary creatives ui",
   "main": "./index.js",
   "module": "./index.es.js",

package/services/api.js

@@ -710,6 +710,17 @@ export const createCommDefinition = (payload) => {
   return request(url, getAPICallObject('POST', payload, false, false, false, true));
 };
 
+// Opens a new DRAFT version with the given content on an EXISTING
+// CommDefinition (same id/referenceId) — used by CommunicationFlow's edit-mode
+// save (re-editing a rejected alert) instead of createCommDefinition, so the
+// alert keeps its identity rather than becoming a brand-new CommDefinition.
+// Route verified against a real Postman sample against Veyron's own
+// /commdefinition/{id}/edit endpoint.
+export const editCommDefinition = (commDefinitionId, payload) => {
+  const url = `${API_ENDPOINT}/comm-definitions/${commDefinitionId}/edit`;
+  return request(url, getAPICallObject('POST', payload, false, false, false, true));
+};
+
 export const getCentralCommsMetaIds = (metaIds, metaType = TRANSACTION) => {
   const url = `${API_ENDPOINT}/common/central-comms/meta-id/${metaType}?metaIds=${metaIds}`;
   return request(url, getAPICallObject('GET', null, false, false, false, true));

package/v2Containers/CommunicationFlow/CommunicationFlow.js

@@ -21,7 +21,7 @@ import CapLabel from '@capillarytech/cap-ui-library/CapLabel';
 // import injectSaga from '../../utils/injectSaga';   // cap-coupons flows disabled
 // import injectReducer from '../../utils/injectReducer';
 import { makeSelectAuthenticated } from '../Cap/selectors';
-import { createCommDefinition } from '../../services/api';
+import { createCommDefinition, editCommDefinition } from '../../services/api';
 import DynamicControlsStep from './steps/DynamicControlsStep';
 import MessageTypeStep from './steps/MessageTypeStep';
 import CommunicationStrategyStep from './steps/CommunicationStrategyStep';
@@ -225,8 +225,19 @@ const CommunicationFlow = ({
           },
         };
 
+        // Editing an existing (e.g. rejected) alert: config.context.existingCommDefinitionId
+        // opens a new DRAFT version on that SAME CommDefinition instead of creating a
+        // brand-new one, so the alert keeps its id/referenceId across the edit.
+        const { existingCommDefinitionId } = config?.context || {};
+
         try {
-          const res = await createCommDefinition(payload);
+          const res = existingCommDefinitionId
+            ? await editCommDefinition(existingCommDefinitionId, {
+              strategyType: payload.strategyType,
+              settings: payload.settings,
+              singleChannelStrategy: payload.singleChannelStrategy,
+            })
+            : await createCommDefinition(payload);
           if (isDuplicateReferenceIdError(res)) {
             // Duplicate referenceId in this org — block the save so the user can
             // change it, rather than silently proceeding without a CCS comm.
@@ -234,7 +245,16 @@ const CommunicationFlow = ({
             return;
           }
           const data = res?.response?.data;
-          if (data?.id) {
+          if (existingCommDefinitionId) {
+            if (data) {
+              ccsCommDefinition = {
+                id: existingCommDefinitionId,
+                referenceId: referenceId || data.referenceId,
+                version: data.version?.version ?? data.version ?? 1,
+                status: data.status,
+              };
+            }
+          } else if (data?.id) {
             ccsCommDefinition = {
               id: data.id,
               referenceId: data.referenceId,

package/v2Containers/CommunicationFlow/Tests/CommunicationFlow.test.js

@@ -2,6 +2,7 @@ import React from 'react';
 
 jest.mock('../../../services/api', () => ({
   createCommDefinition: jest.fn(),
+  editCommDefinition: jest.fn(),
 }));
 
 jest.mock('../../CreativesContainer', () => function MockCreativesContainer({
@@ -37,7 +38,7 @@ import { IntlProvider } from 'react-intl';
 import history from '../../../utils/history';
 import { initialReducer } from '../../../initialReducer';
 import CommunicationFlow from '../CommunicationFlow';
-import { createCommDefinition } from '../../../services/api';
+import { createCommDefinition, editCommDefinition } from '../../../services/api';
 import { getEnabledSteps } from '../utils/getEnabledSteps';
 import {
   CHANNELS,
@@ -738,6 +739,86 @@ describe('handleSave — CCS flow', () => {
       gsmSenderId: 'BRAND1',
     });
   });
+
+  it('does not call editCommDefinition when config.context.existingCommDefinitionId is absent', async () => {
+    const onSave = jest.fn();
+    renderWithFlow({
+      features: {},
+      config: ccsConfig,
+      initialData: { contentItems: [{ channel: 'SMS', templateData: {} }] },
+      onSave,
+    });
+
+    await userEvent.click(screen.getByRole('button', { name: /^save$/i }));
+
+    await waitFor(() => expect(createCommDefinition).toHaveBeenCalledTimes(1));
+    expect(editCommDefinition).not.toHaveBeenCalled();
+  });
+
+  it('calls editCommDefinition (not createCommDefinition) and merges the existing id into ccsCommDefinition when config.context.existingCommDefinitionId is set', async () => {
+    editCommDefinition.mockResolvedValue({
+      response: { data: { version: { version: 2 }, status: 'DRAFT' } },
+    });
+    const onSave = jest.fn();
+    renderWithFlow({
+      features: {},
+      config: {
+        ...ccsConfig,
+        context: { ...ccsConfig.context, referenceId: 'ORDER_PLACED', existingCommDefinitionId: 'cd_existing_1' },
+      },
+      initialData: { contentItems: [{ channel: 'SMS', templateData: {} }] },
+      onSave,
+    });
+
+    await userEvent.click(screen.getByRole('button', { name: /^save$/i }));
+
+    await waitFor(() => expect(editCommDefinition).toHaveBeenCalledTimes(1));
+    expect(editCommDefinition).toHaveBeenCalledWith(
+      'cd_existing_1',
+      expect.objectContaining({
+        strategyType: 'SINGLE',
+        settings: expect.anything(),
+        singleChannelStrategy: expect.anything(),
+      }),
+    );
+    expect(createCommDefinition).not.toHaveBeenCalled();
+
+    await waitFor(() => expect(onSave).toHaveBeenCalledTimes(1));
+    expect(onSave).toHaveBeenCalledWith(
+      expect.objectContaining({
+        ccsCommDefinition: {
+          id: 'cd_existing_1',
+          referenceId: 'ORDER_PLACED',
+          version: 2,
+          status: 'DRAFT',
+        },
+      }),
+    );
+  });
+
+  it('blocks save and shows an error when editCommDefinition resolves with a duplicate REFERENCE_ID_EXISTS conflict', async () => {
+    editCommDefinition.mockResolvedValue({
+      success: false,
+      status: { isError: true, code: 409, message: 'REFERENCE_ID_EXISTS' },
+      message: 'REFERENCE_ID_EXISTS',
+    });
+    const onSave = jest.fn();
+    renderWithFlow({
+      features: {},
+      config: {
+        ...ccsConfig,
+        context: { ...ccsConfig.context, referenceId: 'ORDER_PLACED', existingCommDefinitionId: 'cd_existing_1' },
+      },
+      initialData: { contentItems: [{ channel: 'SMS', templateData: {} }] },
+      onSave,
+    });
+
+    await userEvent.click(screen.getByRole('button', { name: /^save$/i }));
+
+    await waitFor(() => expect(editCommDefinition).toHaveBeenCalledTimes(1));
+    expect(await screen.findByText(/already in use in your organization/i)).toBeInTheDocument();
+    expect(onSave).not.toHaveBeenCalled();
+  });
 });
 
 describe('renderSteps — null returns and edge cases', () => {