@capillarytech/creatives-library 9.0.29 → 9.0.30

package/v2Components/CommonTestAndPreview/tests/DeliverySettings/ModifyDeliverySettings.test.js

@@ -187,7 +187,7 @@ describe('ModifyDeliverySettings', () => {
       const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
 
       renderComponent({
-        channel: 'RCS',
+        channel: 'UNSUPPORTED_CHANNEL',
         onSaveDeliverySettings: onSave,
       });
 
@@ -468,6 +468,31 @@ describe('ModifyDeliverySettings', () => {
       const domainOptions = Array.from(getSelects()[0].querySelectorAll('option')).map((opt) => opt.textContent);
       expect(domainOptions).not.toEqual(expect.arrayContaining(['Domain One']));
     });
+
+    it('should keep full domain list when TRAI DLT is enabled but no sender IDs are registered', () => {
+      renderComponent({
+        channel: CHANNELS.SMS,
+        senderDetailsOptions: [
+          {
+            domainId: 11,
+            domainName: 'Domain One',
+            gsmSenders: [{ value: 'ID1' }],
+            cdmaSenders: [],
+          },
+          {
+            domainId: 22,
+            domainName: 'Domain Two',
+            gsmSenders: [{ value: 'ID2' }],
+            cdmaSenders: [],
+          },
+        ],
+        smsTraiDltEnabled: true,
+        registeredSenderIds: [],
+      });
+
+      const domainOptions = Array.from(getSelects()[0].querySelectorAll('option')).map((opt) => opt.textContent);
+      expect(domainOptions).toEqual(expect.arrayContaining(['Domain One', 'Domain Two']));
+    });
   });
 
   describe('EMAIL flow', () => {
@@ -614,6 +639,22 @@ describe('ModifyDeliverySettings', () => {
       expect(senderNameOptions).toEqual(expect.arrayContaining(['fallback@test.com']));
       expect(replyToOptions).toEqual(expect.arrayContaining(['Reply Label']));
     });
+
+    it('should use reply-to label when value is empty in reply-to options', () => {
+      renderComponent({
+        channel: CHANNELS.EMAIL,
+        senderDetailsOptions: [{
+          domainId: 90,
+          domainName: 'Reply Label Domain',
+          emailSenders: [{ value: 'a@test.com' }],
+          emailRepliers: [{ label: 'OnlyLabel', value: '' }],
+        }],
+        deliverySettings: { domainId: 90, domainGatewayMapId: 1 },
+      });
+
+      const replyToOptions = Array.from(getSelects()[3].querySelectorAll('option')).map((opt) => opt.textContent);
+      expect(replyToOptions).toEqual(expect.arrayContaining(['OnlyLabel']));
+    });
   });
 
   describe('WHATSAPP flow', () => {
@@ -838,6 +879,19 @@ describe('ModifyDeliverySettings', () => {
         sourceAccountIdentifier: 'waba-1',
       });
     });
+
+    it('should render disabled CapLabel with label3 for locked WhatsApp account row', () => {
+      renderComponent({
+        channel: CHANNELS.WHATSAPP,
+        senderDetailsOptions: whatsappDomains,
+        wecrmAccounts,
+        whatsappAccountFromForm: { accountName: 'Account One' },
+      });
+
+      const labels = screen.getAllByTestId('cap-label');
+      const disabledHint = labels.find((el) => el.getAttribute('data-type') === 'label3');
+      expect(disabledHint).toBeTruthy();
+    });
   });
 
   describe('Done and close handling', () => {
@@ -886,105 +940,325 @@ describe('ModifyDeliverySettings', () => {
     });
   });
 
-  describe('onDomainChange — dgmId edge cases', () => {
-    it('should not update domainGatewayMapId when selected SMS domain has no dgmId', () => {
+  describe('RCS flow', () => {
+    const rcsDomains = [
+      {
+        domainId: 51,
+        domainName: 'RCS Domain A',
+        dgmId: 511,
+        gsmSenders: [{ value: 'RCS_GSM_1' }, { value: 'RCS_GSM_2' }],
+      },
+      {
+        domainId: 52,
+        domainName: 'RCS Domain B',
+        dgmId: 522,
+        gsmSenders: [{ value: 'RCS_OTHER' }],
+      },
+    ];
+
+    const smsFallbackDomains = [
+      {
+        domainId: 61,
+        domainName: 'SMS Fallback',
+        gsmSenders: [{ value: 'SMS_FB_1' }],
+      },
+    ];
+
+    it('should render RCS domain and sender selects', () => {
+      renderComponent({
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+      });
+      expect(getSelects()).toHaveLength(2);
+    });
+
+    it('should set composite gsm sender id when RCS domain changes', () => {
       const onSave = jest.fn();
 
       renderComponent({
-        channel: CHANNELS.SMS,
-        senderDetailsOptions: [
-          {
-            domainId: 99,
-            domainName: 'No DGM Domain',
-            // dgmId intentionally absent
-            gsmSenders: [{ value: 'GSM_99', default: true }],
-            cdmaSenders: [{ value: 'CDMA_99', default: true }],
-          },
-        ],
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        onSaveDeliverySettings: onSave,
+      });
+
+      fireEvent.change(getSelects()[0], { target: { value: '51' } });
+      fireEvent.click(screen.getByText('Done'));
+
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          domainId: 51,
+          gsmSenderId: '51|RCS_GSM_1',
+        }),
+      );
+    });
+
+    it('should render SMS fallback domain and sender when fallback options exist', () => {
+      renderComponent({
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        smsFallbackSenderDetailsOptions: smsFallbackDomains,
+      });
+      expect(getSelects()).toHaveLength(4);
+    });
+
+    it('should strip gsm and fallback sender ids that are not in current options on Done', () => {
+      const onSave = jest.fn();
+
+      renderComponent({
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        smsFallbackSenderDetailsOptions: smsFallbackDomains,
         deliverySettings: {
-          domainId: null,
-          domainGatewayMapId: 555,
+          domainId: 51,
+          gsmSenderId: 'not-a-valid-composite',
+          smsFallbackDomainId: 61,
+          cdmaSenderId: '61|SMS_FB_1',
+        },
+        onSaveDeliverySettings: onSave,
+      });
+
+      fireEvent.click(screen.getByText('Done'));
+
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          domainId: 51,
           gsmSenderId: '',
+          smsFallbackDomainId: 61,
+          cdmaSenderId: '61|SMS_FB_1',
+        }),
+      );
+    });
+
+    it('should strip invalid SMS fallback composite sender on Done', () => {
+      const onSave = jest.fn();
+
+      renderComponent({
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        smsFallbackSenderDetailsOptions: smsFallbackDomains,
+        deliverySettings: {
+          domainId: 51,
+          gsmSenderId: '51|RCS_GSM_1',
+          smsFallbackDomainId: 61,
+          cdmaSenderId: 'bogus|value',
+        },
+        onSaveDeliverySettings: onSave,
+      });
+
+      fireEvent.click(screen.getByText('Done'));
+
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          gsmSenderId: '51|RCS_GSM_1',
           cdmaSenderId: '',
+        }),
+      );
+    });
+
+    it('should filter SMS fallback domains and GSM senders when TRAI DLT and registered sender IDs apply', () => {
+      const fallbackDlt = [
+        {
+          domainId: 71,
+          domainName: 'Has Registered GSM',
+          gsmSenders: [{ value: 'REG_OK' }, { value: 'NOT_ON_DLT' }],
+        },
+        {
+          domainId: 72,
+          domainName: 'No Match',
+          gsmSenders: [{ value: 'UNMATCHED' }],
+        },
+      ];
+      const onSave = jest.fn();
+
+      renderComponent({
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        smsFallbackSenderDetailsOptions: fallbackDlt,
+        smsTraiDltEnabled: true,
+        registeredSenderIds: ['REG_OK'],
+        deliverySettings: {
+          domainId: 51,
+          gsmSenderId: '51|RCS_GSM_1',
+          smsFallbackDomainId: 71,
+          cdmaSenderId: '71|REG_OK',
         },
         onSaveDeliverySettings: onSave,
       });
 
-      fireEvent.change(getSelects()[0], { target: { value: '99' } });
       fireEvent.click(screen.getByText('Done'));
 
-      expect(onSave).toHaveBeenCalledWith({
-        domainId: 99,
-        domainGatewayMapId: 555, // unchanged — domain has no dgmId
-        gsmSenderId: 'GSM_99',
-        cdmaSenderId: 'CDMA_99',
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          smsFallbackDomainId: 71,
+          cdmaSenderId: '71|REG_OK',
+        }),
+      );
+    });
+
+    it('should set SMS fallback composite to first GSM after skipping domain-name echo row', () => {
+      const fallbackEcho = [
+        {
+          domainId: 80,
+          domainName: 'Echo',
+          gsmSenders: [{ value: 'Echo' }, { value: 'REAL_SENDER' }],
+        },
+      ];
+      const onSave = jest.fn();
+
+      renderComponent({
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        smsFallbackSenderDetailsOptions: fallbackEcho,
+        deliverySettings: {
+          domainId: 51,
+          gsmSenderId: '51|RCS_GSM_1',
+        },
+        onSaveDeliverySettings: onSave,
       });
+
+      fireEvent.change(getSelects()[2], { target: { value: '80' } });
+      fireEvent.click(screen.getByText('Done'));
+
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          smsFallbackDomainId: 80,
+          cdmaSenderId: '80|REAL_SENDER',
+        }),
+      );
     });
 
-    it('should not update domainGatewayMapId when selected EMAIL domain has no dgmId', () => {
+    it('should only list RCS sender options for the selected RCS domain', () => {
       const onSave = jest.fn();
 
       renderComponent({
-        channel: CHANNELS.EMAIL,
-        senderDetailsOptions: [
-          {
-            domainId: 55,
-            domainName: 'No DGM Email Domain',
-            // no dgmId
-            emailSenders: [{ value: 'sender@test.com', label: 'Sender', default: true }],
-            emailRepliers: [{ value: 'reply@test.com', default: true }],
-          },
-        ],
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        onSaveDeliverySettings: onSave,
         deliverySettings: {
-          domainId: null,
-          domainGatewayMapId: 777,
-          senderEmail: '',
-          senderLabel: '',
-          senderReplyTo: '',
+          domainId: 52,
+          gsmSenderId: '52|RCS_OTHER',
+        },
+      });
+
+      fireEvent.click(screen.getByText('Done'));
+
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          domainId: 52,
+          gsmSenderId: '52|RCS_OTHER',
+        }),
+      );
+    });
+
+    it('should set composite RCS gsm when domain id is numeric zero', () => {
+      const rcsWithZero = [
+        {
+          domainId: 0,
+          domainName: 'Zero Id',
+          dgmId: 1,
+          gsmSenders: [{ value: 'Z_GSM' }],
         },
+      ];
+      const onSave = jest.fn();
+
+      renderComponent({
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsWithZero,
         onSaveDeliverySettings: onSave,
       });
 
-      fireEvent.change(getSelects()[0], { target: { value: '55' } });
+      fireEvent.change(getSelects()[0], { target: { value: '0' } });
       fireEvent.click(screen.getByText('Done'));
 
-      expect(onSave).toHaveBeenCalledWith({
-        domainId: 55,
-        domainGatewayMapId: 777, // unchanged — domain has no dgmId
-        senderEmail: 'sender@test.com',
-        senderLabel: 'Sender',
-        senderReplyTo: 'reply@test.com',
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          domainId: 0,
+          gsmSenderId: '0|Z_GSM',
+        }),
+      );
+    });
+
+    it('should update RCS sender id directly when sender select changes', () => {
+      const onSave = jest.fn();
+
+      renderComponent({
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        onSaveDeliverySettings: onSave,
+        deliverySettings: {
+          domainId: 51,
+          gsmSenderId: '51|RCS_GSM_1',
+        },
       });
+
+      fireEvent.change(getSelects()[1], { target: { value: '51|RCS_GSM_2' } });
+      fireEvent.click(screen.getByText('Done'));
+
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          gsmSenderId: '51|RCS_GSM_2',
+        }),
+      );
     });
-  });
 
-  describe('findDefault fallback — first item used when no default:true', () => {
-    it('should use first gsm/cdma sender when none has default:true flag', () => {
+    it('should update SMS fallback sender id directly when fallback sender select changes', () => {
       const onSave = jest.fn();
 
       renderComponent({
-        channel: CHANNELS.SMS,
-        senderDetailsOptions: [
-          {
-            domainId: 77,
-            domainName: 'No Default Domain',
-            dgmId: 777,
-            gsmSenders: [{ value: 'FIRST_GSM' }, { value: 'SECOND_GSM' }],
-            cdmaSenders: [{ value: 'FIRST_CDMA' }, { value: 'SECOND_CDMA' }],
-          },
-        ],
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        smsFallbackSenderDetailsOptions: smsFallbackDomains,
         onSaveDeliverySettings: onSave,
+        deliverySettings: {
+          domainId: 51,
+          gsmSenderId: '51|RCS_GSM_1',
+          smsFallbackDomainId: 61,
+          cdmaSenderId: '61|SMS_FB_1',
+        },
       });
 
-      fireEvent.change(getSelects()[0], { target: { value: '77' } });
+      fireEvent.change(getSelects()[3], { target: { value: '61|SMS_FB_1' } });
       fireEvent.click(screen.getByText('Done'));
 
-      expect(onSave).toHaveBeenCalledWith({
-        domainId: 77,
-        domainGatewayMapId: 777,
-        gsmSenderId: 'FIRST_GSM',
-        cdmaSenderId: 'FIRST_CDMA',
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          cdmaSenderId: '61|SMS_FB_1',
+        }),
+      );
+    });
+
+    it('should filter fallback GSM senders by registered sender IDs when changing SMS fallback domain in TRAI DLT mode', () => {
+      const fallbackDlt = [
+        {
+          domainId: 90,
+          domainName: 'Fallback DLT Domain',
+          gsmSenders: [{ value: 'REG_SENDER' }, { value: 'UNREG_SENDER' }],
+        },
+      ];
+      const onSave = jest.fn();
+
+      renderComponent({
+        channel: CHANNELS.RCS,
+        senderDetailsOptions: rcsDomains,
+        smsFallbackSenderDetailsOptions: fallbackDlt,
+        smsTraiDltEnabled: true,
+        registeredSenderIds: ['REG_SENDER'],
+        deliverySettings: {
+          domainId: 51,
+          gsmSenderId: '51|RCS_GSM_1',
+        },
+        onSaveDeliverySettings: onSave,
       });
+
+      fireEvent.change(getSelects()[2], { target: { value: '90' } });
+      fireEvent.click(screen.getByText('Done'));
+
+      expect(onSave).toHaveBeenCalledWith(
+        expect.objectContaining({
+          smsFallbackDomainId: 90,
+          cdmaSenderId: '90|REG_SENDER',
+        }),
+      );
     });
   });
 });

package/v2Components/CommonTestAndPreview/tests/DeliverySettings/index.test.js

@@ -40,7 +40,7 @@ describe('DeliverySettings', () => {
   const defaultProps = {
     channel: CHANNELS.SMS,
     deliverySettings: {},
-    senderDetailsOptions: [],
+    senderDetailsByChannel: {},
     wecrmAccounts: [],
     onSaveDeliverySettings: jest.fn(),
     isLoadingSenderDetails: false,
@@ -85,14 +85,14 @@ describe('DeliverySettings', () => {
     });
 
     it('should show summary values for SMS when deliverySettings and senderDetailsOptions match', () => {
-      const senderDetailsOptions = [{ domainId: 1, domainName: 'SMS Domain' }];
+      const senderDetailsByChannel = { [CHANNELS.SMS]: [{ domainId: 1, domainName: 'SMS Domain' }] };
       const deliverySettings = { domainId: 1, gsmSenderId: 'SENDER1' };
       render(
         <DeliverySettings
           {...defaultProps}
           channel={CHANNELS.SMS}
           deliverySettings={deliverySettings}
-          senderDetailsOptions={senderDetailsOptions}
+          senderDetailsByChannel={senderDetailsByChannel}
         />
       );
       expect(screen.getAllByText(/SMS Domain/).length).toBeGreaterThan(0);
@@ -105,7 +105,7 @@ describe('DeliverySettings', () => {
     });
 
     it('should show summary for EMAIL when has domain and sender', () => {
-      const senderDetailsOptions = [{ domainId: 2, domainName: 'Email Domain' }];
+      const senderDetailsByChannel = { [CHANNELS.EMAIL]: [{ domainId: 2, domainName: 'Email Domain' }] };
       const deliverySettings = {
         domainId: 2,
         senderEmail: 'noreply@test.com',
@@ -117,7 +117,7 @@ describe('DeliverySettings', () => {
           {...defaultProps}
           channel={CHANNELS.EMAIL}
           deliverySettings={deliverySettings}
-          senderDetailsOptions={senderDetailsOptions}
+          senderDetailsByChannel={senderDetailsByChannel}
         />
       );
       expect(screen.getAllByText(/Email Domain/).length).toBeGreaterThan(0);
@@ -141,6 +141,76 @@ describe('DeliverySettings', () => {
       expect(screen.getAllByText(/WABA One/).length).toBeGreaterThan(0);
       expect(screen.getAllByText(/\+1234567890/).length).toBeGreaterThan(0);
     });
+
+    it('RCS: when isChannelSmsFallbackPreviewEnabled is false, summary omits fallback SMS sender even if cdma is set', () => {
+      const rcsDomain = {
+        domainId: 10,
+        domainName: 'RCS D',
+        gsmSenders: [{ value: 'R1', default: true }],
+      };
+      const smsDomain = {
+        domainId: 20,
+        domainName: 'SMS D',
+        gsmSenders: [{ value: 'F1', default: true }],
+      };
+      const senderDetailsByChannel = {
+        [CHANNELS.RCS]: [rcsDomain],
+        [CHANNELS.SMS]: [smsDomain],
+      };
+      const deliverySettings = {
+        gsmSenderId: '10|R1',
+        cdmaSenderId: '20|F1',
+      };
+      render(
+        <IntlProvider locale="en" messages={{}}>
+          <DeliverySettings
+            {...defaultProps}
+            channel={CHANNELS.RCS}
+            deliverySettings={deliverySettings}
+            senderDetailsByChannel={senderDetailsByChannel}
+            isChannelSmsFallbackPreviewEnabled={false}
+            formatMessage={(m) => m?.defaultMessage || m?.id || ''}
+          />
+        </IntlProvider>,
+      );
+      expect(screen.getAllByText(/R1/).length).toBeGreaterThan(0);
+      expect(screen.queryByText(/F1/)).toBeNull();
+    });
+
+    it('RCS: when isChannelSmsFallbackPreviewEnabled is true, summary includes fallback SMS sender', () => {
+      const rcsDomain = {
+        domainId: 10,
+        domainName: 'RCS D',
+        gsmSenders: [{ value: 'R1', default: true }],
+      };
+      const smsDomain = {
+        domainId: 20,
+        domainName: 'SMS D',
+        gsmSenders: [{ value: 'F1', default: true }],
+      };
+      const senderDetailsByChannel = {
+        [CHANNELS.RCS]: [rcsDomain],
+        [CHANNELS.SMS]: [smsDomain],
+      };
+      const deliverySettings = {
+        gsmSenderId: '10|R1',
+        cdmaSenderId: '20|F1',
+      };
+      render(
+        <IntlProvider locale="en" messages={{}}>
+          <DeliverySettings
+            {...defaultProps}
+            channel={CHANNELS.RCS}
+            deliverySettings={deliverySettings}
+            senderDetailsByChannel={senderDetailsByChannel}
+            isChannelSmsFallbackPreviewEnabled
+            formatMessage={(m) => m?.defaultMessage || m?.id || ''}
+          />
+        </IntlProvider>,
+      );
+      expect(screen.getAllByText(/R1/).length).toBeGreaterThan(0);
+      expect(screen.getAllByText(/F1/).length).toBeGreaterThan(0);
+    });
   });
 
   describe('edit and slidebox', () => {
@@ -169,6 +239,49 @@ describe('DeliverySettings', () => {
       );
     });
 
+    it('RCS: should not pass smsFallbackSenderDetailsOptions when isChannelSmsFallbackPreviewEnabled is false', () => {
+      render(
+        <DeliverySettings
+          {...defaultProps}
+          channel={CHANNELS.RCS}
+          senderDetailsByChannel={{
+            [CHANNELS.RCS]: [{ domainId: 1, domainName: 'R', gsmSenders: [] }],
+            [CHANNELS.SMS]: [{ domainId: 2, domainName: 'S', gsmSenders: [] }],
+          }}
+          isChannelSmsFallbackPreviewEnabled={false}
+        />,
+      );
+      fireEvent.click(screen.getByTestId('delivery-settings-edit'));
+      expect(mockModifyDeliverySettings).toHaveBeenCalledWith(
+        expect.objectContaining({
+          channel: CHANNELS.RCS,
+          smsFallbackSenderDetailsOptions: undefined,
+        }),
+      );
+    });
+
+    it('RCS: should pass smsFallbackSenderDetailsOptions when isChannelSmsFallbackPreviewEnabled is true', () => {
+      const smsDomains = [{ domainId: 2, domainName: 'S', gsmSenders: [] }];
+      render(
+        <DeliverySettings
+          {...defaultProps}
+          channel={CHANNELS.RCS}
+          senderDetailsByChannel={{
+            [CHANNELS.RCS]: [{ domainId: 1, domainName: 'R', gsmSenders: [] }],
+            [CHANNELS.SMS]: smsDomains,
+          }}
+          isChannelSmsFallbackPreviewEnabled
+        />,
+      );
+      fireEvent.click(screen.getByTestId('delivery-settings-edit'));
+      expect(mockModifyDeliverySettings).toHaveBeenCalledWith(
+        expect.objectContaining({
+          channel: CHANNELS.RCS,
+          smsFallbackSenderDetailsOptions: smsDomains,
+        }),
+      );
+    });
+
     it('should call onSaveDeliverySettings and close slidebox when Done is clicked', () => {
       const onSave = jest.fn();
       render(