@capillarytech/creatives-library 8.0.316-alpha.4 → 8.0.317-alpha.0

package/constants/unified.js

@@ -60,6 +60,7 @@ export const AI_CONTENT_BOT_DISABLED = 'AI_CONTENT_BOT_DISABLED';
 export const AI_DOCUMENTATION_BOT_ENABLED = 'AI_DOCUMENTATION_BOT_ENABLED';
 export const ENABLE_NEW_LEFT_NAVIGATION = 'ENABLE_NEW_LEFT_NAVIGATION';
 export const ENABLE_PRODUCT_SUPPORT_VIDEOS = 'ENABLE_PRODUCT_SUPPORT_VIDEOS';
+export const SUPPORT_ENGAGEMENT_MODULE = 'SUPPORT_ENGAGEMENT_MODULE';
 export const EMBEDDED = 'embedded';
 // --- Tag/Validation Constants ---
 export const CARD_RELATED_TAGS = [

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@capillarytech/creatives-library",
   "author": "meharaj",
-  "version": "8.0.316-alpha.4",
+  "version": "8.0.317-alpha.0",
   "description": "Capillary creatives ui",
   "main": "./index.js",
   "module": "./index.es.js",

package/services/api.js

@@ -334,6 +334,12 @@ export const getTemplateDetails = async ({id, channel}) => {
   return { ...compressedTemplatesData, response: decompressData};
 };
 
+export const getDomainProperties = (channels, orgUnitId) => {
+  const queryString = channels?.map((channel) => `channel=${channel?.toUpperCase()}`)?.join('&');
+  const url = `${CAMPAIGNS_API_ORG_ENDPOINT}/meta/domainProperties?${queryString}`;
+  return request(url, getAPICallObject('GET', null, false, true, orgUnitId));
+};
+
 export const getMediaDetails = async ({ id }) => {
   const url = `${API_ENDPOINT}/media/${id}`;
   return request(url, getAPICallObject('GET'));

package/services/tests/api.test.js

@@ -1,5 +1,6 @@
 import {
   getSenderDetails,
+  getDomainProperties,
   uploadFile,
   getCdnTransformationConfig,
   createWhatsappTemplate,
@@ -52,6 +53,12 @@ describe('getSenderDetails -- Test with valid responses', () => {
     expect(getSenderDetails('WHATSAPP', -1)).toEqual(Promise.resolve()));
 });
 
+describe('getDomainProperties -- Test with valid responses', () => {
+  it('Should return correct response', () => {
+    expect(getDomainProperties(['SMS', 'EMAIL'], null)).toEqual(Promise.resolve());
+  });
+});
+
 describe('getCdnTransformationConfigs -- Test with valid responses', () => {
   it('Should return correct response', () =>
     expect(getCdnTransformationConfig()).toEqual(Promise.resolve()));

package/utils/common.js

@@ -25,7 +25,8 @@ import {
   ENABLE_WEBPUSH,
   SUPPORT_CK_EDITOR,
   ENABLE_NEW_MPUSH,
-  ENABLE_NEW_EDITOR_FLOW_INAPP
+  ENABLE_NEW_EDITOR_FLOW_INAPP,
+  SUPPORT_ENGAGEMENT_MODULE,
 } from '../constants/unified';
 import { apiMessageFormatHandler } from './commonUtils';
 
@@ -96,6 +97,10 @@ export const hasSupportCKEditor = Auth.hasFeatureAccess.bind(
   null,
   SUPPORT_CK_EDITOR,
 );
+export const hasSupportEngagementModule = Auth.hasFeatureAccess.bind(
+  null,
+  SUPPORT_ENGAGEMENT_MODULE,
+);
 
 export const hasGiftVoucherFeature = Auth.hasFeatureAccess.bind(
   null,

package/utils/tests/tagValidations.test.js

@@ -242,6 +242,7 @@ describe("validateTags", () => {
       tagsParam,
       location,
       tagModule,
+      waitEventContextTags: {},
     });
 
     expect(result.valid).toEqual(true);
@@ -273,6 +274,7 @@ describe("validateTags", () => {
       tagsParam: tagsParamLocal,
       location,
       tagModule,
+      waitEventContextTags: {},
     });
 
     expect(result.valid).toEqual(true);
@@ -310,6 +312,7 @@ describe("validateTags", () => {
       tagsParam: tagsParamLocal,
       location,
       tagModule,
+      waitEventContextTags: {},
     });
 
     expect(result.valid).toEqual(false);
@@ -335,6 +338,7 @@ describe("validateTags", () => {
       tagsParam: tagsParamUnsubscribe,
       location,
       tagModule,
+      waitEventContextTags: {},
     });
     expect(resultMissing.missingTags).toContain("unsubscribe");
     expect(resultMissing.valid).toBe(false);
@@ -345,6 +349,7 @@ describe("validateTags", () => {
       tagsParam: tagsParamUnsubscribe,
       location,
       tagModule,
+      waitEventContextTags: {},
     });
     expect(resultSkipped.missingTags).not.toContain("unsubscribe");
     expect(resultSkipped.valid).toBe(true);
@@ -360,6 +365,35 @@ describe("validateTags", () => {
     expect(resultWhitespace.valid).toBe(true);
     expect(resultWhitespace.unsupportedTags ?? []).toEqual([]);
   });
+
+  it('should treat tags from waitEventContextTags as supported', () => {
+    const content = 'Hello {{waitEvent.orderId}}';
+    const tagsParam = [];
+    const injectedTagsParams = [];
+    const location = { query: { module: 'DEFAULT' } };
+    const tagModule = null;
+    const waitEventContextTags = {
+      block1: {
+        eventName: 'Order Placed',
+        blockName: 'Wait Block',
+        tags: [{ tagName: 'waitEvent.orderId', label: 'Order ID' }],
+      },
+    };
+
+    const result = validateTags({
+      content,
+      tagsParam,
+      injectedTagsParams,
+      location,
+      tagModule,
+      eventContextTags: [],
+      waitEventContextTags,
+    });
+
+    expect(result.valid).toEqual(true);
+    expect(result.missingTags).toEqual([]);
+    expect(result.isBraceError).toEqual(false);
+  });
 });
 
 describe('validateTags wrapper (v2 consumers)', () => {

package/v2Components/CapTagList/index.js

@@ -211,6 +211,7 @@ class CapTagList extends React.Component { // eslint-disable-line react/prefer-s
       } else if (info && info.selectedNodes && info.selectedNodes.length > 0 && !info.selectedNodes[0].props.isLeaf) {
         this.handleOnExpand(selectedKeys[0]);
       }
+      this.setState({expandedKeys: []})
     }
   };
 
@@ -233,6 +234,13 @@ class CapTagList extends React.Component { // eslint-disable-line react/prefer-s
     }
   };
 
+  /** Single-line ellipsis within popover width; full label on hover via CapTooltip. */
+  wrapTreeTitle = (displayNode, text) => (
+    <CapTooltip title={displayNode}>
+      <CapLabel.CapLabelInline type="label15" className="cap-tag-list-tree-title-wrap">{text || displayNode}</CapLabel.CapLabelInline>
+    </CapTooltip>
+  );
+
   renderDynamicTagFlow = () => {
     this.setState({showModal: true, visible: false});
   };
@@ -280,7 +288,7 @@ class CapTagList extends React.Component { // eslint-disable-line react/prefer-s
         if (temp?.length) {
           const tagValue = (
             <CapTreeNode
-              title={disabled ? <CapTooltip title={loyaltyAttrDisableText}>{val?.name}</CapTooltip> : val?.name}
+              title={disabled ? this.wrapTreeTitle(loyaltyAttrDisableText, val?.name) : this.wrapTreeTitle(val?.name)}
               tag={val}
               key={val?.incentiveSeriesId ? `${key}(${val?.incentiveSeriesId})` : `${key}`}
               disabled={disabled}
@@ -303,17 +311,9 @@ class CapTagList extends React.Component { // eslint-disable-line react/prefer-s
               <CapTreeNode
                 title={
                   childDisabled ? (
-                    <CapTooltip
-                      title={
-                        key === CUSTOMER_BARCODE_TAG
-                          ? customerBarcodeDisableText
-                          : loyaltyAttrDisableText
-                      }
-                    >
-                      {val?.desc || val?.name}
-                    </CapTooltip>
+                    this.wrapTreeTitle(key === CUSTOMER_BARCODE_TAG ? customerBarcodeDisableText : loyaltyAttrDisableText, val?.desc || val?.name)
                   ) : (
-                    val?.desc || val?.name
+                    this.wrapTreeTitle(val?.desc || val?.name)
                   )
                 }
                 tag={val}
@@ -339,17 +339,9 @@ class CapTagList extends React.Component { // eslint-disable-line react/prefer-s
             <CapTreeNode
               title={
                 childDisabled ? (
-                  <CapTooltip
-                    title={
-                      key === CUSTOMER_BARCODE_TAG
-                        ? customerBarcodeDisableText
-                        : loyaltyAttrDisableText
-                    }
-                  >
-                    {val?.desc || val?.name}
-                  </CapTooltip>
+                  this.wrapTreeTitle(key === CUSTOMER_BARCODE_TAG ? customerBarcodeDisableText : loyaltyAttrDisableText, val?.desc || val?.name)
                 ) : (
-                  val?.desc || val?.name
+                  this.wrapTreeTitle(val?.desc || val?.name)
                 )
               }
               tag={val}
@@ -407,7 +399,7 @@ class CapTagList extends React.Component { // eslint-disable-line react/prefer-s
       },
     ];
     const contentSection = (
-      <CapRow>
+      <CapRow className="cap-tag-list-popover-inner">
         <CapSpin tip={formatMessage(messages.gettingTags)} spinning={shouldShowLoading}>
           <Search
             style={{ marginBottom: 8, width: '250px'}}
@@ -475,6 +467,7 @@ class CapTagList extends React.Component { // eslint-disable-line react/prefer-s
             visible={fetchingSchemaError ? false : visible}
             onVisibleChange={this.togglePopoverVisibility}
             content={contentSection}
+            overlayClassName="cap-tag-list-popover-overlay"
             trigger="click"
             placement={this.props.popoverPlacement || (channel === EMAIL.toUpperCase() ? "leftTop" : "rightTop")}
             overlayStyle={overlayStyle}

package/v2Components/CapTagList/style.scss

@@ -1,5 +1,53 @@
 @import "~@capillarytech/cap-ui-library/styles/_variables";
 
+// Tag list popover: keep overlay width aligned with search (250px); tree rows ellipsis + tooltip for full text
+.cap-tag-list-popover-overlay.ant-popover {
+  .ant-popover-inner-content {
+    max-width: 20rem;
+    box-sizing: border-box;
+    overflow: hidden;
+  }
+}
+
+.cap-tag-list-popover-inner {
+  max-width: 20rem;
+  min-width: 0;
+  box-sizing: border-box;
+
+  .ant-tree.cap-tree-v2.ant-tree-icon-hide {
+    width: 100%;
+    max-width: 100%;
+
+    ul {
+      max-width: 100%;
+    }
+
+    li {
+      overflow: hidden;
+      max-width: 100%;
+    }
+
+    li .ant-tree-node-content-wrapper {
+      width: calc(100% - 3.5rem); // leave room for switcher (~24px)
+      max-width: calc(100% - 3.5rem);
+      overflow: hidden;
+      vertical-align: top;
+      box-sizing: border-box;
+    }
+
+    .cap-tag-list-tree-title-wrap {
+      display: inline-block;
+      width: 100%;
+      overflow: hidden;
+      text-overflow: ellipsis;
+      white-space: nowrap;
+      max-width: 100%;
+      vertical-align: top;
+      margin-top: 0.5rem;
+    }
+  }
+}
+
 @media (max-height: 25rem) {
   .ant-tree.cap-tree-v2.ant-tree-icon-hide {
     height: 8.5714rem;

package/v2Components/CapTagListWithInput/__tests__/CapTagListWithInput.test.js

@@ -0,0 +1,63 @@
+import React from 'react';
+import { render, screen } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import { IntlProvider } from 'react-intl';
+import CapTagListWithInput from '../index';
+
+const capturedTagListProps = { current: null };
+
+jest.mock('../../../v2Containers/TagList', () => {
+  const React = require('react');
+  const Mock = (props) => {
+    capturedTagListProps.current = props;
+    return <div data-testid="mock-tag-list">TagList</div>;
+  };
+  return Mock;
+});
+
+jest.mock('@capillarytech/cap-ui-library/CapRow', () => ({ children }) => <div>{children}</div>);
+jest.mock('@capillarytech/cap-ui-library/CapColumn', () => ({ children }) => <div>{children}</div>);
+jest.mock('@capillarytech/cap-ui-library/CapHeading', () => () => null);
+jest.mock('@capillarytech/cap-ui-library/CapInput', () => () => <input data-testid="cap-input" />);
+
+const waitMap = {
+  b1: { eventName: 'Order Placed', blockName: 'Wait', tags: [] },
+};
+
+describe('CapTagListWithInput', () => {
+  beforeEach(() => {
+    capturedTagListProps.current = null;
+  });
+
+  it('forwards waitEventContextTags to TagList', () => {
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CapTagListWithInput
+          inputId="test-url"
+          inputOnChange={jest.fn()}
+          waitEventContextTags={waitMap}
+          onTagSelect={jest.fn()}
+          onContextChange={jest.fn()}
+        />
+      </IntlProvider>
+    );
+
+    expect(screen.getByTestId('mock-tag-list')).toBeInTheDocument();
+    expect(capturedTagListProps.current.waitEventContextTags).toEqual(waitMap);
+  });
+
+  it('uses default empty object for waitEventContextTags when omitted', () => {
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CapTagListWithInput
+          inputId="test-url"
+          inputOnChange={jest.fn()}
+          onTagSelect={jest.fn()}
+          onContextChange={jest.fn()}
+        />
+      </IntlProvider>
+    );
+
+    expect(capturedTagListProps.current.waitEventContextTags).toEqual({});
+  });
+});

package/v2Components/CapTagListWithInput/index.js

@@ -27,6 +27,7 @@ export const CapTagListWithInput = (props) => {
     userLocale = 'en',
     eventContextTags = [],
     restrictPersonalization = false,
+    waitEventContextTags = {},
     // CapInput props
     inputId,
     inputValue = '',
@@ -77,6 +78,7 @@ export const CapTagListWithInput = (props) => {
             userLocale={userLocale}
             selectedOfferDetails={selectedOfferDetails}
             eventContextTags={eventContextTags}
+            waitEventContextTags={waitEventContextTags}
             style={tagListStyle}
             popoverPlacement={popoverPlacement}
             restrictPersonalization={restrictPersonalization}
@@ -116,6 +118,7 @@ CapTagListWithInput.propTypes = {
   userLocale: PropTypes.string,
   eventContextTags: PropTypes.array,
   restrictPersonalization: PropTypes.bool,
+  waitEventContextTags: PropTypes.object,
 
   // CapInput props
   inputId: PropTypes.string.isRequired,
@@ -154,6 +157,7 @@ CapTagListWithInput.defaultProps = {
   userLocale: 'en',
   eventContextTags: [],
   restrictPersonalization: false,
+  waitEventContextTags: {},
   inputValue: '',
   inputSize: 'default',
   inputRequired: false,

package/v2Components/CapWhatsappCTA/index.js

@@ -52,6 +52,7 @@ export const CapWhatsappCTA = (props) => {
     injectedTags = {},
     selectedOfferDetails = [],
     eventContextTags = [],
+    waitEventContextTags = {},
   } = props;
   const { formatMessage } = intl;
   const invalidVarRegex = /{{(.*?)}}/g;
@@ -283,6 +284,7 @@ export const CapWhatsappCTA = (props) => {
                   injectedTags={injectedTags}
                   selectedOfferDetails={selectedOfferDetails}
                   eventContextTags={eventContextTags}
+                  waitEventContextTags={waitEventContextTags}
                 />
               </CapColumn>
             )}

package/v2Components/CommonTestAndPreview/tests/CustomValuesEditor.test.js

@@ -169,4 +169,184 @@ describe('CustomValuesEditor', () => {
     );
     expect(screen.getAllByTestId('tag-input').length).toBeGreaterThan(0);
   });
+
+  it('renders section title as FormattedMessage when title is an intl message object (not a string)', () => {
+    render(
+      <IntlProvider locale="en" messages={{ 'section.title.id': 'Intl Section Title' }}>
+        <CustomValuesEditor
+          {...baseProps}
+          sections={[
+            {
+              key: 'intl-sec',
+              title: { id: 'section.title.id', defaultMessage: 'Intl Section Title' },
+              requiredTags: [{ fullPath: 'tag.a', name: 'a' }],
+              optionalTags: [],
+            },
+          ]}
+        />
+      </IntlProvider>,
+    );
+    expect(screen.getByText('Intl Section Title')).toBeInTheDocument();
+  });
+
+  it('renders section title as plain text when title is a string', () => {
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CustomValuesEditor
+          {...baseProps}
+          sections={[
+            {
+              key: 'str-sec',
+              title: 'Plain String Title',
+              requiredTags: [{ fullPath: 'tag.a', name: 'a' }],
+              optionalTags: [],
+            },
+          ]}
+        />
+      </IntlProvider>,
+    );
+    expect(screen.getByText('Plain String Title')).toBeInTheDocument();
+  });
+
+  it('renders nothing for section title when title is null (does not crash)', () => {
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CustomValuesEditor
+          {...baseProps}
+          sections={[
+            {
+              key: 'no-title-sec',
+              title: null,
+              requiredTags: [{ fullPath: 'tag.a', name: 'a' }],
+              optionalTags: [],
+            },
+          ]}
+        />
+      </IntlProvider>,
+    );
+    const inputs = screen.getAllByTestId('tag-input');
+    expect(inputs.length).toBeGreaterThan(0);
+  });
+
+  it('uses tag.name as column label when fullPath is absent', () => {
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CustomValuesEditor
+          {...baseProps}
+          sections={[
+            {
+              key: 'name-only',
+              title: 'Section',
+              requiredTags: [{ name: 'myTag' }],
+              optionalTags: [],
+            },
+          ]}
+        />
+      </IntlProvider>,
+    );
+    expect(screen.getByText('myTag')).toBeInTheDocument();
+  });
+
+  it('uses empty string as column label when both fullPath and name are absent', () => {
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CustomValuesEditor
+          {...baseProps}
+          sections={[
+            {
+              key: 'no-label',
+              title: 'Section',
+              requiredTags: [{}],
+              optionalTags: [],
+            },
+          ]}
+        />
+      </IntlProvider>,
+    );
+    const inputs = screen.getAllByTestId('tag-input');
+    expect(inputs.length).toBeGreaterThan(0);
+  });
+
+  it('renders optional-only section (no requiredTags) correctly', () => {
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CustomValuesEditor
+          {...baseProps}
+          sections={[
+            {
+              key: 'optional-only',
+              title: 'Optional Section',
+              requiredTags: [],
+              optionalTags: [{ fullPath: 'tag.opt', name: 'opt' }],
+            },
+          ]}
+        />
+      </IntlProvider>,
+    );
+    expect(screen.getByText('Optional Section')).toBeInTheDocument();
+    const inputs = screen.getAllByTestId('tag-input');
+    expect(inputs.length).toBeGreaterThan(0);
+  });
+
+  it('renders required-only section (no optionalTags) correctly', () => {
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CustomValuesEditor
+          {...baseProps}
+          sections={[
+            {
+              key: 'required-only',
+              title: 'Required Section',
+              requiredTags: [{ fullPath: 'tag.req', name: 'req' }],
+              optionalTags: [],
+            },
+          ]}
+        />
+      </IntlProvider>,
+    );
+    expect(screen.getByText('Required Section')).toBeInTheDocument();
+    const inputs = screen.getAllByTestId('tag-input');
+    expect(inputs.length).toBeGreaterThan(0);
+  });
+
+  it('renders line numbers in JSON mode matching JSON line count', () => {
+    const multiValueCustomValues = { a: 'val1', b: 'val2', c: 'val3' };
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CustomValuesEditor
+          {...baseProps}
+          showJSON
+          customValues={multiValueCustomValues}
+        />
+      </IntlProvider>,
+    );
+    const lineNumbers = document.querySelectorAll('.line-number');
+    const expectedLineCount = JSON.stringify(multiValueCustomValues, null, 2).split('\n').length;
+    expect(lineNumbers.length).toBe(expectedLineCount);
+  });
+
+  it('passes fullPath as key for required tag row when fullPath is present', () => {
+    const handleChange = jest.fn();
+    render(
+      <IntlProvider locale="en" messages={{}}>
+        <CustomValuesEditor
+          {...baseProps}
+          sections={[
+            {
+              key: 'sec',
+              title: 'S',
+              requiredTags: [{ fullPath: 'my.full.path', name: 'name' }],
+              optionalTags: [],
+            },
+          ]}
+          handleCustomValueChange={handleChange}
+          customValues={{ 'my.full.path': 'existing' }}
+        />
+      </IntlProvider>,
+    );
+    const input = screen.getByTestId('tag-input');
+    expect(input.value).toBe('existing');
+    fireEvent.change(input, { target: { value: 'updated' } });
+    expect(handleChange).toHaveBeenCalledWith('my.full.path', 'updated');
+  });
 });

package/v2Components/CommonTestAndPreview/tests/DeliverySettings/utils/parseSenderDetailsResponse.test.js

@@ -477,4 +477,100 @@ describe('parseSenderDetailsResponse', () => {
       expect(parseSenderDetailsResponse('SMS', response)).toEqual({ domains: [] });
     });
   });
+
+  describe('unwrapEntity edge cases', () => {
+    it('should return empty domains when entity key is explicitly null', () => {
+      // unwrapEntity: response.entity === null → returns null → parseSenderDetailsResponse returns { domains: [] }
+      expect(parseSenderDetailsResponse('SMS', { entity: null })).toEqual({ domains: [] });
+    });
+  });
+
+  describe('null or empty channel', () => {
+    it('should return empty domains when channel is null', () => {
+      const response = { entity: { SMS: [{ id: 1, domainProperties: { domainName: 'D', id: 10, contactInfo: [] } }] } };
+      expect(parseSenderDetailsResponse(null, response)).toEqual({ domains: [] });
+    });
+
+    it('should return empty domains when channel is empty string', () => {
+      const response = { entity: { SMS: [{ id: 1, domainProperties: { domainName: 'D', id: 10, contactInfo: [] } }] } };
+      expect(parseSenderDetailsResponse('', response)).toEqual({ domains: [] });
+    });
+  });
+
+  describe('single non-array domain object', () => {
+    it('should wrap single domain with domainProperties in an array and return one domain', () => {
+      const response = {
+        entity: {
+          SMS: {
+            id: 5,
+            domainProperties: {
+              domainName: 'SingleDomain',
+              id: 99,
+              contactInfo: [{ type: 'gsm_sender_id', valid: true, value: 'GSMSINGLE' }],
+            },
+          },
+        },
+      };
+      const result = parseSenderDetailsResponse('SMS', response);
+      expect(result.domains).toHaveLength(1);
+      expect(result.domains[0].domainName).toBe('SingleDomain');
+      expect(result.domains[0].gsmSenders[0].value).toBe('GSMSINGLE');
+    });
+
+    it('should return empty domains for single non-array domain without domainProperties', () => {
+      const response = {
+        entity: { SMS: { id: 5, someProp: 'value' } },
+      };
+      expect(parseSenderDetailsResponse('SMS', response)).toEqual({ domains: [] });
+    });
+  });
+
+  describe('deduplication by domainId when domainName is null', () => {
+    it('should deduplicate two entries sharing the same domainId when domainName is null', () => {
+      const response = {
+        entity: {
+          SMS: [
+            {
+              id: 10,
+              priority: 1,
+              domainProperties: { domainName: null, id: 42, contactInfo: [] },
+            },
+            {
+              id: 11,
+              priority: 2,
+              domainProperties: { domainName: null, id: 42, contactInfo: [] },
+            },
+          ],
+        },
+      };
+      const result = parseSenderDetailsResponse('SMS', response);
+      expect(result.domains).toHaveLength(1);
+      expect(result.domains[0].domainId).toBe(42);
+    });
+  });
+
+  describe('typeMatches null-type filtering', () => {
+    it('should exclude contactInfo items with null type from gsmSenders', () => {
+      const response = {
+        entity: {
+          SMS: [
+            {
+              id: 1,
+              domainProperties: {
+                domainName: 'D',
+                id: 1,
+                contactInfo: [
+                  { type: null, valid: true, value: 'EXCLUDED' },
+                  { type: 'gsm_sender_id', valid: true, value: 'INCLUDED' },
+                ],
+              },
+            },
+          ],
+        },
+      };
+      const result = parseSenderDetailsResponse('SMS', response);
+      expect(result.domains[0].gsmSenders).toHaveLength(1);
+      expect(result.domains[0].gsmSenders[0].value).toBe('INCLUDED');
+    });
+  });
 });