@capillarytech/creatives-library 8.0.292-alpha.1 → 8.0.292-alpha.2

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@capillarytech/creatives-library",
   "author": "meharaj",
-  "version": "8.0.292-alpha.1",
+  "version": "8.0.292-alpha.2",
   "description": "Capillary creatives ui",
   "main": "./index.js",
   "module": "./index.es.js",

package/v2Containers/MobilePush/Create/index.js

@@ -98,11 +98,11 @@ export class Create extends React.Component { // eslint-disable-line react/prefe
     // Library mode: on Done click (transition to isGetFormData), run extractTags only when no existing validation errors (braces, personalization, etc.)
     if (nextProps.isGetFormData && !this.props.isGetFormData && !nextProps.isFullMode) {
       // If form already has validation errors (braces, personalization tags, etc.), do not call extractTags; just fail
-      if (!this.state.isFormValid && nextProps.onValidationFail) {
+      if (!this.state.isFormValid && typeof nextProps.onValidationFail === 'function') {
         nextProps.onValidationFail();
         return;
       }
-      if (nextProps.getLiquidTags && nextProps.showLiquidErrorInFooter && nextProps.onValidationFail) {
+      if (typeof nextProps.getLiquidTags === 'function' && typeof nextProps.showLiquidErrorInFooter === 'function' && typeof nextProps.onValidationFail === 'function') {
         const formDataArr = [this.state.formData?.[0], this.state.formData?.[1]];
         validateMobilePushContent(formDataArr, {
           currentTab: this.state.currentTab,
@@ -115,21 +115,27 @@ export class Create extends React.Component { // eslint-disable-line react/prefe
             const toArray = (v) => (Array.isArray(v) ? v : (v && typeof v === 'object' ? [].concat(...Object.values(v)) : []));
             const STANDARD_ERROR_MSG = toArray(standardErrors);
             const LIQUID_ERROR_MSG = toArray(liquidErrors);
-            nextProps.showLiquidErrorInFooter(
-              { STANDARD_ERROR_MSG, LIQUID_ERROR_MSG },
-              this.state.currentTab
-            );
+            if (typeof nextProps.showLiquidErrorInFooter === 'function') {
+              nextProps.showLiquidErrorInFooter(
+                { STANDARD_ERROR_MSG, LIQUID_ERROR_MSG },
+                this.state.currentTab
+              );
+            }
             // Only trigger onValidationFail when there are actual errors; skip when helper called onError with empty arrays (reset case)
-            if (STANDARD_ERROR_MSG.length > 0 || LIQUID_ERROR_MSG.length > 0) {
+            if ((STANDARD_ERROR_MSG.length > 0 || LIQUID_ERROR_MSG.length > 0) && typeof nextProps.onValidationFail === 'function') {
               nextProps.onValidationFail();
             }
           },
           onSuccess: () => {
-            nextProps.getFormLibraryData(this.getFormData());
+            if (typeof nextProps.getFormLibraryData === 'function') {
+              nextProps.getFormLibraryData(this.getFormData());
+            }
           },
         });
-      } else {
+      } else if (typeof nextProps.getFormLibraryData === 'function') {
         nextProps.getFormLibraryData(this.getFormData());
+      } else if (typeof nextProps.onValidationFail === 'function') {
+        nextProps.onValidationFail();
       }
     } else if (nextProps.isGetFormData && this.props.isGetFormData !== nextProps.isGetFormData && this.props.isFullMode && !this.props.Create.createTemplateInProgress) {
       this.startValidation();

package/v2Containers/MobilePush/Edit/index.js

@@ -69,6 +69,7 @@ export class Edit extends React.Component { // eslint-disable-line react/prefer-
       schema: {},
       currentTab: 1,
       editData: {},
+      errorData: [],
       loading: false,
       isFormValid: true,
       injectedTags: {},
@@ -133,11 +134,11 @@ export class Edit extends React.Component { // eslint-disable-line react/prefer-
     // Library mode: on Done click (transition to isGetFormData), run extractTags only when no existing validation errors (braces, personalization, etc.)
     if (nextProps.isGetFormData && !this.props.isGetFormData && !nextProps.isFullMode) {
       // If form already has validation errors (braces, personalization tags, etc.), do not call extractTags; just fail
-      if (!this.state.isFormValid && nextProps.onValidationFail) {
-        nextProps.onValidationFail();
+      if (!this.state.isFormValid) {
+        nextProps.onValidationFail?.();
         return;
       }
-      if (nextProps.getLiquidTags && nextProps.showLiquidErrorInFooter && nextProps.onValidationFail) {
+      if (nextProps.getLiquidTags && nextProps.showLiquidErrorInFooter) {
         const formDataArr = [this.state.formData?.[0], this.state.formData?.[1]];
         validateMobilePushContent(formDataArr, {
           currentTab: this.state.currentTab,
@@ -156,8 +157,8 @@ export class Edit extends React.Component { // eslint-disable-line react/prefer-
             );
             // Only treat as validation failure when there are actual errors; skip when helper called onError with empty reset payload
             const hasErrors = STANDARD_ERROR_MSG.length > 0 || LIQUID_ERROR_MSG.length > 0;
-            if (hasErrors && nextProps.onValidationFail) {
-              nextProps.onValidationFail();
+            if (hasErrors) {
+              nextProps.onValidationFail?.();
             }
           },
           onSuccess: () => {
@@ -745,8 +746,8 @@ export class Edit extends React.Component { // eslint-disable-line react/prefer-
     const errorMessage = {key: 'validation-error', message: intl.formatMessage(messages.validationError)};
     if (!_.isEmpty(this.state.formData) && !this.state.isFormValid) {
       let tab = this.state.currentTab;
-      const isAndroidInvalid = Object.values(errorData[0] || {}).includes(true);
-      const isIosInvalid = Object.values(errorData[1] || {}).includes(true);
+      const isAndroidInvalid = Object.values(errorData?.[0] || {}).includes(true);
+      const isIosInvalid = Object.values(errorData?.[1] || {}).includes(true);
       const isIosTabVisible = get(schema, 'containers[0].panes[1].isSupported', true) !== false;
       if (isAndroidInvalid) {
         tab = 1;