@capillarytech/creatives-library 8.0.292-alpha.0 → 8.0.293

package/utils/tests/commonUtil.test.js

@@ -22,17 +22,13 @@ describe("validateLiquidTemplateContent", () => {
     somethingWentWrong: { id: "wrong" },
     unsupportedTagsValidationError: { id: "unsupported" }
   };
+  const tagLookupMap = { foo: true };
   const eventContextTags = [{ tagName: "bar" }];
   const onError = jest.fn();
   const onSuccess = jest.fn();
 
   beforeEach(() => {
     jest.clearAllMocks();
-    formatMessage.mockImplementation((msg, vars) =>
-      vars && vars.unsupportedTags != null
-        ? `${msg?.id}:${vars.unsupportedTags}`
-        : (msg?.id ?? "unsupported")
-    );
   });
 
   it("calls onError for empty content", async () => {
@@ -45,10 +41,11 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
-      standardErrors: ["empty"],
+      standardErrors: [undefined],
       liquidErrors: [],
       tabType: undefined
     });
@@ -63,6 +60,7 @@ describe("validateLiquidTemplateContent", () => {
       getLiquidTags,
       formatMessage,
       messages,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).not.toHaveBeenCalled();
@@ -79,6 +77,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
@@ -102,6 +101,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
@@ -124,6 +124,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
@@ -144,6 +145,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
@@ -164,6 +166,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
@@ -194,6 +197,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
@@ -214,6 +218,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
@@ -223,15 +228,9 @@ describe("validateLiquidTemplateContent", () => {
     });
   });
 
-  it("calls onError when API returns success but response.errors has validation errors (e.g. unsupported tag)", async () => {
+  it("calls onError for unsupported tags", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
-      cb({
-        askAiraResponse: {
-          errors: [{ message: "Unsupported tag: custom_tag" }],
-          data: []
-        },
-        isError: false
-      })
+      cb({ askAiraResponse: { errors: [], data: [{ name: "baz" }] }, isError: false })
     );
     await validateLiquidTemplateContent("foo", {
       getLiquidTags,
@@ -239,33 +238,18 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
       standardErrors: [],
-      liquidErrors: ["Unsupported tag: custom_tag"],
+      liquidErrors: [undefined],
       tabType: undefined
     });
     expect(onSuccess).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns no errors and a single extracted tag (extracted tags are not validated)", async () => {
-    const getLiquidTags = jest.fn((content, cb) =>
-      cb({ askAiraResponse: { errors: [], data: [{ name: "foo" }] }, isError: false })
-    );
-    await validateLiquidTemplateContent("foo", {
-      getLiquidTags,
-      formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags
-    });
-    expect(onSuccess).toHaveBeenCalledWith("foo", undefined);
-    expect(onError).not.toHaveBeenCalled();
-  });
-
-  it("calls onSuccess for valid content when API returns multiple extracted tags but no errors", async () => {
+  it("calls onSuccess for valid content", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "foo" }, { name: "bar" }] }, isError: false })
     );
@@ -275,6 +259,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onSuccess).toHaveBeenCalledWith("foo", undefined);
@@ -290,6 +275,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -307,6 +293,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -324,6 +311,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -341,6 +329,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -358,6 +347,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -375,6 +365,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -392,6 +383,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -409,6 +401,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -426,6 +419,7 @@ describe("validateLiquidTemplateContent", () => {
     };
     const onError = jest.fn();
     const onSuccess = jest.fn();
+    const tagLookupMap = {};
     const eventContextTags = [];
     await validateLiquidTemplateContent('', {
       getLiquidTags,
@@ -433,6 +427,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
     });
     expect(formatMessage).toHaveBeenCalledWith(messages.emailBodyEmptyError);
@@ -444,7 +439,7 @@ describe("validateLiquidTemplateContent", () => {
     expect(onSuccess).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns extracted tags from {% for %} template but no errors (extracted tags are not validated)", async () => {
+  it("should skip tags that appear in {% %} syntax (like order.items in for loop)", async () => {
     const content = '{% for item in order.items %} Hello {% endfor %}';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "order.items" }] }, isError: false })
@@ -455,13 +450,15 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
+    // order.items appears in {% %} syntax, so it should be skipped and validation should pass
     expect(onSuccess).toHaveBeenCalledWith(content, undefined);
     expect(onError).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns extracted tags in {% %} blocks but no errors", async () => {
+  it("should skip tags that appear only inside {% %} blocks (like item.name in for loop)", async () => {
     const content = '{% for item in order.items %} {{ item.name }} - {{ item.quantity }} {% endfor %}';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "item.name" }, { name: "item.quantity" }] }, isError: false })
@@ -472,13 +469,15 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
+    // item.name and item.quantity appear inside {% for %} block, so they should be skipped
     expect(onSuccess).toHaveBeenCalledWith(content, undefined);
     expect(onError).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns extracted tags not in content but no errors", async () => {
+  it("should validate tags that don't appear in content but are extracted by API", async () => {
     const content = 'Some content without the tag';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "extractedTag" }] }, isError: false })
@@ -489,13 +488,19 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
+    // extractedTag doesn't appear in content but was extracted by API, should be validated
+    expect(onError).toHaveBeenCalledWith({
+      standardErrors: [],
+      liquidErrors: [undefined],
+      tabType: undefined
+    });
+    expect(onSuccess).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns tags outside {% %} but no errors", async () => {
+  it("should validate tags that appear outside {% %} blocks", async () => {
     const content = '{{ outsideTag }} {% for item in order.items %} {{ item.name }} {% endfor %}';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "outsideTag" }, { name: "item.name" }] }, isError: false })
@@ -506,70 +511,20 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
-  });
-
-  it("calls onSuccess when API returns tag in {{ }} and no errors", async () => {
-    const content = 'Hello {{ unsupportedTag }} world';
-    const getLiquidTags = jest.fn((content, cb) =>
-      cb({ askAiraResponse: { errors: [], data: [{ name: "unsupportedTag" }] }, isError: false })
-    );
-    await validateLiquidTemplateContent(content, {
-      getLiquidTags,
-      formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags
-    });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
-  });
-
-  it("calls onSuccess when API returns tag with spacing variants and no errors", async () => {
-    const content = '{{ tag}} and {{tag }} and {{ tag }}';
-    const getLiquidTags = jest.fn((content, cb) =>
-      cb({
-        askAiraResponse: {
-          errors: [],
-          data: [{ name: "tag" }]
-        },
-        isError: false
-      })
-    );
-    await validateLiquidTemplateContent(content, {
-      getLiquidTags,
-      formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags
-    });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
-  });
-
-  it("calls onSuccess when API returns tag inside {% %} blocks but no errors", async () => {
-    const content = '{% for x in some.unsupported %} {{ x }} {% endfor %}';
-    const getLiquidTags = jest.fn((content, cb) =>
-      cb({ askAiraResponse: { errors: [], data: [{ name: "some.unsupported" }] }, isError: false })
-    );
-    await validateLiquidTemplateContent(content, {
-      getLiquidTags,
-      formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags
+    // outsideTag appears outside {% %} block, so it should be validated
+    // item.name appears inside block, so it should be skipped
+    expect(onError).toHaveBeenCalledWith({
+      standardErrors: [],
+      liquidErrors: [undefined],
+      tabType: undefined
     });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
+    expect(onSuccess).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns tags with dots in {% %} syntax but no errors", async () => {
+  it("should skip tags with dots that appear in {% %} syntax", async () => {
     const content = '{% assign myVar = order.items %} Some text';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "order.items" }] }, isError: false })
@@ -580,8 +535,10 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
+    // order.items appears in {% %} syntax, so it should be skipped
     expect(onSuccess).toHaveBeenCalledWith(content, undefined);
     expect(onError).not.toHaveBeenCalled();
   });
@@ -636,6 +593,7 @@ describe("validateMobilePushContent", () => {
     somethingWentWrong: { id: "wrong" },
     unsupportedTagsValidationError: { id: "unsupported" }
   };
+  const tagLookupMap = { foo: true };
   const eventContextTags = [{ tagName: "foo" }];
   const onError = jest.fn();
   const onSuccess = jest.fn();
@@ -644,7 +602,7 @@ describe("validateMobilePushContent", () => {
     jest.clearAllMocks();
   });
 
-  it("calls onError for empty formData (validateMobilePushContent)", async () => {
+  it("calls onError for empty formData", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [] }, isError: false })
     );
@@ -653,17 +611,18 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1
       }
     );
     expect(onError).toHaveBeenCalled();
   });
 
-  it("calls onSuccess for valid android and ios content (validateMobilePushContent)", async () => {
+  it("calls onSuccess for valid android and ios content", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [] }, isError: false })
     );
@@ -674,6 +633,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       currentTab: 1
     });
@@ -691,6 +651,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       currentTab: 1
     });
@@ -708,6 +669,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       currentTab: 2
     });
@@ -725,6 +687,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onSuccess).toHaveBeenCalledWith(JSON.stringify(formData[0]), "android");
@@ -741,6 +704,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onSuccess).toHaveBeenCalledWith("null", "android");
@@ -753,10 +717,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1,
       },
     );
@@ -770,10 +735,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1,
       },
     );
@@ -787,10 +753,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1,
       },
     );
@@ -804,10 +771,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1,
       },
     );
@@ -821,10 +789,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -837,10 +806,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -853,10 +823,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -869,10 +840,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -885,10 +857,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -902,6 +875,7 @@ describe("validateInAppContent", () => {
     somethingWentWrong: { id: "wrong" },
     unsupportedTagsValidationError: { id: "unsupported" }
   };
+  const tagLookupMap = { foo: true };
   const eventContextTags = [{ tagName: "foo" }];
   const onError = jest.fn();
   const onSuccess = jest.fn();
@@ -910,7 +884,7 @@ describe("validateInAppContent", () => {
     jest.clearAllMocks();
   });
 
-  it("calls onError for empty formData (validateInAppContent)", async () => {
+  it("calls onError for empty formData", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [] }, isError: false })
     );
@@ -919,16 +893,17 @@ describe("validateInAppContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       }
     );
     expect(onError).toHaveBeenCalled();
   });
 
-  it("calls onSuccess for valid android and ios content (validateInAppContent)", async () => {
+  it("calls onSuccess for valid android and ios content", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [] }, isError: false })
     );
@@ -948,6 +923,7 @@ describe("validateInAppContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       singleTab: ANDROID,
     });
@@ -974,6 +950,7 @@ describe("validateInAppContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       singleTab: IOS,
     });
@@ -1000,11 +977,11 @@ describe("getChannelData", () => {
     expect(getChannelData("SMS", formData)).toBe("Hi Test");
   });
 
-  it("returns string with undefineds for SMS when base and template-name are empty or undefined", () => {
+  it("returns string with undefineds for SMS channel with missing fields", () => {
     const formData = { base: {}, "template-name": undefined };
     expect(getChannelData("SMS", formData)).toBe("undefined undefined");
   });
-  it("returns string with undefineds for SMS when formData is empty string", () => {
+  it("returns string with undefineds for SMS channel with missing fields", () => {
     expect(getChannelData("SMS", "")).toBe("undefined undefined");
   });