@capillarytech/creatives-library 8.0.287-alpha.0 → 8.0.287

package/utils/tests/commonUtil.test.js

@@ -20,17 +20,13 @@ describe("validateLiquidTemplateContent", () => {
     somethingWentWrong: { id: "wrong" },
     unsupportedTagsValidationError: { id: "unsupported" }
   };
+  const tagLookupMap = { foo: true };
   const eventContextTags = [{ tagName: "bar" }];
   const onError = jest.fn();
   const onSuccess = jest.fn();
 
   beforeEach(() => {
     jest.clearAllMocks();
-    formatMessage.mockImplementation((msg, vars) =>
-      vars && vars.unsupportedTags != null
-        ? `${msg?.id}:${vars.unsupportedTags}`
-        : (msg?.id ?? "unsupported")
-    );
   });
 
   it("calls onError for empty content", async () => {
@@ -43,10 +39,11 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
-      standardErrors: ["empty"],
+      standardErrors: [undefined],
       liquidErrors: [],
       tabType: undefined
     });
@@ -61,6 +58,7 @@ describe("validateLiquidTemplateContent", () => {
       getLiquidTags,
       formatMessage,
       messages,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).not.toHaveBeenCalled();
@@ -77,6 +75,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
@@ -87,15 +86,9 @@ describe("validateLiquidTemplateContent", () => {
     expect(onSuccess).not.toHaveBeenCalled();
   });
 
-  it("calls onError when API returns success but response.errors has validation errors (e.g. unsupported tag)", async () => {
+  it("calls onError for unsupported tags", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
-      cb({
-        askAiraResponse: {
-          errors: [{ message: "Unsupported tag: custom_tag" }],
-          data: []
-        },
-        isError: false
-      })
+      cb({ askAiraResponse: { errors: [], data: [{ name: "baz" }] }, isError: false })
     );
     await validateLiquidTemplateContent("foo", {
       getLiquidTags,
@@ -103,33 +96,18 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onError).toHaveBeenCalledWith({
       standardErrors: [],
-      liquidErrors: ["Unsupported tag: custom_tag"],
+      liquidErrors: [undefined],
       tabType: undefined
     });
     expect(onSuccess).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns no errors and a single extracted tag (extracted tags are not validated)", async () => {
-    const getLiquidTags = jest.fn((content, cb) =>
-      cb({ askAiraResponse: { errors: [], data: [{ name: "foo" }] }, isError: false })
-    );
-    await validateLiquidTemplateContent("foo", {
-      getLiquidTags,
-      formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags
-    });
-    expect(onSuccess).toHaveBeenCalledWith("foo", undefined);
-    expect(onError).not.toHaveBeenCalled();
-  });
-
-  it("calls onSuccess for valid content when API returns multiple extracted tags but no errors", async () => {
+  it("calls onSuccess for valid content", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "foo" }, { name: "bar" }] }, isError: false })
     );
@@ -139,6 +117,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onSuccess).toHaveBeenCalledWith("foo", undefined);
@@ -154,6 +133,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -171,6 +151,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -188,6 +169,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -205,6 +187,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -222,6 +205,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -239,6 +223,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -256,6 +241,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -273,6 +259,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       skipTags
     });
@@ -290,6 +277,7 @@ describe("validateLiquidTemplateContent", () => {
     };
     const onError = jest.fn();
     const onSuccess = jest.fn();
+    const tagLookupMap = {};
     const eventContextTags = [];
     await validateLiquidTemplateContent('', {
       getLiquidTags,
@@ -297,6 +285,7 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
     });
     expect(formatMessage).toHaveBeenCalledWith(messages.emailBodyEmptyError);
@@ -308,7 +297,7 @@ describe("validateLiquidTemplateContent", () => {
     expect(onSuccess).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns extracted tags from {% for %} template but no errors (extracted tags are not validated)", async () => {
+  it("should skip tags that appear in {% %} syntax (like order.items in for loop)", async () => {
     const content = '{% for item in order.items %} Hello {% endfor %}';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "order.items" }] }, isError: false })
@@ -319,13 +308,15 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
+    // order.items appears in {% %} syntax, so it should be skipped and validation should pass
     expect(onSuccess).toHaveBeenCalledWith(content, undefined);
     expect(onError).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns extracted tags in {% %} blocks but no errors", async () => {
+  it("should skip tags that appear only inside {% %} blocks (like item.name in for loop)", async () => {
     const content = '{% for item in order.items %} {{ item.name }} - {{ item.quantity }} {% endfor %}';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "item.name" }, { name: "item.quantity" }] }, isError: false })
@@ -336,13 +327,15 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
+    // item.name and item.quantity appear inside {% for %} block, so they should be skipped
     expect(onSuccess).toHaveBeenCalledWith(content, undefined);
     expect(onError).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns extracted tags not in content but no errors", async () => {
+  it("should validate tags that don't appear in content but are extracted by API", async () => {
     const content = 'Some content without the tag';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "extractedTag" }] }, isError: false })
@@ -353,13 +346,19 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
+    // extractedTag doesn't appear in content but was extracted by API, should be validated
+    expect(onError).toHaveBeenCalledWith({
+      standardErrors: [],
+      liquidErrors: [undefined],
+      tabType: undefined
+    });
+    expect(onSuccess).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns tags outside {% %} but no errors", async () => {
+  it("should validate tags that appear outside {% %} blocks", async () => {
     const content = '{{ outsideTag }} {% for item in order.items %} {{ item.name }} {% endfor %}';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "outsideTag" }, { name: "item.name" }] }, isError: false })
@@ -370,70 +369,20 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
-  });
-
-  it("calls onSuccess when API returns tag in {{ }} and no errors", async () => {
-    const content = 'Hello {{ unsupportedTag }} world';
-    const getLiquidTags = jest.fn((content, cb) =>
-      cb({ askAiraResponse: { errors: [], data: [{ name: "unsupportedTag" }] }, isError: false })
-    );
-    await validateLiquidTemplateContent(content, {
-      getLiquidTags,
-      formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags
-    });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
-  });
-
-  it("calls onSuccess when API returns tag with spacing variants and no errors", async () => {
-    const content = '{{ tag}} and {{tag }} and {{ tag }}';
-    const getLiquidTags = jest.fn((content, cb) =>
-      cb({
-        askAiraResponse: {
-          errors: [],
-          data: [{ name: "tag" }]
-        },
-        isError: false
-      })
-    );
-    await validateLiquidTemplateContent(content, {
-      getLiquidTags,
-      formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags
-    });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
-  });
-
-  it("calls onSuccess when API returns tag inside {% %} blocks but no errors", async () => {
-    const content = '{% for x in some.unsupported %} {{ x }} {% endfor %}';
-    const getLiquidTags = jest.fn((content, cb) =>
-      cb({ askAiraResponse: { errors: [], data: [{ name: "some.unsupported" }] }, isError: false })
-    );
-    await validateLiquidTemplateContent(content, {
-      getLiquidTags,
-      formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags
+    // outsideTag appears outside {% %} block, so it should be validated
+    // item.name appears inside block, so it should be skipped
+    expect(onError).toHaveBeenCalledWith({
+      standardErrors: [],
+      liquidErrors: [undefined],
+      tabType: undefined
     });
-    expect(onSuccess).toHaveBeenCalledWith(content, undefined);
-    expect(onError).not.toHaveBeenCalled();
+    expect(onSuccess).not.toHaveBeenCalled();
   });
 
-  it("calls onSuccess when API returns tags with dots in {% %} syntax but no errors", async () => {
+  it("should skip tags with dots that appear in {% %} syntax", async () => {
     const content = '{% assign myVar = order.items %} Some text';
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [{ name: "order.items" }] }, isError: false })
@@ -444,8 +393,10 @@ describe("validateLiquidTemplateContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
+    // order.items appears in {% %} syntax, so it should be skipped
     expect(onSuccess).toHaveBeenCalledWith(content, undefined);
     expect(onError).not.toHaveBeenCalled();
   });
@@ -500,6 +451,7 @@ describe("validateMobilePushContent", () => {
     somethingWentWrong: { id: "wrong" },
     unsupportedTagsValidationError: { id: "unsupported" }
   };
+  const tagLookupMap = { foo: true };
   const eventContextTags = [{ tagName: "foo" }];
   const onError = jest.fn();
   const onSuccess = jest.fn();
@@ -508,7 +460,7 @@ describe("validateMobilePushContent", () => {
     jest.clearAllMocks();
   });
 
-  it("calls onError for empty formData (validateMobilePushContent)", async () => {
+  it("calls onError for empty formData", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [] }, isError: false })
     );
@@ -517,17 +469,18 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1
       }
     );
     expect(onError).toHaveBeenCalled();
   });
 
-  it("calls onSuccess for valid android and ios content (validateMobilePushContent)", async () => {
+  it("calls onSuccess for valid android and ios content", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [] }, isError: false })
     );
@@ -538,6 +491,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       currentTab: 1
     });
@@ -555,6 +509,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       currentTab: 1
     });
@@ -572,6 +527,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       currentTab: 2
     });
@@ -589,6 +545,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onSuccess).toHaveBeenCalledWith(JSON.stringify(formData[0]), "android");
@@ -605,6 +562,7 @@ describe("validateMobilePushContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags
     });
     expect(onSuccess).toHaveBeenCalledWith("null", "android");
@@ -617,10 +575,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1,
       },
     );
@@ -634,10 +593,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1,
       },
     );
@@ -651,10 +611,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1,
       },
     );
@@ -668,10 +629,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
         currentTab: 1,
       },
     );
@@ -685,10 +647,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -701,10 +664,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -717,10 +681,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -733,10 +698,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -749,10 +715,11 @@ describe("validateMobilePushContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       },
     );
     expect(onError).toHaveBeenCalled();
@@ -766,6 +733,7 @@ describe("validateInAppContent", () => {
     somethingWentWrong: { id: "wrong" },
     unsupportedTagsValidationError: { id: "unsupported" }
   };
+  const tagLookupMap = { foo: true };
   const eventContextTags = [{ tagName: "foo" }];
   const onError = jest.fn();
   const onSuccess = jest.fn();
@@ -774,7 +742,7 @@ describe("validateInAppContent", () => {
     jest.clearAllMocks();
   });
 
-  it("calls onError for empty formData (validateInAppContent)", async () => {
+  it("calls onError for empty formData", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [] }, isError: false })
     );
@@ -783,16 +751,17 @@ describe("validateInAppContent", () => {
       {
         getLiquidTags,
         formatMessage,
-      messages,
-      onError,
-      onSuccess,
-      eventContextTags,
+        messages,
+        onError,
+        onSuccess,
+        tagLookupMap,
+        eventContextTags,
       }
     );
     expect(onError).toHaveBeenCalled();
   });
 
-  it("calls onSuccess for valid android and ios content (validateInAppContent)", async () => {
+  it("calls onSuccess for valid android and ios content", async () => {
     const getLiquidTags = jest.fn((content, cb) =>
       cb({ askAiraResponse: { errors: [], data: [] }, isError: false })
     );
@@ -812,6 +781,7 @@ describe("validateInAppContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       singleTab: ANDROID,
     });
@@ -838,6 +808,7 @@ describe("validateInAppContent", () => {
       messages,
       onError,
       onSuccess,
+      tagLookupMap,
       eventContextTags,
       singleTab: IOS,
     });
@@ -864,11 +835,11 @@ describe("getChannelData", () => {
     expect(getChannelData("SMS", formData)).toBe("Hi Test");
   });
 
-  it("returns string with undefineds for SMS when base and template-name are empty or undefined", () => {
+  it("returns string with undefineds for SMS channel with missing fields", () => {
     const formData = { base: {}, "template-name": undefined };
     expect(getChannelData("SMS", formData)).toBe("undefined undefined");
   });
-  it("returns string with undefineds for SMS when formData is empty string", () => {
+  it("returns string with undefineds for SMS channel with missing fields", () => {
     expect(getChannelData("SMS", "")).toBe("undefined undefined");
   });