@capillarytech/creatives-library 7.17.108-alpha.0 → 7.17.109

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@capillarytech/creatives-library",
   "author": "meharaj",
-  "version": "7.17.108-alpha.0",
+  "version": "7.17.109",
   "description": "Capillary creatives ui",
   "main": "./index.js",
   "module": "./index.es.js",

package/services/api.js

@@ -84,7 +84,7 @@ function checkStatus(response) {
       statusCode: status,
     });
   }
-  if ((status >= 200 && status < 300) || [500, 409, 413].includes(response.status)) {
+  if ((status >= 200 && status < 300) || [400, 409, 413, 500].includes(response.status)) {
     return response;
   }
   const isLoginPage = window.location.pathname.indexOf('/login') !== -1;

package/v2Containers/Whatsapp/sagas.js

@@ -1,5 +1,7 @@
 import { take, cancel, call, put, takeLatest } from 'redux-saga/effects';
 import { LOCATION_CHANGE } from 'react-router-redux';
+import isEmpty from 'lodash/isEmpty';
+import get from 'lodash/get';
 import * as Api from '../../services/api';
 import {
   TEMPLATE_CREATE_REQUEST,
@@ -44,7 +46,19 @@ export function* sendForApprovalCreate({ payload, callback, gupshupMediaFile })
   try {
     const result = yield call(Api.createWhatsappTemplate, { payload, gupshupMediaFile });
     if (result?.status?.code && result.status.code >= 400) {
-      errorMsg = result?.message || result.status.code;
+      const { message, status } = result || {};
+      const errorMessageObj = get(message?.error, 'errorMessage', {});
+      if (!isEmpty(errorMessageObj)) {
+        try {
+          // If the errorMessageObj is plain JS and JSON.parse fails, catch block will assign the error msg
+          const parsedErrorMsgObj = JSON.parse(errorMessageObj);
+          errorMsg = parsedErrorMsgObj?.error?.message;
+        } catch (error) {
+          errorMsg = message;
+        }
+      } else {
+        errorMsg = message || status.code;
+      }
       throw errorMsg;
     }
     yield put({

package/v2Containers/Whatsapp/tests/mockData.js

@@ -251,4 +251,75 @@ export const mockData = {
     description: 'sample',
     url: "https://capillarytech.com",
   },
+  sendForApprovalCreatePayload: {
+    name: 'dffdf',
+    versions: {
+      base: {
+        content: {
+          whatsapp: {
+            category: 'UTILITY',
+            languages: [
+              {
+                language: 'sq',
+                content: 'fdfd',
+              },
+            ],
+            buttonType: 'CTA',
+            buttons: [
+              {
+                index: 0,
+                type: 'PHONE_NUMBER',
+                text: 'tt',
+                phone_number: '+913333333333333',
+              },
+            ],
+            mediaType: 'TEXT',
+            varMapped: {},
+            templateEditor: false,
+            accountId: '123456789',
+            accessToken: '12345',
+            hostName: 'karixwhatsappbulk',
+            whatsappMedia: {
+              header: '',
+              headerVarMapped: {},
+              headerTemplate: false,
+              footer: '',
+            },
+          },
+        },
+      },
+    },
+    type: "WHATSAPP",
+  },
+  sendForApprovalCreateResult1: {
+    success: false,
+    status: {
+      isError: true,
+      code: 400,
+    },
+    message: {
+      name: "StatusCodeError",
+      statusCode: 500,
+      error: {
+        errorCode: "1004",
+        errorMessage: "{\"error\":{\"message\":\"(#192) Param components[1]['buttons'][0]['phone_number'] is not a valid phone number.\",\"type\":\"OAuthException\",\"code\":192,\"fbtrace_id\":\"12345\"}}",
+      },
+    },
+  },
+  sendForApprovalCreateResult2: {
+    success: false,
+    status: {
+      isError: true,
+      code: 400,
+    },
+    message: {
+      name: "StatusCodeError",
+      statusCode: 500,
+      message: "500 - Invalid params",
+      error: {
+        errorCode: "1004",
+        errorMessage: 'Invalid params',
+      },
+    },
+  },
 };

package/v2Containers/Whatsapp/tests/saga.test.js

@@ -1,13 +1,16 @@
 import { expectSaga, testSaga } from "redux-saga-test-plan";
 import * as matchers from "redux-saga-test-plan/matchers";
 import { takeLatest } from "redux-saga/effects";
-import { getMetaTagsDetails, watchGetMetaTagsDetails } from "../sagas";
+import { getMetaTagsDetails, watchGetMetaTagsDetails, sendForApprovalCreate } from "../sagas";
 import {
   URL_META_TAGS_REQUEST,
   URL_META_TAGS_SUCCESS,
   URL_META_TAGS_FAILURE,
+  TEMPLATE_CREATE_SUCCESS,
+  TEMPLATE_CREATE_FAILURE,
 } from "../constants";
 import * as Api from "../../../services/api";
+import { mockData } from "./mockData";
 
 describe("Whatsapp saga", () => {
   const error = new Error("error");
@@ -26,11 +29,11 @@ describe("Whatsapp saga", () => {
           },
         ],
       ])
-      .put({
-        type: URL_META_TAGS_SUCCESS,
-        result: {},
-      })
-      .run();
+        .put({
+          type: URL_META_TAGS_SUCCESS,
+          result: {},
+        })
+        .run();
     });
 
     it("handle success false response from getMetaTagsDetails", () => {
@@ -47,11 +50,11 @@ describe("Whatsapp saga", () => {
           },
         ],
       ])
-      .put({
-        type: URL_META_TAGS_FAILURE,
-        error: 'error',
-      })
-      .run();
+        .put({
+          type: URL_META_TAGS_FAILURE,
+          error: 'error',
+        })
+        .run();
     });
 
     it("handle success false response from getMetaTagsDetails when callback not present", () => {
@@ -67,11 +70,11 @@ describe("Whatsapp saga", () => {
           },
         ],
       ])
-      .put({
-        type: URL_META_TAGS_FAILURE,
-        error: 'error',
-      })
-      .run();
+        .put({
+          type: URL_META_TAGS_FAILURE,
+          error: 'error',
+        })
+        .run();
     });
 
     it("handles error thrown", () => {
@@ -87,4 +90,112 @@ describe("Whatsapp saga", () => {
       );
     });
   });
+
+  describe("whatsapp test saga for sendForApprovalCreate", () => {
+    // const callBack = jest.fn();
+    it("handle success response from sendForApprovalCreate", () => {
+      expectSaga(sendForApprovalCreate, {
+        payload: mockData.sendForApprovalCreatePayload,
+        callBack,
+      }).provide([
+        [
+          matchers.call.fn(Api.createWhatsappTemplate),
+          {
+            success: true,
+            result: { response: "Test data"},
+          },
+        ],
+      ])
+        .put({
+          type: TEMPLATE_CREATE_SUCCESS,
+          result: {},
+        })
+        .run();
+    });
+
+    it("handle error response with json string for sendForApprovalCreate", () => {
+      expectSaga(sendForApprovalCreate, {
+        payload: mockData.sendForApprovalCreatePayload,
+        callBack,
+      }).provide([
+        [
+          matchers.call.fn(Api.createWhatsappTemplate),
+          mockData.sendForApprovalCreateResult1,
+        ],
+      ])
+        .put({
+          type: TEMPLATE_CREATE_FAILURE,
+          error: "(#192) Param components[1]['buttons'][0]['phone_number'] is not a valid phone number.",
+        })
+        .run();
+    });
+
+    it("handle error response for sendForApprovalCreate even if json parsing fails", () => {
+      expectSaga(sendForApprovalCreate, {
+        payload: mockData.sendForApprovalCreatePayload,
+        callBack,
+      }).provide([
+        [
+          matchers.call.fn(Api.createWhatsappTemplate),
+          mockData.sendForApprovalCreateResult2,
+        ],
+      ])
+        .put({
+          type: TEMPLATE_CREATE_FAILURE,
+          error: 'Invalid params',
+        })
+        .run();
+    });
+
+    it("handle error response for sendForApprovalCreate", () => {
+      expectSaga(sendForApprovalCreate, {
+        payload: mockData.sendForApprovalCreatePayload,
+        callBack,
+      }).provide([
+        [
+          matchers.call.fn(Api.createWhatsappTemplate),
+          {
+            success: false,
+            status: {
+              isError: true,
+              code: 500,
+            },
+            message: 'error',
+          },
+        ],
+      ])
+        .put({
+          type: TEMPLATE_CREATE_FAILURE,
+          error: 'error',
+        })
+        .run();
+    });
+
+    it("handle error response for sendForApprovalCreate with status code if error message empty", () => {
+      expectSaga(sendForApprovalCreate, {
+        payload: mockData.sendForApprovalCreatePayload,
+        callBack,
+      }).provide([
+        [
+          matchers.call.fn(Api.createWhatsappTemplate),
+          {
+            success: false,
+            status: {
+              isError: true,
+              code: 500,
+            },
+          },
+        ],
+      ])
+        .put({
+          type: TEMPLATE_CREATE_FAILURE,
+          error: 500,
+        })
+        .run();
+    });
+
+    it("handles error thrown", () => {
+      testSaga(sendForApprovalCreate, { callBack }).next().throw(error).next().isDone();
+    });
+  });
 });