@capgo/capacitor-updater 7.42.9 → 7.45.10

package/android/src/main/java/ee/forgr/capacitor_updater/CapgoUpdater.java

@@ -345,7 +345,7 @@ public class CapgoUpdater {
         }
     }
 
-    private void observeWorkProgress(Context context, String id) {
+    private void observeWorkProgress(Context context, String id, boolean setNext) {
         if (!(context instanceof LifecycleOwner)) {
             logger.error("Context is not a LifecycleOwner, cannot observe work progress");
             return;
@@ -375,7 +375,7 @@ public class CapgoUpdater {
                             boolean isManifest = outputData.getBoolean(DownloadService.IS_MANIFEST, false);
 
                             io.execute(() -> {
-                                boolean success = finishDownload(id, dest, version, sessionKey, checksum, true, isManifest);
+                                boolean success = finishDownload(id, dest, version, sessionKey, checksum, setNext, isManifest);
                                 BundleInfo resultBundle;
                                 if (!success) {
                                     logger.error("Finish download failed");
@@ -454,13 +454,14 @@ public class CapgoUpdater {
         final String version,
         final String sessionKey,
         final String checksum,
-        final JSONArray manifest
+        final JSONArray manifest,
+        final boolean setNext
     ) {
         if (this.activity == null) {
             logger.error("Activity is null, cannot observe work progress");
             return;
         }
-        observeWorkProgress(this.activity, id);
+        observeWorkProgress(this.activity, id, setNext);
 
         DownloadWorkerManager.enqueueDownload(
             this.activity,
@@ -573,7 +574,7 @@ public class CapgoUpdater {
             this.notifyDownload(id, 100);
 
             final Map<String, Object> ret = new HashMap<>();
-            ret.put("bundle", next.toJSONMap());
+            ret.put("bundle", InternalUtils.mapToJSObject(next.toJSONMap()));
             logger.info("updateAvailable: " + ret);
             CapgoUpdater.this.notifyListeners("updateAvailable", ret);
             logger.info("setNext: " + setNext);
@@ -757,12 +758,37 @@ public class CapgoUpdater {
         this.editor.commit();
     }
 
+    static boolean shouldResetForForeignBundle(final String bundlePath, final boolean isBuiltin, final boolean hasStoredBundleInfo) {
+        return bundlePath != null && !bundlePath.trim().isEmpty() && !isBuiltin && !hasStoredBundleInfo;
+    }
+
+    private boolean hasStoredBundleInfo(final String id) {
+        return (
+            id != null &&
+            !id.isEmpty() &&
+            !BundleInfo.ID_BUILTIN.equals(id) &&
+            !BundleInfo.VERSION_UNKNOWN.equals(id) &&
+            this.prefs.contains(id + INFO_SUFFIX)
+        );
+    }
+
     public void downloadBackground(
         final String url,
         final String version,
         final String sessionKey,
         final String checksum,
         final JSONArray manifest
+    ) {
+        downloadBackground(url, version, sessionKey, checksum, manifest, true);
+    }
+
+    public void downloadBackground(
+        final String url,
+        final String version,
+        final String sessionKey,
+        final String checksum,
+        final JSONArray manifest,
+        final boolean setNext
     ) {
         final String id = this.randomString();
 
@@ -784,7 +810,7 @@ public class CapgoUpdater {
         this.notifyDownload(id, 0);
         this.notifyDownload(id, 5);
 
-        this.download(id, url, this.randomString(), version, sessionKey, checksum, manifest);
+        this.download(id, url, this.randomString(), version, sessionKey, checksum, manifest, setNext);
     }
 
     public BundleInfo download(final String url, final String version, final String sessionKey, final String checksum) throws IOException {
@@ -806,7 +832,59 @@ public class CapgoUpdater {
         downloadFutures.put(id, downloadFuture);
 
         // Start the download
-        this.download(id, url, dest, version, sessionKey, checksum, null);
+        this.download(id, url, dest, version, sessionKey, checksum, null, false);
+
+        // Wait for completion without timeout
+        try {
+            BundleInfo result = downloadFuture.get();
+            if (result.isErrorStatus()) {
+                throw new IOException("Download failed with status: " + result.getStatus());
+            }
+            return result;
+        } catch (Exception e) {
+            // Clean up on failure
+            downloadFutures.remove(id);
+            logger.error("Error waiting for download");
+            logger.debug("Error: " + e.getMessage());
+            BundleInfo errorBundle = new BundleInfo(id, version, BundleStatus.ERROR, new Date(System.currentTimeMillis()), "");
+            saveBundleInfo(id, errorBundle);
+            if (e instanceof IOException) {
+                throw (IOException) e;
+            }
+            throw new IOException("Error waiting for download: " + e.getMessage(), e);
+        }
+    }
+
+    public BundleInfo downloadManifest(
+        final String url,
+        final String version,
+        final String sessionKey,
+        final String checksum,
+        final JSONArray manifest
+    ) throws IOException {
+        if (manifest == null) {
+            return download(url, version, sessionKey, checksum);
+        }
+
+        // Check for existing bundle with same version and clean up if in error state
+        BundleInfo existingBundle = this.getBundleInfoByName(version);
+        if (existingBundle != null && (existingBundle.isErrorStatus() || existingBundle.isDeleted())) {
+            logger.info("Found existing failed bundle for version " + version + ", deleting before retry");
+            this.delete(existingBundle.getId(), true);
+        }
+
+        final String id = this.randomString();
+        saveBundleInfo(id, new BundleInfo(id, version, BundleStatus.DOWNLOADING, new Date(System.currentTimeMillis()), ""));
+        this.notifyDownload(id, 0);
+        this.notifyDownload(id, 5);
+        final String dest = this.randomString();
+
+        // Create a CompletableFuture to track download completion
+        CompletableFuture<BundleInfo> downloadFuture = new CompletableFuture<>();
+        downloadFutures.put(id, downloadFuture);
+
+        // Start the download
+        this.download(id, url, dest, version, sessionKey, checksum, manifest, false);
 
         // Wait for completion without timeout
         try {
@@ -913,6 +991,64 @@ public class CapgoUpdater {
         return (bundle.isDirectory() && bundle.exists() && new File(bundle.getPath(), "/index.html").exists() && !bundleInfo.isDeleted());
     }
 
+    static final class ResetState {
+
+        final String currentBundlePath;
+        final String fallbackBundleId;
+        final String nextBundleId;
+
+        ResetState(final String currentBundlePath, final String fallbackBundleId, final String nextBundleId) {
+            this.currentBundlePath = currentBundlePath;
+            this.fallbackBundleId = fallbackBundleId;
+            this.nextBundleId = nextBundleId;
+        }
+    }
+
+    ResetState captureResetState() {
+        return new ResetState(
+            this.getCurrentBundlePath(),
+            this.prefs.getString(FALLBACK_VERSION, BundleInfo.ID_BUILTIN),
+            this.prefs.getString(NEXT_VERSION, null)
+        );
+    }
+
+    void restoreResetState(final ResetState state) {
+        final String currentBundlePath = state.currentBundlePath == null || state.currentBundlePath.trim().isEmpty()
+            ? "public"
+            : state.currentBundlePath;
+        final String fallbackBundleId = state.fallbackBundleId == null || state.fallbackBundleId.isEmpty()
+            ? BundleInfo.ID_BUILTIN
+            : state.fallbackBundleId;
+
+        this.editor.putString(this.CAP_SERVER_PATH, currentBundlePath);
+        this.editor.putString(FALLBACK_VERSION, fallbackBundleId);
+        if (state.nextBundleId == null || state.nextBundleId.isEmpty()) {
+            this.editor.remove(NEXT_VERSION);
+        } else {
+            this.editor.putString(NEXT_VERSION, state.nextBundleId);
+        }
+        this.editor.commit();
+    }
+
+    void prepareResetStateForTransition() {
+        this.setCurrentBundle(new File("public"));
+        this.setFallbackBundle(null);
+        this.setNextBundle(null);
+    }
+
+    void finalizeResetTransition(final String previousBundleName, final boolean internal) {
+        if (this.activity != null) {
+            DownloadWorkerManager.cancelAllDownloads(this.activity);
+        }
+        if (!internal) {
+            this.sendStats("reset", this.getCurrentBundle().getVersionName(), previousBundleName);
+        }
+    }
+
+    boolean canSet(final BundleInfo bundle) {
+        return bundle != null && (bundle.isBuiltin() || this.bundleExists(bundle.getId()));
+    }
+
     public Boolean set(final BundleInfo bundle) {
         return this.set(bundle.getId());
     }
@@ -937,11 +1073,32 @@ public class CapgoUpdater {
         return false;
     }
 
+    boolean stagePendingReload(final BundleInfo bundle) {
+        if (bundle == null || bundle.isBuiltin() || !this.bundleExists(bundle.getId())) {
+            return false;
+        }
+        this.setCurrentBundle(this.getBundleDirectory(bundle.getId()));
+        return true;
+    }
+
+    void finalizePendingReload(final BundleInfo bundle, final String previousBundleName) {
+        if (bundle == null || bundle.isBuiltin()) {
+            return;
+        }
+        this.sendStats("set", bundle.getVersionName(), previousBundleName);
+    }
+
     public void autoReset() {
         final BundleInfo currentBundle = this.getCurrentBundle();
         if (!currentBundle.isBuiltin() && !this.bundleExists(currentBundle.getId())) {
             logger.info("Folder at bundle path does not exist. Triggering reset.");
             this.reset();
+            return;
+        }
+        String bundlePath = this.prefs.getString(this.CAP_SERVER_PATH, null);
+        if (shouldResetForForeignBundle(bundlePath, currentBundle.isBuiltin(), this.hasStoredBundleInfo(currentBundle.getId()))) {
+            logger.info("Current bundle id is not one of the bundle ids stored by this plugin. Triggering reset.");
+            this.reset();
         }
     }
 
@@ -974,17 +1131,9 @@ public class CapgoUpdater {
 
     public void reset(final boolean internal) {
         logger.debug("reset: " + internal);
-        var currentBundleName = this.getCurrentBundle().getVersionName();
-        this.setCurrentBundle(new File("public"));
-        this.setFallbackBundle(null);
-        this.setNextBundle(null);
-        // Cancel any ongoing downloads
-        if (this.activity != null) {
-            DownloadWorkerManager.cancelAllDownloads(this.activity);
-        }
-        if (!internal) {
-            this.sendStats("reset", this.getCurrentBundle().getVersionName(), currentBundleName);
-        }
+        final String currentBundleName = this.getCurrentBundle().getVersionName();
+        this.prepareResetStateForTransition();
+        this.finalizeResetTransition(currentBundleName, internal);
     }
 
     private JSONObject createInfoObject() throws JSONException {
@@ -1080,6 +1229,7 @@ public class CapgoUpdater {
                         Map<String, Object> retError = new HashMap<>();
                         retError.put("message", "Request failed: " + e.getMessage());
                         retError.put("error", "network_error");
+                        retError.put("kind", "failed");
                         callback.callback(retError);
                     }
 
@@ -1087,11 +1237,46 @@ public class CapgoUpdater {
                     public void onResponse(@NonNull Call call, @NonNull Response response) throws IOException {
                         try (ResponseBody responseBody = response.body()) {
                             final int statusCode = response.code();
+                            final String responseData = responseBody != null ? responseBody.string() : "";
+                            JSONObject jsonResponse = null;
+                            if (!responseData.isEmpty()) {
+                                try {
+                                    jsonResponse = new JSONObject(responseData);
+                                } catch (JSONException ignored) {
+                                    // Non-JSON responses are handled as response or parse errors below.
+                                }
+                            }
+
+                            if (jsonResponse != null && (jsonResponse.has("error") || jsonResponse.has("kind"))) {
+                                if (statusCode == 429) {
+                                    checkAndHandleRateLimitResponse(response);
+                                }
+                                Map<String, Object> retError = new HashMap<>();
+                                if (jsonResponse.has("error") && !jsonResponse.isNull("error")) {
+                                    retError.put("error", jsonResponse.getString("error"));
+                                }
+                                if (jsonResponse.has("kind") && !jsonResponse.isNull("kind")) {
+                                    retError.put("kind", jsonResponse.getString("kind"));
+                                }
+                                if (jsonResponse.has("message") && !jsonResponse.isNull("message")) {
+                                    retError.put("message", jsonResponse.getString("message"));
+                                } else {
+                                    retError.put("message", "server did not provide a message");
+                                }
+                                if (jsonResponse.has("version") && !jsonResponse.isNull("version")) {
+                                    retError.put("version", jsonResponse.getString("version"));
+                                }
+                                retError.put("statusCode", statusCode);
+                                callback.callback(retError);
+                                return;
+                            }
+
                             // Check for 429 rate limit
                             if (checkAndHandleRateLimitResponse(response)) {
                                 Map<String, Object> retError = new HashMap<>();
                                 retError.put("message", "Rate limit exceeded");
                                 retError.put("error", "rate_limit_exceeded");
+                                retError.put("kind", "failed");
                                 retError.put("statusCode", statusCode);
                                 callback.callback(retError);
                                 return;
@@ -1101,27 +1286,14 @@ public class CapgoUpdater {
                                 Map<String, Object> retError = new HashMap<>();
                                 retError.put("message", "Server error: " + response.code());
                                 retError.put("error", "response_error");
+                                retError.put("kind", "failed");
                                 retError.put("statusCode", statusCode);
                                 callback.callback(retError);
                                 return;
                             }
 
-                            assert responseBody != null;
-                            String responseData = responseBody.string();
-                            JSONObject jsonResponse = new JSONObject(responseData);
-
-                            // Check for server-side errors first
-                            if (jsonResponse.has("error")) {
-                                Map<String, Object> retError = new HashMap<>();
-                                retError.put("error", jsonResponse.getString("error"));
-                                if (jsonResponse.has("message")) {
-                                    retError.put("message", jsonResponse.getString("message"));
-                                } else {
-                                    retError.put("message", "server did not provide a message");
-                                }
-                                retError.put("statusCode", statusCode);
-                                callback.callback(retError);
-                                return;
+                            if (jsonResponse == null) {
+                                throw new JSONException("Response is not a JSON object");
                             }
 
                             Map<String, Object> ret = new HashMap<>();
@@ -1143,6 +1315,7 @@ public class CapgoUpdater {
                             Map<String, Object> retError = new HashMap<>();
                             retError.put("message", "JSON parse error: " + e.getMessage());
                             retError.put("error", "parse_error");
+                            retError.put("kind", "failed");
                             callback.callback(retError);
                         }
                     }
@@ -1643,7 +1816,13 @@ public class CapgoUpdater {
         }
         BundleInfo result;
         if (BundleInfo.ID_BUILTIN.equals(trueId)) {
-            result = new BundleInfo(trueId, null, BundleStatus.SUCCESS, "", "");
+            result = new BundleInfo(
+                trueId,
+                this.versionBuild == null || this.versionBuild.isEmpty() ? null : this.versionBuild,
+                BundleStatus.SUCCESS,
+                "",
+                ""
+            );
         } else if (BundleInfo.VERSION_UNKNOWN.equals(trueId)) {
             result = new BundleInfo(trueId, null, BundleStatus.ERROR, "", "");
         } else {
@@ -1748,6 +1927,7 @@ public class CapgoUpdater {
     }
 
     public boolean setNextBundle(final String next) {
+        BundleInfo bundleToNotify = null;
         if (next == null) {
             this.editor.remove(NEXT_VERSION);
         } else {
@@ -1757,8 +1937,15 @@ public class CapgoUpdater {
             }
             this.editor.putString(NEXT_VERSION, next);
             this.setBundleStatus(next, BundleStatus.PENDING);
+            bundleToNotify = newBundle;
         }
         this.editor.commit();
+        if (bundleToNotify != null) {
+            this.sendStats("set_next", bundleToNotify.getVersionName(), this.getCurrentBundle().getVersionName());
+            final Map<String, Object> payload = new HashMap<>();
+            payload.put("bundle", bundleToNotify.toJSONMap());
+            this.notifyListeners("setNext", payload);
+        }
         return true;
     }
 

package/android/src/main/java/ee/forgr/capacitor_updater/DelayUpdateUtils.java

@@ -2,9 +2,12 @@ package ee.forgr.capacitor_updater;
 
 import android.content.SharedPreferences;
 import io.github.g00fy2.versioncompare.Version;
+import java.text.ParsePosition;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Date;
+import java.util.Locale;
+import java.util.TimeZone;
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
@@ -98,25 +101,16 @@ public class DelayUpdateUtils {
                     break;
                 case DelayUntilNext.date:
                     if (!"".equals(value)) {
-                        try {
-                            final SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS");
-                            Date date = sdf.parse(value);
-                            assert date != null;
+                        Date date = parseDateCondition(value);
+                        if (date != null) {
                             if (new Date().compareTo(date) > 0) {
                                 logger.info("Date delay (value: " + value + ") condition removed due to expired date at index " + index);
                             } else {
                                 delayConditionListToKeep.add(condition);
                                 logger.info("Date delay (value: " + value + ") condition kept at index " + index);
                             }
-                        } catch (final Exception e) {
-                            logger.error(
-                                "Date delay (value: " +
-                                    value +
-                                    ") condition removed due to parsing issue at index " +
-                                    index +
-                                    " " +
-                                    e.getMessage()
-                            );
+                        } else {
+                            logger.error("Date delay (value: " + value + ") condition removed due to parsing issue at index " + index);
                         }
                     } else {
                         logger.debug("Date delay (value: " + value + ") condition removed due to empty value at index " + index);
@@ -190,6 +184,48 @@ public class DelayUpdateUtils {
         return conditions;
     }
 
+    private Date parseDateCondition(String value) {
+        String[] patterns = {
+            "yyyy-MM-dd'T'HH:mm:ss.SSSXXX",
+            "yyyy-MM-dd'T'HH:mm:ssXXX",
+            "yyyy-MM-dd'T'HH:mm:ss.SSSXX",
+            "yyyy-MM-dd'T'HH:mm:ssXX",
+            "yyyy-MM-dd'T'HH:mm:ss.SSSX",
+            "yyyy-MM-dd'T'HH:mm:ssX",
+            "yyyy-MM-dd'T'HH:mm:ss.SSS",
+            "yyyy-MM-dd'T'HH:mm:ss"
+        };
+
+        for (String pattern : patterns) {
+            Date parsed = parseDateWithPattern(value, pattern);
+            if (parsed != null) {
+                return parsed;
+            }
+        }
+
+        return null;
+    }
+
+    private Date parseDateWithPattern(String value, String pattern) {
+        try {
+            SimpleDateFormat sdf = new SimpleDateFormat(pattern, Locale.US);
+            sdf.setLenient(false);
+
+            // If no timezone is provided, keep historical behavior and interpret as local time.
+            if (!pattern.contains("X")) {
+                sdf.setTimeZone(TimeZone.getDefault());
+            }
+
+            ParsePosition position = new ParsePosition(0);
+            Date parsed = sdf.parse(value, position);
+            if (parsed != null && position.getIndex() == value.length()) {
+                return parsed;
+            }
+        } catch (Exception ignored) {}
+
+        return null;
+    }
+
     private String convertDelayConditionsToJson(ArrayList<DelayCondition> conditions) {
         JSONArray array = new JSONArray();
         for (DelayCondition condition : conditions) {

package/android/src/main/java/ee/forgr/capacitor_updater/DownloadService.java

@@ -91,27 +91,52 @@ public class DownloadService extends Worker {
             .protocols(Arrays.asList(Protocol.HTTP_2, Protocol.HTTP_1_1))
             .addInterceptor((chain) -> {
                 Request originalRequest = chain.request();
-                String userAgent =
-                    "CapacitorUpdater/" +
-                    (currentPluginVersion != null ? currentPluginVersion : "unknown") +
-                    " (" +
-                    (currentAppId != null ? currentAppId : "unknown") +
-                    ") android/" +
-                    (currentVersionOs != null ? currentVersionOs : "unknown");
+                String userAgent = buildUserAgent(currentAppId, currentPluginVersion, currentVersionOs);
                 Request requestWithUserAgent = originalRequest.newBuilder().header("User-Agent", userAgent).build();
                 return chain.proceed(requestWithUserAgent);
             })
             .build();
     }
 
+    static String buildUserAgent(String appId, String pluginVersion, String versionOs) {
+        return (
+            "CapacitorUpdater/" +
+            sanitizeUserAgentValue(pluginVersion) +
+            " (" +
+            sanitizeUserAgentValue(appId) +
+            ") android/" +
+            sanitizeUserAgentValue(versionOs)
+        );
+    }
+
+    private static String sanitizeUserAgentValue(String value) {
+        if (value == null || value.isEmpty()) {
+            return "unknown";
+        }
+
+        StringBuilder sanitized = new StringBuilder();
+        value
+            .codePoints()
+            .forEach((cp) -> {
+                boolean isVisibleAscii = cp >= 0x20 && cp <= 0x7E;
+                boolean isIso88591 = cp >= 0xA0 && cp <= 0xFF;
+                if (isVisibleAscii || isIso88591) {
+                    sanitized.appendCodePoint(cp);
+                }
+            });
+
+        String result = sanitized.toString().trim();
+        return result.isEmpty() ? "unknown" : result;
+    }
+
     // Method to update User-Agent values
     public static void updateUserAgent(String appId, String pluginVersion, String versionOs) {
-        currentAppId = appId != null ? appId : "unknown";
-        currentPluginVersion = pluginVersion != null ? pluginVersion : "unknown";
-        currentVersionOs = versionOs != null ? versionOs : "unknown";
-        logger.debug(
-            "Updated User-Agent: CapacitorUpdater/" + currentPluginVersion + " (" + currentAppId + ") android/" + currentVersionOs
-        );
+        currentAppId = sanitizeUserAgentValue(appId);
+        currentPluginVersion = sanitizeUserAgentValue(pluginVersion);
+        currentVersionOs = sanitizeUserAgentValue(versionOs);
+        if (logger != null) {
+            logger.debug("Updated User-Agent: " + buildUserAgent(currentAppId, currentPluginVersion, currentVersionOs));
+        }
     }
 
     public DownloadService(@NonNull Context context, @NonNull WorkerParameters params) {

package/android/src/main/java/ee/forgr/capacitor_updater/InternalUtils.java

@@ -3,9 +3,22 @@ package ee.forgr.capacitor_updater;
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager;
 import android.os.Build;
+import com.getcapacitor.JSObject;
+import java.util.Map;
 
 public class InternalUtils {
 
+    /**
+     * Converts a Map to JSObject for proper bridge serialization.
+     */
+    public static JSObject mapToJSObject(Map<String, Object> map) {
+        JSObject jsObject = new JSObject();
+        for (Map.Entry<String, Object> entry : map.entrySet()) {
+            jsObject.put(entry.getKey(), entry.getValue());
+        }
+        return jsObject;
+    }
+
     public static String getPackageName(PackageManager pm, String packageName) {
         try {
             PackageInfo pInfo = getPackageInfoInternal(pm, packageName);