@capgo/capacitor-updater 6.42.3 → 6.43.3

package/ios/Sources/CapacitorUpdaterPlugin/CapgoUpdater.swift

@@ -579,10 +579,15 @@ import UIKit
 
         for entry in manifest {
             guard let fileName = entry.file_name,
-                  var fileHash = entry.file_hash,
                   let downloadUrl = entry.download_url else {
                 continue
             }
+            guard let entryFileHash = entry.file_hash, !entryFileHash.isEmpty else {
+                logger.error("Missing file_hash for manifest entry: \(entry.file_name ?? "unknown")")
+                hasError.value = true
+                continue
+            }
+            var fileHash = entryFileHash
 
             // Decrypt checksum if needed (done before creating operation)
             if !self.publicKey.isEmpty && !sessionKey.isEmpty {
@@ -749,16 +754,14 @@ import UIKit
                     // Write to destination
                     try finalData.write(to: destFilePath)
 
-                    // Verify checksum if encryption is enabled
-                    if !self.publicKey.isEmpty && !sessionKey.isEmpty {
-                        let calculatedChecksum = CryptoCipher.calcChecksum(filePath: destFilePath)
-                        CryptoCipher.logChecksumInfo(label: "Calculated checksum", hexChecksum: calculatedChecksum)
-                        CryptoCipher.logChecksumInfo(label: "Expected checksum", hexChecksum: fileHash)
-                        if calculatedChecksum != fileHash {
-                            try? FileManager.default.removeItem(at: destFilePath)
-                            self.sendStats(action: "download_manifest_checksum_fail", versionName: "\(version):\(destFileName)")
-                            throw NSError(domain: "ChecksumError", code: 1, userInfo: [NSLocalizedDescriptionKey: "Computed checksum is not equal to required checksum (\(calculatedChecksum) != \(fileHash)) for file \(fileName) at url \(downloadUrl)"])
-                        }
+                    // Always verify checksum when file_hash is present
+                    let calculatedChecksum = CryptoCipher.calcChecksum(filePath: destFilePath)
+                    CryptoCipher.logChecksumInfo(label: "Calculated checksum", hexChecksum: calculatedChecksum)
+                    CryptoCipher.logChecksumInfo(label: "Expected checksum", hexChecksum: fileHash)
+                    if calculatedChecksum != fileHash {
+                        try? FileManager.default.removeItem(at: destFilePath)
+                        self.sendStats(action: "download_manifest_checksum_fail", versionName: "\(version):\(destFileName)")
+                        throw NSError(domain: "ChecksumError", code: 1, userInfo: [NSLocalizedDescriptionKey: "Computed checksum is not equal to required checksum (\(calculatedChecksum) != \(fileHash)) for file \(fileName) at url \(downloadUrl)"])
                     }
 
                     // Save to cache
@@ -1554,6 +1557,15 @@ import UIKit
                 if let responseValue = response.value {
                     if let error = responseValue.error {
                         setChannel.error = error
+                    } else if responseValue.unset == true {
+                        // Server requested to unset channel (public channel was requested)
+                        // Clear persisted defaultChannel and revert to config value
+                        UserDefaults.standard.removeObject(forKey: defaultChannelKey)
+                        UserDefaults.standard.synchronize()
+                        self.logger.info("Public channel requested, channel override removed")
+
+                        setChannel.status = responseValue.status ?? "ok"
+                        setChannel.message = responseValue.message ?? "Public channel requested, channel override removed. Device will use public channel automatically."
                     } else {
                         // Success - persist defaultChannel
                         self.defaultChannel = channel

package/ios/Sources/CapacitorUpdaterPlugin/InternalUtils.swift

@@ -23,6 +23,7 @@ struct SetChannelDec: Decodable {
     let status: String?
     let error: String?
     let message: String?
+    let unset: Bool?
 }
 public class SetChannel: NSObject {
     var status: String = ""

package/ios/Sources/CapacitorUpdaterPlugin/ShakeMenu.swift

@@ -37,11 +37,16 @@ extension UIWindow {
                 return
             }
 
-            showShakeMenu(plugin: plugin, bridge: bridge)
+            // Check if channel selector mode is enabled
+            if plugin.shakeChannelSelectorEnabled {
+                showChannelSelector(plugin: plugin, bridge: bridge)
+            } else {
+                showDefaultMenu(plugin: plugin, bridge: bridge)
+            }
         }
     }
 
-    private func showShakeMenu(plugin: CapacitorUpdaterPlugin, bridge: CAPBridgeProtocol) {
+    private func showDefaultMenu(plugin: CapacitorUpdaterPlugin, bridge: CAPBridgeProtocol) {
         // Prevent multiple alerts from showing
         if let topVC = UIApplication.topViewController(),
            topVC.isKind(of: UIAlertController.self) {
@@ -110,4 +115,327 @@ extension UIWindow {
             }
         }
     }
+
+    private func showChannelSelector(plugin: CapacitorUpdaterPlugin, bridge: CAPBridgeProtocol) {
+        // Prevent multiple alerts from showing
+        if let topVC = UIApplication.topViewController(),
+           topVC.isKind(of: UIAlertController.self) {
+            plugin.logger.info("UIAlertController is already presented")
+            return
+        }
+
+        let updater = plugin.implementation
+
+        // Show loading indicator
+        let loadingAlert = UIAlertController(title: "Loading Channels...", message: nil, preferredStyle: .alert)
+        var didCancel = false
+        let loadingIndicator = UIActivityIndicatorView(style: .medium)
+        loadingIndicator.translatesAutoresizingMaskIntoConstraints = false
+        loadingIndicator.startAnimating()
+        loadingAlert.view.addSubview(loadingIndicator)
+
+        NSLayoutConstraint.activate([
+            loadingIndicator.centerXAnchor.constraint(equalTo: loadingAlert.view.centerXAnchor),
+            loadingIndicator.bottomAnchor.constraint(equalTo: loadingAlert.view.bottomAnchor, constant: -20)
+        ])
+
+        // Add cancel button to loading alert
+        loadingAlert.addAction(UIAlertAction(title: "Cancel", style: .cancel) { _ in
+            didCancel = true
+        })
+
+        DispatchQueue.main.async {
+            if let topVC = UIApplication.topViewController() {
+                topVC.present(loadingAlert, animated: true) {
+                    // Fetch channels in background
+                    DispatchQueue.global(qos: .userInitiated).async {
+                        let result = updater.listChannels()
+
+                        DispatchQueue.main.async {
+                            loadingAlert.dismiss(animated: true) {
+                                guard !didCancel else { return }
+                                if !result.error.isEmpty {
+                                    self.showError(message: "Failed to load channels: \(result.error)", plugin: plugin)
+                                } else if result.channels.isEmpty {
+                                    self.showError(message: "No channels available for self-assignment", plugin: plugin)
+                                } else {
+                                    self.presentChannelPicker(channels: result.channels, plugin: plugin, bridge: bridge)
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        }
+    }
+
+    private func presentChannelPicker(channels: [[String: Any]], plugin: CapacitorUpdaterPlugin, bridge: CAPBridgeProtocol) {
+        let alert = UIAlertController(title: "Select Channel", message: "Choose a channel to switch to", preferredStyle: .actionSheet)
+
+        // Get channel names
+        let channelNames = channels.compactMap { $0["name"] as? String }
+
+        // Show first 5 channels as actions
+        let channelsToShow = Array(channelNames.prefix(5))
+
+        for channelName in channelsToShow {
+            alert.addAction(UIAlertAction(title: channelName, style: .default) { [weak self] _ in
+                self?.selectChannel(name: channelName, plugin: plugin, bridge: bridge)
+            })
+        }
+
+        // If there are more channels, add a "More..." option
+        if channelNames.count > 5 {
+            alert.addAction(UIAlertAction(title: "More channels...", style: .default) { [weak self] _ in
+                self?.showSearchableChannelPicker(channels: channels, plugin: plugin, bridge: bridge)
+            })
+        }
+
+        alert.addAction(UIAlertAction(title: "Cancel", style: .cancel))
+
+        // For iPad support
+        if let popoverController = alert.popoverPresentationController {
+            popoverController.sourceView = self
+            popoverController.sourceRect = CGRect(x: self.bounds.midX, y: self.bounds.midY, width: 0, height: 0)
+            popoverController.permittedArrowDirections = []
+        }
+
+        DispatchQueue.main.async {
+            if let topVC = UIApplication.topViewController() {
+                topVC.present(alert, animated: true)
+            }
+        }
+    }
+
+    private func showSearchableChannelPicker(channels: [[String: Any]], plugin: CapacitorUpdaterPlugin, bridge: CAPBridgeProtocol) {
+        let alert = UIAlertController(title: "Search Channels", message: "Enter channel name to search", preferredStyle: .alert)
+
+        alert.addTextField { textField in
+            textField.placeholder = "Channel name..."
+        }
+
+        let channelNames = channels.compactMap { $0["name"] as? String }
+
+        alert.addAction(UIAlertAction(title: "Search", style: .default) { [weak self, weak alert] _ in
+            guard let searchText = alert?.textFields?.first?.text?.lowercased(), !searchText.isEmpty else {
+                // If empty, show first 5
+                self?.presentChannelPicker(channels: channels, plugin: plugin, bridge: bridge)
+                return
+            }
+
+            // Filter channels
+            let filtered = channelNames.filter { $0.lowercased().contains(searchText) }
+
+            if filtered.isEmpty {
+                self?.showError(message: "No channels found matching '\(searchText)'", plugin: plugin)
+            } else if filtered.count == 1 {
+                // Directly select if only one match
+                self?.selectChannel(name: filtered[0], plugin: plugin, bridge: bridge)
+            } else {
+                // Show filtered results
+                let filteredChannels = channels.filter { channel in
+                    if let name = channel["name"] as? String {
+                        return name.lowercased().contains(searchText)
+                    }
+                    return false
+                }
+                self?.presentChannelPicker(channels: filteredChannels, plugin: plugin, bridge: bridge)
+            }
+        })
+
+        alert.addAction(UIAlertAction(title: "Cancel", style: .cancel))
+
+        DispatchQueue.main.async {
+            if let topVC = UIApplication.topViewController() {
+                topVC.present(alert, animated: true)
+            }
+        }
+    }
+
+    private func selectChannel(name: String, plugin: CapacitorUpdaterPlugin, bridge: CAPBridgeProtocol) {
+        let updater = plugin.implementation
+
+        // Show progress indicator
+        let progressAlert = UIAlertController(title: "Switching to \(name)", message: "Setting channel...", preferredStyle: .alert)
+        let indicator = UIActivityIndicatorView(style: .medium)
+        indicator.translatesAutoresizingMaskIntoConstraints = false
+        indicator.startAnimating()
+        progressAlert.view.addSubview(indicator)
+
+        NSLayoutConstraint.activate([
+            indicator.centerXAnchor.constraint(equalTo: progressAlert.view.centerXAnchor),
+            indicator.bottomAnchor.constraint(equalTo: progressAlert.view.bottomAnchor, constant: -20)
+        ])
+
+        DispatchQueue.main.async {
+            if let topVC = UIApplication.topViewController() {
+                topVC.present(progressAlert, animated: true) {
+                    DispatchQueue.global(qos: .userInitiated).async {
+                        // Set the channel - respect plugin's allowSetDefaultChannel config
+                        let setResult = updater.setChannel(
+                            channel: name,
+                            defaultChannelKey: "CapacitorUpdater.defaultChannel",
+                            allowSetDefaultChannel: plugin.allowSetDefaultChannel
+                        )
+
+                        if !setResult.error.isEmpty {
+                            DispatchQueue.main.async {
+                                progressAlert.dismiss(animated: true) {
+                                    self.showError(message: "Failed to set channel: \(setResult.error)", plugin: plugin)
+                                }
+                            }
+                            return
+                        }
+
+                        // Update progress message
+                        DispatchQueue.main.async {
+                            progressAlert.message = "Checking for updates..."
+                        }
+
+                        // Check for updates with the new channel
+                        let pluginUpdateUrl = plugin.getUpdateUrl()
+                        let updateUrlStr = pluginUpdateUrl.isEmpty ? CapacitorUpdaterPlugin.updateUrlDefault : pluginUpdateUrl
+                        guard let updateUrl = URL(string: updateUrlStr) else {
+                            DispatchQueue.main.async {
+                                progressAlert.dismiss(animated: true) {
+                                    self.showError(
+                                        message: "Channel set to \(name). Invalid update URL, could not check for updates.",
+                                        plugin: plugin
+                                    )
+                                }
+                            }
+                            return
+                        }
+
+                        let latest = updater.getLatest(url: updateUrl, channel: name)
+
+                        // Handle update errors first (before "no new version" check)
+                        if let error = latest.error, !error.isEmpty && error != "no_new_version_available" {
+                            DispatchQueue.main.async {
+                                progressAlert.dismiss(animated: true) {
+                                    self.showError(message: "Channel set to \(name). Update check failed: \(error)", plugin: plugin)
+                                }
+                            }
+                            return
+                        }
+
+                        // Check if there's an actual update available
+                        if latest.error == "no_new_version_available" || latest.url.isEmpty {
+                            DispatchQueue.main.async {
+                                progressAlert.dismiss(animated: true) {
+                                    self.showSuccess(message: "Channel set to \(name). Already on latest version.", plugin: plugin)
+                                }
+                            }
+                            return
+                        }
+
+                        // Update message
+                        DispatchQueue.main.async {
+                            progressAlert.message = "Downloading update \(latest.version)..."
+                        }
+
+                        // Download the update
+                        do {
+                            let bundle: BundleInfo
+                            if let manifest = latest.manifest, !manifest.isEmpty {
+                                bundle = try updater.downloadManifest(
+                                    manifest: manifest,
+                                    version: latest.version,
+                                    sessionKey: latest.sessionKey ?? ""
+                                )
+                            } else {
+                                // Safe unwrap URL
+                                guard let downloadUrl = URL(string: latest.url) else {
+                                    DispatchQueue.main.async {
+                                        progressAlert.dismiss(animated: true) {
+                                            self.showError(message: "Failed to download update: invalid update URL.", plugin: plugin)
+                                        }
+                                    }
+                                    return
+                                }
+                                bundle = try updater.download(
+                                    url: downloadUrl,
+                                    version: latest.version,
+                                    sessionKey: latest.sessionKey ?? ""
+                                )
+                            }
+
+                            // Set as next bundle
+                            _ = updater.setNextBundle(next: bundle.getId())
+
+                            DispatchQueue.main.async {
+                                progressAlert.dismiss(animated: true) {
+                                    self.showSuccessWithReload(
+                                        message: "Update downloaded! Reload to apply version \(latest.version)?",
+                                        plugin: plugin,
+                                        bridge: bridge,
+                                        onReload: { [weak plugin] in
+                                            _ = updater.set(bundle: bundle)
+                                            _ = plugin?._reload()
+                                        }
+                                    )
+                                }
+                            }
+                        } catch {
+                            DispatchQueue.main.async {
+                                progressAlert.dismiss(animated: true) {
+                                    self.showError(message: "Failed to download update: \(error.localizedDescription)", plugin: plugin)
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        }
+    }
+
+    private func showError(message: String, plugin: CapacitorUpdaterPlugin) {
+        plugin.logger.error(message)
+        let alert = UIAlertController(title: "Error", message: message, preferredStyle: .alert)
+        alert.addAction(UIAlertAction(title: "OK", style: .default))
+
+        DispatchQueue.main.async {
+            if let topVC = UIApplication.topViewController() {
+                topVC.present(alert, animated: true)
+            }
+        }
+    }
+
+    private func showSuccess(message: String, plugin: CapacitorUpdaterPlugin) {
+        plugin.logger.info(message)
+        let alert = UIAlertController(title: "Success", message: message, preferredStyle: .alert)
+        alert.addAction(UIAlertAction(title: "OK", style: .default))
+
+        DispatchQueue.main.async {
+            if let topVC = UIApplication.topViewController() {
+                topVC.present(alert, animated: true)
+            }
+        }
+    }
+
+    private func showSuccessWithReload(
+        message: String,
+        plugin: CapacitorUpdaterPlugin,
+        bridge: CAPBridgeProtocol,
+        onReload: (() -> Void)? = nil
+    ) {
+        plugin.logger.info(message)
+        let alert = UIAlertController(title: "Update Ready", message: message, preferredStyle: .alert)
+        alert.addAction(UIAlertAction(title: "Later", style: .cancel))
+        alert.addAction(UIAlertAction(title: "Reload Now", style: .default) { _ in
+            if let onReload = onReload {
+                onReload()
+            } else {
+                DispatchQueue.main.async {
+                    bridge.webView?.reload()
+                }
+            }
+        })
+
+        DispatchQueue.main.async {
+            if let topVC = UIApplication.topViewController() {
+                topVC.present(alert, animated: true)
+            }
+        }
+    }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@capgo/capacitor-updater",
-  "version": "6.42.3",
+  "version": "6.43.3",
   "license": "MPL-2.0",
   "description": "Live update for capacitor apps",
   "main": "dist/plugin.cjs.js",
@@ -57,7 +57,8 @@
     "build": "npm run clean && npm run docgen && tsc && rollup -c rollup.config.mjs",
     "clean": "rimraf ./dist",
     "watch": "tsc --watch",
-    "prepublishOnly": "npm run build"
+    "prepublishOnly": "npm run build",
+    "check:wiring": "node scripts/check-capacitor-plugin-wiring.mjs"
   },
   "devDependencies": {
     "@capacitor/android": "^6.1.2",