@capgo/capacitor-autofill-save-password 7.0.2 → 7.0.4

package/README.md

@@ -11,6 +11,10 @@ Prompt to display dialog for saving password to keychain from webview app
 
 Fork of original plugin to work with Capacitor 7 
 
+IOS work for old versions and 18.3
+
+Android still WIP
+
 ## Install
 
 ```bash
@@ -49,6 +53,30 @@ login(username: string, password: string) {
 }
 ```
 
+
+### Android
+
+Add `apply plugin: 'com.google.gms.google-services'` beneath `apply plugin: 'com.android.application'` in `android/app/build.gradle`
+
+this will allow the plugin to import the proper lib.
+
+Then you need to make sure you did set properly your domain and did add google-services.json.
+
+guide here https://developer.android.com/identity/sign-in/credential-manager
+
+You need to have the file at this path `android/google-services.json` set, if you dont use firebase add empty json
+
+then add your domain in `example-app/android/app/src/main/res/values/strings.xml`
+
+with 
+```xml
+    <string name="asset_statements" translatable="false">
+    [{
+    \"include\": \"https://YOURDOMAIN/.well-known/assetlinks.json\"
+    }]
+    </string>
+```
+
 ## API
 
 <docgen-index>

package/android/build.gradle

@@ -47,14 +47,12 @@ repositories {
     mavenCentral()
 }
 
-
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
     implementation project(':capacitor-android')
     implementation "androidx.appcompat:appcompat:$androidxAppCompatVersion"
-    implementation(libs.androidx.credentials)
-    implementation(libs.androidx.credentials.play.services.auth)
-//    implementation 'androidx.credentials:credentials:1.5.0'
+    implementation "androidx.credentials:credentials:1.5.0"
+    implementation "androidx.credentials:credentials-play-services-auth:1.5.0"
     testImplementation "junit:junit:$junitVersion"
     androidTestImplementation "androidx.test.ext:junit:$androidxJunitVersion"
     androidTestImplementation "androidx.test.espresso:espresso-core:$androidxEspressoCoreVersion"

package/android/src/main/java/ee/forgr/autofill_password/SavePasswordPlugin.java

@@ -1,78 +1,111 @@
 package ee.forgr.autofill_password;
 
-import com.getcapacitor.JSObject;
-import com.getcapacitor.Plugin;
-import com.getcapacitor.PluginCall;
-import com.getcapacitor.PluginMethod;
-import com.getcapacitor.annotation.CapacitorPlugin;
+import android.app.Activity;
+import android.os.Build;
 import android.util.Log;
-import android.os.CancellationSignal;
+
 import androidx.credentials.CredentialManager;
-import androidx.credentials.CredentialManagerCallback;
 import androidx.credentials.CreatePasswordRequest;
 import androidx.credentials.CreateCredentialResponse;
+import androidx.credentials.PendingGetCredentialRequest;
+import androidx.credentials.CredentialManagerCallback;
 import androidx.credentials.exceptions.CreateCredentialException;
-import java.util.concurrent.Executor;
+
+import com.getcapacitor.Plugin;
+import com.getcapacitor.PluginCall;
+import com.getcapacitor.PluginMethod;
+import com.getcapacitor.annotation.CapacitorPlugin;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import androidx.core.content.ContextCompat;
 
 @CapacitorPlugin(name = "SavePassword")
 public class SavePasswordPlugin extends Plugin {
+    private static final String TAG = "CredentialManager";
+    private CredentialManager credentialManager;
+    private Map<String, PendingGetCredentialRequest> pendingRequestsByElementId = new HashMap<>();
 
-    private static final String TAG = "SavePasswordPlugin";
+    @Override
+    public void load() {
+        super.load();
+        try {
+            credentialManager = CredentialManager.create(getContext());
+        } catch (Exception e) {
+            Log.e(TAG, "Error initializing CredentialManager", e);
+        }
+    }
 
     @PluginMethod
-    public void promptDialog(PluginCall call) {
+    public void promptDialog(final PluginCall call) {
+        if (!isCredentialManagerAvailable(call)) {
+            return;
+        }
+
         String username = call.getString("username");
         String password = call.getString("password");
 
         if (username == null || username.isEmpty()) {
-            call.reject("Username cannot be empty.");
-            Log.w(TAG, "Username was null or empty.");
+            call.reject("Username is required");
             return;
         }
 
-        if (password == null) {
-            call.reject("Password cannot be null. Provide an empty string if the password is meant to be empty.");
-            Log.w(TAG, "Password was null.");
+        if (password == null || password.isEmpty()) {
+            call.reject("Password is required");
             return;
         }
 
-        if (getActivity() == null) {
-            call.reject("Activity is not available to show dialog.");
-            Log.e(TAG, "Activity was null, cannot access CredentialManager.");
-            return;
-        }
-
-        // Build the CreatePasswordRequest
-        CreatePasswordRequest createPasswordRequest = new CreatePasswordRequest(username, password);
-
-        // Get the CredentialManager instance
-        CredentialManager credentialManager = CredentialManager.create(getActivity());
-
-        // Set up executor and cancellation signal
-        Executor executor = getActivity().getMainExecutor();
-        CancellationSignal cancellationSignal = new CancellationSignal();
-
-        credentialManager.createCredentialAsync(
-            getActivity(),
-            createPasswordRequest,
-            cancellationSignal,
-            executor,
-            new CredentialManagerCallback<CreateCredentialResponse, CreateCredentialException>() {
-                @Override
-                public void onResult(CreateCredentialResponse result) {
-                    JSObject response = new JSObject();
-                    response.put("prompted", true);
-                    Log.d(TAG, "Password save prompt completed successfully.");
-                    call.resolve(response);
+        try {
+            // Build request directly with username & password (API 1.5.0 signature)
+            CreatePasswordRequest request = new CreatePasswordRequest(username, password);
+            
+            // Execute on main thread
+            bridge.executeOnMainThread(() -> {
+                Activity activity = getActivity();
+                if (activity == null) {
+                    call.reject("Activity not available");
+                    return;
                 }
 
-                @Override
-                public void onError(CreateCredentialException e) {
-                    String errorMessage = "Failed to save password credential: " + e.getMessage();
-                    Log.e(TAG, errorMessage, e);
-                    call.reject(errorMessage, e);
+                try {
+                    credentialManager.createCredentialAsync(
+                        activity,
+                        request,
+                        null,
+                        ContextCompat.getMainExecutor(getContext()),
+                        new CredentialManagerCallback<CreateCredentialResponse, CreateCredentialException>() {
+                            @Override
+                            public void onResult(CreateCredentialResponse response) {
+                                call.resolve();
+                            }
+
+                            @Override
+                            public void onError(CreateCredentialException e) {
+                                call.reject("Error saving credential: " + e.getMessage(), e);
+                            }
+                        }
+                    );
+                } catch (Exception e) {
+                    call.reject("Error saving credential", e);
                 }
-            }
-        );
+            });
+        } catch (Exception e) {
+            call.reject("Error building save credential request", e);
+        }
+    }
+
+    private boolean isCredentialManagerAvailable(PluginCall call) {
+        if (credentialManager == null) {
+            call.reject("Credential Manager not available on this device");
+            return false;
+        }
+
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.P) {
+            call.reject("Credential Manager requires Android API level 28 or higher");
+            return false;
+        }
+
+        return true;
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@capgo/capacitor-autofill-save-password",
-  "version": "7.0.2",
+  "version": "7.0.4",
   "description": "Prompt to display dialog for saving password to keychain from webview app",
   "main": "dist/plugin.cjs.js",
   "module": "dist/esm/index.js",