@capacitor/cli 3.3.2 → 3.4.1

package/CHANGELOG.md

@@ -3,6 +3,49 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [3.4.1](https://github.com/ionic-team/capacitor/compare/3.4.0...3.4.1) (2022-02-09)
+
+
+### Bug Fixes
+
+* **cli:** Better error on gradlew permission problems ([#5405](https://github.com/ionic-team/capacitor/issues/5405)) ([9420f08](https://github.com/ionic-team/capacitor/commit/9420f08dedad78cfaa5500cccf8bdbf1a9140684))
+
+
+
+
+
+# [3.4.0](https://github.com/ionic-team/capacitor/compare/3.3.4...3.4.0) (2022-01-19)
+
+**Note:** Version bump only for package @capacitor/cli
+
+
+
+
+
+## [3.3.4](https://github.com/ionic-team/capacitor/compare/3.3.3...3.3.4) (2022-01-05)
+
+
+### Bug Fixes
+
+* **cli:** Escape appName from invalid characters on add ([#5325](https://github.com/ionic-team/capacitor/issues/5325)) ([033f4ee](https://github.com/ionic-team/capacitor/commit/033f4eef59fdb7cc32018b162114511448bc46a6))
+* **cli:** sync failing if Info.plist is localized ([#5333](https://github.com/ionic-team/capacitor/issues/5333)) ([df7a104](https://github.com/ionic-team/capacitor/commit/df7a1041c4e2d9a5a1ceef247ed00f9f8467df76))
+
+
+
+
+
+## [3.3.3](https://github.com/ionic-team/capacitor/compare/3.3.2...3.3.3) (2021-12-08)
+
+
+### Bug Fixes
+
+* **android:** restrict android run command to configured flavour ([#5256](https://github.com/ionic-team/capacitor/issues/5256)) ([ba84443](https://github.com/ionic-team/capacitor/commit/ba84443dce9c81e09140def57a60018b527b5bb5))
+* **cli:** Add onesignal-cordova-plugin to the static list again ([#5262](https://github.com/ionic-team/capacitor/issues/5262)) ([e67ca99](https://github.com/ionic-team/capacitor/commit/e67ca9964c5a923d35f5cf41eb802c665563726f))
+
+
+
+
+
 ## [3.3.2](https://github.com/ionic-team/capacitor/compare/3.3.1...3.3.2) (2021-11-17)
 
 

package/dist/android/common.js

@@ -56,7 +56,11 @@ exports.resolvePlugin = resolvePlugin;
  */
 async function editProjectSettingsAndroid(config) {
     const appId = config.app.appId;
-    const appName = config.app.appName;
+    const appName = config.app.appName
+        .replace(/&/g, '&')
+        .replace(/</g, '&lt;')
+        .replace(/"/g, '\\"')
+        .replace(/'/g, "\\'");
     const manifestPath = path_1.resolve(config.android.srcMainDirAbs, 'AndroidManifest.xml');
     const buildGradlePath = path_1.resolve(config.android.appDirAbs, 'build.gradle');
     let manifestContent = await utils_fs_1.readFile(manifestPath, { encoding: 'utf-8' });
@@ -89,7 +93,7 @@ async function editProjectSettingsAndroid(config) {
     const stringsPath = path_1.resolve(config.android.resDirAbs, 'values/strings.xml');
     let stringsContent = await utils_fs_1.readFile(stringsPath, { encoding: 'utf-8' });
     stringsContent = stringsContent.replace(/com.getcapacitor.myapp/g, appId);
-    stringsContent = stringsContent.replace(/My App/g, appName.replace(/'/g, `\\'`));
+    stringsContent = stringsContent.replace(/My App/g, appName);
     await utils_fs_1.writeFile(stringsPath, stringsContent);
 }
 exports.editProjectSettingsAndroid = editProjectSettingsAndroid;

package/dist/android/run.js

@@ -10,12 +10,24 @@ const native_run_1 = require("../util/native-run");
 const subprocess_1 = require("../util/subprocess");
 const debug = debug_1.default('capacitor:android:run');
 async function runAndroid(config, { target: selectedTarget }) {
+    var _a;
     const target = await common_1.promptForPlatformTarget(await native_run_1.getPlatformTargets('android'), selectedTarget);
-    const gradleArgs = ['assembleDebug'];
+    const arg = `assemble${((_a = config.android) === null || _a === void 0 ? void 0 : _a.flavor) || ''}Debug`;
+    const gradleArgs = [arg];
     debug('Invoking ./gradlew with args: %O', gradleArgs);
-    await common_1.runTask('Running Gradle build', async () => subprocess_1.runCommand('./gradlew', gradleArgs, {
-        cwd: config.android.platformDirAbs,
-    }));
+    try {
+        await common_1.runTask('Running Gradle build', async () => subprocess_1.runCommand('./gradlew', gradleArgs, {
+            cwd: config.android.platformDirAbs,
+        }));
+    }
+    catch (e) {
+        if (e.includes('EACCES')) {
+            throw `gradlew file does not have executable permissions. This can happen if the Android platform was added on a Windows machine. Please run ${colors_1.default.strong(`chmod +x ./${config.android.platformDir}/gradlew`)} and try again.`;
+        }
+        else {
+            throw e;
+        }
+    }
     const apkPath = path_1.resolve(config.android.buildOutputDirAbs, config.android.apkName);
     const nativeRunArgs = ['android', '--app', apkPath, '--target', target.id];
     debug('Invoking native-run with args: %O', nativeRunArgs);

package/dist/config.js

@@ -148,7 +148,7 @@ async function loadCLIConfig(rootDir) {
     };
 }
 async function loadAndroidConfig(rootDir, extConfig, cliConfig) {
-    var _a, _b, _c, _d, _e;
+    var _a, _b, _c, _d, _e, _f;
     const name = 'android';
     const platformDir = (_b = (_a = extConfig.android) === null || _a === void 0 ? void 0 : _a.path) !== null && _b !== void 0 ? _b : 'android';
     const platformDirAbs = path_1.resolve(rootDir, platformDir);
@@ -160,9 +160,10 @@ async function loadAndroidConfig(rootDir, extConfig, cliConfig) {
     const resDir = `${srcMainDir}/res`;
     let apkPath = `${appDir}/build/outputs/apk/`;
     let flavorPrefix = '';
-    if ((_c = extConfig.android) === null || _c === void 0 ? void 0 : _c.flavor) {
-        apkPath = `${apkPath}/${(_d = extConfig.android) === null || _d === void 0 ? void 0 : _d.flavor}`;
-        flavorPrefix = `-${(_e = extConfig.android) === null || _e === void 0 ? void 0 : _e.flavor}`;
+    const flavor = ((_c = extConfig.android) === null || _c === void 0 ? void 0 : _c.flavor) || '';
+    if ((_d = extConfig.android) === null || _d === void 0 ? void 0 : _d.flavor) {
+        apkPath = `${apkPath}/${(_e = extConfig.android) === null || _e === void 0 ? void 0 : _e.flavor}`;
+        flavorPrefix = `-${(_f = extConfig.android) === null || _f === void 0 ? void 0 : _f.flavor}`;
     }
     const apkName = `app${flavorPrefix}-debug.apk`;
     const buildOutputDir = `${apkPath}/debug`;
@@ -191,6 +192,7 @@ async function loadAndroidConfig(rootDir, extConfig, cliConfig) {
         apkName,
         buildOutputDir,
         buildOutputDirAbs: path_1.resolve(platformDirAbs, buildOutputDir),
+        flavor,
     };
 }
 async function loadIOSConfig(rootDir, extConfig) {

package/dist/cordova.js

@@ -263,39 +263,47 @@ async function logCordovaManualSteps(cordovaPlugins, config, platform) {
 }
 exports.logCordovaManualSteps = logCordovaManualSteps;
 async function logiOSPlist(configElement, config, plugin) {
-    const plistPath = path_1.resolve(config.ios.nativeTargetDirAbs, 'Info.plist');
-    const xmlMeta = await xml_1.readXML(plistPath);
-    const data = await utils_fs_1.readFile(plistPath, { encoding: 'utf-8' });
-    const plistData = plist_1.default.parse(data);
-    const dict = xmlMeta.plist.dict.pop();
-    if (!dict.key.includes(configElement.$.parent)) {
-        let xml = buildConfigFileXml(configElement);
-        xml = `<key>${configElement.$.parent}</key>${getConfigFileTagContent(xml)}`;
-        log_1.logger.warn(`Configuration required for ${colors_1.default.strong(plugin.id)}.\n` +
-            `Add the following to Info.plist:\n` +
-            xml);
+    let plistPath = path_1.resolve(config.ios.nativeTargetDirAbs, 'Info.plist');
+    if (!(await utils_fs_1.pathExists(plistPath))) {
+        plistPath = path_1.resolve(config.ios.nativeTargetDirAbs, 'Base.lproj', 'Info.plist');
     }
-    else if (configElement.array || configElement.dict) {
-        if (configElement.array &&
-            configElement.array.length > 0 &&
-            configElement.array[0].string) {
-            let xml = '';
-            configElement.array[0].string.map((element) => {
-                const d = plistData[configElement.$.parent];
-                if (Array.isArray(d) && !d.includes(element)) {
-                    xml = xml.concat(`<string>${element}</string>\n`);
+    if (await utils_fs_1.pathExists(plistPath)) {
+        const xmlMeta = await xml_1.readXML(plistPath);
+        const data = await utils_fs_1.readFile(plistPath, { encoding: 'utf-8' });
+        const plistData = plist_1.default.parse(data);
+        const dict = xmlMeta.plist.dict.pop();
+        if (!dict.key.includes(configElement.$.parent)) {
+            let xml = buildConfigFileXml(configElement);
+            xml = `<key>${configElement.$.parent}</key>${getConfigFileTagContent(xml)}`;
+            log_1.logger.warn(`Configuration required for ${colors_1.default.strong(plugin.id)}.\n` +
+                `Add the following to Info.plist:\n` +
+                xml);
+        }
+        else if (configElement.array || configElement.dict) {
+            if (configElement.array &&
+                configElement.array.length > 0 &&
+                configElement.array[0].string) {
+                let xml = '';
+                configElement.array[0].string.map((element) => {
+                    const d = plistData[configElement.$.parent];
+                    if (Array.isArray(d) && !d.includes(element)) {
+                        xml = xml.concat(`<string>${element}</string>\n`);
+                    }
+                });
+                if (xml.length > 0) {
+                    log_1.logger.warn(`Configuration required for ${colors_1.default.strong(plugin.id)}.\n` +
+                        `Add the following in the existing ${colors_1.default.strong(configElement.$.parent)} array of your Info.plist:\n` +
+                        xml);
                 }
-            });
-            if (xml.length > 0) {
-                log_1.logger.warn(`Configuration required for ${colors_1.default.strong(plugin.id)}.\n` +
-                    `Add the following in the existing ${colors_1.default.strong(configElement.$.parent)} array of your Info.plist:\n` +
-                    xml);
             }
-        }
-        else {
-            logPossibleMissingItem(configElement, plugin);
+            else {
+                logPossibleMissingItem(configElement, plugin);
+            }
         }
     }
+    else {
+        logPossibleMissingItem(configElement, plugin);
+    }
 }
 function logPossibleMissingItem(configElement, plugin) {
     let xml = buildConfigFileXml(configElement);
@@ -388,7 +396,11 @@ function getIncompatibleCordovaPlugins(platform) {
 exports.getIncompatibleCordovaPlugins = getIncompatibleCordovaPlugins;
 function needsStaticPod(plugin, config) {
     var _a, _b, _c, _d;
-    let pluginList = ['phonegap-plugin-push', '@batch.com/cordova-plugin'];
+    let pluginList = [
+        'phonegap-plugin-push',
+        '@batch.com/cordova-plugin',
+        'onesignal-cordova-plugin',
+    ];
     if ((_b = (_a = config.app.extConfig) === null || _a === void 0 ? void 0 : _a.cordova) === null || _b === void 0 ? void 0 : _b.staticPlugins) {
         pluginList = pluginList.concat((_d = (_c = config.app.extConfig) === null || _c === void 0 ? void 0 : _c.cordova) === null || _d === void 0 ? void 0 : _d.staticPlugins);
     }

package/dist/ios/common.js

@@ -58,7 +58,10 @@ exports.resolvePlugin = resolvePlugin;
  */
 async function editProjectSettingsIOS(config) {
     const appId = config.app.appId;
-    const appName = config.app.appName;
+    const appName = config.app.appName
+        .replace(/&/g, '&')
+        .replace(/</g, '&lt;')
+        .replace(/>/g, '&gt;');
     const pbxPath = `${config.ios.nativeXcodeProjDirAbs}/project.pbxproj`;
     const plistPath = path_1.resolve(config.ios.nativeTargetDirAbs, 'Info.plist');
     let plistContent = await utils_fs_1.readFile(plistPath, { encoding: 'utf-8' });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@capacitor/cli",
-  "version": "3.3.2",
+  "version": "3.4.1",
   "description": "Capacitor: Cross-platform apps with JavaScript and the web",
   "homepage": "https://capacitorjs.com",
   "author": "Ionic Team <hi@ionic.io> (https://ionic.io)",
@@ -85,5 +85,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "3158cd9a293ac79de801c833bb937d2df54e0d96"
+  "gitHead": "bc7b49ff2ad242fecff7bcb3900c627ff6880f7b"
 }