@capacitor-community/sqlite 4.2.2-1 → 4.5.0

package/README.md

@@ -16,10 +16,11 @@
   <a href="https://www.npmjs.com/package/@capacitor-community/sqlite"><img src="https://img.shields.io/npm/dw/@capacitor-community/sqlite?style=flat-square" /></a>
   <a href="https://www.npmjs.com/package/@capacitor-community/sqlite"><img src="https://img.shields.io/npm/v/@capacitor-community/sqlite?style=flat-square" /></a>
 <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-<a href="#contributors-"><img src="https://img.shields.io/badge/all%20contributors-22-orange?style=flat-square" /></a>
+<a href="#contributors-"><img src="https://img.shields.io/badge/all%20contributors-24-orange?style=flat-square" /></a>
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
 </p>
 
+
 ## Maintainers
 
 | Maintainer        | GitHub                                    | Social |
@@ -94,6 +95,7 @@ npm install --save jszip
 npm install --save node-fetch
 npm install --save-dev @types/sqlite3
 ```
+- **Important**: `node-fetch` version must be `<=2.6.7`; otherwise [you'll get an error](https://github.com/capacitor-community/sqlite/issues/349 "you'll get an error ERR_REQUIRE_ESM") running the app. 
 
 ## IOS Quirks
 
@@ -223,9 +225,9 @@ npm install --save-dev @types/sqlite3
 ## Dependencies
 
 The iOS and Android codes are using `SQLCipher` allowing for database encryption.
-The iOS codes is using `ZIPFoundation` for unzipping assets files
+The iOS codes is using `ZIPFoundation` for unzipping assets files.
 The Electron code is using `sqlite3` and `node-fetch` from 4.2.0.
-The Web code is using the Stencil component `jeep-sqlite` based on `sql.js`, `localforage`. and `jszip`  
+The Web code is using the Stencil component `jeep-sqlite` based on `sql.js`, `localforage`, and `jszip`.
 
 ## Contributors ✨
 
@@ -256,7 +258,9 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
   <a href="https://github.com/antoniovlx" title="antoniovlx"><img src="https://github.com/antoniovlx.png?size=100" width="50" height="50" /></a>
   <a href="https://github.com/HarelM" title="HarelM"><img src="https://github.com/HarelM.png?size=100" width="50" height="50" /></a>
   <a href="https://github.com/rdlabo" title="rdlabo"><img src="https://github.com/rdlabo.png?size=100" width="50" height="50" /></a>
-  <a href="https://github.com/axkristiansen" title="rdlabo"><img src="https://github.com/axkristiansen.png?size=100" width="50" height="50" /></a>
+  <a href="https://github.com/axkristiansen" title="axkristiansen"><img src="https://github.com/axkristiansen.png?size=100" width="50" height="50" /></a>
+  <a href="https://github.com/aeinn" title="aeinn"><img src="https://github.com/aeinn.png?size=100" width="50" height="50" /></a>
+  <a href="https://github.com/https://github.com/jonz94" title="aeinn"><img src="https://github.com/jonz94.png?size=100" width="50" height="50" /></a>
 </p>
 
 <!-- markdownlint-enable -->

package/electron/dist/plugin.js

@@ -218,19 +218,15 @@ class UtilsSQLite {
      * BeginTransaction
      * @param db
      * @param isOpen
-     * @param mode
      */
-    async beginTransaction(db, isOpen, mode) {
+    async beginTransaction(db, isOpen) {
         // eslint-disable-next-line no-async-promise-executor
         return new Promise((resolve, reject) => {
             const msg = 'BeginTransaction: ';
             if (!isOpen) {
                 return Promise.reject(`${msg}database not opened`);
             }
-            let sql = 'BEGIN TRANSACTION;';
-            if (mode.slice(0, 3) === "wal") {
-                sql = "BEGIN CONCURRENT";
-            }
+            const sql = 'BEGIN TRANSACTION;';
             db.run(sql, (err) => {
                 if (err) {
                     reject(`${msg}${err.message}`);
@@ -830,7 +826,7 @@ class UtilsSQLite {
     }
     async getJournalMode(mDB) {
         let resQuery = [];
-        let retMode = "delete";
+        let retMode = 'delete';
         const query = `PRAGMA journal_mode;`;
         try {
             resQuery = await this.queryAll(mDB, query, []);
@@ -949,8 +945,7 @@ class UtilsJson {
         let changes = 0;
         try {
             // start a transaction
-            const mode = await this.sqliteUtil.getJournalMode(mDB);
-            await this.sqliteUtil.beginTransaction(mDB, true, mode);
+            await this.sqliteUtil.beginTransaction(mDB, true);
         }
         catch (err) {
             return Promise.reject(`CreateDatabaseSchema: ${err}`);
@@ -2586,8 +2581,7 @@ class ImportFromJson {
         try {
             initChanges = await this.sqliteUtil.dbChanges(mDB);
             // start a transaction
-            const mode = await this.sqliteUtil.getJournalMode(mDB);
-            await this.sqliteUtil.beginTransaction(mDB, true, mode);
+            await this.sqliteUtil.beginTransaction(mDB, true);
         }
         catch (err) {
             return Promise.reject(`createTablesData: ${err}`);
@@ -2647,8 +2641,7 @@ class ImportFromJson {
         try {
             initChanges = await this.sqliteUtil.dbChanges(mDB);
             // start a transaction
-            const mode = await this.sqliteUtil.getJournalMode(mDB);
-            await this.sqliteUtil.beginTransaction(mDB, true, mode);
+            await this.sqliteUtil.beginTransaction(mDB, true);
         }
         catch (err) {
             return Promise.reject(`createViews: ${err}`);
@@ -3265,9 +3258,7 @@ class UtilsUpgrade {
      */
     async onUpgrade(mDB, vUpgDict, curVersion, targetVersion) {
         let changes;
-        const sortedKeys = Object.keys(vUpgDict)
-            .map(item => parseInt(item))
-            .sort();
+        const sortedKeys = new Int32Array(Object.keys(vUpgDict).map(item => parseInt(item))).sort();
         for (const versionKey of sortedKeys) {
             if (versionKey > curVersion && versionKey <= targetVersion) {
                 const statements = vUpgDict[versionKey].statements;
@@ -3298,8 +3289,7 @@ class UtilsUpgrade {
      */
     async executeStatementsProcess(mDB, statements) {
         try {
-            const mode = await this.sqliteUtil.getJournalMode(mDB);
-            await this.sqliteUtil.beginTransaction(mDB, true, mode);
+            await this.sqliteUtil.beginTransaction(mDB, true);
             for (const statement of statements) {
                 await this.sqliteUtil.execute(mDB, statement, false);
             }
@@ -3611,7 +3601,8 @@ class Database {
         try {
             if (transaction) {
                 const mode = await this.sqliteUtil.getJournalMode(this.database);
-                await this.sqliteUtil.beginTransaction(this.database, this._isDbOpen, mode);
+                console.log(`$$$ in executeSQL journal_mode: ${mode} $$$`);
+                await this.sqliteUtil.beginTransaction(this.database, this._isDbOpen);
             }
             const changes = await this.sqliteUtil.execute(this.database, sql, false);
             if (changes < 0) {
@@ -3668,7 +3659,8 @@ class Database {
             // start a transaction
             if (transaction) {
                 const mode = await this.sqliteUtil.getJournalMode(this.database);
-                await this.sqliteUtil.beginTransaction(this.database, this._isDbOpen, mode);
+                console.log(`$$$ in runSQL journal_mode: ${mode} $$$`);
+                await this.sqliteUtil.beginTransaction(this.database, this._isDbOpen);
             }
         }
         catch (err) {
@@ -3712,7 +3704,8 @@ class Database {
             // start a transaction
             if (transaction) {
                 const mode = await this.sqliteUtil.getJournalMode(this.database);
-                await this.sqliteUtil.beginTransaction(this.database, this._isDbOpen, mode);
+                console.log(`$$$ in execSet journal_mode: ${mode} $$$`);
+                await this.sqliteUtil.beginTransaction(this.database, this._isDbOpen);
             }
         }
         catch (err) {