@cap-js/cds-typer 0.21.2 → 0.22.0

package/CHANGELOG.md

@@ -4,7 +4,11 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
-## Version 0.22.0 - TBD
+## Version 0.23.0 - TBD
+
+## Version 0.22.0 - 2024-06-20
+### Fixed
+- Fixed a bug where keys would sometimes inconsistently become nullable
 
 ## Version 0.21.2 - 2024-06-06
 ### Fixed

package/lib/visitor.js

@@ -157,13 +157,15 @@ class Visitor {
                         // lookup in cds.definitions can fail for inline structs.
                         // We don't really have to care for this case, as keys from such structs are _not_ propagated to
                         // the containing entity.
-                        for (const [kname, kelement] of this.#keys(element.target)) {
-                            if (this.resolver.getMaxCardinality(element) === 1) {  // FIXME: kelement?
+                        for (const [kname, originalKeyElement] of this.#keys(element.target)) {
+                            if (this.resolver.getMaxCardinality(element) === 1 && typeof element.on !== 'object') {  // FIXME: kelement?
                                 const foreignKey = `${ename}_${kname}`
                                 if (Object.hasOwn(entity.elements, foreignKey)) {
                                     this.logger.error(`Attempting to generate a foreign key reference called '${foreignKey}' in type definition for entity ${name}. But a property of that name is already defined explicitly. Consider renaming that property.`)
                                 } else {
-                                    kelement.isRefNotNull = !!element.notNull || !!element.key
+                                    const kelement = Object.assign(Object.create(originalKeyElement), { 
+                                        isRefNotNull: !!element.notNull || !!element.key 
+                                    })
                                     this.visitElement(foreignKey, kelement, file, buffer)
                                 }
                             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cap-js/cds-typer",
-  "version": "0.21.2",
+  "version": "0.22.0",
   "description": "Generates .ts files for a CDS model to receive code completion in VS Code",
   "main": "index.js",
   "repository": "github:cap-js/cds-typer",