@cap-js-community/event-queue 1.6.2 → 1.6.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cap-js-community/event-queue",
-  "version": "1.6.2",
+  "version": "1.6.3",
   "description": "An event queue that enables secure transactional processing of asynchronous and periodic events, featuring instant event processing with Redis Pub/Sub and load distribution across all application instances.",
   "main": "src/index.js",
   "types": "src/index.d.ts",

package/src/EventQueueProcessorBase.js

@@ -384,38 +384,46 @@ class EventQueueProcessorBase {
    * The function accepts no arguments as there are dedicated functions to set the status of events (e.g. setEventStatus)
    */
   async persistEventStatus(tx, { skipChecks, statusMap = this.__statusMap } = {}) {
-    return await trace(this.baseContext, "persist-event-status", async () => {
-      this.logger.debug("entering persistEventStatus", {
+    this.logger.debug("entering persistEventStatus", {
+      eventType: this.#eventType,
+      eventSubType: this.#eventSubType,
+    });
+    this.#ensureOnlySelectedQueueEntries(statusMap);
+    if (!skipChecks) {
+      this.#ensureEveryQueueEntryHasStatus();
+    }
+    this.#ensureEveryStatusIsAllowed(statusMap);
+
+    const { success, failed, exceeded, invalidAttempts } = Object.entries(statusMap).reduce(
+      (result, [notificationEntityId, processingStatus]) => {
+        this.__commitedStatusMap[notificationEntityId] = processingStatus;
+        if (processingStatus === EventProcessingStatus.Open) {
+          result.invalidAttempts.push(notificationEntityId);
+        } else if (processingStatus === EventProcessingStatus.Done) {
+          result.success.push(notificationEntityId);
+        } else if (processingStatus === EventProcessingStatus.Error) {
+          result.failed.push(notificationEntityId);
+        } else if (processingStatus === EventProcessingStatus.Exceeded) {
+          result.exceeded.push(notificationEntityId);
+        }
+        return result;
+      },
+      {
+        success: [],
+        failed: [],
+        exceeded: [],
+        invalidAttempts: [],
+      }
+    );
+    if (![success, failed, exceeded, invalidAttempts].some((statusArray) => statusArray.length)) {
+      this.logger.debug("exiting persistEventStatus", {
         eventType: this.#eventType,
         eventSubType: this.#eventSubType,
       });
-      this.#ensureOnlySelectedQueueEntries(statusMap);
-      if (!skipChecks) {
-        this.#ensureEveryQueueEntryHasStatus();
-      }
-      this.#ensureEveryStatusIsAllowed(statusMap);
-
-      const { success, failed, exceeded, invalidAttempts } = Object.entries(statusMap).reduce(
-        (result, [notificationEntityId, processingStatus]) => {
-          this.__commitedStatusMap[notificationEntityId] = processingStatus;
-          if (processingStatus === EventProcessingStatus.Open) {
-            result.invalidAttempts.push(notificationEntityId);
-          } else if (processingStatus === EventProcessingStatus.Done) {
-            result.success.push(notificationEntityId);
-          } else if (processingStatus === EventProcessingStatus.Error) {
-            result.failed.push(notificationEntityId);
-          } else if (processingStatus === EventProcessingStatus.Exceeded) {
-            result.exceeded.push(notificationEntityId);
-          }
-          return result;
-        },
-        {
-          success: [],
-          failed: [],
-          exceeded: [],
-          invalidAttempts: [],
-        }
-      );
+      return;
+    }
+
+    return await trace(this.baseContext, "persist-event-status", async () => {
       this.logger.debug("persistEventStatus for entries", {
         eventType: this.#eventType,
         eventSubType: this.#eventSubType,
@@ -455,10 +463,6 @@ class EventQueueProcessorBase {
             .where("ID IN", eventIds)
         );
       }
-      this.logger.debug("exiting persistEventStatus", {
-        eventType: this.#eventType,
-        eventSubType: this.#eventSubType,
-      });
     });
   }
 

package/src/shared/openTelemetry.js

@@ -10,6 +10,8 @@ try {
 
 const config = require("../config");
 
+const COMPONENT_NAME = "/shared/openTelemetry";
+
 const trace = async (context, label, fn, { attributes = {}, newRootSpan = false } = {}) => {
   if (!config.enableCAPTelemetry || !otel || !cds._telemetry?.tracer) {
     return fn();
@@ -34,8 +36,14 @@ const trace = async (context, label, fn, { attributes = {}, newRootSpan = false
       throw e;
     };
     const onDone = () => {
-      if (span.status.code !== otel.SpanStatusCode.UNSET && !span.ended) {
-        span.end();
+      try {
+        if (span.status?.code !== otel.SpanStatusCode.UNSET && !span.ended) {
+          span.end?.();
+        }
+      } catch (err) {
+        cds.log(COMPONENT_NAME).error("error in tracing", err, {
+          span,
+        });
       }
     };