@canonical/pragma-cli 0.40.0 → 0.42.0

package/src/capabilities/create/shippedCreate.subprocess.test.ts

@@ -17,8 +17,8 @@
  * existed to turn that crash into a clean refusal.
  *
  * There is no virtual filesystem now. Every generator's templates are real
- * files under its own package, so all three nouns run from the shipped entry and
- * all three are asserted here. THE REFUSAL CASES ARE GONE ON PURPOSE: a test
+ * files under its own package, so all four nouns run from the shipped entry and
+ * all four are asserted here. THE REFUSAL CASES ARE GONE ON PURPOSE: a test
  * asserting `create package` refuses would now be asserting a defect.
  *
  * The svelte + lit cases stay load-bearing: `types.ts.ejs` / `index.ts.ejs` /
@@ -28,7 +28,13 @@
  */
 
 import { execFileSync, spawnSync } from "node:child_process";
-import { mkdtempSync, readdirSync, readFileSync } from "node:fs";
+import {
+  mkdirSync,
+  mkdtempSync,
+  readdirSync,
+  readFileSync,
+  writeFileSync,
+} from "node:fs";
 import { tmpdir } from "node:os";
 import { dirname, join, resolve } from "node:path";
 import { fileURLToPath } from "node:url";
@@ -70,7 +76,12 @@ function snapshot(dir: string): Map<string, string> {
  * No case installs dependencies (`runInstall` defaults false), so every tree is
  * generator output alone and byte-comparable.
  */
-const CASES: ReadonlyArray<{ label: string; args: readonly string[] }> = [
+const CASES: ReadonlyArray<{
+  label: string;
+  args: readonly string[];
+  /** Files that must already exist in the cwd (`page` adds to a domain). */
+  seed?: Readonly<Record<string, string>>;
+}> = [
   ...(["react", "svelte", "lit"] as const).map((framework) => ({
     label: `component ${framework}`,
     // The framework is a PATH SEGMENT, not a flag — `create` mirrors summon's
@@ -88,6 +99,11 @@ const CASES: ReadonlyArray<{ label: string; args: readonly string[] }> = [
     // `application/react`, and the tree mirrors summon's.
     args: ["create", "application", "react", "probeapp", "--yes"],
   },
+  {
+    label: "page",
+    args: ["create", "page", "probe/detail", "--yes"],
+    seed: { "src/domains/probe/routes.ts": "export default {};\n" },
+  },
 ];
 
 /** Run one create invocation in its own cwd and snapshot what it wrote. */
@@ -95,19 +111,24 @@ function create(
   command: string,
   prefix: readonly string[],
   args: readonly string[],
+  seed: Readonly<Record<string, string>> = {},
 ): Map<string, string> {
   const dir = freshCwd();
+  for (const [file, content] of Object.entries(seed)) {
+    mkdirSync(dirname(join(dir, file)), { recursive: true });
+    writeFileSync(join(dir, file), content);
+  }
   execFileSync(command, [...prefix, ...args], { cwd: dir, stdio: "pipe" });
   return snapshot(dir);
 }
 
 describe("shipped pragma create (PROTECTED)", () => {
-  for (const { label, args } of CASES) {
+  for (const { label, args, seed } of CASES) {
     it(`${label}: shipped entry ≡ source run, byte-for-byte`, () => {
       // (1) The shipped entry, exactly as a consumer's `pragma` runs it.
-      const shipped = create(process.execPath, [shippedEntry], args);
+      const shipped = create(process.execPath, [shippedEntry], args, seed);
       // (2) A source run — the reference output.
-      const source = create("bun", [sourceEntry], args);
+      const source = create("bun", [sourceEntry], args, seed);
 
       // Wrote something. Before the distribution stopped shipping a compiled
       // binary, `package` and `application` wrote NOTHING here — they refused.

package/src/capabilities/surface.test.ts

@@ -9,6 +9,7 @@ import {
   type Covenant,
 } from "../kernel/spec/surfaceConformance.js";
 import { projectMcp } from "../testing/helpers/projectMcp.js";
+import { CREATE_GENERATORS } from "./create/constants.js";
 import { CREATE_SURFACE } from "./create/createSurface.generated.js";
 import { capabilities } from "./index.js";
 
@@ -199,7 +200,7 @@ describe("surface conformance — capabilities ⊆ covenant (PROTECTED)", () =>
     // args carry the kebab positional the usage line prints, so the covenant
     // names `--no-with-styles` and `[component-path]`, never a
     // `--with-styles` the CLI rejects or a `[componentPath]` its help never
-    // prints. Pin the three entries verbatim so a prompt edit that moves the
+    // prints. Pin the four entries verbatim so a prompt edit that moves the
     // covenant is SEEN.
     expect(emitted.nouns.create?.verbs).toEqual([
       {
@@ -247,6 +248,13 @@ describe("surface conformance — capabilities ⊆ covenant (PROTECTED)", () =>
         mutates: true,
         mcp: "create_application",
       },
+      {
+        v: "page",
+        // The one prompt is the positional page path, so there is no flag.
+        args: ["[page-path]"],
+        mutates: true,
+        mcp: "create_page",
+      },
     ]);
   });
 
@@ -267,8 +275,25 @@ describe("surface conformance — capabilities ⊆ covenant (PROTECTED)", () =>
         );
       }
     }
+    // A create verb carries flags if and only if one of its generators has a
+    // non-positional prompt (`page`, whose one prompt is positional, carries
+    // none) — checked per verb against the projected surface.
+    for (const verb of emitted.nouns.create?.verbs ?? []) {
+      const binding =
+        CREATE_GENERATORS[verb.v as keyof typeof CREATE_GENERATORS];
+      expect(binding, `no binding for create ${verb.v}`).toBeDefined();
+      const hasFlagPrompt = (binding.paths as readonly string[]).some(
+        (commandPath) =>
+          CREATE_SURFACE[commandPath]?.prompts.some(
+            (prompt) => prompt.positional !== true,
+          ) === true,
+      );
+      expect(
+        (verb.flags?.length ?? 0) > 0,
+        `create ${verb.v}: flags iff a non-positional prompt`,
+      ).toBe(hasFlagPrompt);
+    }
     for (const verb of emitted.nouns.create?.verbs ?? []) {
-      expect(verb.flags?.length ?? 0).toBeGreaterThan(0);
       for (const token of verb.flags ?? []) {
         expect([...registered.values()]).toContain(token);
       }
@@ -378,14 +403,14 @@ describe("surface COMPLETE — emitted == covenant (PROTECTED)", () => {
   // The CLOSING direction: assertConforms already proves emitted ⊆ covenant;
   // this proves covenant ⊆ emitted, so together the tool sets are EQUAL — the
   // surface-complete milestone. After PR7, every covenant tool is realized.
-  it("emits every covenant tool (all 50) — set equality with the covenant", () => {
+  it("emits every covenant tool (all 51) — set equality with the covenant", () => {
     const emittedTools = new Set(emitted.mcpSurface.tools);
     const missing = golden.mcpSurface.tools.filter((t) => !emittedTools.has(t));
     expect(missing).toEqual([]);
     expect([...emitted.mcpSurface.tools].sort()).toEqual(
       [...golden.mcpSurface.tools].sort(),
     );
-    expect(emitted.mcpSurface.tools).toHaveLength(50);
+    expect(emitted.mcpSurface.tools).toHaveLength(51);
   });
 
   // The covenant edit: the non-tool MCP surface is frozen too.

package/src/kernel/completion/shellDrive.test.ts

@@ -339,7 +339,7 @@ const STRUCTURE = [
     at: "pragma create <TAB>",
     words: ["pragma", "create", ""],
     cword: 2,
-    offers: ["application", "component", "package"],
+    offers: ["application", "component", "package", "page"],
   },
   {
     at: "pragma --format <TAB>",
@@ -546,7 +546,7 @@ describe.skipIf(!hasShell("fish"))(
       },
       {
         line: "pragma create ",
-        offers: ["application", "component", "package"],
+        offers: ["application", "component", "package", "page"],
       },
       // fish's own inline convention: it returns the whole `--flag=value` word,
       // not the bare value bash offers. Assert what fish returns.

package/src/kernel/spec/surfaceConformance.test.ts

@@ -84,8 +84,8 @@ describe("surface conformance (PROTECTED)", () => {
     );
   });
 
-  it("freezes exactly 50 designed MCP tools including info, the config family, colophon", () => {
-    expect(golden.mcpSurface.tools).toHaveLength(50);
+  it("freezes exactly 51 designed MCP tools including info, the config family, colophon", () => {
+    expect(golden.mcpSurface.tools).toHaveLength(51);
     expect(golden.mcpSurface.tools).toContain("info");
     expect(golden.mcpSurface.tools).toContain("config_show");
     expect(golden.mcpSurface.tools).toContain("config_get");

package/src/testing/behavioral/README.md

@@ -136,7 +136,7 @@ assuming a mismatch is a bug:
 ## Extension points this PR left for you, by owner
 
 - **PR5 (`create`)** — `C1` in the port ledger. No journey exists yet for
-  `create component/package/application` dry-run/real/byte-equality. Add
+  `create component/package/application/page` dry-run/real/byte-equality. Add
   `journeys.create.test.ts` here plus its own eval cases.
 - **PR6 (config mutation, info enrichment, doctor, upgrade, setup, `graph
   query`)** — `C2`/`C3`/`C4` — **BUILT**. Each new verb ships its own