@canonical/pragma-cli 0.34.0 → 0.36.0

package/src/capabilities/doctor/checks/checkMcpConfigured.ts

@@ -1,68 +0,0 @@
-import type { DetectedHarness } from "@canonical/harnesses";
-import { detectHarnesses, readMcpConfig } from "@canonical/harnesses";
-import { runTask } from "@canonical/task/node";
-import { BIN_NAME, MCP_SERVER_NAME } from "../../../constants.js";
-import type { CheckResult } from "../types.js";
-import { deriveBand } from "./deriveBand.js";
-
-/**
- * Check that at least one AI harness has this CLI configured as an MCP server. The
- * result's band is derived from the harnesses actually found (Windsurf ⇒ global,
- * Cursor ⇒ project), not the check name — so a global-scope harness is not
- * mislabeled PROJECT.
- *
- * @param cwd - The project root to detect harnesses against.
- * @returns A CheckResult listing configured harnesses, or fail with a remedy.
- * @note Impure — detects harnesses and reads their MCP configs.
- */
-export async function checkMcpConfigured(cwd: string): Promise<CheckResult> {
-  let detected: DetectedHarness[];
-  try {
-    detected = await runTask(detectHarnesses(cwd));
-  } catch {
-    return {
-      name: "MCP configured",
-      status: "fail",
-      detail: "harness detection failed",
-      remedy: `${BIN_NAME} setup mcp`,
-    };
-  }
-
-  if (detected.length === 0) {
-    return {
-      name: "MCP configured",
-      status: "fail",
-      detail: "no AI harnesses detected",
-      remedy: `${BIN_NAME} setup mcp`,
-    };
-  }
-
-  const configured: DetectedHarness[] = [];
-  for (const d of detected) {
-    if (!d.configExists) continue;
-    try {
-      const servers = await runTask(readMcpConfig(d.harness, cwd));
-      if (MCP_SERVER_NAME in servers) configured.push(d);
-    } catch {
-      // Config unreadable — skip.
-    }
-  }
-
-  if (configured.length > 0) {
-    return {
-      name: "MCP configured",
-      status: "pass",
-      detail: configured.map((d) => d.harness.name).join(", "),
-      band: deriveBand(configured),
-    };
-  }
-
-  const names = detected.map((d) => d.harness.name).join(", ");
-  return {
-    name: "MCP configured",
-    status: "fail",
-    detail: `detected ${names} but ${MCP_SERVER_NAME} not configured`,
-    remedy: `${BIN_NAME} setup mcp`,
-    band: deriveBand(detected),
-  };
-}

package/src/capabilities/doctor/checks/checkSkillsSymlinked.ts

@@ -1,61 +0,0 @@
-import { existsSync } from "node:fs";
-import type { DetectedHarness } from "@canonical/harnesses";
-import { detectHarnesses } from "@canonical/harnesses";
-import { runTask } from "@canonical/task/node";
-import { BIN_NAME } from "../../../constants.js";
-import type { CheckResult } from "../types.js";
-
-/**
- * Check that a skills directory exists for each detected AI harness. Skipped
- * when no harnesses are detected.
- *
- * @param cwd - The project root to detect harnesses against.
- * @returns A CheckResult indicating pass, fail (with a remedy), or skip.
- * @note Impure — detects harnesses and probes the filesystem.
- */
-export async function checkSkillsSymlinked(cwd: string): Promise<CheckResult> {
-  let detected: DetectedHarness[];
-  try {
-    detected = await runTask(detectHarnesses(cwd));
-  } catch {
-    return {
-      name: "Skills symlinked",
-      status: "fail",
-      detail: "harness detection failed",
-      remedy: `${BIN_NAME} setup skills`,
-    };
-  }
-
-  if (detected.length === 0) {
-    return {
-      name: "Skills symlinked",
-      status: "skip",
-      detail: "no AI harnesses detected",
-    };
-  }
-
-  const linked: string[] = [];
-  const missing: string[] = [];
-  for (const d of detected) {
-    if (existsSync(d.harness.skillsPath(cwd))) {
-      linked.push(d.harness.name);
-    } else {
-      missing.push(d.harness.name);
-    }
-  }
-
-  if (missing.length === 0) {
-    return {
-      name: "Skills symlinked",
-      status: "pass",
-      detail: linked.join(", "),
-    };
-  }
-
-  return {
-    name: "Skills symlinked",
-    status: "fail",
-    detail: `missing for ${missing.join(", ")}`,
-    remedy: `${BIN_NAME} setup skills`,
-  };
-}

package/src/capabilities/doctor/checks/deriveBand.test.ts

@@ -1,42 +0,0 @@
-/**
- * `deriveBand` — band a doctor check by the harnesses it actually found.
- *
- * Fixtures wrap REAL harness definitions (via `findHarnessById`, no casts), so
- * the scope→band mapping is exercised against the true `scope` fields: the
- * regression this guards is a global-scope harness (Windsurf) being mislabeled
- * PROJECT by a static per-name guess.
- */
-
-import type { DetectedHarness } from "@canonical/harnesses";
-import { findHarnessById } from "@canonical/harnesses";
-import { describe, expect, it } from "vitest";
-import { deriveBand } from "./deriveBand.js";
-
-/** A minimal {@link DetectedHarness} over a real definition (no `as` casts). */
-function detect(id: string): DetectedHarness {
-  const harness = findHarnessById(id);
-  if (!harness) throw new Error(`unknown harness fixture: ${id}`);
-  return { harness, confidence: "high", configExists: true, configPath: "x" };
-}
-
-describe("deriveBand", () => {
-  it("bands a project-scope harness (Cursor) as project", () => {
-    expect(deriveBand([detect("cursor")])).toBe("project");
-  });
-
-  it("bands a global-scope harness (Windsurf) as global — the fixed mislabel", () => {
-    expect(deriveBand([detect("windsurf")])).toBe("global");
-  });
-
-  it("bands a dual-scope harness (Claude Code) by its default band (project)", () => {
-    expect(deriveBand([detect("claude-code")])).toBe("project");
-  });
-
-  it("leaves a set spanning BOTH bands unbanded (general, not mislabeled)", () => {
-    expect(deriveBand([detect("cursor"), detect("windsurf")])).toBeUndefined();
-  });
-
-  it("leaves an empty set unbanded", () => {
-    expect(deriveBand([])).toBeUndefined();
-  });
-});

package/src/capabilities/doctor/checks/deriveBand.ts

@@ -1,28 +0,0 @@
-/**
- * Derive a doctor check's config band from the harnesses it actually found,
- * rather than a static per-check-name guess. The aggregate MCP checks read each
- * harness's DEFAULT-band file (`defaultBandOf` — the home config for a
- * global-only harness like Windsurf, the project file otherwise), so the band a
- * finding belongs to is exactly that default band.
- */
-
-import type { DetectedHarness } from "@canonical/harnesses";
-import { defaultBandOf } from "@canonical/harnesses";
-import type { ScopeBand } from "../types.js";
-
-/**
- * The single config band a set of detected harnesses shares, or `undefined` when
- * the set is empty or genuinely spans BOTH bands. A two-band finding stays
- * unbanded (rendered in the general section) instead of being mislabeled as one
- * band — faithful to the two-band model: band by what was found, never a guess.
- *
- * @param harnesses - The detected harnesses the check reports on.
- * @returns The shared {@link ScopeBand}, or `undefined` when none/mixed.
- */
-export function deriveBand(
-  harnesses: readonly DetectedHarness[],
-): ScopeBand | undefined {
-  const bands = new Set<ScopeBand>();
-  for (const detected of harnesses) bands.add(defaultBandOf(detected.harness));
-  return bands.size === 1 ? bands.values().next().value : undefined;
-}

package/src/capabilities/shared/bands.ts

@@ -1,16 +0,0 @@
-/**
- * User-facing labels for the two config bands, shared by the setup recap
- * ({@link ../setup/setup.render}) and the doctor report
- * ({@link ../doctor/doctor.render}) so ONE consistent vocabulary appears across
- * both. The pair matches the CLI grammar users already meet elsewhere: the
- * `--global`/`--local` flags, the `--scope project|global|both` enum, config
- * show's `[global]`/`[project]` origin markers, and the `setup` manifest's
- * `[global]`/`[project]` lines. (Earlier these two surfaces said MACHINE/PROJECT
- * — a third term for the same bands; this is the single source that unifies it.)
- */
-
-/** The user-facing display label for each of the two config bands. */
-export const BAND_LABELS: Record<"project" | "global", string> = {
-  global: "Global",
-  project: "Project",
-};

package/src/kernel/config/__snapshots__/firstRun.test.ts.snap

@@ -1,11 +0,0 @@
-// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
-
-exports[`first run > greets on stderr and seeds the global config 1`] = `
-[
-  "Hello! Thanks for taking the time to try the pre-release pragma CLI.",
-  "Please file issues and feedback at https://github.com/canonical/pragma/issues.",
-  "pragma stores its configuration in <CONFIG> (just created with defaults).",
-  "A \`pragma.config.ts\` in this directory or above it overrides it per project.",
-  "",
-]
-`;