@canonical/pragma-cli 0.34.0 → 0.35.0

package/src/testing/setupXdgIsolation.ts

@@ -1,27 +1,87 @@
 /**
- * Global test setup: isolate the XDG config, data, and state layers.
+ * Per-file test setup: give every test FILE its own directory inside the run's
+ * temp root, and isolate the XDG config, data, state, and cache layers in it.
  *
- * The layered config reader consults `$XDG_CONFIG_HOME/pragma/config.json`
- * on every read, global-first writes create it, and the project-config
- * evaluator caches compiled configs under `$XDG_STATE_HOME`. Point all three
- * at per-run temp directories so tests neither observe nor pollute the
- * developer's real global state. Individual tests that exercise XDG
- * behaviour override these values themselves.
+ * The layered config reader consults `$XDG_CONFIG_HOME/pragma/config.json` on
+ * every read, global-first writes create it, and the project-config evaluator
+ * caches compiled configs under `$XDG_STATE_HOME`. The store layer writes its
+ * content-addressed pack cache under `$XDG_CACHE_HOME`. Pointing all four at
+ * temp directories is what keeps tests from observing or polluting the
+ * developer's real global state. Individual tests that exercise XDG behaviour
+ * override these values themselves.
+ *
+ * WHY EVERY TEMP PATH IS REDIRECTED, NOT JUST THE FOUR. This module is
+ * registered as `setupFiles`, not `globalSetup`, so vitest executes it once per
+ * test FILE — over a hundred times in a full run, in a fresh process each time.
+ * Four bare module-scope `mkdtempSync` calls therefore left four directories
+ * behind per file with no hook that could ever remove them, and the tests,
+ * helpers and spawned binaries below them left thousands more, until a 12 GB
+ * tmpfs was exhausted. What that exhaustion looks like is why this docblock is
+ * long: a full disk does not read as a full disk. Every worker fails while
+ * IMPORTING its test file, so the suite reports a hundred-odd files failed
+ * against a handful of assertions run — the exact silhouette of a broken build
+ * — and each of those files still passes when run alone.
+ *
+ * So `TMPDIR`, `TMP`, and `TEMP` are pointed at this file's directory before
+ * any other temp directory exists, which puts every later `tmpdir()` consumer
+ * inside it: the four XDG directories here, the `mkdtempSync` calls in the test
+ * files and their helpers, and the subprocesses those tests spawn, which
+ * inherit this environment. 41 of the 82 files that call `mkdtempSync` have no
+ * `rmSync` anywhere in them; none of them needed editing.
+ *
+ * Allocate temp directories freely under `tmpdir()`; they are cleaned for you.
+ * Do not reintroduce a bare `mkdtempSync` rooted at the REAL system temp
+ * directory (`os.tmpdir()` read before this file runs, or an absolute `/tmp`) —
+ * it escapes the run root and leaks, which is how the tmpfs was exhausted the
+ * first time.
+ *
+ * CORRECTNESS LIVES IN THE RUN ROOT, NOT IN THIS FILE'S HOOK. The `afterAll`
+ * below is hygiene: it keeps a long run's peak disk usage flat instead of
+ * letting every finished file's footprint sit until the end. It is not what
+ * makes the run clean. A fully-skipped file runs no `afterAll` at all, and a
+ * worker torn down mid-file runs no hook either, so anything that depended on
+ * this hook would still leak on exactly the cases hardest to notice. What makes
+ * the run clean is `tempRoot.globalSetup.ts`'s teardown, which removes the run
+ * root wholesale after the last worker exits — every file's directory, skipped
+ * or not, hook or no hook.
  */
 
-import { mkdtempSync } from "node:fs";
-import { tmpdir } from "node:os";
+import { mkdtempSync, rmSync } from "node:fs";
 import { join } from "node:path";
+import { afterAll } from "vitest";
+import { requireTempRoot } from "./tempRoot.globalSetup.js";
 
-process.env.XDG_CONFIG_HOME = mkdtempSync(join(tmpdir(), "pragma-test-xdg-"));
-process.env.XDG_DATA_HOME = mkdtempSync(
-  join(tmpdir(), "pragma-test-xdg-data-"),
-);
-process.env.XDG_STATE_HOME = mkdtempSync(
-  join(tmpdir(), "pragma-test-xdg-state-"),
-);
-// The store layer writes the content-addressed pack cache under
-// $XDG_CACHE_HOME — isolate it too so tests never touch the real cache.
-process.env.XDG_CACHE_HOME = mkdtempSync(
-  join(tmpdir(), "pragma-test-xdg-cache-"),
-);
+/**
+ * This test file's directory inside the run root.
+ *
+ * Allocated before the redirection below, so it lands in the run root rather
+ * than inside itself.
+ */
+const fileTempDir = mkdtempSync(join(requireTempRoot(), "file-"));
+
+// Every subsequent `tmpdir()` in this process, and in the processes it spawns,
+// resolves here. Node reads these three names in this order.
+process.env.TMPDIR = fileTempDir;
+process.env.TMP = fileTempDir;
+process.env.TEMP = fileTempDir;
+
+process.env.XDG_CONFIG_HOME = mkdtempSync(join(fileTempDir, "xdg-config-"));
+process.env.XDG_DATA_HOME = mkdtempSync(join(fileTempDir, "xdg-data-"));
+process.env.XDG_STATE_HOME = mkdtempSync(join(fileTempDir, "xdg-state-"));
+process.env.XDG_CACHE_HOME = mkdtempSync(join(fileTempDir, "xdg-cache-"));
+
+/**
+ * Release this file's footprint early, tolerating every failure.
+ *
+ * A removal that fails (a subprocess still holding a descriptor, a mode a
+ * fixture made read-only) must never turn a green run red — the run root's
+ * teardown collects whatever is left regardless, so there is nothing useful to
+ * do here but continue.
+ */
+afterAll(() => {
+  try {
+    rmSync(fileTempDir, { recursive: true, force: true });
+  } catch {
+    // Deliberately swallowed; the run teardown is the backstop. See above.
+  }
+});

package/src/testing/tempRoot.globalSetup.ts

@@ -0,0 +1,122 @@
+/**
+ * Vitest global setup: one temp root for the whole RUN, allocated before any
+ * worker starts and removed when the last one finishes.
+ *
+ * WHY THE ROOT IS RUN-LEVEL AND NOT PER-FILE. Per-file allocation cannot meet
+ * either half of what this fix is for. A file whose every test is skipped runs
+ * no `afterAll`, and a worker torn down mid-file runs no hook at all, so a
+ * per-file scheme always leaves residue behind and has to reclaim it on some
+ * LATER run — which means a run is never actually clean, only eventually
+ * clean. And a per-file allocation fails per FILE: on a full disk every worker
+ * throws while importing its test file, which is the hundred-failures-no-
+ * assertions silhouette this whole change exists to abolish, reproduced by the
+ * cure.
+ *
+ * Run-level fixes both by construction. `setup` runs ONCE, in the main
+ * process, before a single worker exists: a disk that cannot fit one directory
+ * fails here, once, with a message that names the disk. `teardown` runs after
+ * the last worker exits, whatever happened inside it — skipped files, thrown
+ * files, torn-down workers — so one removal reclaims the run's whole
+ * footprint and the net is zero, not "zero after the next run sweeps".
+ *
+ * The path reaches the workers through the environment, which they inherit
+ * from this process. `setupXdgIsolation.ts` reads it, takes a per-file
+ * subdirectory inside it, and points `TMPDIR` there.
+ */
+
+import { mkdirSync, mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+
+/**
+ * The variable carrying the run root to the workers.
+ *
+ * Read by `setupXdgIsolation.ts`, which runs in each worker. Not a public
+ * contract: both live only inside this package's test configuration.
+ */
+export const TEMP_ROOT_ENV = "PRAGMA_TEST_TEMP_ROOT";
+
+/**
+ * The one name every run root carries, so a human sweeping by hand — or the
+ * workaround in issue #1000 — can recognise this suite's residue.
+ *
+ * DELIBERATELY VENDOR-FREE. Redirecting `tmpdir()` puts this name inside every
+ * temp path the tests build, and some of them assert on the path text:
+ * `identity.test.ts` derives a skills root under `tmpdir()` and requires it to
+ * carry no distribution name, so a root called `pragma-…` fails a PROTECTED
+ * cell that has nothing to do with temp directories. Keep it clear of
+ * `pragma`, `canonical`, and `design-system`.
+ */
+const ROOT_PREFIX = "vitest-tmproot-";
+
+/** The run root, remembered between {@link setup} and {@link teardown}. */
+let runRoot: string | undefined;
+
+/**
+ * Allocate the run root, or fail the run with a diagnosis rather than a
+ * hundred import errors.
+ *
+ * @returns Nothing; the root is published on the environment.
+ * @note Impure — creates a directory and writes `process.env`.
+ */
+export function setup(): void {
+  const systemTmp = tmpdir();
+  try {
+    runRoot = mkdtempSync(join(systemTmp, ROOT_PREFIX));
+  } catch (error) {
+    const reason = error instanceof Error ? error.message : String(error);
+    // The whole point of allocating here: ONE failure, named. A full disk
+    // presents as a mass import failure when it is discovered per worker, and
+    // that shape reads as a broken build rather than a full disk — which is
+    // how the leak this file fixes cost so much diagnosis time.
+    throw new Error(
+      `Could not create the test temp root under ${systemTmp}.\n` +
+        `This is a DISK problem, not a test failure: ${reason}\n\n` +
+        `Check free space with \`df -h ${systemTmp}\`, then reclaim this ` +
+        `suite's residue:\n` +
+        `  find ${systemTmp} -maxdepth 1 -type d -name '${ROOT_PREFIX}*' -exec rm -rf {} +`,
+    );
+  }
+  process.env[TEMP_ROOT_ENV] = runRoot;
+}
+
+/**
+ * Remove the run root and everything any worker put inside it.
+ *
+ * Tolerates failure: a removal that throws (a subprocess still holding a
+ * descriptor, a fixture that made a directory read-only) must never turn a
+ * green run red. One leaked root is one directory, and the message says which.
+ *
+ * @note Impure — removes a directory tree.
+ */
+export function teardown(): void {
+  if (runRoot === undefined) return;
+  try {
+    rmSync(runRoot, { recursive: true, force: true });
+  } catch (error) {
+    const reason = error instanceof Error ? error.message : String(error);
+    console.warn(`Could not remove the test temp root ${runRoot}: ${reason}`);
+  }
+}
+
+/**
+ * The run root, for a worker that needs to allocate inside it.
+ *
+ * @returns The run root path.
+ * @throws If {@link setup} did not run — a configuration error, not a
+ *   transient one, so it says how to fix the config rather than degrading to
+ *   a per-file root that would silently reintroduce the leak.
+ * @note Impure — reads `process.env`.
+ */
+export function requireTempRoot(): string {
+  const root = process.env[TEMP_ROOT_ENV];
+  if (root === undefined || root === "") {
+    throw new Error(
+      `${TEMP_ROOT_ENV} is unset, so the run-level temp root was never ` +
+        `allocated. Add "./src/testing/tempRoot.globalSetup.ts" to this ` +
+        `config's \`globalSetup\` array.`,
+    );
+  }
+  mkdirSync(root, { recursive: true });
+  return root;
+}

package/src/capabilities/create/compiledCreate.subprocess.test.ts

@@ -1,189 +0,0 @@
-/**
- * PROTECTED — the compiled-binary `create` guard.
- *
- * Builds the real standalone `dist/pragma` (`bun build --compile`) and spawns
- * `pragma create component … --yes` for react, svelte AND lit, asserting each
- * tree is BYTE-IDENTICAL to a source run of the same generator (`bun src/bin.ts
- * …`, which reads the `.ejs` templates from disk).
- *
- * This is what proves PR7's two compiled-`create` fixes end-to-end:
- *   1. Summon is bundled — a computed-specifier import used to keep summon-core +
- *      the generators OUT of the binary; static dynamic imports now include them.
- *   2. The templates are embedded AND resolved by DIRECTORY-QUALIFIED path. The
- *      svelte + lit cases are load-bearing: `types.ts.ejs` / `index.ts.ejs` /
- *      `styles.css.ejs` / `stories.ts.ejs` exist in react/, svelte/ AND lit/, so
- *      the old basename-matching fallback could emit the WRONG framework's file
- *      in the binary. A wrong file would differ from the source run → red here.
- *
- * On base (summon not bundled, templates not embedded) the binary's `create`
- * writes nothing (it errors), so `compiled.size > 0` already fails.
- */
-
-import { execFileSync, spawnSync } from "node:child_process";
-import { mkdtempSync, readdirSync, readFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { dirname, join, resolve } from "node:path";
-import { fileURLToPath } from "node:url";
-import { describe, expect, it } from "vitest";
-
-const here = dirname(fileURLToPath(import.meta.url));
-const repoRoot = resolve(here, "../../../../../..");
-const cliNextDir = join(repoRoot, "packages/cli/pragma");
-const pragmaBin = join(cliNextDir, "src/bin.ts");
-const compiledBin = join(cliNextDir, "dist/pragma");
-const freshCwd = (): string => mkdtempSync(join(tmpdir(), "pragma-compiled-"));
-
-// The binary is provisioned by `testing/perf/globalSetup.ts`, which rebuilds it
-// whenever it is missing or older than `src/**`, `scripts/**`, `pragma.conf.ts`
-// or `package.json` — so these tests exercise the current bundle + embedded
-// manifest without a second `beforeAll` writing `dist/pragma` in place while
-// another worker's test is spawning it.
-
-/** Read a directory tree into a sorted map of relative path → contents. */
-function snapshot(dir: string): Map<string, string> {
-  const out = new Map<string, string>();
-  const walk = (d: string, base: string): void => {
-    for (const entry of readdirSync(d, { withFileTypes: true }).sort((a, b) =>
-      a.name.localeCompare(b.name),
-    )) {
-      const rel = base ? `${base}/${entry.name}` : entry.name;
-      if (entry.isDirectory()) walk(join(d, entry.name), rel);
-      else out.set(rel, readFileSync(join(d, entry.name), "utf-8"));
-    }
-  };
-  walk(dir, "");
-  return out;
-}
-
-/** Run a `create component` in its own cwd and snapshot what it wrote. */
-function createComponent(
-  bin: string,
-  args: readonly string[],
-  framework: string,
-): Map<string, string> {
-  const dir = freshCwd();
-  execFileSync(
-    bin,
-    [
-      ...args,
-      "create",
-      "component",
-      "src/components/Widget",
-      "--framework",
-      framework,
-      "--yes",
-    ],
-    { cwd: dir, stdio: "pipe" },
-  );
-  return snapshot(dir);
-}
-
-describe("compiled pragma create component (PROTECTED)", () => {
-  for (const framework of ["react", "svelte", "lit"] as const) {
-    it(`${framework}: compiled binary ≡ source run, byte-for-byte`, () => {
-      // (1) The real standalone binary — templates come from the embedded manifest.
-      const compiled = createComponent(compiledBin, [], framework);
-      // (2) A source run — templates come from disk. The reference output.
-      const source = createComponent("bun", [pragmaBin], framework);
-
-      // Wrote something (fails on base, where the binary's create errors out).
-      expect(compiled.size).toBeGreaterThan(0);
-      // Same file set …
-      expect([...compiled.keys()].sort()).toEqual([...source.keys()].sort());
-      // … and byte-identical contents (the collision fix: svelte/lit must NOT
-      // carry react's template text).
-      for (const [path, content] of compiled) {
-        expect(source.get(path), `content of ${path}`).toBe(content);
-      }
-    }, 120_000);
-  }
-});
-
-/**
- * PROTECTED — the compiled-binary `create` gate.
- *
- * `create component` runs from the binary (the describe above proves it byte for
- * byte) because summon-component routes every template read through
- * `loadTemplateSync` and passes `content:` into `template()`. `create package` /
- * `create application` do NOT: they call `template({ source })`, summon-core
- * falls through to `readFile(options.source)`, and the run dies with `ENOENT …
- * /$bunfs/templates/package.json.ejs` AFTER `mkdir` has already run — a
- * half-made package left on the user's disk. Measured against a real
- * `dist/pragma` with the gate lifted, for both nouns.
- *
- * A `--dry-run` does NOT test this: it exits 0 without reading a template and
- * merely PRINTS `Read file: /$bunfs/templates/package.json.ejs` as a planned
- * effect. That false positive is why the gate has to be pinned by a real run.
- *
- * The `readdirSync(dir)` assertion is the load-bearing one: it fails with the
- * real symptom if the gate is ever lifted without fixing the generators.
- */
-describe("compiled pragma create gate (PROTECTED)", () => {
-  // A LITERAL noun list, deliberately not derived from `create`'s own
-  // declaration: changing the gate's input must turn this red rather than
-  // silently drop the case.
-  for (const kind of ["package", "application"] as const) {
-    it(`refuses \`create ${kind}\` and leaves the cwd untouched`, () => {
-      const dir = freshCwd();
-      const result = spawnSync(compiledBin, ["create", kind, "--yes"], {
-        cwd: dir,
-        stdio: "pipe",
-        encoding: "utf-8",
-      });
-      const output = `${result.stdout ?? ""}${result.stderr ?? ""}`;
-      // 1, not merely non-zero: UNSUPPORTED is a runtime refusal, which
-      // `kernel/error/constants.ts` maps to the generic runtime exit.
-      expect(result.status).toBe(1);
-      expect(output).toContain("not available in the compiled pragma binary");
-      // The clean refusal, not the crash it exists to prevent.
-      expect(output).not.toMatch(/ENOENT/);
-      expect(output).not.toMatch(/Internal error/);
-      // And nothing half-made on disk: the generator's `mkdir` effects run
-      // BEFORE its first template read, so a lifted gate leaves a stub tree.
-      expect(readdirSync(dir)).toEqual([]);
-    }, 30_000);
-  }
-});
-
-/**
- * PROTECTED — the compiled-binary READ guard (U1-orig).
- *
- * A READ command (`block list`, `--help`) never calls a generator's
- * `generate()`, so — with the generators loading their templates LAZILY on first
- * `generate()` rather than at module-eval — it must never touch a `.ejs`
- * template that the standalone binary lacks. This is the exact gap the
- * create-only smoke above missed: the component generators used to load
- * templates via a top-level `await`, so a READ crashed with `Template not found`
- * on any bun version whose `--compile` code-splitting did not keep the generator
- * modules lazy. The lazy load makes a READ template-free regardless of bun.
- */
-describe("compiled pragma READ smoke (PROTECTED)", () => {
-  // A cold store cleanly reports STORE_UNAVAILABLE (exit 3); `--help` never needs
-  // a store (exit 0). Both fully exercise startup + dispatch — the phase where an
-  // eager generator template load would have crashed — without a store or writes.
-  const READS: ReadonlyArray<{
-    args: readonly string[];
-    okExit: readonly number[];
-  }> = [
-    { args: ["block", "list"], okExit: [0, 3] },
-    { args: ["--help"], okExit: [0] },
-  ];
-
-  for (const { args, okExit } of READS) {
-    it(`\`${args.join(" ")}\` runs without a Template-not-found crash`, () => {
-      const result = spawnSync(compiledBin, [...args], {
-        cwd: freshCwd(),
-        stdio: "pipe",
-        encoding: "utf-8",
-      });
-      const output = `${result.stdout ?? ""}${result.stderr ?? ""}`;
-      // The exact crash the lazy-template fix closes: a READ never loads a
-      // generator, so it never touches a `.ejs` the standalone binary lacks.
-      expect(output).not.toMatch(/Template not found/);
-      // Nor does it collapse to the internal-bug path (the crash's other tell).
-      expect(output).not.toMatch(/Internal error/);
-      // It reaches a clean dispatch outcome, not an uncaught startup crash.
-      expect(okExit).toContain(result.status);
-    }, 30_000);
-  }
-});

package/src/capabilities/create/templates.embedded.generated.ts

@@ -1,28 +0,0 @@
-// AUTO-GENERATED by scripts/build.ts — do not edit by hand.
-// Regenerate: `bun run scripts/build.ts`. Inlines the .ejs templates of the
-// generators that read through this manifest (`create component`) as strings, so
-// `pragma create component` works from the standalone --compile binary (the .ejs
-// files are absent from the binary's virtual filesystem).
-/** Directory-qualified template path → file contents. */
-export const TEMPLATES: Record<string, string> = {
-  "component/lit/component.ts.ejs": "import { html, LitElement } from \"lit\";\nimport { customElement } from \"lit/decorators.js\";\n<% if (withStyles) { -%>\nimport styles from \"./styles.css\";\n<% } -%>\nimport type { <%= name %>Props } from \"./types.js\";\n\nconst componentCssClassName = \"ds <%= kebabName %>\";\n\n/**\n * <%= name %> web component.\n *\n * @implements ds:global.component.<%= kebabName %>\n */\n@customElement(\"ds-<%= kebabName %>\")\nexport default class <%= name %> extends LitElement implements <%= name %>Props {\n<% if (withStyles) { -%>\n  static styles = styles;\n\n<% } -%>\n  render() {\n    return html`\n      <div class=\"${componentCssClassName}\">\n        <slot></slot>\n      </div>\n    `;\n  }\n}\n",
-  "component/lit/index.ts.ejs": "export { default as <%= name %> } from \"./<%= name %>.js\";\nexport type { <%= name %>Props } from \"./types.js\";\n",
-  "component/lit/stories.ts.ejs": "import type { Meta, StoryObj } from \"@storybook/web-components-vite\";\nimport { html } from \"lit\";\n\nimport \"./<%= name %>.js\";\nimport type <%= name %> from \"./<%= name %>.js\";\n\nconst meta = {\n  title: \"Web Components/<%= name %>\",\n  tags: [\"autodocs\"],\n} satisfies Meta<<%= name %>>;\n\nexport default meta;\ntype Story = StoryObj<<%= name %>>;\n\nexport const Default: Story = {\n  render: () => html`<ds-<%= kebabName %>>Hello, <%= name %>!</ds-<%= kebabName %>>`,\n};\n",
-  "component/lit/styles.css.ejs": "/*\n * Lit Layout Primer\n * Delete this comment block when you're done implementing.\n *\n * Styles live in a shadow DOM, isolated from the page by default.\n *\n * Two layers:\n *\n *   1) :host — the outer shell, how this component presents to its parent layout.\n *      display, width, height                          (always apply)\n *      grid-column, grid-row, align-self, justify-self (parent must be grid/flex)\n *\n *   2) .ds.<%= kebabName %> — the inner shell, how this component arranges its shadow children.\n *      display: grid/flex, gap, grid-template-columns, align-items, justify-content\n *\n * Subgrid pattern — use when the parent defines grid tracks you want to inherit:\n *\n *   In the parent component:\n *   .ds.parent { display: grid; grid-template-columns: repeat(4, 1fr); }\n *\n *   In this component:\n *   :host                { display: grid; grid-column: span 2; }\n *   .ds.<%= kebabName %> { display: grid; grid-template-columns: subgrid; }\n *\n *   In this example, the parent establishes a 4-column grid.\n *   This component claims 2 of those columns and inherits their widths via subgrid.\n *\n * Keep in mind:\n *   - Custom elements are display: inline by default — always set display on :host.\n *   - Flex/grid rules only affect direct children of the container, not deeper descendants.\n *   - External CSS cannot pierce the shadow boundary — expose CSS custom properties for theming.\n */\n\n:host {\n  /*\n   * Host controls the outer layout role.\n   * Declare component CSS variables here when needed.\n   * Variables must be on :host to be accessible inside the shadow tree.\n   *\n   * Example:\n   * --<%= kebabName %>-color-background: var(--color-background-default);\n   * --<%= kebabName %>-color-text: var(--color-text-default);\n   */\n  display: inline-flex;\n}\n\n.ds.<%= kebabName %> {\n  /* Inner layout and visual styles go here. */\n}\n",
-  "component/lit/tests.ts.ejs": "import { afterEach, beforeEach, describe, expect, it } from \"vitest\";\nimport \"./<%= name %>.js\";\nimport type <%= name %> from \"./<%= name %>.js\";\n\ndescribe(\"<%= name %> component\", () => {\n  let elem: <%= name %>;\n\n  beforeEach(() => {\n    elem = document.createElement(\"ds-<%= kebabName %>\") as <%= name %>;\n    document.body.appendChild(elem);\n  });\n\n  afterEach(() => {\n    elem.remove();\n  });\n\n  it(\"should render component\", async () => {\n    await customElements.whenDefined(\"ds-<%= kebabName %>\");\n\n    const container = elem.shadowRoot?.querySelector(\".ds.<%= kebabName %>\");\n    expect(container).toBeTruthy();\n  });\n\n  it(\"should have correct tag name\", () => {\n    expect(elem.tagName.toLowerCase()).toBe(\"ds-<%= kebabName %>\");\n  });\n});\n",
-  "component/lit/types.ts.ejs": "/**\n * Props for the <%= name %> component.\n */\nexport interface <%= name %>Props {\n  // Define props specific to <%= name %> here\n}\n",
-  "component/react/component.tsx.ejs": "import type React from \"react\";\nimport type { <%= name %>Props } from \"./types.js\";\n<% if (withStyles) { -%>\nimport \"./styles.css\";\n<% } -%>\n\nconst componentCssClassName = \"ds <%= kebabName %>\";\n\n/**\n * <%= name %> component\n */\nconst <%= name %> = ({\n\tclassName,\n\tchildren,\n\t...props\n}: <%= name %>Props): React.ReactElement => {\n\treturn (\n\t\t<div\n\t\t\tclassName={[componentCssClassName, className].filter(Boolean).join(\" \")}\n\t\t\t{...props}\n\t\t>\n\t\t\t{children}\n\t\t</div>\n\t);\n};\n\nexport default <%= name %>;\n",
-  "component/react/index.ts.ejs": "export { default as <%= name %> } from \"./<%= name %>.js\";\nexport type * from \"./types.js\";\n",
-  "component/react/ssr.test.tsx.ejs": "import { describe, expect, it } from \"vitest\";\nimport { renderToString } from \"react-dom/server\";\nimport <%= name %> from \"./<%= name %>.js\";\n\ndescribe(\"<%= name %> SSR\", () => {\n\tit(\"renders without hydration errors\", () => {\n\t\tconst html = renderToString(<<%= name %>>Test content</<%= name %>>);\n\t\texpect(html).toContain(\"Test content\");\n\t\texpect(html).toContain(\"ds <%= kebabName %>\");\n\t});\n});\n",
-  "component/react/stories.tsx.ejs": "import type { Meta, StoryObj } from \"@storybook/react-vite\";\nimport <%= name %> from \"./<%= name %>.js\";\n\nconst meta: Meta<typeof <%= name %>> = {\n\ttitle: \"Components/<%= name %>\",\n\tcomponent: <%= name %>,\n\ttags: [\"autodocs\"],\n};\n\nexport default meta;\ntype Story = StoryObj<typeof <%= name %>>;\n\nexport const Default: Story = {\n\targs: {\n\t\tchildren: \"Hello, <%= name %>!\",\n\t},\n};\n\nexport const WithCustomClass: Story = {\n\targs: {\n\t\tchildren: \"Custom styled\",\n\t\tclassName: \"custom-class\",\n\t},\n};\n",
-  "component/react/test.tsx.ejs": "import { describe, expect, it } from \"vitest\";\nimport { render, screen } from \"@testing-library/react\";\nimport <%= name %> from \"./<%= name %>.js\";\n\ndescribe(\"<%= name %>\", () => {\n\tit(\"renders children\", () => {\n\t\trender(<<%= name %>>Test content</<%= name %>>);\n\t\texpect(screen.getByText(\"Test content\")).toBeInTheDocument();\n\t});\n\n\tit(\"applies custom className\", () => {\n\t\trender(<<%= name %> className=\"custom-class\">Content</<%= name %>>);\n\t\tconst element = screen.getByText(\"Content\");\n\t\texpect(element.className).toContain(\"ds <%= kebabName %>\");\n\t\texpect(element.className).toContain(\"custom-class\");\n\t});\n\n\tit(\"passes through additional props\", () => {\n\t\trender(<<%= name %> data-testid=\"test-component\">Content</<%= name %>>);\n\t\texpect(screen.getByTestId(\"test-component\")).toBeInTheDocument();\n\t});\n});\n",
-  "component/react/types.ts.ejs": "import type { HTMLAttributes, ReactNode } from \"react\";\n\nexport interface <%= name %>Props extends HTMLAttributes<HTMLDivElement> {\n\t/** Content to render inside the component */\n\tchildren?: ReactNode;\n}\n",
-  "component/shared/styles.css.ejs": ".ds.<%= kebabName %> {\n\t/* Component styles */\n}\n",
-  "component/svelte/component.svelte.ejs": "<script lang=\"ts\">\n\timport type { <%= name %>Props } from \"./types.js\";\n<% if (withStyles) { -%>\n\timport \"./styles.css\";\n<% } -%>\n\n\tconst componentCssClassName = \"ds <%= kebabName %>\";\n\n\tlet {\n\t\tclass: className,\n\t\tchildren,\n\t\t...rest\n\t}: <%= name %>Props = $props();\n</script>\n\n<div\n\tclass={[componentCssClassName, className]}\n\t{...rest}\n>\n\t{@render children?.()}\n</div>\n",
-  "component/svelte/index.ts.ejs": "export { default as <%= name %> } from \"./<%= name %>.svelte\";\nexport type { <%= name %>Props } from \"./types.js\";\n",
-  "component/svelte/ssr.test.ts.ejs": "import { render } from \"@canonical/svelte-ssr-test\";\nimport type { RenderResult } from \"@canonical/svelte-ssr-test\";\nimport { createRawSnippet } from \"svelte\";\nimport type { ComponentProps } from \"svelte\";\nimport { describe, expect, it } from \"vitest\";\nimport Component from \"./<%= name %>.svelte\";\n\ndescribe(\"<%= name %> SSR\", () => {\n\tconst baseProps = {\n\t\tchildren: createRawSnippet(() => ({\n\t\t\trender: () => `<span><%= name %></span>`,\n\t\t})),\n\t} satisfies ComponentProps<typeof Component>;\n\n\tdescribe(\"basics\", () => {\n\t\tit(\"doesn't throw\", () => {\n\t\t\texpect(() => {\n\t\t\t\trender(Component, { props: { ...baseProps } });\n\t\t\t}).not.toThrow();\n\t\t});\n\n\t\tit(\"renders\", () => {\n\t\t\tconst page = render(Component, { props: { ...baseProps } });\n\t\t\texpect(componentLocator(page)).toBeInstanceOf(page.window.HTMLDivElement);\n\t\t});\n\t});\n\n\tdescribe(\"attributes\", () => {\n\t\tit.each([\n\t\t\t[\"id\", \"test-id\"],\n\t\t\t[\"aria-label\", \"test-aria-label\"],\n\t\t])(\"applies %s\", (attribute, expected) => {\n\t\t\tconst page = render(Component, {\n\t\t\t\tprops: { ...baseProps, [attribute]: expected },\n\t\t\t});\n\t\t\texpect(componentLocator(page).getAttribute(attribute)).toBe(expected);\n\t\t});\n\n\t\tit(\"applies classes\", () => {\n\t\t\tconst page = render(Component, {\n\t\t\t\tprops: { class: \"test-class\", ...baseProps },\n\t\t\t});\n\t\t\texpect(componentLocator(page).classList).toContain(\"test-class\");\n<% if (withStyles) { _%>\n\t\t\texpect(componentLocator(page).classList).toContain(\"ds\");\n\t\t\texpect(componentLocator(page).classList).toContain(\"<%= kebabName %>\");<% } %>\n\t\t});\n\n\t\tit(\"applies style\", () => {\n\t\t\tconst page = render(Component, {\n\t\t\t\tprops: { style: \"color: orange;\", ...baseProps },\n\t\t\t});\n\t\t\texpect(componentLocator(page).style.color).toBe(\"orange\");\n\t\t});\n\t});\n});\n\n// Note: Prefer role/semantics-oriented ways of selecting elements (e.g., by role, label, etc.) not only for component roots but for all elements to enhance accessibility and maintainability.\n// To select the component's root element, use one of the available [Queries](https://testing-library.com/docs/queries/about/#priority).\nfunction componentLocator(page: RenderResult): HTMLElement {\n\t// 1. SEMANTIC ROLES (PREFERRED) - These the most closely resemble how assistive technologies interact with your component\n\t// return page.getByRole(\"link\", { name: \"Learn more\" });\n\n\t// 2. LABELS - To test the association between labels and form controls\n\t// return page.getByLabelText(\"Email address\");\n\n\t// 3. PLACEHOLDER TEXT - Useful for input fields with placeholders\n\t// return page.getByPlaceholderText(\"Enter your email\");\n\n\t// 4. TEXT CONTENT - Good for testing the presence of unique texts and selecting non-interactive elements\n\t// return page.getByText(\"<%= name %>\");\n\n\t// 5. DISPLAY VALUE - For selecting form elements by their current value\n\t// return page.getByDisplayValue(\"test value\");\n\n\t// 6. ALT TEXT - For images and visual elements\n\t// return page.getByAltText(\"Company logo\");\n\n\t// 7. TITLE ATTRIBUTE - For elements with title tooltips\n\t// return page.getByTitle(\"Close dialog\");\n\n\t// 8. TEST IDS (LAST RESORT) - When semantic options aren't available\n\t// return page.getByTestId(\"<%= kebabName %>\");\n}\n",
-  "component/svelte/stories.svelte.ejs": "<script lang=\"ts\" module>\n\timport { defineMeta } from \"@storybook/addon-svelte-csf\";\n\timport <%= name %> from \"./<%= name %>.svelte\";\n\n\tconst { Story } = defineMeta({\n\t\ttitle: \"Components/<%= name %>\",\n\t\tcomponent: <%= name %>,\n\t\ttags: [\"autodocs\"],\n\t});\n</script>\n\n<Story name=\"Default\">\n\tHello, <%= name %>!\n</Story>\n\n<Story\n  name=\"WithCustomClass\"\n  args={{\n    class: \"custom-class\",\n    id: \"custom-id\",\n    style: \"background-color: tomato;\",\n  }}\n>\n\tCustom styled\n</Story>\n",
-  "component/svelte/stories.ts.ejs": "import type { Meta, StoryObj } from \"@storybook/svelte\";\nimport <%= name %> from \"./<%= name %>.svelte\";\n\nconst meta: Meta<typeof <%= name %>> = {\n\ttitle: \"Components/<%= name %>\",\n\tcomponent: <%= name %>,\n\ttags: [\"autodocs\"],\n};\n\nexport default meta;\ntype Story = StoryObj<typeof <%= name %>>;\n\nexport const Default: Story = {};\n\nexport const WithCustomClass: Story = {\n\targs: {\n\t\tclass: \"custom-class\",\n\t},\n};\n",
-  "component/svelte/test.ts.ejs": "import type { Locator } from \"@vitest/browser/context\";\nimport { createRawSnippet } from \"svelte\";\nimport type { ComponentProps } from \"svelte\";\nimport { describe, expect, it } from \"vitest\";\nimport { render } from \"vitest-browser-svelte\";\nimport type { RenderResult } from \"vitest-browser-svelte\";\nimport Component from \"./<%= name %>.svelte\";\n\ndescribe(\"<%= name %> component\", () => {\n\tconst baseProps = {\n\t\tchildren: createRawSnippet(() => ({\n\t\t\trender: () => `<span><%= name %></span>`,\n\t\t})),\n\t} satisfies ComponentProps<typeof Component>;\n\n\tit(\"renders\", async () => {\n\t\tconst page = render(Component, { ...baseProps });\n\t\tawait expect.element(componentLocator(page)).toBeInTheDocument();\n\t\tawait expect.element(page.getByText(\"<%= name %>\")).toBeVisible();\n\t});\n\n\tdescribe(\"attributes\", () => {\n\t\tit.each([\n\t\t\t[\"id\", \"test-id\"],\n\t\t\t[\"aria-label\", \"test-aria-label\"],\n\t\t])(\"applies %s\", async (attribute, expected) => {\n\t\t\tconst page = render(Component, { ...baseProps, [attribute]: expected });\n\t\t\tawait expect\n\t\t\t\t.element(componentLocator(page))\n\t\t\t\t.toHaveAttribute(attribute, expected);\n\t\t});\n\n\t\tit(\"applies classes\", async () => {\n\t\t\tconst page = render(Component, { ...baseProps, class: \"test-class\" });\n\t\t\tawait expect.element(componentLocator(page)).toHaveClass(\"test-class\");\n<% if (withStyles) { _%>\n\t\t\tawait expect.element(componentLocator(page)).toHaveClass(\"ds\");\n\t\t\tawait expect\n\t\t\t\t.element(componentLocator(page))\n\t\t\t\t.toHaveClass(\"<%= kebabName %>\");<% } %>\n\t\t});\n\n\t\tit(\"applies style\", async () => {\n\t\t\tconst page = render(Component, {\n\t\t\t\t...baseProps,\n\t\t\t\tstyle: \"color: orange;\",\n\t\t\t});\n\t\t\tawait expect\n\t\t\t\t.element(componentLocator(page))\n\t\t\t\t.toHaveStyle({ color: \"orange\" });\n\t\t});\n\t});\n});\n\n// Note: Prefer role/semantics-oriented ways of selecting elements (e.g., by role, label, etc.) not only for component roots but for all elements to enhance accessibility and maintainability.\n// To select the component's root element, use one of the available [Locators](https://vitest.dev/guide/browser/locators.html).\nfunction componentLocator(page: RenderResult<typeof Component>): Locator {\n\t// 1. SEMANTIC ROLES (PREFERRED) - These the most closely resemble how assistive technologies interact with your component\n\t// return page.getByRole(\"link\", { name: \"Learn more\" });\n\n\t// 2. LABELS - To test the association between labels and form controls\n\t// return page.getByLabel(\"Email address\");\n\n\t// 3. PLACEHOLDER TEXT - Useful for input fields with placeholders\n\t// return page.getByPlaceholder(\"Enter your email\");\n\n\t// 4. TEXT CONTENT - Good for testing the presence of unique texts and selecting non-interactive elements\n\t// return page.getByText(\"<%= name %>\");\n\n\t// 5. ALT TEXT - For images and visual elements\n\t// return page.getByAltText(\"Company logo\");\n\n\t// 6. TITLE ATTRIBUTE - For elements with title tooltips\n\t// return page.getByTitle(\"Close dialog\");\n\n\t// 7. TEST IDS (LAST RESORT) - When semantic options aren't available\n\t// return page.getByTestId(\"<%= kebabName %>\");\n}\n",
-  "component/svelte/types.ts.ejs": "import type { Snippet } from \"svelte\";\nimport type { SvelteHTMLElements } from \"svelte/elements\";\n\n/*\n\tFor components that render specific HTML elements with extended prop sets,\n\tmake sure to change `\"div\"` to the appropriate HTML element type.\n*/\ntype BaseProps = SvelteHTMLElements[\"div\"];\n\nexport interface <%= name %>Props extends BaseProps {\n\t/** Content to render inside the component */\n\tchildren?: Snippet;\n\t// Define additional props specific to <%= name %> here\n}\n\n/*\n\t...or consider using appropriate interfaces directly exported from `svelte/elements`.\n\n\tFor example:\n\t- `HTMLButtonAttributes` (provides `disabled`, `type`, etc.)\n\t- `HTMLAnchorAttributes` (provides `href`, `target`, etc.)\n\t- `HTMLInputAttributes` (provides `type`, `checked`, `value`, etc.)\n\t- `HTMLFormAttributes` (provides `action`, `method`, etc.)\n\n\t```typescript\n\timport type { HTMLButtonAttributes } from \"svelte/elements\";\n\n\texport interface MyButtonProps extends HTMLButtonAttributes {\n\t\t// Your custom props here\n\t}\n\t```\n\n\tSee Svelte documentation on typing wrapper components:\n\thttps://svelte.dev/docs/svelte/typescript#Typing-wrapper-components\n*/\n",
-};

package/src/capabilities/doctor/checks/checkConfigFile.ts

@@ -1,42 +0,0 @@
-import { BIN_NAME } from "../../../constants.js";
-import { readConfig } from "../../../kernel/config/readConfig.js";
-import type { PragmaRuntime } from "../../../kernel/runtime/types.js";
-import type { CheckResult } from "../types.js";
-
-/**
- * Check which config layer is active for the working directory.
- *
- * Passes when a project config is found up the tree, or — the CLI is
- * global-first — when only the global XDG config exists. Fails only when
- * neither layer is configured.
- *
- * @param rt - The per-invocation runtime (for `cwd`).
- * @returns A CheckResult indicating the active layer, or fail with a remedy.
- * @note Impure — reads the config layers from disk.
- */
-export async function checkConfigFile(rt: PragmaRuntime): Promise<CheckResult> {
-  const layers = await readConfig(rt.cwd);
-
-  if (layers.project.exists) {
-    return {
-      name: `${BIN_NAME} config`,
-      status: "pass",
-      detail: `project config active (${layers.project.path})`,
-    };
-  }
-
-  if (layers.global.exists) {
-    return {
-      name: `${BIN_NAME} config`,
-      status: "pass",
-      detail: `no project config — global config active (${layers.global.path})`,
-    };
-  }
-
-  return {
-    name: `${BIN_NAME} config`,
-    status: "fail",
-    detail: "not found",
-    remedy: `${BIN_NAME} config set tier <path>`,
-  };
-}

package/src/capabilities/doctor/checks/checkMcpCommands.ts

@@ -1,114 +0,0 @@
-import { existsSync } from "node:fs";
-import { delimiter, isAbsolute, join } from "node:path";
-import type { DetectedHarness } from "@canonical/harnesses";
-import { detectHarnesses, readMcpConfig } from "@canonical/harnesses";
-import { runTask } from "@canonical/task/node";
-import type { CheckItem, CheckResult } from "../types.js";
-import { deriveBand } from "./deriveBand.js";
-
-const NAME = "MCP commands";
-
-/**
- * Extract the stdio command from an MCP server config entry, if any. HTTP/SSE
- * entries (`{ type: "http", url }`) have no command and are not checked.
- */
-function commandOf(entry: unknown): string | undefined {
-  if (typeof entry !== "object" || entry === null) return undefined;
-  const command = (entry as { command?: unknown }).command;
-  return typeof command === "string" && command.length > 0
-    ? command
-    : undefined;
-}
-
-/**
- * Resolve a command the way a shell would: a path-bearing entry is checked as a
- * file (relative to the project root), a bare name is searched across `PATH`.
- */
-function commandResolves(command: string, cwd: string): boolean {
-  if (command.includes("/") || command.includes("\\")) {
-    return existsSync(isAbsolute(command) ? command : join(cwd, command));
-  }
-  return (process.env.PATH ?? "")
-    .split(delimiter)
-    .filter((dir) => dir.length > 0)
-    .some((dir) => existsSync(join(dir, command)));
-}
-
-/**
- * Check that every command-based MCP server entry in detected harness configs
- * resolves to an executable. A dead entry makes every agent session try and
- * fail to boot it, so it is flagged with its config path.
- *
- * @param cwd - The project root to detect harnesses against.
- * @returns pass (all resolve), fail (listing broken entries), or skip (nothing
- *   to check).
- * @note Impure — detects harnesses, reads configs, and probes PATH/the fs.
- */
-export async function checkMcpCommands(cwd: string): Promise<CheckResult> {
-  let detected: DetectedHarness[];
-  try {
-    detected = await runTask(detectHarnesses(cwd));
-  } catch {
-    return { name: NAME, status: "skip", detail: "harness detection failed" };
-  }
-
-  const withConfig = detected.filter((d) => d.configExists);
-  if (withConfig.length === 0) {
-    return { name: NAME, status: "skip", detail: "no MCP configs found" };
-  }
-
-  // Band the finding by the harnesses whose configs were actually examined, so
-  // a global-scope harness's broken command is reported under the global band.
-  const band = deriveBand(withConfig);
-  const broken: CheckItem[] = [];
-  let checked = 0;
-
-  for (const d of withConfig) {
-    let servers: Record<string, unknown>;
-    try {
-      servers = await runTask(readMcpConfig(d.harness, cwd));
-    } catch {
-      continue; // The "MCP configured" check reports on unreadable configs.
-    }
-
-    for (const [serverName, entry] of Object.entries(servers)) {
-      const command = commandOf(entry);
-      if (!command) continue;
-      checked += 1;
-      if (!commandResolves(command, cwd)) {
-        broken.push({
-          label: `"${serverName}"`,
-          status: "fail",
-          detail: `"${command}" not found · ${d.configPath}`,
-        });
-      }
-    }
-  }
-
-  if (checked === 0) {
-    return {
-      name: NAME,
-      status: "skip",
-      detail: "no command-based MCP servers configured",
-    };
-  }
-
-  if (broken.length === 0) {
-    return {
-      name: NAME,
-      status: "pass",
-      detail: `${checked} command${checked === 1 ? "" : "s"} resolve on PATH`,
-      band,
-    };
-  }
-
-  return {
-    name: NAME,
-    status: "fail",
-    detail: `${broken.length} of ${checked} unresolvable`,
-    items: broken,
-    remedy:
-      "Install the missing command or remove the entry — every agent session tries and fails to boot it.",
-    band,
-  };
-}