@canivel/ralph 0.2.0 → 0.2.3

package/tests/agent-ping.mjs

@@ -1,39 +1,39 @@
-import { spawnSync } from "node:child_process";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-
-const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
-const cliPath = path.join(repoRoot, "bin", "ralph");
-
-function run(cmd, args, options = {}) {
-  const result = spawnSync(cmd, args, { stdio: "inherit", ...options });
-  if (result.status !== 0) {
-    console.error(`Command failed: ${cmd} ${args.join(" ")}`);
-    process.exit(result.status ?? 1);
-  }
-}
-
-const agents = [
-  { name: "codex", bin: "codex" },
-  { name: "claude", bin: "claude" },
-  { name: "droid", bin: "droid" },
-  { name: "opencode", bin: "opencode" },
-];
-const runnable = [];
-const skipped = [];
-for (const agent of agents) {
-  const check = spawnSync(`command -v ${agent.bin}`, { shell: true, stdio: "ignore" });
-  if (check.status === 0) {
-    runnable.push(agent.name);
-  } else {
-    skipped.push(agent.name);
-  }
-}
-if (skipped.length) {
-  console.log(`Skipping ping for missing agents: ${skipped.join(", ")}`);
-}
-for (const agent of runnable) {
-  run(process.execPath, [cliPath, "ping", `--agent=${agent}`]);
-}
-
-console.log("Agent ping tests passed.");
+import { spawnSync } from "node:child_process";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+
+const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
+const cliPath = path.join(repoRoot, "bin", "ralph");
+
+function run(cmd, args, options = {}) {
+  const result = spawnSync(cmd, args, { stdio: "inherit", ...options });
+  if (result.status !== 0) {
+    console.error(`Command failed: ${cmd} ${args.join(" ")}`);
+    process.exit(result.status ?? 1);
+  }
+}
+
+const agents = [
+  { name: "codex", bin: "codex" },
+  { name: "claude", bin: "claude" },
+  { name: "droid", bin: "droid" },
+  { name: "opencode", bin: "opencode" },
+];
+const runnable = [];
+const skipped = [];
+for (const agent of agents) {
+  const check = spawnSync(`command -v ${agent.bin}`, { shell: true, stdio: "ignore" });
+  if (check.status === 0) {
+    runnable.push(agent.name);
+  } else {
+    skipped.push(agent.name);
+  }
+}
+if (skipped.length) {
+  console.log(`Skipping ping for missing agents: ${skipped.join(", ")}`);
+}
+for (const agent of runnable) {
+  run(process.execPath, [cliPath, "ping", `--agent=${agent}`]);
+}
+
+console.log("Agent ping tests passed.");

package/tests/audit.md

@@ -1,56 +1,56 @@
-# Ralph Test Coverage Audit
-
-## Scope reviewed
-- `bin/ralph`
-- `.agents/ralph/loop.sh`
-- `.agents/ralph/PROMPT_build.md`
-- `.agents/ralph/log-activity.sh`
-- `.agents/ralph/references/*`
-- `skills/*`
-- `tests/*`
-
-## Current test coverage
-
-### CLI
-- `tests/cli-smoke.mjs`
-  - Verifies `--help` output
-  - Verifies `ralph prd ... --out` creates a PRD JSON file (dry-run)
-  - Verifies `ralph overview --prd ...` creates an overview file
-
-### Loop (dry-run)
-- `tests/agent-loops.mjs`
-  - Runs `ralph build 1 --no-commit` with all agents using `RALPH_DRY_RUN=1`
-  - Confirms loops execute and log to stdout without real agent execution
-
-### Agent ping (fast, real)
-- `tests/agent-ping.mjs`
-  - Runs `ralph ping` for codex/claude/droid
-  - Verifies each agent responds with `<end>pong</end>`
-
-### Real integration (new)
-- `tests/real-agents.mjs`
-  - Creates a temp repo with a 2‑story JSON PRD and minimal AGENTS instructions
-  - Runs `ralph build 2 --agent=<codex|claude|droid>`
-  - Verifies:
-    - PRD stories are all marked `done`
-    - At least one git commit was created
-    - Progress log exists
-  - Cleans up the temp repo and logs after each agent run (pass or fail)
-
-## Gaps identified
-- **Interactive installs**: `ralph install` and `ralph install --skills` require prompts and are not exercised in automated tests.
-- **Skill installation paths**: Local vs global skill locations are not validated in tests.
-- **Failure logging**: `.ralph/errors.log` contents are not asserted.
-- **Activity logging**: Activity log presence is not asserted (only implied via run completion).
-- **Guardrails**: No test verifies that guardrails are created/updated.
-
-## Recommendations
-1. Keep default tests deterministic (`npm test`) and provide a separate real‑agent test (`npm run test:real`).
-2. Add a non‑interactive flag for skill install if you want it testable in CI.
-3. Add assertions for `.ralph/activity.log` and `.ralph/guardrails.md` creation in `tests/real-agents.mjs`.
-4. Consider adding coverage for PRD selection when multiple JSON files exist.
-
-## How to run
-- **Deterministic:** `npm test`
-- **Fast real agent check:** `npm run test:ping`
-- **Real agents:** `npm run test:real` (requires codex/claude/droid installed and authenticated)
+# Ralph Test Coverage Audit
+
+## Scope reviewed
+- `bin/ralph`
+- `.agents/ralph/loop.sh`
+- `.agents/ralph/PROMPT_build.md`
+- `.agents/ralph/log-activity.sh`
+- `.agents/ralph/references/*`
+- `skills/*`
+- `tests/*`
+
+## Current test coverage
+
+### CLI
+- `tests/cli-smoke.mjs`
+  - Verifies `--help` output
+  - Verifies `ralph prd ... --out` creates a PRD JSON file (dry-run)
+  - Verifies `ralph overview --prd ...` creates an overview file
+
+### Loop (dry-run)
+- `tests/agent-loops.mjs`
+  - Runs `ralph build 1 --no-commit` with all agents using `RALPH_DRY_RUN=1`
+  - Confirms loops execute and log to stdout without real agent execution
+
+### Agent ping (fast, real)
+- `tests/agent-ping.mjs`
+  - Runs `ralph ping` for codex/claude/droid
+  - Verifies each agent responds with `<end>pong</end>`
+
+### Real integration (new)
+- `tests/real-agents.mjs`
+  - Creates a temp repo with a 2‑story JSON PRD and minimal AGENTS instructions
+  - Runs `ralph build 2 --agent=<codex|claude|droid>`
+  - Verifies:
+    - PRD stories are all marked `done`
+    - At least one git commit was created
+    - Progress log exists
+  - Cleans up the temp repo and logs after each agent run (pass or fail)
+
+## Gaps identified
+- **Interactive installs**: `ralph install` and `ralph install --skills` require prompts and are not exercised in automated tests.
+- **Skill installation paths**: Local vs global skill locations are not validated in tests.
+- **Failure logging**: `.ralph/errors.log` contents are not asserted.
+- **Activity logging**: Activity log presence is not asserted (only implied via run completion).
+- **Guardrails**: No test verifies that guardrails are created/updated.
+
+## Recommendations
+1. Keep default tests deterministic (`npm test`) and provide a separate real‑agent test (`npm run test:real`).
+2. Add a non‑interactive flag for skill install if you want it testable in CI.
+3. Add assertions for `.ralph/activity.log` and `.ralph/guardrails.md` creation in `tests/real-agents.mjs`.
+4. Consider adding coverage for PRD selection when multiple JSON files exist.
+
+## How to run
+- **Deterministic:** `npm test`
+- **Fast real agent check:** `npm run test:ping`
+- **Real agents:** `npm run test:real` (requires codex/claude/droid installed and authenticated)

package/tests/cli-smoke.mjs

@@ -1,47 +1,47 @@
-import { spawnSync } from "node:child_process";
-import { mkdtempSync, existsSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-
-function run(cmd, args, options = {}) {
-  const result = spawnSync(cmd, args, { stdio: "inherit", ...options });
-  if (result.status !== 0) {
-    console.error(`Command failed: ${cmd} ${args.join(" ")}`);
-    process.exit(result.status ?? 1);
-  }
-}
-
-const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
-const cliPath = path.join(repoRoot, "bin", "ralph");
-
-run(process.execPath, [cliPath, "--help"]);
-
-const projectRoot = mkdtempSync(path.join(tmpdir(), "ralph-cli-"));
-try {
-  const outPath = path.join(projectRoot, "prd.json");
-  run(process.execPath, [cliPath, "prd", "Smoke test PRD", "--out", outPath], {
-    cwd: projectRoot,
-    env: { ...process.env, RALPH_DRY_RUN: "1" },
-  });
-
-  if (!existsSync(outPath)) {
-    console.error("PRD smoke test failed: output not created.");
-    process.exit(1);
-  }
-
-  run(process.execPath, [cliPath, "overview", "--prd", outPath], {
-    cwd: projectRoot,
-    env: { ...process.env },
-  });
-
-  const overviewPath = outPath.replace(/\.json$/i, ".overview.md");
-  if (!existsSync(overviewPath)) {
-    console.error("Overview smoke test failed: output not created.");
-    process.exit(1);
-  }
-} finally {
-  rmSync(projectRoot, { recursive: true, force: true });
-}
-
-console.log("CLI smoke test passed.");
+import { spawnSync } from "node:child_process";
+import { mkdtempSync, existsSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+
+function run(cmd, args, options = {}) {
+  const result = spawnSync(cmd, args, { stdio: "inherit", ...options });
+  if (result.status !== 0) {
+    console.error(`Command failed: ${cmd} ${args.join(" ")}`);
+    process.exit(result.status ?? 1);
+  }
+}
+
+const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
+const cliPath = path.join(repoRoot, "bin", "ralph");
+
+run(process.execPath, [cliPath, "--help"]);
+
+const projectRoot = mkdtempSync(path.join(tmpdir(), "ralph-cli-"));
+try {
+  const outPath = path.join(projectRoot, "prd.json");
+  run(process.execPath, [cliPath, "prd", "Smoke test PRD", "--out", outPath], {
+    cwd: projectRoot,
+    env: { ...process.env, RALPH_DRY_RUN: "1" },
+  });
+
+  if (!existsSync(outPath)) {
+    console.error("PRD smoke test failed: output not created.");
+    process.exit(1);
+  }
+
+  run(process.execPath, [cliPath, "overview", "--prd", outPath], {
+    cwd: projectRoot,
+    env: { ...process.env },
+  });
+
+  const overviewPath = outPath.replace(/\.json$/i, ".overview.md");
+  if (!existsSync(overviewPath)) {
+    console.error("Overview smoke test failed: output not created.");
+    process.exit(1);
+  }
+} finally {
+  rmSync(projectRoot, { recursive: true, force: true });
+}
+
+console.log("CLI smoke test passed.");

package/tests/real-agents.mjs

@@ -1,127 +1,127 @@
-import { mkdtempSync, mkdirSync, writeFileSync, readFileSync, existsSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import path from "node:path";
-import { spawnSync } from "node:child_process";
-import { fileURLToPath } from "node:url";
-
-const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
-const cliPath = path.join(repoRoot, "bin", "ralph");
-
-function run(cmd, args, options = {}) {
-  const result = spawnSync(cmd, args, { stdio: "inherit", ...options });
-  if (result.status !== 0) {
-    throw new Error(`Command failed: ${cmd} ${args.join(" ")}`);
-  }
-}
-
-function setupTempProject() {
-  const base = mkdtempSync(path.join(tmpdir(), "ralph-real-"));
-  mkdirSync(path.join(base, ".agents", "tasks"), { recursive: true });
-  mkdirSync(path.join(base, ".ralph"), { recursive: true });
-
-  const prd = {
-    version: 1,
-    project: "Real Agent Smoke Test",
-    qualityGates: [],
-    stories: [
-      {
-        id: "US-001",
-        title: "Create baseline file",
-        status: "open",
-        dependsOn: [],
-        description:
-          "As a user, I want a baseline file so the repo has an artifact.",
-        acceptanceCriteria: [
-          "File \"docs/US-001.txt\" exists with the exact text \"US-001 complete\"",
-          "Example: open docs/US-001.txt -> \"US-001 complete\"",
-          "Negative case: missing file -> failure",
-        ],
-      },
-      {
-        id: "US-002",
-        title: "Add second artifact",
-        status: "open",
-        dependsOn: ["US-001"],
-        description:
-          "As a user, I want a second artifact to verify multi-story iteration.",
-        acceptanceCriteria: [
-          "File \"docs/US-002.txt\" exists with the exact text \"US-002 complete\"",
-          "Example: open docs/US-002.txt -> \"US-002 complete\"",
-          "Negative case: missing file -> failure",
-        ],
-      },
-    ],
-  };
-
-  writeFileSync(
-    path.join(base, ".agents", "tasks", "prd.json"),
-    `${JSON.stringify(prd, null, 2)}\n`,
-  );
-
-  const agents = `# AGENTS\n\n## Validation\n- For this repo, verify changes with shell checks only.\n- Use commands like: test -f <file>, grep -q \"text\" <file>\n- Do NOT run package manager tests.\n`;
-
-  writeFileSync(path.join(base, "AGENTS.md"), agents);
-
-  run("git", ["init"], { cwd: base });
-  run("git", ["config", "user.email", "ralph@example.com"], { cwd: base });
-  run("git", ["config", "user.name", "ralph"], { cwd: base });
-
-  return base;
-}
-
-function assertAllStoriesComplete(prdPath) {
-  const prd = JSON.parse(readFileSync(prdPath, "utf-8"));
-  const stories = Array.isArray(prd.stories) ? prd.stories : [];
-  const remaining = stories.filter(
-    (story) => String(story.status || "open").toLowerCase() !== "done",
-  );
-  if (remaining.length > 0) {
-    throw new Error(
-      `Some stories remain incomplete: ${remaining.map((s) => s.id).join(", ")}`,
-    );
-  }
-}
-
-function assertCommitted(cwd) {
-  const result = spawnSync("git", ["rev-list", "--count", "HEAD"], { cwd, encoding: "utf-8" });
-  if (result.status !== 0) {
-    throw new Error("Failed to read git history.");
-  }
-  const count = Number(result.stdout.trim() || "0");
-  if (count < 1) {
-    throw new Error("Expected at least one commit, found none.");
-  }
-}
-
-function runForAgent(agent) {
-  console.log(`\n=== Real agent test: ${agent} ===`);
-  const projectRoot = setupTempProject();
-  const env = { ...process.env };
-
-  try {
-    run(process.execPath, [cliPath, "build", "2", `--agent=${agent}`], {
-      cwd: projectRoot,
-      env,
-    });
-
-    const prdPath = path.join(projectRoot, ".agents", "tasks", "prd.json");
-    assertAllStoriesComplete(prdPath);
-    assertCommitted(projectRoot);
-
-    const progressPath = path.join(projectRoot, ".ralph", "progress.md");
-    if (!existsSync(progressPath)) {
-      throw new Error("Progress log not created.");
-    }
-
-    console.log(`Agent ${agent} passed.`);
-  } finally {
-    rmSync(projectRoot, { recursive: true, force: true });
-  }
-}
-
-const agents = ["codex", "claude", "droid"];
-for (const agent of agents) {
-  runForAgent(agent);
-}
-
-console.log("Real agent integration tests passed.");
+import { mkdtempSync, mkdirSync, writeFileSync, readFileSync, existsSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import path from "node:path";
+import { spawnSync } from "node:child_process";
+import { fileURLToPath } from "node:url";
+
+const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
+const cliPath = path.join(repoRoot, "bin", "ralph");
+
+function run(cmd, args, options = {}) {
+  const result = spawnSync(cmd, args, { stdio: "inherit", ...options });
+  if (result.status !== 0) {
+    throw new Error(`Command failed: ${cmd} ${args.join(" ")}`);
+  }
+}
+
+function setupTempProject() {
+  const base = mkdtempSync(path.join(tmpdir(), "ralph-real-"));
+  mkdirSync(path.join(base, ".agents", "tasks"), { recursive: true });
+  mkdirSync(path.join(base, ".ralph"), { recursive: true });
+
+  const prd = {
+    version: 1,
+    project: "Real Agent Smoke Test",
+    qualityGates: [],
+    stories: [
+      {
+        id: "US-001",
+        title: "Create baseline file",
+        status: "open",
+        dependsOn: [],
+        description:
+          "As a user, I want a baseline file so the repo has an artifact.",
+        acceptanceCriteria: [
+          "File \"docs/US-001.txt\" exists with the exact text \"US-001 complete\"",
+          "Example: open docs/US-001.txt -> \"US-001 complete\"",
+          "Negative case: missing file -> failure",
+        ],
+      },
+      {
+        id: "US-002",
+        title: "Add second artifact",
+        status: "open",
+        dependsOn: ["US-001"],
+        description:
+          "As a user, I want a second artifact to verify multi-story iteration.",
+        acceptanceCriteria: [
+          "File \"docs/US-002.txt\" exists with the exact text \"US-002 complete\"",
+          "Example: open docs/US-002.txt -> \"US-002 complete\"",
+          "Negative case: missing file -> failure",
+        ],
+      },
+    ],
+  };
+
+  writeFileSync(
+    path.join(base, ".agents", "tasks", "prd.json"),
+    `${JSON.stringify(prd, null, 2)}\n`,
+  );
+
+  const agents = `# AGENTS\n\n## Validation\n- For this repo, verify changes with shell checks only.\n- Use commands like: test -f <file>, grep -q \"text\" <file>\n- Do NOT run package manager tests.\n`;
+
+  writeFileSync(path.join(base, "AGENTS.md"), agents);
+
+  run("git", ["init"], { cwd: base });
+  run("git", ["config", "user.email", "ralph@example.com"], { cwd: base });
+  run("git", ["config", "user.name", "ralph"], { cwd: base });
+
+  return base;
+}
+
+function assertAllStoriesComplete(prdPath) {
+  const prd = JSON.parse(readFileSync(prdPath, "utf-8"));
+  const stories = Array.isArray(prd.stories) ? prd.stories : [];
+  const remaining = stories.filter(
+    (story) => String(story.status || "open").toLowerCase() !== "done",
+  );
+  if (remaining.length > 0) {
+    throw new Error(
+      `Some stories remain incomplete: ${remaining.map((s) => s.id).join(", ")}`,
+    );
+  }
+}
+
+function assertCommitted(cwd) {
+  const result = spawnSync("git", ["rev-list", "--count", "HEAD"], { cwd, encoding: "utf-8" });
+  if (result.status !== 0) {
+    throw new Error("Failed to read git history.");
+  }
+  const count = Number(result.stdout.trim() || "0");
+  if (count < 1) {
+    throw new Error("Expected at least one commit, found none.");
+  }
+}
+
+function runForAgent(agent) {
+  console.log(`\n=== Real agent test: ${agent} ===`);
+  const projectRoot = setupTempProject();
+  const env = { ...process.env };
+
+  try {
+    run(process.execPath, [cliPath, "build", "2", `--agent=${agent}`], {
+      cwd: projectRoot,
+      env,
+    });
+
+    const prdPath = path.join(projectRoot, ".agents", "tasks", "prd.json");
+    assertAllStoriesComplete(prdPath);
+    assertCommitted(projectRoot);
+
+    const progressPath = path.join(projectRoot, ".ralph", "progress.md");
+    if (!existsSync(progressPath)) {
+      throw new Error("Progress log not created.");
+    }
+
+    console.log(`Agent ${agent} passed.`);
+  } finally {
+    rmSync(projectRoot, { recursive: true, force: true });
+  }
+}
+
+const agents = ["codex", "claude", "droid"];
+for (const agent of agents) {
+  runForAgent(agent);
+}
+
+console.log("Real agent integration tests passed.");