@canboat/canboatjs 3.0.0 → 3.0.2

package/.github/workflows/test.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x, 18.x, 20.x]
+        node-version: [18.x, 20.x, 22.x]
 
     steps:
     - uses: actions/checkout@v3

package/lib/n2kDevice.js

@@ -161,7 +161,9 @@ class N2kDevice extends EventEmitter {
 function handleISORequest(device, n2kMsg) {
   debug('handleISORequest %j', n2kMsg)
 
-  switch (n2kMsg.fields.PGN) {
+  const PGN = n2kMsg.fields.PGN || n2kMsg.fields.pgn
+  
+  switch (PGN) {
   case 126996:  // Product Information request
     sendProductInformation(device)
     break;
@@ -177,8 +179,8 @@ function handleISORequest(device, n2kMsg) {
     break;
   default:
     if ( !device.options.disableNAKs ) {
-      debug(`Got unsupported ISO request for PGN ${n2kMsg.fields.PGN}. Sending NAK.`)
-      sendNAKAcknowledgement(device, n2kMsg.src, n2kMsg.fields.PGN)
+      debug(`Got unsupported ISO request for PGN ${PGN}. Sending NAK.`)
+      sendNAKAcknowledgement(device, n2kMsg.src, PGN)
     }
   }
 }
@@ -197,13 +199,16 @@ function handleGroupFunction(device, n2kMsg) {
   function handleRequestGroupFunction(device, n2kMsg) {
     if ( !device.options.disableNAKs ) {
       // We really don't support group function requests for any PGNs yet -> always respond with pgnErrorCode 1 = "PGN not supported"
-      debug("Sending 'PGN Not Supported' Group Function response for requested PGN", n2kMsg.fields.PGN)
+
+      const PGN = n2kMsg.fields.PGN || n2kMsg.fields.pgn      
+      
+      debug("Sending 'PGN Not Supported' Group Function response for requested PGN", PGN)
       
       const acknowledgement = {
         pgn: 126208,
         dst: n2kMsg.src,
         "Function Code": 2,
-        "PGN": n2kMsg.fields.PGN,
+        "PGN": PGN,
         "PGN error code": 4,
         "Transmission interval/Priority error code": 0,
       "# of Parameters": 0
@@ -215,13 +220,16 @@ function handleGroupFunction(device, n2kMsg) {
   function handleCommandGroupFunction(device, n2kMsg) {
     if ( !device.options.disableNAKs ) {
       // We really don't support group function commands for any PGNs yet -> always respond with pgnErrorCode 1 = "PGN not supported"
-      debug("Sending 'PGN Not Supported' Group Function response for commanded PGN", n2kMsg.fields.PGN)
+
+      const PGN = n2kMsg.fields.PGN || n2kMsg.fields.pgn
+      
+      debug("Sending 'PGN Not Supported' Group Function response for commanded PGN", PGN)
       
       const acknowledgement = {
         pgn: 126208,
         dst: n2kMsg.src,
         "Function Code": 2,
-        "PGN": n2kMsg.fields.PGN,
+        "PGN": PGN,
         "PGN error code": 4,
       "Transmission interval/Priority error code": 0,
         "# of Parameters": 0

package/lib/ydgw02.js

@@ -77,7 +77,7 @@ function Ydgw02Stream (options, type) {
       options.app.emit(this.outEvent, Buffer.from([0x30, 0x0a]))
     }
 
-    if ( options.createDevice === true || options.createDevice === undefined ) {
+    if ( options.createDevice === true ) {
       this.device = new YdDevice(options)
       this.device.start()
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@canboat/canboatjs",
-  "version": "3.0.0",
+  "version": "3.0.2",
   "description": "Native javascript version of canboat",
   "main": "index.js",
   "scripts": {