@camunda/linting 3.7.2 → 3.8.0

package/lib/utils/properties-panel.js

@@ -22,7 +22,11 @@ const TIMER_PROPERTIES = [
  */
 export function getErrors(reports, element) {
   return reports.reduce((errors, report) => {
-    if (!element || getBusinessObject(element).get('id') !== report.id) {
+    const { category } = report;
+
+    if (!element
+      || getBusinessObject(element).get('id') !== report.id
+      || category !== 'error') {
       return errors;
     }
 
@@ -226,7 +230,7 @@ export function getEntryIds(report) {
   ];
 
   for (const [ type, prefix ] of LIST_PROPERTIES) {
-    if (hasType(data, type)
+    if (isType(data, type)
         && getPropertyName(data)) {
 
       const index = path[ path.length - 2 ];
@@ -235,7 +239,7 @@ export function getEntryIds(report) {
     }
   }
 
-  if (hasType(data, 'zeebe:LoopCharacteristics')) {
+  if (isType(data, 'zeebe:LoopCharacteristics')) {
     return [ `multiInstance-${getPropertyName(data)}` ];
   }
 
@@ -298,10 +302,6 @@ export function getErrorMessage(id, report) {
     return 'Cannot be an expression.';
   }
 
-  if (data.type === ERROR_TYPES.SECRET_EXPRESSION_FORMAT_DEPRECATED) {
-    return 'Secret expression format deprecated.';
-  }
-
   if (id === 'isExecutable') {
     const { parentNode } = data;
 
@@ -384,7 +384,11 @@ export function getErrorMessage(id, report) {
     return 'Type must be defined.';
   }
 
-  if (id === 'messageSubscriptionCorrelationKey') {
+  if (id === 'messageSubscriptionCorrelationKey'
+    && [
+      ERROR_TYPES.EXTENSION_ELEMENT_REQUIRED,
+      ERROR_TYPES.PROPERTY_REQUIRED
+    ].includes(data.type)) {
     return 'Subscription correlation key must be defined.';
   }
 
@@ -498,14 +502,16 @@ function isPropertyError(data, property, type) {
     && (!type || is(data.node, type));
 }
 
-function hasType(data, type) {
-  return data.node && is(data.node, type);
-}
-
 function getPropertyName(data) {
-  const propertyKey = data.type === ERROR_TYPES.PROPERTY_REQUIRED ? 'requiredProperty' : 'property';
+  if (data.type === ERROR_TYPES.PROPERTY_REQUIRED) {
+    return data.requiredProperty;
+  }
 
-  return data[ propertyKey ];
+  return data.property;
+}
+
+function isType(data, type) {
+  return data.node && is(data.node, type);
 }
 
 function isOneOfPropertiesRequiredError(data, requiredProperty, type) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "3.7.2",
+  "version": "3.8.0",
   "description": "Linting for Camunda Platform",
   "main": "index.js",
   "scripts": {
@@ -32,7 +32,7 @@
     "@bpmn-io/diagram-js-ui": "^0.2.2",
     "bpmn-moddle": "^8.0.0",
     "bpmnlint": "^9.2.0",
-    "bpmnlint-plugin-camunda-compat": "^2.7.1",
+    "bpmnlint-plugin-camunda-compat": "^2.8.0",
     "bpmnlint-utils": "^1.0.2",
     "camunda-bpmn-moddle": "^7.0.1",
     "clsx": "^2.0.0",