@camunda/linting 3.6.0 → 3.7.1

package/lib/compiled-config.js

@@ -47,6 +47,7 @@ const rules = {
   "camunda-compat/message-reference": "error",
   "camunda-compat/no-candidate-users": "error",
   "camunda-compat/no-expression": "error",
+  "camunda-compat/no-loop": "error",
   "camunda-compat/no-multiple-none-start-events": "error",
   "camunda-compat/no-propagate-all-parent-variables": "error",
   "camunda-compat/no-signal-event-sub-process": "error",
@@ -148,58 +149,62 @@ import rule_17 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-expre
 
 cache['bpmnlint-plugin-camunda-compat/no-expression'] = rule_17;
 
-import rule_18 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-multiple-none-start-events';
+import rule_18 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-loop';
 
-cache['bpmnlint-plugin-camunda-compat/no-multiple-none-start-events'] = rule_18;
+cache['bpmnlint-plugin-camunda-compat/no-loop'] = rule_18;
 
-import rule_19 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-propagate-all-parent-variables';
+import rule_19 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-multiple-none-start-events';
 
-cache['bpmnlint-plugin-camunda-compat/no-propagate-all-parent-variables'] = rule_19;
+cache['bpmnlint-plugin-camunda-compat/no-multiple-none-start-events'] = rule_19;
 
-import rule_20 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-signal-event-sub-process';
+import rule_20 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-propagate-all-parent-variables';
 
-cache['bpmnlint-plugin-camunda-compat/no-signal-event-sub-process'] = rule_20;
+cache['bpmnlint-plugin-camunda-compat/no-propagate-all-parent-variables'] = rule_20;
 
-import rule_21 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-schedule';
+import rule_21 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-signal-event-sub-process';
 
-cache['bpmnlint-plugin-camunda-compat/no-task-schedule'] = rule_21;
+cache['bpmnlint-plugin-camunda-compat/no-signal-event-sub-process'] = rule_21;
 
-import rule_22 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-template';
+import rule_22 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-schedule';
 
-cache['bpmnlint-plugin-camunda-compat/no-template'] = rule_22;
+cache['bpmnlint-plugin-camunda-compat/no-task-schedule'] = rule_22;
 
-import rule_23 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-properties';
+import rule_23 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-template';
 
-cache['bpmnlint-plugin-camunda-compat/no-zeebe-properties'] = rule_23;
+cache['bpmnlint-plugin-camunda-compat/no-template'] = rule_23;
 
-import rule_24 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/secrets';
+import rule_24 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-properties';
 
-cache['bpmnlint-plugin-camunda-compat/secrets'] = rule_24;
+cache['bpmnlint-plugin-camunda-compat/no-zeebe-properties'] = rule_24;
 
-import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/sequence-flow-condition';
+import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/secrets';
 
-cache['bpmnlint-plugin-camunda-compat/sequence-flow-condition'] = rule_25;
+cache['bpmnlint-plugin-camunda-compat/secrets'] = rule_25;
 
-import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/signal-reference';
+import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/sequence-flow-condition';
 
-cache['bpmnlint-plugin-camunda-compat/signal-reference'] = rule_26;
+cache['bpmnlint-plugin-camunda-compat/sequence-flow-condition'] = rule_26;
 
-import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/start-form';
+import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/signal-reference';
 
-cache['bpmnlint-plugin-camunda-compat/start-form'] = rule_27;
+cache['bpmnlint-plugin-camunda-compat/signal-reference'] = rule_27;
 
-import rule_28 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
+import rule_28 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/start-form';
 
-cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_28;
+cache['bpmnlint-plugin-camunda-compat/start-form'] = rule_28;
 
-import rule_29 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
+import rule_29 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
 
-cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_29;
+cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_29;
 
-import rule_30 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
+import rule_30 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
 
-cache['bpmnlint-plugin-camunda-compat/timer'] = rule_30;
+cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_30;
 
-import rule_31 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
+import rule_31 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
 
-cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_31;
+cache['bpmnlint-plugin-camunda-compat/timer'] = rule_31;
+
+import rule_32 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
+
+cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_32;

package/lib/utils/error-messages.js

@@ -144,8 +144,12 @@ export function getErrorMessage(report, executionPlatform, executionPlatformVers
     return getEventBasedGatewayTargetNotAllowedErrorMessage(report);
   }
 
-  if (type === ERROR_TYPES.SECRET_EXPRESSION_INVALID) {
-    return getSecretExpressionInvalidErrorMessage(report);
+  if (type === ERROR_TYPES.SECRET_EXPRESSION_FORMAT_DEPRECATED) {
+    return getSecretExpressionFormatDeprecatedErrorMessage(report);
+  }
+
+  if (type === ERROR_TYPES.LOOP_NOT_ALLOWED) {
+    return getLoopNotAllowedErrorMessage(report);
   }
 
   return message;
@@ -633,12 +637,12 @@ function getPropertyValueNotAllowedErrorMessage(report, executionPlatform, execu
   return message;
 }
 
-function getSecretExpressionInvalidErrorMessage(report) {
+function getSecretExpressionFormatDeprecatedErrorMessage(report) {
   const { data } = report;
 
   const { property } = data;
 
-  return `Property <${ property }> is not a valid secret`;
+  return `Property <${ property }> uses deprecated secret expression format secrets.SECRET, use {{secrets.SECRET}} instead`;
 }
 
 function getElementPropertyValueDuplicatedErrorMessage(report) {
@@ -660,4 +664,12 @@ function getElementPropertyValueDuplicatedErrorMessage(report) {
   }
 
   return message;
+}
+
+function getLoopNotAllowedErrorMessage(report) {
+  const { data } = report;
+
+  const { elements } = data;
+
+  return `A <Process> is not allowed to contain a straight-through processing loop: ${ elements.map(element => `<${ element }>`).join(', ') }`;
 }

package/lib/utils/properties-panel.js

@@ -298,8 +298,8 @@ export function getErrorMessage(id, report) {
     return 'Cannot be an expression.';
   }
 
-  if (data.type === ERROR_TYPES.SECRET_EXPRESSION_INVALID) {
-    return 'Is not a valid secret.';
+  if (data.type === ERROR_TYPES.SECRET_EXPRESSION_FORMAT_DEPRECATED) {
+    return 'Secret expression format deprecated.';
   }
 
   if (id === 'isExecutable') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "3.6.0",
+  "version": "3.7.1",
   "description": "Linting for Camunda Platform",
   "main": "index.js",
   "scripts": {
@@ -32,7 +32,7 @@
     "@bpmn-io/diagram-js-ui": "^0.2.2",
     "bpmn-moddle": "^8.0.0",
     "bpmnlint": "^9.2.0",
-    "bpmnlint-plugin-camunda-compat": "^2.6.3",
+    "bpmnlint-plugin-camunda-compat": "^2.7.1",
     "bpmnlint-utils": "^1.0.2",
     "clsx": "^2.0.0",
     "min-dash": "^4.0.0",