@camunda/linting 3.5.1 → 3.6.0

package/lib/compiled-config.js

@@ -42,15 +42,18 @@ const rules = {
   "camunda-compat/history-time-to-live": "error",
   "camunda-compat/implementation": "error",
   "camunda-compat/inclusive-gateway": "error",
+  "camunda-compat/link-event": "error",
   "camunda-compat/loop-characteristics": "error",
   "camunda-compat/message-reference": "error",
   "camunda-compat/no-candidate-users": "error",
   "camunda-compat/no-expression": "error",
   "camunda-compat/no-multiple-none-start-events": "error",
+  "camunda-compat/no-propagate-all-parent-variables": "error",
   "camunda-compat/no-signal-event-sub-process": "error",
   "camunda-compat/no-task-schedule": "error",
   "camunda-compat/no-template": "error",
   "camunda-compat/no-zeebe-properties": "error",
+  "camunda-compat/secrets": "error",
   "camunda-compat/sequence-flow-condition": "error",
   "camunda-compat/signal-reference": "error",
   "camunda-compat/start-form": "error",
@@ -125,66 +128,78 @@ import rule_12 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/inclusiv
 
 cache['bpmnlint-plugin-camunda-compat/inclusive-gateway'] = rule_12;
 
-import rule_13 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/loop-characteristics';
+import rule_13 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/link-event';
 
-cache['bpmnlint-plugin-camunda-compat/loop-characteristics'] = rule_13;
+cache['bpmnlint-plugin-camunda-compat/link-event'] = rule_13;
 
-import rule_14 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/message-reference';
+import rule_14 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/loop-characteristics';
 
-cache['bpmnlint-plugin-camunda-compat/message-reference'] = rule_14;
+cache['bpmnlint-plugin-camunda-compat/loop-characteristics'] = rule_14;
 
-import rule_15 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-candidate-users';
+import rule_15 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/message-reference';
 
-cache['bpmnlint-plugin-camunda-compat/no-candidate-users'] = rule_15;
+cache['bpmnlint-plugin-camunda-compat/message-reference'] = rule_15;
 
-import rule_16 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-expression';
+import rule_16 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-candidate-users';
 
-cache['bpmnlint-plugin-camunda-compat/no-expression'] = rule_16;
+cache['bpmnlint-plugin-camunda-compat/no-candidate-users'] = rule_16;
 
-import rule_17 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-multiple-none-start-events';
+import rule_17 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-expression';
 
-cache['bpmnlint-plugin-camunda-compat/no-multiple-none-start-events'] = rule_17;
+cache['bpmnlint-plugin-camunda-compat/no-expression'] = rule_17;
 
-import rule_18 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-signal-event-sub-process';
+import rule_18 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-multiple-none-start-events';
 
-cache['bpmnlint-plugin-camunda-compat/no-signal-event-sub-process'] = rule_18;
+cache['bpmnlint-plugin-camunda-compat/no-multiple-none-start-events'] = rule_18;
 
-import rule_19 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-schedule';
+import rule_19 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-propagate-all-parent-variables';
 
-cache['bpmnlint-plugin-camunda-compat/no-task-schedule'] = rule_19;
+cache['bpmnlint-plugin-camunda-compat/no-propagate-all-parent-variables'] = rule_19;
 
-import rule_20 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-template';
+import rule_20 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-signal-event-sub-process';
 
-cache['bpmnlint-plugin-camunda-compat/no-template'] = rule_20;
+cache['bpmnlint-plugin-camunda-compat/no-signal-event-sub-process'] = rule_20;
 
-import rule_21 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-properties';
+import rule_21 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-schedule';
 
-cache['bpmnlint-plugin-camunda-compat/no-zeebe-properties'] = rule_21;
+cache['bpmnlint-plugin-camunda-compat/no-task-schedule'] = rule_21;
 
-import rule_22 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/sequence-flow-condition';
+import rule_22 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-template';
 
-cache['bpmnlint-plugin-camunda-compat/sequence-flow-condition'] = rule_22;
+cache['bpmnlint-plugin-camunda-compat/no-template'] = rule_22;
 
-import rule_23 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/signal-reference';
+import rule_23 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-properties';
 
-cache['bpmnlint-plugin-camunda-compat/signal-reference'] = rule_23;
+cache['bpmnlint-plugin-camunda-compat/no-zeebe-properties'] = rule_23;
 
-import rule_24 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/start-form';
+import rule_24 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/secrets';
 
-cache['bpmnlint-plugin-camunda-compat/start-form'] = rule_24;
+cache['bpmnlint-plugin-camunda-compat/secrets'] = rule_24;
 
-import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
+import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/sequence-flow-condition';
 
-cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_25;
+cache['bpmnlint-plugin-camunda-compat/sequence-flow-condition'] = rule_25;
 
-import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
+import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/signal-reference';
 
-cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_26;
+cache['bpmnlint-plugin-camunda-compat/signal-reference'] = rule_26;
 
-import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
+import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/start-form';
 
-cache['bpmnlint-plugin-camunda-compat/timer'] = rule_27;
+cache['bpmnlint-plugin-camunda-compat/start-form'] = rule_27;
 
-import rule_28 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
+import rule_28 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
 
-cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_28;
+cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_28;
+
+import rule_29 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
+
+cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_29;
+
+import rule_30 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
+
+cache['bpmnlint-plugin-camunda-compat/timer'] = rule_30;
+
+import rule_31 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
+
+cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_31;

package/lib/utils/error-messages.js

@@ -88,6 +88,10 @@ export function getErrorMessage(report, executionPlatform, executionPlatformVers
     return getElementCollapsedNotAllowedErrorMessage(report);
   }
 
+  if (type === ERROR_TYPES.ELEMENT_PROPERTY_VALUE_DUPLICATED) {
+    return getElementPropertyValueDuplicatedErrorMessage(report);
+  }
+
   if (type === ERROR_TYPES.ELEMENT_TYPE_NOT_ALLOWED) {
     return getElementTypeNotAllowedErrorMessage(report, executionPlatform, executionPlatformVersion);
   }
@@ -116,6 +120,10 @@ export function getErrorMessage(report, executionPlatform, executionPlatformVers
     return getPropertyValueDuplicatedErrorMessage(report);
   }
 
+  if (type == ERROR_TYPES.PROPERTY_VALUE_NOT_ALLOWED) {
+    return getPropertyValueNotAllowedErrorMessage(report, executionPlatform, executionPlatformVersion, modeler);
+  }
+
   if (type === ERROR_TYPES.PROPERTY_VALUE_REQUIRED) {
     return getPropertyValueRequiredErrorMessage(report);
   }
@@ -136,6 +144,10 @@ export function getErrorMessage(report, executionPlatform, executionPlatformVers
     return getEventBasedGatewayTargetNotAllowedErrorMessage(report);
   }
 
+  if (type === ERROR_TYPES.SECRET_EXPRESSION_INVALID) {
+    return getSecretExpressionInvalidErrorMessage(report);
+  }
+
   return message;
 }
 
@@ -490,6 +502,10 @@ function getPropertyRequiredErrorMessage(report, executionPlatform, executionPla
     return `${ getIndefiniteArticle(typeString) } <${ typeString }> must have a defined <History time to live>`;
   }
 
+  if (is(node, 'bpmn:LinkEventDefinition') && requiredProperty === 'name') {
+    return `${ getIndefiniteArticle(typeString) } <${ typeString }> must have a defined <Name>`;
+  }
+
   return message;
 }
 
@@ -593,4 +609,55 @@ function getEventBasedGatewayTargetNotAllowedErrorMessage(report) {
   }
 
   return report.message;
+}
+
+function getPropertyValueNotAllowedErrorMessage(report, executionPlatform, executionPlatformVersion, modeler = 'desktop') {
+  const {
+    data,
+    message
+  } = report;
+
+  const {
+    allowedVersion,
+    node,
+    parentNode,
+    property
+  } = data;
+
+  const typeString = getTypeString(parentNode || node);
+
+  if (is(node, 'zeebe:CalledElement') && property === 'propagateAllParentVariables') {
+    return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with <Propagate all variables> disabled`, executionPlatform, executionPlatformVersion, allowedVersion);
+  }
+
+  return message;
+}
+
+function getSecretExpressionInvalidErrorMessage(report) {
+  const { data } = report;
+
+  const { property } = data;
+
+  return `Property <${ property }> is not a valid secret`;
+}
+
+function getElementPropertyValueDuplicatedErrorMessage(report) {
+  const {
+    data,
+    message
+  } = report;
+
+  const {
+    node,
+    parentNode,
+    duplicatedProperty
+  } = data;
+
+  const typeString = getTypeString(parentNode || node);
+
+  if (is(node, 'bpmn:LinkEventDefinition') && duplicatedProperty === 'name') {
+    return `${ getIndefiniteArticle(typeString) } <${ typeString }> must have a unique <Name>`;
+  }
+
+  return message;
 }

package/lib/utils/properties-panel.js

@@ -229,9 +229,9 @@ export function getEntryIds(report) {
     if (hasType(data, type)
         && getPropertyName(data)) {
 
-      const index = path[path.length - 2];
+      const index = path[ path.length - 2 ];
 
-      return [ `${ id }-${prefix}-${index}-${ getPropertyName(data) }` ];
+      return [ `${ id }-${ prefix }-${ index }-${ getPropertyName(data) }` ];
     }
   }
 
@@ -271,6 +271,15 @@ export function getEntryIds(report) {
     return ids;
   }
 
+  if (isPropertyError(data, 'propagateAllParentVariables', 'zeebe:CalledElement')) {
+    return [ 'propagateAllParentVariables' ];
+  }
+
+  if (isPropertyError(data, 'name', 'bpmn:LinkEventDefinition')
+    || isElementPropertyValueDuplicated(data, 'name', 'bpmn:LinkEventDefinition')) {
+    return [ 'linkName' ];
+  }
+
   return [];
 }
 
@@ -289,6 +298,10 @@ export function getErrorMessage(id, report) {
     return 'Cannot be an expression.';
   }
 
+  if (data.type === ERROR_TYPES.SECRET_EXPRESSION_INVALID) {
+    return 'Is not a valid secret.';
+  }
+
   if (id === 'isExecutable') {
     const { parentNode } = data;
 
@@ -446,6 +459,18 @@ export function getErrorMessage(id, report) {
       return 'Must be an ISO 8601 date.';
     }
   }
+
+  if (id === 'propagateAllParentVariables') {
+    return 'Not supported.';
+  }
+
+  if (id === 'linkName') {
+    if (data.type === ERROR_TYPES.ELEMENT_PROPERTY_VALUE_DUPLICATED) {
+      return 'Must be unique.';
+    } else {
+      return 'Must be defined.';
+    }
+  }
 }
 
 function isExtensionElementNotAllowedError(data, extensionElement, type) {
@@ -508,6 +533,12 @@ function isExpressionValueNotAllowedError(data, propertyName, type) {
     && (!type || is(data.node, type));
 }
 
+function isElementPropertyValueDuplicated(data, propertyName, type) {
+  return data.type === ERROR_TYPES.ELEMENT_PROPERTY_VALUE_DUPLICATED
+    && data.duplicatedProperty === propertyName
+    && (!type || is(data.node, type));
+}
+
 function getBusinessObject(element) {
   return element.businessObject || element;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "3.5.1",
+  "version": "3.6.0",
   "description": "Linting for Camunda Platform",
   "main": "index.js",
   "scripts": {
@@ -32,20 +32,20 @@
     "@bpmn-io/diagram-js-ui": "^0.2.2",
     "bpmn-moddle": "^8.0.0",
     "bpmnlint": "^9.2.0",
-    "bpmnlint-plugin-camunda-compat": "^2.4.0",
+    "bpmnlint-plugin-camunda-compat": "^2.6.3",
     "bpmnlint-utils": "^1.0.2",
     "clsx": "^2.0.0",
     "min-dash": "^4.0.0",
     "min-dom": "^4.1.0",
     "modeler-moddle": "^0.2.0",
     "semver-compare": "^1.0.0",
-    "zeebe-bpmn-moddle": "^0.18.0"
+    "zeebe-bpmn-moddle": "^1.0.0"
   },
   "devDependencies": {
     "bpmn-js": "^13.2.2",
-    "bpmn-js-element-templates": "^1.2.0",
-    "bpmn-js-properties-panel": "^3.0.0",
-    "camunda-bpmn-js-behaviors": "^0.6.0",
+    "bpmn-js-element-templates": "^1.3.0",
+    "bpmn-js-properties-panel": "^5.0.0",
+    "camunda-bpmn-js-behaviors": "^1.0.0",
     "chai": "^4.3.7",
     "cross-env": "^7.0.3",
     "eslint": "^8.45.0",