@camunda/linting 3.47.0 → 3.48.1

package/lib/utils/error-messages.js

@@ -805,6 +805,21 @@ function getPropertyValueNotAllowedErrorMessage(report, executionPlatform, execu
     return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with <Binding: ${ bindingTypeString }>`, executionPlatform, executionPlatformVersion, allowedVersion);
   }
 
+  if (
+    (isAny(node, [
+      'zeebe:Input',
+      'zeebe:Output'
+    ]) && property === 'target') ||
+    (isAny(node, [
+      'zeebe:Script',
+      'zeebe:CalledDecision'
+    ]) && property === 'resultVariable') ||
+    (is(node, 'zeebe:AdHoc') && property === 'outputCollection') ||
+    (is(node, 'zeebe:LoopCharacteristics') && [ 'inputElement', 'outputCollection' ].includes(property))
+  ) {
+    return 'Variable name must start with a letter or an underscore, and may contain only letters, digits, underscores, and dots.';
+  }
+
   return message;
 }
 

package/lib/utils/properties-panel.js

@@ -15,6 +15,8 @@ const TIMER_PROPERTIES = [
   'timeCycle'
 ];
 
+const INVALID_VARIABLE_NAME_ERROR = 'Must be a valid variable name.';
+
 /**
  * Get errors for a given element.
  *
@@ -457,10 +459,6 @@ export function getErrorMessage(id, report) {
     return 'FEEL expression must be defined.';
   }
 
-  if (id === 'resultVariable') {
-    return 'Result variable must be defined.';
-  }
-
   if (id === 'errorCode' && type === ERROR_TYPES.PROPERTY_REQUIRED) {
     return 'Code must be defined.';
   }
@@ -481,10 +479,6 @@ export function getErrorMessage(id, report) {
     return 'Input collection must be defined.';
   }
 
-  if (id === 'multiInstance-outputCollection') {
-    return 'Output collection must be defined.';
-  }
-
   if (id === 'multiInstance-outputElement') {
     return 'Output element must be defined.';
   }
@@ -652,6 +646,52 @@ export function getErrorMessage(id, report) {
     return 'Variable name must be defined.';
   }
 
+  if (/^.+-(?:input|output)-[0-9]+-target$/.test(id) && type === ERROR_TYPES.PROPERTY_VALUE_NOT_ALLOWED) {
+    return INVALID_VARIABLE_NAME_ERROR;
+  }
+
+  if (id === 'resultVariable') {
+    if (type === ERROR_TYPES.PROPERTY_REQUIRED) {
+      return 'Result variable must be defined.';
+    } else if (type === ERROR_TYPES.PROPERTY_VALUE_NOT_ALLOWED) {
+      return INVALID_VARIABLE_NAME_ERROR;
+    }
+  }
+
+  if (id === 'multiInstance-outputCollection') {
+    if (type === ERROR_TYPES.PROPERTY_DEPENDENT_REQUIRED || type === ERROR_TYPES.PROPERTY_REQUIRED) {
+      return 'Output collection must be defined.';
+    } else if (type === ERROR_TYPES.PROPERTY_VALUE_NOT_ALLOWED) {
+      return INVALID_VARIABLE_NAME_ERROR;
+    }
+  }
+
+  if (id === 'multiInstance-inputElement') {
+    if (type === ERROR_TYPES.PROPERTY_REQUIRED) {
+      return 'Input element must be defined.';
+    } else if (type === ERROR_TYPES.PROPERTY_VALUE_NOT_ALLOWED) {
+      return INVALID_VARIABLE_NAME_ERROR;
+    }
+  }
+
+  if (id === 'adHocOutputCollection') {
+    if (type === ERROR_TYPES.PROPERTY_DEPENDENT_REQUIRED || type === ERROR_TYPES.PROPERTY_REQUIRED) {
+      return 'Output collection must be defined.';
+    } else if (type === ERROR_TYPES.PROPERTY_NOT_ALLOWED) {
+      return getNotSupportedMessage('Output collection', allowedVersion);
+    } else if (type === ERROR_TYPES.PROPERTY_VALUE_NOT_ALLOWED) {
+      return INVALID_VARIABLE_NAME_ERROR;
+    }
+  }
+
+  if (id === 'adHocOutputElement') {
+    if (type === ERROR_TYPES.PROPERTY_DEPENDENT_REQUIRED || type === ERROR_TYPES.PROPERTY_REQUIRED) {
+      return 'Output element must be defined.';
+    } else if (type === ERROR_TYPES.PROPERTY_NOT_ALLOWED) {
+      return getNotSupportedMessage('Output element', allowedVersion);
+    }
+  }
+
   if (id === 'bindingType') {
     return getNotSupportedMessage('', allowedVersion);
   }
@@ -664,10 +704,6 @@ export function getErrorMessage(id, report) {
     }
   }
 
-  if (isPropertyDependentRequiredError(data, 'outputCollection', 'zeebe:AdHoc')) {
-    return 'Output collection must be defined.';
-  }
-
   if (isPropertyDependentRequiredError(data, 'outputElement', 'zeebe:AdHoc')) {
     return 'Output element must be defined.';
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "3.47.0",
+  "version": "3.48.1",
   "description": "Linting for Camunda",
   "main": "index.js",
   "scripts": {
@@ -32,7 +32,7 @@
     "@bpmn-io/diagram-js-ui": "^0.2.3",
     "bpmn-moddle": "^10.0.0",
     "bpmnlint": "^11.10.0",
-    "bpmnlint-plugin-camunda-compat": "^2.47.0",
+    "bpmnlint-plugin-camunda-compat": "^2.48.1",
     "bpmnlint-utils": "^1.0.2",
     "camunda-bpmn-moddle": "^7.0.1",
     "clsx": "^2.0.0",