@camunda/linting 3.4.0 → 3.5.0

package/assets/linting.css

@@ -7,14 +7,18 @@
   --cl-color-success: #52b415;
 }
 
+.cl-icon, .cl-icon * {
+  box-sizing: border-box;
+}
+
 .cl-icon {
   --icon-color: white;
   --icon-bg-color: #333;
   background: var(--icon-bg-color);
   color: var(--icon-color);
   border-radius: 100%;
-  height: .75em;
-  width: .75em;
+  height: 20px;
+  width: 20px;
   border: solid 4px var(--icon-bg-color);
   display: flex;
   align-items: center;

package/lib/Linter.js

@@ -17,6 +17,8 @@ import { getEntryIds } from './utils/properties-panel';
 
 import { toSemverMinor } from './utils/version';
 
+import { getDocumentationUrl } from './utils/documentation';
+
 const moddle = new BpmnModdle({
   modeler: modelerModdle,
   zeebe: zeebeModdle
@@ -83,6 +85,9 @@ export class Linter {
             propertiesPanel: {
               entryIds
             },
+            documentation: {
+              url: getDocumentationUrl(rule)
+            },
             rule
           };
         })

package/lib/compiled-config.js

@@ -53,6 +53,7 @@ const rules = {
   "camunda-compat/no-zeebe-properties": "error",
   "camunda-compat/sequence-flow-condition": "error",
   "camunda-compat/signal-reference": "error",
+  "camunda-compat/start-form": "error",
   "camunda-compat/subscription": "error",
   "camunda-compat/task-schedule": "error",
   "camunda-compat/timer": "error",
@@ -168,18 +169,22 @@ import rule_23 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/signal-r
 
 cache['bpmnlint-plugin-camunda-compat/signal-reference'] = rule_23;
 
-import rule_24 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
+import rule_24 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/start-form';
 
-cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_24;
+cache['bpmnlint-plugin-camunda-compat/start-form'] = rule_24;
 
-import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
+import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
 
-cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_25;
+cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_25;
 
-import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
+import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
 
-cache['bpmnlint-plugin-camunda-compat/timer'] = rule_26;
+cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_26;
 
-import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
+import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
 
-cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_27;
+cache['bpmnlint-plugin-camunda-compat/timer'] = rule_27;
+
+import rule_28 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
+
+cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_28;

package/lib/modeler/LintingAnnotations.js

@@ -90,7 +90,7 @@ function getAnnotationPosition(element) {
   }
 
   return {
-    bottom: 13,
+    bottom: 14,
     left: -6
   };
 }

package/lib/utils/documentation.js

@@ -0,0 +1,33 @@
+const baseUrl = 'https://docs.camunda.io/docs/next/components/modeler/reference/modeling-guidance/rules';
+
+export function getDocumentationUrl(rule) {
+  if (rule === 'camunda-compat/called-element') {
+    return getUrl('called-element');
+  }
+
+  if (rule === 'camunda-compat/element-type') {
+    return getUrl('element-type');
+  }
+
+  if (rule === 'camunda-compat/error-reference') {
+    return getUrl('error-reference');
+  }
+
+  if (rule === 'camunda-compat/escalation-reference') {
+    return getUrl('escalation-reference');
+  }
+
+  if (rule === 'camunda-compat/feel') {
+    return getUrl('feel');
+  }
+
+  if (rule === 'camunda-compat/message-reference') {
+    return getUrl('message-reference');
+  }
+
+  return null;
+}
+
+function getUrl(rule) {
+  return `${ baseUrl }/${ rule }`;
+}

package/lib/utils/error-messages.js

@@ -265,6 +265,10 @@ function getExtensionElementNotAllowedErrorMessage(report, executionPlatform, ex
     return getSupportedMessage('A <User Task> with <Due date> or <Follow up date>', executionPlatform, executionPlatformVersion, allowedVersion);
   }
 
+  if (is(node, 'bpmn:StartEvent') && is(extensionElement, 'zeebe:FormDefinition')) {
+    return getSupportedMessage('A <Start Event> with <User Task Form>', executionPlatform, executionPlatformVersion, allowedVersion);
+  }
+
   return message;
 }
 

package/lib/utils/properties-panel.js

@@ -181,6 +181,11 @@ export function getEntryIds(report) {
     });
   }
 
+  if (isExtensionElementNotAllowedError(data, 'zeebe:FormDefinition', 'bpmn:StartEvent')) {
+    return [ 'formType' ];
+  }
+
+
   if (isPropertyError(data, 'conditionExpression', 'bpmn:SequenceFlow')) {
     return [ 'conditionExpression' ];
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "3.4.0",
+  "version": "3.5.0",
   "description": "Linting for Camunda Platform",
   "main": "index.js",
   "scripts": {
@@ -32,7 +32,7 @@
     "@bpmn-io/diagram-js-ui": "^0.2.2",
     "bpmn-moddle": "^8.0.0",
     "bpmnlint": "^9.2.0",
-    "bpmnlint-plugin-camunda-compat": "^2.3.0",
+    "bpmnlint-plugin-camunda-compat": "^2.4.0",
     "bpmnlint-utils": "^1.0.2",
     "clsx": "^2.0.0",
     "min-dash": "^4.0.0",