@camunda/linting 3.38.0 → 3.40.0

package/lib/Resolver.js

@@ -1,31 +1,31 @@
-export default class NestedResolver {
-  constructor(resolvers) {
-    this.resolvers = resolvers.slice().reverse();
-  }
-
-  resolveRule(pkg, ruleName) {
-    for (const resolver of this.resolvers) {
-      try {
-        return resolver.resolveRule(pkg, ruleName);
-      } catch (err) {
-
-        // ignore
-      }
-    }
-
-    throw new Error(`unknown rule <${ pkg }/${ ruleName }>`);
-  }
-
-  resolveConfig(pkg, configName) {
-    for (const resolver of this.resolvers) {
-      try {
-        return resolver.resolveConfig(pkg, configName);
-      } catch (err) {
-
-        // ignore
-      }
-    }
-
-    throw new Error(`unknown config <${ pkg }/${ configName }>`);
-  }
-}
+export default class NestedResolver {
+  constructor(resolvers) {
+    this.resolvers = resolvers.slice().reverse();
+  }
+
+  resolveRule(pkg, ruleName) {
+    for (const resolver of this.resolvers) {
+      try {
+        return resolver.resolveRule(pkg, ruleName);
+      } catch (err) {
+
+        // ignore
+      }
+    }
+
+    throw new Error(`unknown rule <${ pkg }/${ ruleName }>`);
+  }
+
+  resolveConfig(pkg, configName) {
+    for (const resolver of this.resolvers) {
+      try {
+        return resolver.resolveConfig(pkg, configName);
+      } catch (err) {
+
+        // ignore
+      }
+    }
+
+    throw new Error(`unknown config <${ pkg }/${ configName }>`);
+  }
+}

package/lib/compiled-config.js

@@ -48,6 +48,7 @@ const rules = {
   "camunda-compat/inclusive-gateway": "error",
   "camunda-compat/link-event": "error",
   "camunda-compat/loop-characteristics": "error",
+  "camunda-compat/io-mapping": "error",
   "camunda-compat/message-reference": "error",
   "camunda-compat/no-binding-type": "error",
   "camunda-compat/no-candidate-users": "error",
@@ -78,6 +79,7 @@ const rules = {
   "camunda-compat/user-task-form": "error",
   "camunda-compat/version-tag": "error",
   "camunda-compat/wait-for-completion": "error",
+  "start-event-required": "error",
   "ad-hoc-sub-process": "error",
   "event-sub-process-typed-start-event": "error",
   "link-event": "error",
@@ -175,146 +177,154 @@ import rule_18 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/loop-cha
 
 cache['bpmnlint-plugin-camunda-compat/loop-characteristics'] = rule_18;
 
-import rule_19 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/message-reference';
+import rule_19 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/io-mapping';
 
-cache['bpmnlint-plugin-camunda-compat/message-reference'] = rule_19;
+cache['bpmnlint-plugin-camunda-compat/io-mapping'] = rule_19;
 
-import rule_20 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-binding-type';
+import rule_20 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/message-reference';
 
-cache['bpmnlint-plugin-camunda-compat/no-binding-type'] = rule_20;
+cache['bpmnlint-plugin-camunda-compat/message-reference'] = rule_20;
 
-import rule_21 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-candidate-users';
+import rule_21 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-binding-type';
 
-cache['bpmnlint-plugin-camunda-compat/no-candidate-users'] = rule_21;
+cache['bpmnlint-plugin-camunda-compat/no-binding-type'] = rule_21;
 
-import rule_22 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-execution-listeners';
+import rule_22 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-candidate-users';
 
-cache['bpmnlint-plugin-camunda-compat/no-execution-listeners'] = rule_22;
+cache['bpmnlint-plugin-camunda-compat/no-candidate-users'] = rule_22;
 
-import rule_23 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-expression';
+import rule_23 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-execution-listeners';
 
-cache['bpmnlint-plugin-camunda-compat/no-expression'] = rule_23;
+cache['bpmnlint-plugin-camunda-compat/no-execution-listeners'] = rule_23;
 
-import rule_24 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-loop';
+import rule_24 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-expression';
 
-cache['bpmnlint-plugin-camunda-compat/no-loop'] = rule_24;
+cache['bpmnlint-plugin-camunda-compat/no-expression'] = rule_24;
 
-import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-multiple-none-start-events';
+import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-loop';
 
-cache['bpmnlint-plugin-camunda-compat/no-multiple-none-start-events'] = rule_25;
+cache['bpmnlint-plugin-camunda-compat/no-loop'] = rule_25;
 
-import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-priority-definition';
+import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-multiple-none-start-events';
 
-cache['bpmnlint-plugin-camunda-compat/no-priority-definition'] = rule_26;
+cache['bpmnlint-plugin-camunda-compat/no-multiple-none-start-events'] = rule_26;
 
-import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-propagate-all-parent-variables';
+import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-priority-definition';
 
-cache['bpmnlint-plugin-camunda-compat/no-propagate-all-parent-variables'] = rule_27;
+cache['bpmnlint-plugin-camunda-compat/no-priority-definition'] = rule_27;
 
-import rule_28 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-signal-event-sub-process';
+import rule_28 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-propagate-all-parent-variables';
 
-cache['bpmnlint-plugin-camunda-compat/no-signal-event-sub-process'] = rule_28;
+cache['bpmnlint-plugin-camunda-compat/no-propagate-all-parent-variables'] = rule_28;
 
-import rule_29 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-schedule';
+import rule_29 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-signal-event-sub-process';
 
-cache['bpmnlint-plugin-camunda-compat/no-task-schedule'] = rule_29;
+cache['bpmnlint-plugin-camunda-compat/no-signal-event-sub-process'] = rule_29;
 
-import rule_30 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-listeners';
+import rule_30 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-schedule';
 
-cache['bpmnlint-plugin-camunda-compat/no-task-listeners'] = rule_30;
+cache['bpmnlint-plugin-camunda-compat/no-task-schedule'] = rule_30;
 
-import rule_31 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-template';
+import rule_31 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-listeners';
 
-cache['bpmnlint-plugin-camunda-compat/no-template'] = rule_31;
+cache['bpmnlint-plugin-camunda-compat/no-task-listeners'] = rule_31;
 
-import rule_32 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-version-tag';
+import rule_32 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-template';
 
-cache['bpmnlint-plugin-camunda-compat/no-version-tag'] = rule_32;
+cache['bpmnlint-plugin-camunda-compat/no-template'] = rule_32;
 
-import rule_33 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-properties';
+import rule_33 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-version-tag';
 
-cache['bpmnlint-plugin-camunda-compat/no-zeebe-properties'] = rule_33;
+cache['bpmnlint-plugin-camunda-compat/no-version-tag'] = rule_33;
 
-import rule_34 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-user-task';
+import rule_34 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-properties';
 
-cache['bpmnlint-plugin-camunda-compat/no-zeebe-user-task'] = rule_34;
+cache['bpmnlint-plugin-camunda-compat/no-zeebe-properties'] = rule_34;
 
-import rule_35 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/priority-definition';
+import rule_35 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-user-task';
 
-cache['bpmnlint-plugin-camunda-compat/priority-definition'] = rule_35;
+cache['bpmnlint-plugin-camunda-compat/no-zeebe-user-task'] = rule_35;
 
-import rule_36 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/zeebe-user-task';
+import rule_36 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/priority-definition';
 
-cache['bpmnlint-plugin-camunda-compat/zeebe-user-task'] = rule_36;
+cache['bpmnlint-plugin-camunda-compat/priority-definition'] = rule_36;
 
-import rule_37 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/secrets';
+import rule_37 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/zeebe-user-task';
 
-cache['bpmnlint-plugin-camunda-compat/secrets'] = rule_37;
+cache['bpmnlint-plugin-camunda-compat/zeebe-user-task'] = rule_37;
 
-import rule_38 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/sequence-flow-condition';
+import rule_38 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/secrets';
 
-cache['bpmnlint-plugin-camunda-compat/sequence-flow-condition'] = rule_38;
+cache['bpmnlint-plugin-camunda-compat/secrets'] = rule_38;
 
-import rule_39 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/signal-reference';
+import rule_39 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/sequence-flow-condition';
 
-cache['bpmnlint-plugin-camunda-compat/signal-reference'] = rule_39;
+cache['bpmnlint-plugin-camunda-compat/sequence-flow-condition'] = rule_39;
 
-import rule_40 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/start-event-form';
+import rule_40 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/signal-reference';
 
-cache['bpmnlint-plugin-camunda-compat/start-event-form'] = rule_40;
+cache['bpmnlint-plugin-camunda-compat/signal-reference'] = rule_40;
 
-import rule_41 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
+import rule_41 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/start-event-form';
 
-cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_41;
+cache['bpmnlint-plugin-camunda-compat/start-event-form'] = rule_41;
 
-import rule_42 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-listener';
+import rule_42 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
 
-cache['bpmnlint-plugin-camunda-compat/task-listener'] = rule_42;
+cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_42;
 
-import rule_43 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
+import rule_43 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-listener';
 
-cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_43;
+cache['bpmnlint-plugin-camunda-compat/task-listener'] = rule_43;
 
-import rule_44 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
+import rule_44 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
 
-cache['bpmnlint-plugin-camunda-compat/timer'] = rule_44;
+cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_44;
 
-import rule_45 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-definition';
+import rule_45 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
 
-cache['bpmnlint-plugin-camunda-compat/user-task-definition'] = rule_45;
+cache['bpmnlint-plugin-camunda-compat/timer'] = rule_45;
 
-import rule_46 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
+import rule_46 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-definition';
 
-cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_46;
+cache['bpmnlint-plugin-camunda-compat/user-task-definition'] = rule_46;
 
-import rule_47 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/version-tag';
+import rule_47 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
 
-cache['bpmnlint-plugin-camunda-compat/version-tag'] = rule_47;
+cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_47;
 
-import rule_48 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/wait-for-completion';
+import rule_48 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/version-tag';
 
-cache['bpmnlint-plugin-camunda-compat/wait-for-completion'] = rule_48;
+cache['bpmnlint-plugin-camunda-compat/version-tag'] = rule_48;
 
-import rule_49 from 'bpmnlint/rules/ad-hoc-sub-process';
+import rule_49 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/wait-for-completion';
 
-cache['bpmnlint/ad-hoc-sub-process'] = rule_49;
+cache['bpmnlint-plugin-camunda-compat/wait-for-completion'] = rule_49;
 
-import rule_50 from 'bpmnlint/rules/event-sub-process-typed-start-event';
+import rule_50 from 'bpmnlint/rules/start-event-required';
 
-cache['bpmnlint/event-sub-process-typed-start-event'] = rule_50;
+cache['bpmnlint/start-event-required'] = rule_50;
 
-import rule_51 from 'bpmnlint/rules/link-event';
+import rule_51 from 'bpmnlint/rules/ad-hoc-sub-process';
 
-cache['bpmnlint/link-event'] = rule_51;
+cache['bpmnlint/ad-hoc-sub-process'] = rule_51;
 
-import rule_52 from 'bpmnlint/rules/no-duplicate-sequence-flows';
+import rule_52 from 'bpmnlint/rules/event-sub-process-typed-start-event';
 
-cache['bpmnlint/no-duplicate-sequence-flows'] = rule_52;
+cache['bpmnlint/event-sub-process-typed-start-event'] = rule_52;
 
-import rule_53 from 'bpmnlint/rules/sub-process-blank-start-event';
+import rule_53 from 'bpmnlint/rules/link-event';
 
-cache['bpmnlint/sub-process-blank-start-event'] = rule_53;
+cache['bpmnlint/link-event'] = rule_53;
 
-import rule_54 from 'bpmnlint/rules/single-blank-start-event';
+import rule_54 from 'bpmnlint/rules/no-duplicate-sequence-flows';
 
-cache['bpmnlint/single-blank-start-event'] = rule_54;
+cache['bpmnlint/no-duplicate-sequence-flows'] = rule_54;
+
+import rule_55 from 'bpmnlint/rules/sub-process-blank-start-event';
+
+cache['bpmnlint/sub-process-blank-start-event'] = rule_55;
+
+import rule_56 from 'bpmnlint/rules/single-blank-start-event';
+
+cache['bpmnlint/single-blank-start-event'] = rule_56;

package/lib/modeler/Linting.js

@@ -1,124 +1,124 @@
-import { getBusinessObject, is } from 'bpmn-js/lib/util/ModelUtil';
-
-import { getErrors } from '../utils/properties-panel';
-
-export default class Linting {
-  constructor(canvas, config, elementRegistry, eventBus, lintingAnnotations, selection) {
-    this._canvas = canvas;
-    this._elementRegistry = elementRegistry;
-    this._eventBus = eventBus;
-    this._lintingAnnotations = lintingAnnotations;
-    this._selection = selection;
-
-    this._active = config && config.active || false;
-    this._reports = [];
-
-    eventBus.on('selection.changed', () => this._update());
-
-    eventBus.on('lintingAnnotations.click', ({ report }) => this.showError(report));
-  }
-
-  showError(report) {
-    const {
-      id,
-      propertiesPanel = {}
-    } = report;
-
-    const selectableElement = this._getSelectableElement(id);
-
-    if (selectableElement) {
-      this._canvas.scrollToElement(selectableElement);
-
-      if (selectableElement === this._canvas.getRootElement()) {
-        this._selection.select();
-      } else {
-        this._selection.select(selectableElement);
-      }
-    }
-
-    const { entryIds = [] } = propertiesPanel;
-
-    // TODO(philippfromme): remove timeout once properties panel is fixed
-    setTimeout(() => {
-      this._eventBus.fire('propertiesPanel.showEntry', {
-        id: entryIds[ Math.max(0, entryIds.length - 1) ]
-      });
-    });
-  }
-
-  setErrors(reports) {
-    this._reports = reports;
-
-    this._update();
-  }
-
-  activate() {
-    this._active = true;
-
-    this._update();
-  }
-
-  deactivate() {
-    this._active = false;
-
-    this._update();
-  }
-
-  isActive() {
-    return this._active;
-  }
-
-  _update() {
-
-    // set annotations
-    this._lintingAnnotations.setErrors(this.isActive() ? this._reports : []);
-
-    // set properties panel errors
-    const selectedElement = this._getSelectedElement();
-
-    this._eventBus.fire('propertiesPanel.setErrors', {
-      errors: getErrors(this._reports, selectedElement)
-    });
-  }
-
-  _getSelectableElement(id) {
-    let element = this._elementRegistry.get(id);
-
-    if (!element) {
-      element = this._elementRegistry.filter(element => {
-        return is(element, 'bpmn:Participant') && getBusinessObject(element).get('processRef').get('id') === id;
-      })[ 0 ];
-    }
-
-    return element;
-  }
-
-  _getSelectedElement() {
-    const selection = this._selection.get();
-
-    if (!selection || !selection.length) {
-      return this._canvas.getRootElement();
-    }
-
-    const selectedElement = selection[ 0 ];
-
-    if (isLabel(selectedElement)) {
-      return selectedElement.labelTarget;
-    }
-
-    return selectedElement;
-  }
-}
-
-Linting.$inject = [
-  'canvas',
-  'config.linting',
-  'elementRegistry',
-  'eventBus',
-  'lintingAnnotations',
-  'selection'
-];
-
-function isLabel(element) {
-  return !!element.labelTarget;
-}
+import { getBusinessObject, is } from 'bpmn-js/lib/util/ModelUtil';
+
+import { getErrors } from '../utils/properties-panel';
+
+export default class Linting {
+  constructor(canvas, config, elementRegistry, eventBus, lintingAnnotations, selection) {
+    this._canvas = canvas;
+    this._elementRegistry = elementRegistry;
+    this._eventBus = eventBus;
+    this._lintingAnnotations = lintingAnnotations;
+    this._selection = selection;
+
+    this._active = config && config.active || false;
+    this._reports = [];
+
+    eventBus.on('selection.changed', () => this._update());
+
+    eventBus.on('lintingAnnotations.click', ({ report }) => this.showError(report));
+  }
+
+  showError(report) {
+    const {
+      id,
+      propertiesPanel = {}
+    } = report;
+
+    const selectableElement = this._getSelectableElement(id);
+
+    if (selectableElement) {
+      this._canvas.scrollToElement(selectableElement);
+
+      if (selectableElement === this._canvas.getRootElement()) {
+        this._selection.select();
+      } else {
+        this._selection.select(selectableElement);
+      }
+    }
+
+    const { entryIds = [] } = propertiesPanel;
+
+    // TODO(philippfromme): remove timeout once properties panel is fixed
+    setTimeout(() => {
+      this._eventBus.fire('propertiesPanel.showEntry', {
+        id: entryIds[ Math.max(0, entryIds.length - 1) ]
+      });
+    });
+  }
+
+  setErrors(reports) {
+    this._reports = reports;
+
+    this._update();
+  }
+
+  activate() {
+    this._active = true;
+
+    this._update();
+  }
+
+  deactivate() {
+    this._active = false;
+
+    this._update();
+  }
+
+  isActive() {
+    return this._active;
+  }
+
+  _update() {
+
+    // set annotations
+    this._lintingAnnotations.setErrors(this.isActive() ? this._reports : []);
+
+    // set properties panel errors
+    const selectedElement = this._getSelectedElement();
+
+    this._eventBus.fire('propertiesPanel.setErrors', {
+      errors: getErrors(this._reports, selectedElement)
+    });
+  }
+
+  _getSelectableElement(id) {
+    let element = this._elementRegistry.get(id);
+
+    if (!element) {
+      element = this._elementRegistry.filter(element => {
+        return is(element, 'bpmn:Participant') && getBusinessObject(element).get('processRef').get('id') === id;
+      })[ 0 ];
+    }
+
+    return element;
+  }
+
+  _getSelectedElement() {
+    const selection = this._selection.get();
+
+    if (!selection || !selection.length) {
+      return this._canvas.getRootElement();
+    }
+
+    const selectedElement = selection[ 0 ];
+
+    if (isLabel(selectedElement)) {
+      return selectedElement.labelTarget;
+    }
+
+    return selectedElement;
+  }
+}
+
+Linting.$inject = [
+  'canvas',
+  'config.linting',
+  'elementRegistry',
+  'eventBus',
+  'lintingAnnotations',
+  'selection'
+];
+
+function isLabel(element) {
+  return !!element.labelTarget;
+}