@camunda/linting 3.37.0 → 3.38.0

package/lib/Resolver.js

@@ -1,31 +1,31 @@
-export default class NestedResolver {
-  constructor(resolvers) {
-    this.resolvers = resolvers.slice().reverse();
-  }
-
-  resolveRule(pkg, ruleName) {
-    for (const resolver of this.resolvers) {
-      try {
-        return resolver.resolveRule(pkg, ruleName);
-      } catch (err) {
-
-        // ignore
-      }
-    }
-
-    throw new Error(`unknown rule <${ pkg }/${ ruleName }>`);
-  }
-
-  resolveConfig(pkg, configName) {
-    for (const resolver of this.resolvers) {
-      try {
-        return resolver.resolveConfig(pkg, configName);
-      } catch (err) {
-
-        // ignore
-      }
-    }
-
-    throw new Error(`unknown config <${ pkg }/${ configName }>`);
-  }
-}
+export default class NestedResolver {
+  constructor(resolvers) {
+    this.resolvers = resolvers.slice().reverse();
+  }
+
+  resolveRule(pkg, ruleName) {
+    for (const resolver of this.resolvers) {
+      try {
+        return resolver.resolveRule(pkg, ruleName);
+      } catch (err) {
+
+        // ignore
+      }
+    }
+
+    throw new Error(`unknown rule <${ pkg }/${ ruleName }>`);
+  }
+
+  resolveConfig(pkg, configName) {
+    for (const resolver of this.resolvers) {
+      try {
+        return resolver.resolveConfig(pkg, configName);
+      } catch (err) {
+
+        // ignore
+      }
+    }
+
+    throw new Error(`unknown config <${ pkg }/${ configName }>`);
+  }
+}

package/lib/compiled-config.js

@@ -82,7 +82,8 @@ const rules = {
   "event-sub-process-typed-start-event": "error",
   "link-event": "error",
   "no-duplicate-sequence-flows": "warn",
-  "sub-process-blank-start-event": "error"
+  "sub-process-blank-start-event": "error",
+  "single-blank-start-event": "error"
 };
 
 const config = {
@@ -312,4 +313,8 @@ cache['bpmnlint/no-duplicate-sequence-flows'] = rule_52;
 
 import rule_53 from 'bpmnlint/rules/sub-process-blank-start-event';
 
-cache['bpmnlint/sub-process-blank-start-event'] = rule_53;
+cache['bpmnlint/sub-process-blank-start-event'] = rule_53;
+
+import rule_54 from 'bpmnlint/rules/single-blank-start-event';
+
+cache['bpmnlint/single-blank-start-event'] = rule_54;

package/lib/modeler/Linting.js

@@ -1,124 +1,124 @@
-import { getBusinessObject, is } from 'bpmn-js/lib/util/ModelUtil';
-
-import { getErrors } from '../utils/properties-panel';
-
-export default class Linting {
-  constructor(canvas, config, elementRegistry, eventBus, lintingAnnotations, selection) {
-    this._canvas = canvas;
-    this._elementRegistry = elementRegistry;
-    this._eventBus = eventBus;
-    this._lintingAnnotations = lintingAnnotations;
-    this._selection = selection;
-
-    this._active = config && config.active || false;
-    this._reports = [];
-
-    eventBus.on('selection.changed', () => this._update());
-
-    eventBus.on('lintingAnnotations.click', ({ report }) => this.showError(report));
-  }
-
-  showError(report) {
-    const {
-      id,
-      propertiesPanel = {}
-    } = report;
-
-    const selectableElement = this._getSelectableElement(id);
-
-    if (selectableElement) {
-      this._canvas.scrollToElement(selectableElement);
-
-      if (selectableElement === this._canvas.getRootElement()) {
-        this._selection.select();
-      } else {
-        this._selection.select(selectableElement);
-      }
-    }
-
-    const { entryIds = [] } = propertiesPanel;
-
-    // TODO(philippfromme): remove timeout once properties panel is fixed
-    setTimeout(() => {
-      this._eventBus.fire('propertiesPanel.showEntry', {
-        id: entryIds[ Math.max(0, entryIds.length - 1) ]
-      });
-    });
-  }
-
-  setErrors(reports) {
-    this._reports = reports;
-
-    this._update();
-  }
-
-  activate() {
-    this._active = true;
-
-    this._update();
-  }
-
-  deactivate() {
-    this._active = false;
-
-    this._update();
-  }
-
-  isActive() {
-    return this._active;
-  }
-
-  _update() {
-
-    // set annotations
-    this._lintingAnnotations.setErrors(this.isActive() ? this._reports : []);
-
-    // set properties panel errors
-    const selectedElement = this._getSelectedElement();
-
-    this._eventBus.fire('propertiesPanel.setErrors', {
-      errors: getErrors(this._reports, selectedElement)
-    });
-  }
-
-  _getSelectableElement(id) {
-    let element = this._elementRegistry.get(id);
-
-    if (!element) {
-      element = this._elementRegistry.filter(element => {
-        return is(element, 'bpmn:Participant') && getBusinessObject(element).get('processRef').get('id') === id;
-      })[ 0 ];
-    }
-
-    return element;
-  }
-
-  _getSelectedElement() {
-    const selection = this._selection.get();
-
-    if (!selection || !selection.length) {
-      return this._canvas.getRootElement();
-    }
-
-    const selectedElement = selection[ 0 ];
-
-    if (isLabel(selectedElement)) {
-      return selectedElement.labelTarget;
-    }
-
-    return selectedElement;
-  }
-}
-
-Linting.$inject = [
-  'canvas',
-  'config.linting',
-  'elementRegistry',
-  'eventBus',
-  'lintingAnnotations',
-  'selection'
-];
-
-function isLabel(element) {
-  return !!element.labelTarget;
-}
+import { getBusinessObject, is } from 'bpmn-js/lib/util/ModelUtil';
+
+import { getErrors } from '../utils/properties-panel';
+
+export default class Linting {
+  constructor(canvas, config, elementRegistry, eventBus, lintingAnnotations, selection) {
+    this._canvas = canvas;
+    this._elementRegistry = elementRegistry;
+    this._eventBus = eventBus;
+    this._lintingAnnotations = lintingAnnotations;
+    this._selection = selection;
+
+    this._active = config && config.active || false;
+    this._reports = [];
+
+    eventBus.on('selection.changed', () => this._update());
+
+    eventBus.on('lintingAnnotations.click', ({ report }) => this.showError(report));
+  }
+
+  showError(report) {
+    const {
+      id,
+      propertiesPanel = {}
+    } = report;
+
+    const selectableElement = this._getSelectableElement(id);
+
+    if (selectableElement) {
+      this._canvas.scrollToElement(selectableElement);
+
+      if (selectableElement === this._canvas.getRootElement()) {
+        this._selection.select();
+      } else {
+        this._selection.select(selectableElement);
+      }
+    }
+
+    const { entryIds = [] } = propertiesPanel;
+
+    // TODO(philippfromme): remove timeout once properties panel is fixed
+    setTimeout(() => {
+      this._eventBus.fire('propertiesPanel.showEntry', {
+        id: entryIds[ Math.max(0, entryIds.length - 1) ]
+      });
+    });
+  }
+
+  setErrors(reports) {
+    this._reports = reports;
+
+    this._update();
+  }
+
+  activate() {
+    this._active = true;
+
+    this._update();
+  }
+
+  deactivate() {
+    this._active = false;
+
+    this._update();
+  }
+
+  isActive() {
+    return this._active;
+  }
+
+  _update() {
+
+    // set annotations
+    this._lintingAnnotations.setErrors(this.isActive() ? this._reports : []);
+
+    // set properties panel errors
+    const selectedElement = this._getSelectedElement();
+
+    this._eventBus.fire('propertiesPanel.setErrors', {
+      errors: getErrors(this._reports, selectedElement)
+    });
+  }
+
+  _getSelectableElement(id) {
+    let element = this._elementRegistry.get(id);
+
+    if (!element) {
+      element = this._elementRegistry.filter(element => {
+        return is(element, 'bpmn:Participant') && getBusinessObject(element).get('processRef').get('id') === id;
+      })[ 0 ];
+    }
+
+    return element;
+  }
+
+  _getSelectedElement() {
+    const selection = this._selection.get();
+
+    if (!selection || !selection.length) {
+      return this._canvas.getRootElement();
+    }
+
+    const selectedElement = selection[ 0 ];
+
+    if (isLabel(selectedElement)) {
+      return selectedElement.labelTarget;
+    }
+
+    return selectedElement;
+  }
+}
+
+Linting.$inject = [
+  'canvas',
+  'config.linting',
+  'elementRegistry',
+  'eventBus',
+  'lintingAnnotations',
+  'selection'
+];
+
+function isLabel(element) {
+  return !!element.labelTarget;
+}

package/lib/modeler/LintingAnnotations.js

@@ -1,96 +1,96 @@
-import { groupBy } from 'min-dash';
-
-import { domify } from 'min-dom';
-
-import { renderOverlay } from './OverlayComponent';
-import { is } from 'bpmn-js/lib/util/ModelUtil';
-
-
-export default class LintingAnnotations {
-  constructor(canvas, elementRegistry, eventBus, overlays) {
-    this._canvas = canvas;
-    this._elementRegistry = elementRegistry;
-    this._eventBus = eventBus;
-    this._overlays = overlays;
-
-    this._reportsByElement = {};
-
-    this._overlayIds = {};
-  }
-
-  setErrors(reports) {
-    this._reportsByElement = groupBy(reports.filter(report => report.category !== 'rule-error'), 'id');
-
-    this._update();
-  }
-
-  _update(reportsByElement) {
-    if (!reportsByElement) {
-      reportsByElement = this._reportsByElement;
-    }
-
-    this._overlays.remove({ type: 'linting' });
-
-    Object.entries(reportsByElement).forEach(([ id, reports ]) => {
-      const element = this._elementRegistry.get(id);
-
-      if (!element || element === this._canvas.getRootElement()) {
-        return;
-      }
-
-      const html = domify(`
-        <div class="cl-overlay-root"></div>
-      `);
-
-      renderOverlay(html, {
-        reports,
-        onClick: () => {
-          this._eventBus.fire('lintingAnnotations.click', { report: reports[ 0 ] });
-        }
-      });
-
-      const position = getAnnotationPosition(element);
-
-      const overlayId = this._overlays.add(element, 'linting', {
-        position,
-        html,
-        scale: {
-          min: .7
-        }
-      });
-
-      this._overlayIds[ id ] = overlayId;
-    });
-  }
-}
-
-LintingAnnotations.$inject = [
-  'canvas',
-  'elementRegistry',
-  'eventBus',
-  'overlays'
-];
-
-
-function getAnnotationPosition(element) {
-
-  if (!element.parent) {
-
-    if (is(element, 'bpmn:SubProcess')) {
-      return {
-        top: 50,
-        left: 150
-      };
-    }
-
-    return {
-      top: 20,
-      left: 150
-    };
-  }
-
-  return {
-    bottom: 14,
-    left: -6
-  };
+import { groupBy } from 'min-dash';
+
+import { domify } from 'min-dom';
+
+import { renderOverlay } from './OverlayComponent';
+import { is } from 'bpmn-js/lib/util/ModelUtil';
+
+
+export default class LintingAnnotations {
+  constructor(canvas, elementRegistry, eventBus, overlays) {
+    this._canvas = canvas;
+    this._elementRegistry = elementRegistry;
+    this._eventBus = eventBus;
+    this._overlays = overlays;
+
+    this._reportsByElement = {};
+
+    this._overlayIds = {};
+  }
+
+  setErrors(reports) {
+    this._reportsByElement = groupBy(reports.filter(report => report.category !== 'rule-error'), 'id');
+
+    this._update();
+  }
+
+  _update(reportsByElement) {
+    if (!reportsByElement) {
+      reportsByElement = this._reportsByElement;
+    }
+
+    this._overlays.remove({ type: 'linting' });
+
+    Object.entries(reportsByElement).forEach(([ id, reports ]) => {
+      const element = this._elementRegistry.get(id);
+
+      if (!element || element === this._canvas.getRootElement()) {
+        return;
+      }
+
+      const html = domify(`
+        <div class="cl-overlay-root"></div>
+      `);
+
+      renderOverlay(html, {
+        reports,
+        onClick: () => {
+          this._eventBus.fire('lintingAnnotations.click', { report: reports[ 0 ] });
+        }
+      });
+
+      const position = getAnnotationPosition(element);
+
+      const overlayId = this._overlays.add(element, 'linting', {
+        position,
+        html,
+        scale: {
+          min: .7
+        }
+      });
+
+      this._overlayIds[ id ] = overlayId;
+    });
+  }
+}
+
+LintingAnnotations.$inject = [
+  'canvas',
+  'elementRegistry',
+  'eventBus',
+  'overlays'
+];
+
+
+function getAnnotationPosition(element) {
+
+  if (!element.parent) {
+
+    if (is(element, 'bpmn:SubProcess')) {
+      return {
+        top: 50,
+        left: 150
+      };
+    }
+
+    return {
+      top: 20,
+      left: 150
+    };
+  }
+
+  return {
+    bottom: 14,
+    left: -6
+  };
 }

package/lib/modeler/OverlayComponent.js

@@ -1,61 +1,61 @@
-import {
-  render as renderComponent,
-  html
-} from '@bpmn-io/diagram-js-ui';
-
-import classNames from 'clsx';
-
-const errorSvg = html`
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32">
-  <path d="M16,2C8.3,2,2,8.3,2,16s6.3,14,14,14s14-6.3,14-14S23.7,2,16,2z M21.4,23L16,17.6L10.6,23L9,21.4l5.4-5.4L9,10.6L10.6,9
-    l5.4,5.4L21.4,9l1.6,1.6L17.6,16l5.4,5.4L21.4,23z" fill="currentColor" />
-</svg>
-`;
-
-const warningSvg = html`
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32">
-<path d="M16,2C8.3,2,2,8.3,2,16s6.3,14,14,14s14-6.3,14-14C30,8.3,23.7,2,16,2z M14.9,8h2.2v11h-2.2V8z M16,25
-  c-0.8,0-1.5-0.7-1.5-1.5S15.2,22,16,22c0.8,0,1.5,0.7,1.5,1.5S16.8,25,16,25z" fill="currentColor" />
-</svg>
-`;
-
-const infoSvg = html`
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32">
-  <path d="M16,2A14,14,0,1,0,30,16,14,14,0,0,0,16,2Zm0,6a1.5,1.5,0,1,1-1.5,1.5A1.5,1.5,0,0,1,16,8Zm4,16.125H12v-2.25h2.875v-5.75H13v-2.25h4.125v8H20Z" fill="currentColor" />
-</svg>
-`;
-
-const icons = {
-  error: errorSvg,
-  warn: warningSvg,
-  info: infoSvg
-};
-
-export function OverlayComponent(props) {
-
-  const {
-    onClick = () => {},
-    reports
-  } = props;
-
-  const category =
-    reports.find(({ category }) => category === 'error')
-      ? 'error'
-      : reports.find(({ category }) => category === 'warn')
-        ? 'warn'
-        : 'info';
-
-  return html`
-    <div
-      class=${ classNames('cl-icon',`cl-icon-${category}`) }
-      onClick=${ onClick }
-      title="Click to show issue"
-    >
-      ${ icons[category] }
-    </div>
-  `;
-}
-
-export function renderOverlay(el, props) {
-  return renderComponent(html`<${OverlayComponent} ...${props} />`, el);
+import {
+  render as renderComponent,
+  html
+} from '@bpmn-io/diagram-js-ui';
+
+import classNames from 'clsx';
+
+const errorSvg = html`
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32">
+  <path d="M16,2C8.3,2,2,8.3,2,16s6.3,14,14,14s14-6.3,14-14S23.7,2,16,2z M21.4,23L16,17.6L10.6,23L9,21.4l5.4-5.4L9,10.6L10.6,9
+    l5.4,5.4L21.4,9l1.6,1.6L17.6,16l5.4,5.4L21.4,23z" fill="currentColor" />
+</svg>
+`;
+
+const warningSvg = html`
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32">
+<path d="M16,2C8.3,2,2,8.3,2,16s6.3,14,14,14s14-6.3,14-14C30,8.3,23.7,2,16,2z M14.9,8h2.2v11h-2.2V8z M16,25
+  c-0.8,0-1.5-0.7-1.5-1.5S15.2,22,16,22c0.8,0,1.5,0.7,1.5,1.5S16.8,25,16,25z" fill="currentColor" />
+</svg>
+`;
+
+const infoSvg = html`
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32">
+  <path d="M16,2A14,14,0,1,0,30,16,14,14,0,0,0,16,2Zm0,6a1.5,1.5,0,1,1-1.5,1.5A1.5,1.5,0,0,1,16,8Zm4,16.125H12v-2.25h2.875v-5.75H13v-2.25h4.125v8H20Z" fill="currentColor" />
+</svg>
+`;
+
+const icons = {
+  error: errorSvg,
+  warn: warningSvg,
+  info: infoSvg
+};
+
+export function OverlayComponent(props) {
+
+  const {
+    onClick = () => {},
+    reports
+  } = props;
+
+  const category =
+    reports.find(({ category }) => category === 'error')
+      ? 'error'
+      : reports.find(({ category }) => category === 'warn')
+        ? 'warn'
+        : 'info';
+
+  return html`
+    <div
+      class=${ classNames('cl-icon',`cl-icon-${category}`) }
+      onClick=${ onClick }
+      title="Click to show issue"
+    >
+      ${ icons[category] }
+    </div>
+  `;
+}
+
+export function renderOverlay(el, props) {
+  return renderComponent(html`<${OverlayComponent} ...${props} />`, el);
 }

package/lib/modeler/index.js

@@ -1,11 +1,11 @@
-import Linting from './Linting';
-import LintingAnnotations from './LintingAnnotations';
-
-export default {
-  __init__: [
-    'linting',
-    'lintingAnnotations'
-  ],
-  linting: [ 'type', Linting ],
-  lintingAnnotations: [ 'type', LintingAnnotations ]
+import Linting from './Linting';
+import LintingAnnotations from './LintingAnnotations';
+
+export default {
+  __init__: [
+    'linting',
+    'lintingAnnotations'
+  ],
+  linting: [ 'type', Linting ],
+  lintingAnnotations: [ 'type', LintingAnnotations ]
 };