@camunda/linting 3.34.0 → 3.36.0

package/lib/utils/error-messages.js

@@ -157,6 +157,10 @@ export function getErrorMessage(report, executionPlatform, executionPlatformVers
     return getLoopNotAllowedErrorMessage(report);
   }
 
+  if (type === ERROR_TYPES.ATTACHED_TO_REF_ELEMENT_TYPE_NOT_ALLOWED) {
+    return getAttachedToRefElementTypeNotAllowed(report);
+  }
+
   return message;
 }
 
@@ -798,6 +802,17 @@ function getLoopNotAllowedErrorMessage(report) {
   return `A <Process> is not allowed to contain a straight-through processing loop: ${ elements.map(element => `<${ element }>`).join(', ') }`;
 }
 
+function getAttachedToRefElementTypeNotAllowed(report) {
+  const { data } = report;
+
+  const { node , attachedToRef } = data;
+
+  const nodeTypeString = getTypeString(node);
+  const attachedToTypeString = getTypeString(attachedToRef);
+
+  return `${ getIndefiniteArticle(nodeTypeString) } <${nodeTypeString}> is not allowed on ${ getIndefiniteArticle(attachedToTypeString, false) } <${attachedToTypeString}>`;
+}
+
 function isEmptyString(value) {
   return isString(value) && value.trim() === '';
 }

package/lib/utils/properties-panel.js

@@ -229,6 +229,14 @@ export function getEntryIds(report) {
     return [ 'multiInstance-completionCondition' ];
   }
 
+  if (isPropertyError(data, 'completionCondition', 'bpmn:AdHocSubProcess')) {
+    return [ 'completionCondition' ];
+  }
+
+  if (isPropertyError(data, 'cancelRemainingInstances', 'bpmn:AdHocSubProcess')) {
+    return [ 'cancelRemainingInstances' ];
+  }
+
   if (TIMER_PROPERTIES.some(property =>
     isOneOfPropertiesRequiredError(data, property, 'bpmn:TimerEventDefinition'))
   ) {
@@ -447,6 +455,14 @@ export function getErrorMessage(id, report) {
     return 'Output element must be defined.';
   }
 
+  if (id === 'completionCondition' && type === ERROR_TYPES.PROPERTY_NOT_ALLOWED) {
+    return getNotSupportedMessage('', allowedVersion);
+  }
+
+  if (id === 'cancelRemainingInstances' && type === ERROR_TYPES.PROPERTY_VALUE_NOT_ALLOWED) {
+    return 'Must be checked.';
+  }
+
   if (id === 'targetProcessId') {
     return 'Process ID must be defined.';
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "3.34.0",
+  "version": "3.36.0",
   "description": "Linting for Camunda",
   "main": "index.js",
   "scripts": {
@@ -32,7 +32,7 @@
     "@bpmn-io/diagram-js-ui": "^0.2.3",
     "bpmn-moddle": "^9.0.1",
     "bpmnlint": "^11.4.1",
-    "bpmnlint-plugin-camunda-compat": "^2.33.1",
+    "bpmnlint-plugin-camunda-compat": "^2.34.1",
     "bpmnlint-utils": "^1.0.2",
     "camunda-bpmn-moddle": "^7.0.1",
     "clsx": "^2.0.0",
@@ -45,7 +45,7 @@
   "devDependencies": {
     "bpmn-js": "^18.3.1",
     "bpmn-js-element-templates": "^2.5.3",
-    "bpmn-js-properties-panel": "^5.32.1",
+    "bpmn-js-properties-panel": "^5.34.0",
     "camunda-bpmn-js-behaviors": "^1.9.1",
     "chai": "^4.5.0",
     "cross-env": "^7.0.3",