@camunda/linting 3.24.0 → 3.26.0

package/lib/compiled-config.js

@@ -54,12 +54,15 @@ const rules = {
   "camunda-compat/no-expression": "error",
   "camunda-compat/no-loop": "error",
   "camunda-compat/no-multiple-none-start-events": "error",
+  "camunda-compat/no-priority-definition": "error",
   "camunda-compat/no-propagate-all-parent-variables": "error",
   "camunda-compat/no-signal-event-sub-process": "error",
   "camunda-compat/no-task-schedule": "error",
   "camunda-compat/no-template": "error",
+  "camunda-compat/no-version-tag": "error",
   "camunda-compat/no-zeebe-properties": "error",
   "camunda-compat/no-zeebe-user-task": "error",
+  "camunda-compat/priority-definition": "error",
   "camunda-compat/secrets": "warn",
   "camunda-compat/sequence-flow-condition": "error",
   "camunda-compat/signal-reference": "error",
@@ -185,66 +188,78 @@ import rule_24 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-multi
 
 cache['bpmnlint-plugin-camunda-compat/no-multiple-none-start-events'] = rule_24;
 
-import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-propagate-all-parent-variables';
+import rule_25 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-priority-definition';
 
-cache['bpmnlint-plugin-camunda-compat/no-propagate-all-parent-variables'] = rule_25;
+cache['bpmnlint-plugin-camunda-compat/no-priority-definition'] = rule_25;
 
-import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-signal-event-sub-process';
+import rule_26 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-propagate-all-parent-variables';
 
-cache['bpmnlint-plugin-camunda-compat/no-signal-event-sub-process'] = rule_26;
+cache['bpmnlint-plugin-camunda-compat/no-propagate-all-parent-variables'] = rule_26;
 
-import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-schedule';
+import rule_27 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-signal-event-sub-process';
 
-cache['bpmnlint-plugin-camunda-compat/no-task-schedule'] = rule_27;
+cache['bpmnlint-plugin-camunda-compat/no-signal-event-sub-process'] = rule_27;
 
-import rule_28 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-template';
+import rule_28 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-task-schedule';
 
-cache['bpmnlint-plugin-camunda-compat/no-template'] = rule_28;
+cache['bpmnlint-plugin-camunda-compat/no-task-schedule'] = rule_28;
 
-import rule_29 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-properties';
+import rule_29 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-template';
 
-cache['bpmnlint-plugin-camunda-compat/no-zeebe-properties'] = rule_29;
+cache['bpmnlint-plugin-camunda-compat/no-template'] = rule_29;
 
-import rule_30 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-user-task';
+import rule_30 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-version-tag';
 
-cache['bpmnlint-plugin-camunda-compat/no-zeebe-user-task'] = rule_30;
+cache['bpmnlint-plugin-camunda-compat/no-version-tag'] = rule_30;
 
-import rule_31 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/secrets';
+import rule_31 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-properties';
 
-cache['bpmnlint-plugin-camunda-compat/secrets'] = rule_31;
+cache['bpmnlint-plugin-camunda-compat/no-zeebe-properties'] = rule_31;
 
-import rule_32 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/sequence-flow-condition';
+import rule_32 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/no-zeebe-user-task';
 
-cache['bpmnlint-plugin-camunda-compat/sequence-flow-condition'] = rule_32;
+cache['bpmnlint-plugin-camunda-compat/no-zeebe-user-task'] = rule_32;
 
-import rule_33 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/signal-reference';
+import rule_33 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/priority-definition';
 
-cache['bpmnlint-plugin-camunda-compat/signal-reference'] = rule_33;
+cache['bpmnlint-plugin-camunda-compat/priority-definition'] = rule_33;
 
-import rule_34 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/start-event-form';
+import rule_34 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/secrets';
 
-cache['bpmnlint-plugin-camunda-compat/start-event-form'] = rule_34;
+cache['bpmnlint-plugin-camunda-compat/secrets'] = rule_34;
 
-import rule_35 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
+import rule_35 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/sequence-flow-condition';
 
-cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_35;
+cache['bpmnlint-plugin-camunda-compat/sequence-flow-condition'] = rule_35;
 
-import rule_36 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
+import rule_36 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/signal-reference';
 
-cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_36;
+cache['bpmnlint-plugin-camunda-compat/signal-reference'] = rule_36;
 
-import rule_37 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
+import rule_37 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/start-event-form';
 
-cache['bpmnlint-plugin-camunda-compat/timer'] = rule_37;
+cache['bpmnlint-plugin-camunda-compat/start-event-form'] = rule_37;
 
-import rule_38 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-definition';
+import rule_38 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/subscription';
 
-cache['bpmnlint-plugin-camunda-compat/user-task-definition'] = rule_38;
+cache['bpmnlint-plugin-camunda-compat/subscription'] = rule_38;
 
-import rule_39 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
+import rule_39 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/task-schedule';
 
-cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_39;
+cache['bpmnlint-plugin-camunda-compat/task-schedule'] = rule_39;
 
-import rule_40 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/wait-for-completion';
+import rule_40 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/timer';
 
-cache['bpmnlint-plugin-camunda-compat/wait-for-completion'] = rule_40;
+cache['bpmnlint-plugin-camunda-compat/timer'] = rule_40;
+
+import rule_41 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-definition';
+
+cache['bpmnlint-plugin-camunda-compat/user-task-definition'] = rule_41;
+
+import rule_42 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/user-task-form';
+
+cache['bpmnlint-plugin-camunda-compat/user-task-form'] = rule_42;
+
+import rule_43 from 'bpmnlint-plugin-camunda-compat/rules/camunda-cloud/wait-for-completion';
+
+cache['bpmnlint-plugin-camunda-compat/wait-for-completion'] = rule_43;

package/lib/utils/error-messages.js

@@ -324,6 +324,10 @@ function getExtensionElementNotAllowedErrorMessage(report, executionPlatform, ex
     return getSupportedMessage('A <User Task> with <Due date> or <Follow up date>', executionPlatform, executionPlatformVersion, allowedVersion);
   }
 
+  if (is(node, 'bpmn:UserTask') && is(extensionElement, 'zeebe:PriorityDefinition')) {
+    return getSupportedMessage('A <User Task> with <Priority>', executionPlatform, executionPlatformVersion, allowedVersion);
+  }
+
   if (is(node, 'bpmn:StartEvent') && is(extensionElement, 'zeebe:FormDefinition')) {
     return getSupportedMessage('A <Start Event> with <User Task Form>', executionPlatform, executionPlatformVersion, allowedVersion);
   }
@@ -332,6 +336,10 @@ function getExtensionElementNotAllowedErrorMessage(report, executionPlatform, ex
     return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with <Execution listeners>`, executionPlatform, executionPlatformVersion, allowedVersion);
   }
 
+  if (is(node, 'bpmn:Process') && is(extensionElement, 'zeebe:VersionTag')) {
+    return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with <Version tag>`, executionPlatform, executionPlatformVersion, allowedVersion);
+  }
+
   return message;
 }
 
@@ -434,7 +442,7 @@ function getPropertyNotAllowedErrorMessage(report, executionPlatform, executionP
   }
 
   if (is(node, 'zeebe:AssignmentDefinition') && property === 'candidateUsers') {
-    return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with defined <Candidate users>`, executionPlatform, executionPlatformVersion, allowedVersion);
+    return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with <Candidate users>`, executionPlatform, executionPlatformVersion, allowedVersion);
   }
 
   if (is(node, 'bpmn:SequenceFlow') && property === 'conditionExpression') {
@@ -449,6 +457,14 @@ function getPropertyNotAllowedErrorMessage(report, executionPlatform, executionP
     return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with <Form type: Camunda form (linked)>`, executionPlatform, executionPlatformVersion, allowedVersion);
   }
 
+  if (isAny(node, [
+    'zeebe:CalledDecision',
+    'zeebe:CalledElement',
+    'zeebe:FormDefinition'
+  ]) && property === 'versionTag') {
+    return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with <Version tag>`, executionPlatform, executionPlatformVersion, allowedVersion);
+  }
+
   return message;
 }
 
@@ -648,6 +664,10 @@ function getExpressionValueNotAllowedErrorMessage(report, executionPlatform, exe
     return `${ getIndefiniteArticle(typeString) } <${ typeString }> <Follow up date> must be an ISO 8601 date`;
   }
 
+  if (is(node, 'zeebe:PriorityDefinition') && property === 'priority') {
+    return `${ getIndefiniteArticle(typeString) } <${ typeString }> <Priority> must be an expression, or an integer between 0 and 100`;
+  }
+
   return message;
 }
 
@@ -715,7 +735,15 @@ function getPropertyValueNotAllowedErrorMessage(report, executionPlatform, execu
     'zeebe:CalledElement',
     'zeebe:FormDefinition'
   ]) && property === 'bindingType') {
-    return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with <Binding: deployment>`, executionPlatform, executionPlatformVersion, allowedVersion);
+    const bindingType = node.get('bindingType');
+
+    let bindingTypeString = bindingType;
+
+    if (bindingType === 'versionTag') {
+      bindingTypeString = 'version tag';
+    }
+
+    return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with <Binding: ${ bindingTypeString }>`, executionPlatform, executionPlatformVersion, allowedVersion);
   }
 
   return message;

package/lib/utils/properties-panel.js

@@ -303,6 +303,14 @@ export function getEntryIds(report) {
     return ids;
   }
 
+  if (isExpressionValueNotAllowedError(data, 'priority', 'zeebe:PriorityDefinition')) {
+    return [ 'priorityDefinitionPriority' ];
+  }
+
+  if (isExtensionElementNotAllowedError(data, 'zeebe:PriorityDefinition', 'bpmn:UserTask')) {
+    return [ 'priorityDefinition' ];
+  }
+
   if (isPropertyError(data, 'propagateAllParentVariables', 'zeebe:CalledElement')) {
     return [ 'propagateAllParentVariables' ];
   }
@@ -336,6 +344,10 @@ export function getEntryIds(report) {
     return [ 'bindingType' ];
   }
 
+  if (isPropertyError(data, 'versionTag') || isExtensionElementNotAllowedError(data, 'zeebe:VersionTag')) {
+    return [ 'versionTag' ];
+  }
+
   return [];
 }
 
@@ -533,6 +545,14 @@ export function getErrorMessage(id, report) {
     }
   }
 
+  if (id === 'priorityDefinitionPriority') {
+    if (type === ERROR_TYPES.EXTENSION_ELEMENT_NOT_ALLOWED) {
+      return getNotSupportedMessage('', allowedVersion);
+    } else {
+      return 'Must be an expression, or an integer between 0 and 100.';
+    }
+  }
+
   if (id === 'propagateAllParentVariables') {
     return getNotSupportedMessage('', allowedVersion);
   }
@@ -560,6 +580,10 @@ export function getErrorMessage(id, report) {
   if (id === 'bindingType') {
     return getNotSupportedMessage('', allowedVersion);
   }
+
+  if (id === 'versionTag') {
+    return getNotSupportedMessage('', allowedVersion);
+  }
 }
 
 function isExtensionElementNotAllowedError(data, extensionElement, type) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "3.24.0",
+  "version": "3.26.0",
   "description": "Linting for Camunda",
   "main": "index.js",
   "scripts": {
@@ -32,7 +32,7 @@
     "@bpmn-io/diagram-js-ui": "^0.2.3",
     "bpmn-moddle": "^9.0.1",
     "bpmnlint": "^10.3.0",
-    "bpmnlint-plugin-camunda-compat": "^2.23.0",
+    "bpmnlint-plugin-camunda-compat": "^2.25.0",
     "bpmnlint-utils": "^1.0.2",
     "camunda-bpmn-moddle": "^7.0.1",
     "clsx": "^2.0.0",
@@ -40,13 +40,13 @@
     "min-dom": "^5.1.1",
     "modeler-moddle": "^0.2.0",
     "semver-compare": "^1.0.0",
-    "zeebe-bpmn-moddle": "^1.4.0"
+    "zeebe-bpmn-moddle": "^1.6.0"
   },
   "devDependencies": {
-    "bpmn-js": "^17.9.0",
-    "bpmn-js-element-templates": "^1.16.0",
-    "bpmn-js-properties-panel": "^5.21.0",
-    "camunda-bpmn-js-behaviors": "^1.5.0",
+    "bpmn-js": "^17.9.2",
+    "bpmn-js-element-templates": "^2.2.0",
+    "bpmn-js-properties-panel": "^5.23.0",
+    "camunda-bpmn-js-behaviors": "^1.6.1",
     "chai": "^4.4.1",
     "cross-env": "^7.0.3",
     "eslint": "^8.57.0",