@camunda/linting 1.0.0 → 1.2.0

package/lib/utils/error-messages.js

@@ -123,6 +123,10 @@ export function getErrorMessage(report, executionPlatform, executionPlatformVers
     return getExpressionNotAllowedErrorMessage(report);
   }
 
+  if (type === ERROR_TYPES.EVENT_BASED_GATEWAY_TARGET_NOT_ALLOWED) {
+    return getEventBasedGatewayTargetNotAllowedErrorMessage(report);
+  }
+
   return message;
 }
 
@@ -353,6 +357,10 @@ function getPropertyNotAllowedErrorMessage(report, executionPlatform, executionP
     return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with defined <Candidate users>`, executionPlatform, executionPlatformVersion, allowedVersion);
   }
 
+  if (is(node, 'bpmn:SequenceFlow') && property === 'conditionExpression') {
+    return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Condition expression> is only supported if the source is an <Exclusive Gateway> or <Inclusive Gateway>`;
+  }
+
   return message;
 }
 
@@ -412,6 +420,10 @@ function getPropertyRequiredErrorMessage(report, executionPlatform, executionPla
     return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Message Reference> must have a defined <Name>`;
   }
 
+  if (is(node, 'bpmn:Signal') && requiredProperty === 'name') {
+    return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Signal Reference> must have a defined <Name>`;
+  }
+
   if (is(node, 'zeebe:Subscription') && requiredProperty === 'correlationKey') {
     return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Message Reference> must have a defined <Subscription correlation key>`;
   }
@@ -434,6 +446,10 @@ function getPropertyRequiredErrorMessage(report, executionPlatform, executionPla
     return `${ getIndefiniteArticle(typeString) } <${ typeString }> must have a defined <Message Reference>`;
   }
 
+  if (requiredProperty === 'signalRef') {
+    return `${ getIndefiniteArticle(typeString) } <${ typeString }> must have a defined <Signal Reference>`;
+  }
+
   if (is(node, 'zeebe:FormDefinition') && requiredProperty === 'formKey') {
     return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Form type: Custom form key> must have a defined <Form key>`;
   }
@@ -547,5 +563,17 @@ function getExpressionNotAllowedErrorMessage(report) {
     return 'Error code used in a catch event must be a static value';
   }
 
+  return report.message;
+}
+
+function getEventBasedGatewayTargetNotAllowedErrorMessage(report) {
+  const { data } = report;
+
+  const { node } = data;
+
+  if (is(node, 'bpmn:ReceiveTask')) {
+    return 'A <Receive Task> cannot be the target of an <Event-Based Gateway>';
+  }
+
   return report.message;
 }

package/lib/utils/properties-panel.js

@@ -76,6 +76,10 @@ export function getEntryIds(report) {
     return [ 'messageRef' ];
   }
 
+  if (isPropertyError(data, 'signalRef')) {
+    return [ 'signalRef' ];
+  }
+
   if (isPropertyError(data, 'decisionId', 'zeebe:CalledDecision')) {
     return [ 'decisionId' ];
   }
@@ -100,6 +104,10 @@ export function getEntryIds(report) {
     return [ 'messageName' ];
   }
 
+  if (isPropertyError(data, 'name', 'bpmn:Signal')) {
+    return [ 'signalName' ];
+  }
+
   if (isExtensionElementRequiredError(data, 'zeebe:LoopCharacteristics', 'bpmn:MultiInstanceLoopCharacteristics')
     || isPropertyError(data, 'inputCollection', 'zeebe:LoopCharacteristics')) {
     return [ 'multiInstance-inputCollection' ];
@@ -286,6 +294,10 @@ export function getErrorMessage(id, report) {
     return 'Global message reference must be defined.';
   }
 
+  if (id === 'signalRef') {
+    return 'Global signal reference must be defined.';
+  }
+
   if (id === 'decisionId') {
     return 'Decision ID must be defined.';
   }
@@ -310,6 +322,10 @@ export function getErrorMessage(id, report) {
     return 'Name must be defined.';
   }
 
+  if (id === 'signalName') {
+    return 'Name must be defined.';
+  }
+
   if (id === 'multiInstance-inputCollection') {
     return 'Input collection must be defined.';
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "1.0.0",
+  "version": "1.2.0",
   "description": "Linting for Camunda Platform",
   "main": "index.js",
   "scripts": {
@@ -29,7 +29,7 @@
   "dependencies": {
     "bpmn-moddle": "^8.0.0",
     "bpmnlint": "^8.0.0",
-    "bpmnlint-plugin-camunda-compat": "^1.0.1",
+    "bpmnlint-plugin-camunda-compat": "^1.2.0",
     "bpmnlint-utils": "^1.0.2",
     "min-dash": "^4.0.0",
     "min-dom": "^4.1.0",