@camunda/linting 0.9.0 → 0.10.0

package/lib/Linter.js

@@ -13,6 +13,8 @@ import zeebeModdle from 'zeebe-bpmn-moddle/resources/zeebe.json';
 import { getErrorMessage } from './utils/error-messages';
 import { getEntryIds } from './utils/properties-panel';
 
+import { toSemverMinor } from './utils/version';
+
 const moddle = new BpmnModdle({
   modeler: modelerModdle,
   zeebe: zeebeModdle
@@ -133,10 +135,6 @@ function toLowerCase(string) {
   return string.toLowerCase();
 }
 
-function toSemverMinor(executionPlatformVersion) {
-  return executionPlatformVersion.split('.').slice(0, 2).join('.');
-}
-
 async function createCache(configName) {
   let config = require('bpmnlint-plugin-camunda-compat').configs[ configName ];
 

package/lib/utils/error-messages.js

@@ -9,6 +9,8 @@ import {
 
 import { getTypeString } from './types';
 
+import { toSemverMinor } from './version';
+
 const TIMER_PROPERTIES = [
   'timeCycle',
   'timeDate',
@@ -27,7 +29,7 @@ const executionPlatformLabels = {
 
 export function getExecutionPlatformLabel(executionPlatform, executionPlatformVersion) {
   const executionPlatformLabel = executionPlatformLabels[ executionPlatform ]
-    && executionPlatformLabels[ executionPlatform ][ executionPlatformVersion ];
+    && executionPlatformLabels[ executionPlatform ][ toSemverMinor(executionPlatformVersion) ];
 
   if (executionPlatformLabel) {
     return executionPlatformLabel;
@@ -38,7 +40,7 @@ export function getExecutionPlatformLabel(executionPlatform, executionPlatformVe
     executionPlatform = executionPlatformLabels[ executionPlatform ][ 'default' ];
   }
 
-  return `${ executionPlatform } ${ executionPlatformVersion }`;
+  return `${ executionPlatform } ${ toSemverMinor(executionPlatformVersion) }`;
 }
 
 function getIndefiniteArticle(type) {
@@ -101,6 +103,10 @@ export function getErrorMessage(report, executionPlatform, executionPlatformVers
     return getPropertyValueDuplicatedErrorMessage(report);
   }
 
+  if (type === ERROR_TYPES.PROPERTY_VALUE_REQUIRED) {
+    return getPropertyValueRequiredErrorMessage(report);
+  }
+
   if (type === ERROR_TYPES.EXPRESSION_REQUIRED) {
     return getExpressionRequiredErrorMessage(report);
   }
@@ -164,6 +170,29 @@ function getPropertyValueDuplicatedErrorMessage(report) {
   return message;
 }
 
+function getPropertyValueRequiredErrorMessage(report) {
+  const {
+    data,
+    message
+  } = report;
+
+  const {
+    node,
+    property,
+    parentNode
+  } = data;
+
+  if (is(node, 'bpmn:Process') && property === 'isExecutable') {
+    if (parentNode && is(parentNode, 'bpmn:Participant')) {
+      return 'One <Process> must be <Executable>';
+    } else {
+      return 'A <Process> must be <Executable>';
+    }
+  }
+
+  return message;
+}
+
 function getExtensionElementNotAllowedErrorMessage(report, executionPlatform, executionPlatformVersion) {
   const {
     data,

package/lib/utils/properties-panel.js

@@ -51,6 +51,10 @@ export function getEntryIds(report) {
     path
   } = report;
 
+  if (isPropertyError(data, 'isExecutable')) {
+    return [ 'isExecutable' ];
+  }
+
   if (isExtensionElementRequiredError(data, 'zeebe:CalledDecision', 'bpmn:BusinessRuleTask')) {
     return [ 'businessRuleImplementation' ];
   }
@@ -203,6 +207,16 @@ export function getErrorMessage(id, report) {
     return;
   }
 
+  if (id === 'isExecutable') {
+    const { parentNode } = data;
+
+    if (parentNode && is(parentNode, 'bpmn:Participant')) {
+      return 'One process must be executable.';
+    } else {
+      return 'Process must be executable.';
+    }
+  }
+
   if (id === 'businessRuleImplementation') {
     return 'Implementation must be defined.';
   }

package/lib/utils/version.js

@@ -0,0 +1,3 @@
+export function toSemverMinor(executionPlatformVersion) {
+  return executionPlatformVersion.split('.').slice(0, 2).join('.');
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "0.9.0",
+  "version": "0.10.0",
   "description": "Linting for Camunda Platform",
   "main": "index.js",
   "scripts": {
@@ -27,7 +27,7 @@
   "dependencies": {
     "bpmn-moddle": "^7.1.3",
     "bpmnlint": "^8.0.0",
-    "bpmnlint-plugin-camunda-compat": "^0.14.1",
+    "bpmnlint-plugin-camunda-compat": "^0.15.1",
     "bpmnlint-utils": "^1.0.2",
     "min-dash": "^4.0.0",
     "min-dom": "^4.0.1",