@camunda/linting 0.12.0 → 0.14.0

package/lib/Linter.js

@@ -1,4 +1,4 @@
-import BpmnModdle from 'bpmn-moddle/dist/index';
+import BpmnModdle from 'bpmn-moddle';
 
 import { Linter as BpmnLinter } from 'bpmnlint';
 import StaticResolver from 'bpmnlint/lib/resolver/static-resolver';

package/lib/utils/error-messages.js

@@ -115,6 +115,10 @@ export function getErrorMessage(report, executionPlatform, executionPlatformVers
     return getExpressionValueNotAllowedErrorMessage(report);
   }
 
+  if (type === ERROR_TYPES.EXPRESSION_NOT_ALLOWED) {
+    return getExpressionNotAllowedErrorMessage(report);
+  }
+
   return message;
 }
 
@@ -317,6 +321,10 @@ function getPropertyNotAllowedErrorMessage(report, executionPlatform, executionP
     return `${ getIndefiniteArticle(typeString) } <${ typeString }> with more than one incoming <Sequence Flow> is not supported by ${ getExecutionPlatformLabel(executionPlatform, executionPlatformVersion) }`;
   }
 
+  if (is(node, 'zeebe:AssignmentDefinition') && property === 'candidateUsers') {
+    return getSupportedMessage(`${ getIndefiniteArticle(typeString) } <${ typeString }> with defined <Candidate users>`, executionPlatform, executionPlatformVersion, allowedVersion);
+  }
+
   return message;
 }
 
@@ -363,6 +371,10 @@ function getPropertyRequiredErrorMessage(report) {
     return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Error Reference> must have a defined <Error code>`;
   }
 
+  if (is(node, 'bpmn:Escalation') && requiredProperty === 'escalationCode') {
+    return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Escalation Reference> must have a defined <Escalation code>`;
+  }
+
   if (is(node, 'zeebe:LoopCharacteristics') && requiredProperty === 'inputCollection') {
     return `${ getIndefiniteArticle(typeString) } <${ typeString }> with <Multi-instance marker> must have a defined <Input collection>`;
   }
@@ -463,4 +475,22 @@ function getSupportedMessage(prefix, executionPlatform, executionPlatformVersion
   }
 
   return `${ prefix } is not supported by ${ getExecutionPlatformLabel(executionPlatform, executionPlatformVersion) }`;
-}
+}
+
+function getExpressionNotAllowedErrorMessage(report) {
+  const {
+    data
+  } = report;
+
+  const {
+    node,
+    parentNode,
+    property
+  } = data;
+
+  if (is(node, 'bpmn:Escalation') && property === 'escalationCode' && is(parentNode, 'bpmn:CatchEvent')) {
+    return 'Escalation code used in a catch event must be a static value';
+  } else if (is(node, 'bpmn:Error') && property === 'errorCode' && is(parentNode, 'bpmn:CatchEvent')) {
+    return 'Error code used in a catch event must be a static value';
+  }
+}

package/lib/utils/properties-panel.js

@@ -68,6 +68,10 @@ export function getEntryIds(report) {
     return [ 'errorRef' ];
   }
 
+  if (isPropertyError(data, 'escalationRef')) {
+    return [ 'escalationRef' ];
+  }
+
   if (isPropertyError(data, 'messageRef')) {
     return [ 'messageRef' ];
   }
@@ -88,6 +92,10 @@ export function getEntryIds(report) {
     return [ 'errorCode' ];
   }
 
+  if (isPropertyError(data, 'escalationCode', 'bpmn:Escalation')) {
+    return [ 'escalationCode' ];
+  }
+
   if (isPropertyError(data, 'name', 'bpmn:Message')) {
     return [ 'messageName' ];
   }
@@ -205,6 +213,10 @@ export function getEntryIds(report) {
     return [ `multiInstance-${getPropertyName(data)}` ];
   }
 
+  if (isPropertyError(data, 'candidateUsers', 'zeebe:AssignmentDefinition')) {
+    return [ 'assignmentDefinitionCandidateUsers' ];
+  }
+
   return [];
 }
 
@@ -216,6 +228,10 @@ export function getErrorMessage(id, report) {
     return;
   }
 
+  if (data.type === ERROR_TYPES.EXPRESSION_NOT_ALLOWED) {
+    return 'Cannot be an expression.';
+  }
+
   if (id === 'isExecutable') {
     const { parentNode } = data;
 
@@ -234,6 +250,10 @@ export function getErrorMessage(id, report) {
     return 'Global error reference must be defined.';
   }
 
+  if (id === 'escalationRef') {
+    return 'Global escalation reference must be defined.';
+  }
+
   if (id === 'messageRef') {
     return 'Global message reference must be defined.';
   }
@@ -250,7 +270,11 @@ export function getErrorMessage(id, report) {
     return 'Result variable must be defined.';
   }
 
-  if (id === 'errorCode') {
+  if (id === 'errorCode' && data.type === ERROR_TYPES.PROPERTY_REQUIRED) {
+    return 'Code must be defined.';
+  }
+
+  if (id === 'escalationCode' && data.type === ERROR_TYPES.PROPERTY_REQUIRED) {
     return 'Code must be defined.';
   }
 
@@ -326,6 +350,10 @@ export function getErrorMessage(id, report) {
       return 'Must be an expression, or an ISO 8601 interval.';
     }
   }
+
+  if (id === 'assignmentDefinitionCandidateUsers') {
+    return 'Not supported.';
+  }
 }
 
 function isExtensionElementNotAllowedError(data, extensionElement, type) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/linting",
-  "version": "0.12.0",
+  "version": "0.14.0",
   "description": "Linting for Camunda Platform",
   "main": "index.js",
   "scripts": {
@@ -25,35 +25,35 @@
   },
   "license": "MIT",
   "dependencies": {
-    "bpmn-moddle": "^7.1.3",
+    "bpmn-moddle": "^8.0.0",
     "bpmnlint": "^8.0.0",
-    "bpmnlint-plugin-camunda-compat": "^0.17.0",
+    "bpmnlint-plugin-camunda-compat": "^0.20.0",
     "bpmnlint-utils": "^1.0.2",
     "min-dash": "^4.0.0",
-    "min-dom": "^4.0.1",
+    "min-dom": "^4.1.0",
     "zeebe-bpmn-moddle": "^0.17.0"
   },
   "devDependencies": {
-    "bpmn-js": "^9.4.0",
-    "bpmn-js-properties-panel": "^1.13.0",
-    "chai": "^4.3.6",
+    "bpmn-js": "^11.1.1",
+    "bpmn-js-properties-panel": "^1.15.1",
+    "chai": "^4.3.7",
     "cross-env": "^7.0.3",
-    "eslint": "^8.23.1",
-    "eslint-plugin-bpmn-io": "^0.16.0",
-    "karma": "^6.4.0",
+    "eslint": "^8.32.0",
+    "eslint-plugin-bpmn-io": "^1.0.0",
+    "karma": "^6.4.1",
     "karma-chrome-launcher": "^3.1.1",
     "karma-debug-launcher": "0.0.5",
     "karma-env-preprocessor": "^0.1.1",
     "karma-mocha": "^2.0.1",
     "karma-sinon-chai": "^2.0.2",
     "karma-webpack": "^5.0.0",
-    "mocha": "^10.0.0",
+    "mocha": "^10.2.0",
     "mocha-test-container-support": "^0.2.0",
     "modeler-moddle": "^0.2.0",
-    "puppeteer": "^16.2.0",
-    "sinon": "^14.0.0",
+    "puppeteer": "^19.5.2",
+    "sinon": "^15.0.1",
     "sinon-chai": "^3.7.0",
-    "webpack": "^5.74.0"
+    "webpack": "^5.75.0"
   },
   "peerDependencies": {
     "bpmn-js-properties-panel": ">= 1.10.0"