@camunda/e2e-test-suite 0.0.1612 → 0.0.1613

package/dist/pages/8.7/ProcessApplicationPage.d.ts

@@ -9,6 +9,7 @@ declare class ProcessApplicationPage {
     readonly cancelButton: Locator;
     readonly breadcrumb: Locator;
     readonly folderExplorer: Locator;
+    readonly loadErrorState: Locator;
     readonly createNewDropdown: Locator;
     readonly inlineNameInput: Locator;
     readonly defineStagesDialog: Locator;

package/dist/pages/8.7/ProcessApplicationPage.js

@@ -33,6 +33,7 @@ class ProcessApplicationPage {
     cancelButton;
     breadcrumb;
     folderExplorer;
+    loadErrorState;
     createNewDropdown;
     inlineNameInput;
     // "Define stages" dialog, reached from the process application's "Connected
@@ -85,6 +86,11 @@ class ProcessApplicationPage {
         });
         this.breadcrumb = page.locator('[data-test="breadcrumb-process-application-menu"]');
         this.folderExplorer = page.getByRole('region', { name: 'Folder explorer' });
+        // camunda-hub app/components/page/Page.tsx ErrorState: the design-system
+        // EmptyState that replaces the page body when its fetches fail.
+        this.loadErrorState = page.getByRole('heading', {
+            name: /^(Something went wrong|Not found)$/,
+        });
         // The process application page renders more than one diagram-dropdown
         // (hub's own unit tests reach for it with getAllByTestId), so the dropdown
         // has to be resolved inside the folder explorer rather than page-wide.
@@ -133,30 +139,50 @@ class ProcessApplicationPage {
     // absolute deadline: reload() otherwise inherits the 120s navigationTimeout
     // and two slow reloads would eat the test budget during an outage. The last
     // attempt is a plain assertion so a persistent outage still fails loudly.
+    //
+    // Reload only when it can help: as soon as Hub has rendered its error view
+    // (Page.tsx ErrorState -- "Something went wrong" or a "Not found" that a
+    // just-created application can briefly answer), or when one load has sat
+    // on the spinner for `stallAfter`. A fixed per-attempt cut-off used to
+    // reload pages that were still loading, so under load a ~40s render was
+    // restarted twice and the last attempt got ~37s -- not enough for a third
+    // render from scratch.
     async waitWithReload(target, timeout, attempts = 3) {
         const deadline = Date.now() + timeout;
-        const perAttempt = Math.ceil(timeout / attempts);
+        const stallAfter = Math.ceil(timeout / 2);
         const remaining = () => Math.max(deadline - Date.now(), 1000);
-        for (let attempt = 1; attempt < attempts; attempt++) {
+        const settled = target.or(this.loadErrorState).first();
+        let reloadsLeft = attempts - 1;
+        let loadStartedAt = Date.now();
+        while (reloadsLeft > 0 && deadline - Date.now() > 1000) {
             // Hub can drop its session on a navigation and bounce through
             // /login-callback to the identity provider, where neither reloading nor
             // waiting renders the content -- re-authenticate first.
-            await (0, sessionRecovery_1.recoverStuckModelerLogin)(this.page);
-            await (0, sessionRecovery_1.restoreSessionIfLoggedOut)(this.page);
-            const ready = await target
-                .waitFor({ state: 'visible', timeout: Math.min(perAttempt, remaining()) })
-                .then(() => true)
-                .catch(() => false);
-            if (ready) {
+            const recoveredLogin = await (0, sessionRecovery_1.recoverStuckModelerLogin)(this.page);
+            const restoredSession = await (0, sessionRecovery_1.restoreSessionIfLoggedOut)(this.page);
+            if (recoveredLogin || restoredSession) {
+                loadStartedAt = Date.now();
+            }
+            // Short slices so a session dropped mid-wait is still recovered above.
+            await settled
+                .waitFor({ state: 'visible', timeout: Math.min(15000, remaining()) })
+                .catch(() => undefined);
+            if (await target.isVisible()) {
                 return;
             }
-            console.warn(`Process application content did not render (attempt ${attempt}/${attempts}); reloading.`);
+            const errored = await this.loadErrorState.isVisible();
+            if (!errored && Date.now() - loadStartedAt < stallAfter) {
+                continue;
+            }
+            reloadsLeft--;
+            console.warn(`Process application content did not render (${errored ? 'Hub showed its error view' : 'still loading'}); reloading, ${reloadsLeft} reload(s) left.`);
             // 'domcontentloaded': a reload that bounces through /login-callback
             // never reaches "load", and recovery above needs the page back.
             await this.page.reload({
                 waitUntil: 'domcontentloaded',
                 timeout: remaining(),
             });
+            loadStartedAt = Date.now();
         }
         await (0, sessionRecovery_1.recoverStuckModelerLogin)(this.page);
         await (0, sessionRecovery_1.restoreSessionIfLoggedOut)(this.page);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/e2e-test-suite",
-  "version": "0.0.1612",
+  "version": "0.0.1613",
   "description": "End-to-end test helpers for Camunda 8",
   "repository": {
     "type": "git",