@camunda/e2e-test-suite 0.0.1240 → 0.0.1242

package/dist/pages/SM-8.10/NavigationPage.d.ts

@@ -8,18 +8,19 @@ declare class NavigationPage {
     readonly identityPageBanner: Locator;
     readonly keyboardPageBanner: Locator;
     readonly managementIdentityPageBanner: Locator;
+    private onboardingTourSuppressed;
     constructor(page: Page);
     private isGatewayErrorPage;
     private waitForBanner;
     goTo(url: string, banner: Locator, sleepTimeout?: number, { username, password, }?: {
         username?: string;
         password?: string;
-    }, maxRetries?: number, beforeBannerCheck?: () => Promise<void>): Promise<void>;
+    }, maxRetries?: number): Promise<void>;
     goToModeler(sleepTimeout?: number, credentials?: {
         username: string;
         password: string;
     }): Promise<void>;
-    private dismissOnboardingDialog;
+    private suppressOnboardingTour;
     goToTasklist(sleepTimeout?: number, credentials?: {
         username: string;
         password: string;

package/dist/pages/SM-8.10/NavigationPage.js

@@ -28,6 +28,7 @@ class NavigationPage {
     identityPageBanner;
     keyboardPageBanner;
     managementIdentityPageBanner;
+    onboardingTourSuppressed = false;
     constructor(page) {
         this.page = page;
         // Operate renders the Design System header (AppHeaderV2) whenever the
@@ -112,15 +113,12 @@ class NavigationPage {
     // that is exactly the reported "Login (/modeler) failed after 8 attempts".
     // The 60s budget is unchanged: a genuinely slow shell still gets all of it,
     // and a sustained outage still fails.
-    async waitForBanner(url, banner, submitted, beforeBannerCheck) {
+    async waitForBanner(url, banner, submitted) {
         const totalTimeout = constants_1._1_SECOND_IN_MS * 60;
         const deadline = Date.now() + totalTimeout;
         let lastState = 'no banner';
         while (Date.now() < deadline) {
             const round = Math.min(constants_1._1_SECOND_IN_MS * 20, deadline - Date.now());
-            if (beforeBannerCheck) {
-                await beforeBannerCheck();
-            }
             try {
                 await (0, test_1.expect)(banner).toBeVisible({ timeout: round });
                 return;
@@ -148,7 +146,7 @@ class NavigationPage {
         }
         throw new Error(`${url} did not render its banner within ${totalTimeout}ms: ${lastState}`);
     }
-    async goTo(url, banner, sleepTimeout, { username = IDENTITY_FIRSTUSER_USERNAME, password = IDENTITY_FIRSTUSER_PASSWORD, } = {}, maxRetries = 8, beforeBannerCheck) {
+    async goTo(url, banner, sleepTimeout, { username = IDENTITY_FIRSTUSER_USERNAME, password = IDENTITY_FIRSTUSER_PASSWORD, } = {}, maxRetries = 8) {
         const startTime = Date.now();
         let timeout = constants_1._1_SECOND_IN_MS * 10;
         if (url === '/modeler') {
@@ -217,7 +215,7 @@ class NavigationPage {
                 else {
                     submitted = await loginPage.login(username, password);
                 }
-                await this.waitForBanner(url, banner, submitted, beforeBannerCheck);
+                await this.waitForBanner(url, banner, submitted);
                 return;
             }
             catch (error) {
@@ -264,25 +262,27 @@ class NavigationPage {
         }
     }
     async goToModeler(sleepTimeout, credentials) {
-        await this.goTo(MODELER_CONTEXT_PATH, this.modelerPageBanner, sleepTimeout, credentials, 8, () => this.dismissOnboardingDialog());
+        await this.suppressOnboardingTour();
+        await this.goTo(MODELER_CONTEXT_PATH, this.modelerPageBanner, sleepTimeout, credentials, 8);
     }
-    // After the Camunda Hub rebrand a first visit to Modeler home greets the user
-    // with a multi-step "Welcome to Camunda Hub" onboarding dialog. It mounts over
-    // the home and marks the app shell inert, so the "Camunda Modeler home" banner
-    // link leaves the accessibility tree until the dialog is dismissed -- gating on
-    // the banner alone then loops until the whole login budget is spent. Close it
-    // through the dialog's own control before each banner check so the banner can
-    // resolve; only unambiguous dismissals are matched (never "Cancel", which is a
-    // form action on the dialogs other flows open on purpose).
-    async dismissOnboardingDialog() {
-        const dismiss = this.page
-            .locator('[role="dialog"]')
-            .getByRole('button', { name: /^(Got it|Close|Dismiss)/i })
-            .first();
-        await dismiss
-            .waitFor({ state: 'visible', timeout: 3000 })
-            .then(() => dismiss.click())
-            .catch(() => { });
+    // Mirrors camunda-hub@452978f: pre-seed the onboarding tour's "seen" localStorage flag
+    // (SEEN_KEY_PREFIX in .../tour-dialog/use-onboarding-seen.ts) so it never auto-opens, rather
+    // than dismissing it reactively (the two prior fixes here -- both raced the dialog's mount
+    // and lost, since the user id needed for the real key isn't known until after that same
+    // race). addInitScript avoids the race by running before any page script, matching the
+    // flag by prefix since the user id isn't known up front.
+    async suppressOnboardingTour() {
+        if (this.onboardingTourSuppressed) {
+            return;
+        }
+        this.onboardingTourSuppressed = true;
+        await this.page.addInitScript((prefixPattern) => {
+            const pattern = new RegExp(prefixPattern);
+            const originalGetItem = Storage.prototype.getItem;
+            Storage.prototype.getItem = function (key) {
+                return pattern.test(key) ? 'true' : originalGetItem.call(this, key);
+            };
+        }, '^hub\\.onboarding\\..*\\.seen\\.');
     }
     async goToTasklist(sleepTimeout, credentials) {
         await this.goTo(`${NORMALIZED_ORCHESTRATION_CONTEXT_PATH}/tasklist`, this.tasklistPageBanner, sleepTimeout, credentials);

package/dist/pages/SM-8.10/ProcessApplicationPage.js

@@ -156,6 +156,12 @@ class ProcessApplicationPage {
         await (0, test_1.expect)(this.defineStagesDialog).toBeVisible({ timeout: 60000 });
         await this.developmentClusterSelect.click({ timeout: 30000 });
         const escapedClusterName = clusterName?.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+        // The listbox leads with a "No cluster" entry that unassigns the stage; the
+        // placeholder "Select a development cluster" is only the trigger's text, not an
+        // option. Excluding just the placeholder leaves "No cluster" first, so an
+        // unnamed pick binds no cluster and saves defaultDevClusterId=null -- which
+        // makes the later Deploy dialog report "Clusters not configured for stages".
+        // Exclude "No cluster" too so the fallback lands on a real cluster.
         const option = clusterName
             ? this.page
                 .getByRole('option', { name: new RegExp(`^${escapedClusterName}`) })
@@ -163,6 +169,7 @@ class ProcessApplicationPage {
             : this.page
                 .getByRole('option')
                 .filter({ hasNotText: 'Select a development cluster' })
+                .filter({ hasNotText: 'No cluster' })
                 .first();
         await option.click({ timeout: 30000 });
         await this.defineStagesSaveButton.click({ timeout: 30000 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/e2e-test-suite",
-  "version": "0.0.1240",
+  "version": "0.0.1242",
   "description": "End-to-end test helpers for Camunda 8",
   "repository": {
     "type": "git",