@camunda/e2e-test-suite 0.0.1157 → 0.0.1159

package/dist/pages/8.10/OperateProcessInstancePage.js

@@ -809,13 +809,15 @@ class OperateProcessInstancePage {
     async assertProcessVariableIsVisible(variableName, timeout = 30000, maxRetries = 3) {
         for (let retries = 0; retries < maxRetries; retries++) {
             try {
-                await (0, test_1.expect)(this.connectorResultVariableName(variableName)).toBeVisible({ timeout: timeout });
+                await (0, test_1.expect)(this.connectorResultVariableName(variableName)).toBeVisible({ timeout });
                 return;
             }
             catch (error) {
-                console.log(`Variable ${variableName} is not visible yet (attempt ${retries + 1}): ${error}`);
-                await this.page.reload();
-                await (0, sleep_1.sleep)(10000);
+                console.log(`Variable ${variableName} is not visible yet (attempt ${retries + 1}/${maxRetries}): ${error}`);
+                if (retries < maxRetries - 1) {
+                    await this.reload();
+                    await this.variablesList.waitFor({ state: 'visible', timeout });
+                }
             }
         }
         throw new Error(`Variable ${variableName} was not visible after ${maxRetries} attempts.`);

package/dist/pages/8.10/UtilitiesPage.d.ts

@@ -49,6 +49,7 @@ export declare function deleteCluster(clusterName: string, homePage: HomePage, c
 export declare function modelAndRunConnectorsDocHandlingDiagram(modelerCreatePage: ModelerCreatePage, modelerHomePage: ModelerHomePage, processName: string, page: Page, connectorMarketplacePage: ConnectorMarketplacePage, clusterName: string, zeebeUrl: string, zeebeClientId: string, zeebeClientSecret: string): Promise<void>;
 export declare function modelAndRunConnectorsTimerEventDiagram(modelerCreatePage: ModelerCreatePage, modelerHomePage: ModelerHomePage, processName: string, page: Page, connectorMarketplacePage: ConnectorMarketplacePage, clusterName: string, connectorTemplatePage: ConnectorTemplatePage): Promise<void>;
 export declare function createAPIClient(apiClientName: string, homePage: HomePage, clusterDetailsPage: ClusterDetailsPage, clusterName: string, clusterPage: ClusterPage): Promise<void>;
+export declare function ensureDefaultClusterApiCredentials(apiClientName: string, homePage: HomePage, clusterDetailsPage: ClusterDetailsPage, clusterName: string, clusterPage: ClusterPage): Promise<void>;
 export declare function expectCountToBeOneOf(locator: Locator, count1: number, count2: number): Promise<void>;
 export declare function assertTestUsesCorrectOrganizationFromModeler(page: Page): Promise<void>;
 export declare function waitForLoadingToFinish(page: Page, timeout?: number): Promise<void>;

package/dist/pages/8.10/UtilitiesPage.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.waitForLoadingToFinish = exports.assertTestUsesCorrectOrganizationFromModeler = exports.expectCountToBeOneOf = exports.createAPIClient = exports.modelAndRunConnectorsTimerEventDiagram = exports.modelAndRunConnectorsDocHandlingDiagram = exports.deleteCluster = exports.deleteAllUserGroups = exports.assertTestUsesCorrectOrganization = exports.assertLatestAlertEmail = exports.clickInvitationLinkInEmail = exports.enableAuthorizations = exports.disableRBA = exports.goBackWithRetry = exports.runMultipleProcesses = exports.runProcess = exports.completeTaskWithRetry = exports.assertPageTextWithRetry = exports.openAppTabWithRetry = exports.assertLocatorVisibleWithRetry = exports.modelRestConnector = exports.modelDiagramFromFile = exports.withSessionRecovery = exports.isSignedOut = exports.loginWithRetry = void 0;
+exports.waitForLoadingToFinish = exports.assertTestUsesCorrectOrganizationFromModeler = exports.expectCountToBeOneOf = exports.ensureDefaultClusterApiCredentials = exports.createAPIClient = exports.modelAndRunConnectorsTimerEventDiagram = exports.modelAndRunConnectorsDocHandlingDiagram = exports.deleteCluster = exports.deleteAllUserGroups = exports.assertTestUsesCorrectOrganization = exports.assertLatestAlertEmail = exports.clickInvitationLinkInEmail = exports.enableAuthorizations = exports.disableRBA = exports.goBackWithRetry = exports.runMultipleProcesses = exports.runProcess = exports.completeTaskWithRetry = exports.assertPageTextWithRetry = exports.openAppTabWithRetry = exports.assertLocatorVisibleWithRetry = exports.modelRestConnector = exports.modelDiagramFromFile = exports.withSessionRecovery = exports.isSignedOut = exports.loginWithRetry = void 0;
 const test_1 = require("@playwright/test");
 const ModelerHomePage_1 = require("./ModelerHomePage");
 const HomePage_1 = require("./HomePage");
@@ -814,6 +814,35 @@ async function createAPIClient(apiClientName, homePage, clusterDetailsPage, clus
     await clusterDetailsPage.clickCloseModalButton();
 }
 exports.createAPIClient = createAPIClient;
+// The default-cluster ZEEBE_API_* env vars are set by the setup project's
+// "Create Default Cluster" test and reach a spec only through Playwright's
+// dependency env propagation, i.e. within one `playwright test` invocation.
+// Runs that execute a spec without its setup project in that same invocation
+// (the flakiness validate loop and the nightly fix agent's verification loop
+// both pass --no-deps) leave them unset, and every Zeebe API call in the spec
+// then fails before it is made. Provision a client of our own in that case,
+// the same way operate-access-flow.spec.ts does, so a spec that talks to the
+// Zeebe REST API does not depend on how it was launched.
+//
+// Requires `page` to already be logged in to Console as an org admin.
+async function ensureDefaultClusterApiCredentials(apiClientName, homePage, clusterDetailsPage, clusterName, clusterPage) {
+    const required = [
+        'ZEEBE_API_CLIENT_ID',
+        'ZEEBE_API_CLIENT_SECRET',
+        'ZEEBE_API_AUTH_URL',
+        'ZEEBE_API_URL',
+        'ZEEBE_API_TOKEN_AUDIENCE',
+    ];
+    if (required.every((key) => process.env[key])) {
+        return;
+    }
+    console.log('Default-cluster API credentials are not in the environment ' +
+        `(missing: ${required
+            .filter((key) => !process.env[key])
+            .join(', ')}); creating an API client on "${clusterName}".`);
+    await createAPIClient(apiClientName, homePage, clusterDetailsPage, clusterName, clusterPage);
+}
+exports.ensureDefaultClusterApiCredentials = ensureDefaultClusterApiCredentials;
 async function expectCountToBeOneOf(locator, count1, count2) {
     try {
         await Promise.race([

package/dist/pages/8.7/PlayPage.js

@@ -4,6 +4,12 @@ exports.PlayPage = void 0;
 const test_1 = require("@playwright/test");
 const clickLocatorWithRetry_1 = require("../../utils/assertionHelpers/clickLocatorWithRetry");
 const maxWaitTimeSeconds = 180000;
+// The instance-details wait gets its own, larger budget: the old code spent
+// two separate 180s assertions with a page reload between them, so shrinking
+// the total to one 180s pass would have cut the time the step is allowed to
+// take. Keep the generous end-to-end budget (the test is test.slow(), i.e. 36
+// minutes) while polling inside it.
+const instanceDetailsTimeout = 300000;
 class PlayPage {
     page;
     diagram;
@@ -122,44 +128,72 @@ class PlayPage {
         }
     }
     async waitForInstanceDetailsToBeLoaded() {
-        const maxRetries = 2;
-        let attempts = 0;
-        while (attempts < maxRetries) {
-            try {
-                await (0, test_1.expect)(this.page.getByText(/process instance key|instance key/i).first()).toBeVisible({ timeout: maxWaitTimeSeconds });
-                await (0, test_1.expect)(this.page
-                    .getByText(/This process instance has no variables|No variables/i)
-                    .first()).toBeVisible({ timeout: maxWaitTimeSeconds });
-                return;
-            }
-            catch (error) {
-                if (attempts >= maxRetries - 1)
-                    throw error;
-                await this.page.reload();
-                // A reload drops the Modeler back on the Implement tab (the same
-                // trap clickStartInstanceButton's catch block already handles), so
-                // the retry would otherwise wait out its whole 180s budget against
-                // DOM that can never hold the instance details -- which is why the
-                // nightly still failed on "process instance key" despite this loop.
-                // Re-open Play first.
-                if (await this.playTab.isVisible({ timeout: 30000 }).catch(() => false)) {
-                    await this.playTab.click();
-                }
-                // The details panel only renders once an instance exists. The one way
-                // it never rendered is that the start click resolved against a
-                // re-laid-out (briefly detached) overlay and was silently lost --
-                // clickLocatorWithRetry only retries a click that *throws*. Re-issue
-                // the start so the retry has an instance to show; if one is already
-                // running the assertions below simply pass on it.
-                const startTrigger = this.configureTestPanelStartButton
-                    .or(this.startInstanceOverlayButton)
-                    .first();
-                if (await startTrigger.isVisible({ timeout: 30000 }).catch(() => false)) {
-                    await this.clickStartInstanceButton();
+        const instanceKeyHeader = this.page
+            .getByText(/process instance key|instance key/i)
+            .first();
+        const noVariablesMessage = this.page
+            .getByText(/This process instance has no variables|No variables/i)
+            .first();
+        // A Start trigger that is STILL on screen is positive proof that no
+        // instance was ever created: camunda-hub test-studio's ConfigureTestCaseStep
+        // returns null as soon as `processInstanceKey !== undefined`, while
+        // InstanceHeader returns null for as long as it is undefined -- the panel
+        // and the header are mutually exclusive. So the recovery here is to
+        // re-issue the start click, not to reload: `clickLocatorWithRetry` only
+        // retries a click that *throws*, so a click that resolved against a
+        // re-laid-out overlay is lost silently and the sole symptom is this
+        // locator timing out with "element(s) not found" -- exactly the nightly
+        // failure. Re-clicking cannot pile up requests because the product
+        // disables the button while a start is in flight (`isStartingInstance`).
+        //
+        // The previous recovery called `page.reload()` first, which is the very
+        // trap the surrounding comments document: a reload resets test-mode state
+        // and drops the Modeler back on the Implement tab, so the configure panel
+        // needs the whole setup chain (checkExistingDeployment -> deploy step ->
+        // configure step) to re-run before a Start button exists again. The 30s
+        // probe that followed regularly expired before that, no start was
+        // re-issued, and the second attempt then waited out its full budget
+        // against DOM that could never hold the instance details.
+        const startTrigger = this.configureTestPanelStartButton
+            .or(this.startInstanceOverlayButton)
+            .first();
+        // A start the backend rejects raises a notification instead of creating an
+        // instance (camunda-hub test-studio `useStartInstance` -> `notify.error`
+        // with REQUEST_FAILURE / MISSING_PERMISSIONS). Name it in the failure
+        // message so the next occurrence is diagnosable from the report alone
+        // instead of reporting a bare "element(s) not found".
+        const startErrorNotification = this.page
+            .getByText(/Unable to process request|Missing permissions/i)
+            .first();
+        // Grace period before the first re-click, so we never fire a second start
+        // during the brief window where the first one is already in flight but the
+        // panel has not unmounted yet.
+        const recoveryGraceMs = 30000;
+        const startedAt = Date.now();
+        await (0, test_1.expect)(async () => {
+            const hasInstance = await instanceKeyHeader
+                .isVisible()
+                .catch(() => false);
+            if (!hasInstance && Date.now() - startedAt > recoveryGraceMs) {
+                const canRestart = (await startTrigger.isVisible().catch(() => false)) &&
+                    (await startTrigger.isEnabled().catch(() => false));
+                if (canRestart) {
+                    await startTrigger.click({ timeout: 30000 });
                 }
-                attempts++;
             }
-        }
+            const reportedError = (await startErrorNotification
+                .isVisible()
+                .catch(() => false))
+                ? await startErrorNotification.innerText()
+                : undefined;
+            await (0, test_1.expect)(instanceKeyHeader, reportedError === undefined
+                ? 'Play never rendered the process instance header'
+                : `Play reported: ${reportedError}`).toBeVisible({ timeout: 15000 });
+            await (0, test_1.expect)(noVariablesMessage).toBeVisible({ timeout: 15000 });
+        }).toPass({
+            timeout: instanceDetailsTimeout,
+            intervals: [2000, 5000, 10000],
+        });
     }
     async waitForNextElementToBeActive(historyItem) {
         // Same lost-click hazard waitForProcessToBeCompleted documents for the

package/dist/tests/8.10/aws-connectors-user-flows.spec.js

@@ -54,13 +54,26 @@ let authToken;
 _8_10_1.test.describe.configure({ mode: 'parallel' });
 _8_10_1.test.describe('AWS Connectors User Flows', () => {
     const clusterName = 'Test Cluster';
-    _8_10_1.test.beforeAll(async () => {
-        authToken = await (0, apiHelpers_1.authSaasAPI)();
-    });
-    _8_10_1.test.beforeEach(async ({ page, appsPage, loginPage }, testInfo) => {
+    // The Zeebe token is taken here rather than in a beforeAll because
+    // ensureDefaultClusterApiCredentials needs a logged-in Console page, which
+    // only exists once the test-scoped fixtures are up. It is a no-op whenever
+    // the setup project already put the credentials in the environment (the
+    // nightly's path), so this only costs anything on runs launched without it.
+    _8_10_1.test.beforeEach(async ({ page, appsPage, loginPage, homePage, clusterPage, clusterDetailsPage, operateHomePage, }, testInfo) => {
         await (0, UtilitiesPage_1.loginWithRetry)(page, loginPage, testUser, (testInfo.workerIndex + 1) * 1000);
-        await appsPage.clickCamundaApps();
-        await appsPage.clickOperate(clusterName);
+        await (0, UtilitiesPage_1.ensureDefaultClusterApiCredentials)('AWS_Connectors_API_Client' + (await (0, _setup_1.generateRandomStringAsync)(3)), homePage, clusterDetailsPage, clusterName, clusterPage);
+        authToken = await (0, apiHelpers_1.authSaasAPI)();
+        // Gate the hand-off on Operate's own banner instead of returning as soon
+        // as the apps-menu click resolves, which is all `clickOperate` does. A
+        // hand-off that never landed leaves the tab on the page it started from
+        // — here the Console cluster-details view the API-client step above ends
+        // on — and the test then hunts for Operate's nav on a page that is not
+        // Operate. That is exactly what "Failed to click locator
+        // getByRole('link', { name: 'Processes', exact: true }) after 5
+        // attempts" reported here 3/3, and the failure `openOperateWithRetry`
+        // exists to catch: it re-enters through the apps menu until Operate
+        // itself is up, the same way smoke-tests.spec.ts does for this hop.
+        await appsPage.openOperateWithRetry(operateHomePage.operateBanner, clusterName);
     });
     _8_10_1.test.afterEach(async ({ page }, testInfo) => {
         await (0, _setup_1.captureScreenshot)(page, testInfo);

package/dist/utils/apiHelpers.js

@@ -125,6 +125,29 @@ exports.retryOnTransientApiError = retryOnTransientApiError;
 // ---- Cluster Credentials Helper ----
 function getClusterCredentials(clusterType) {
     if (!clusterType) {
+        // These are produced by the setup project ("Create Default Cluster" ->
+        // createAPIClientAndReturnVariables) and reach a spec through Playwright's
+        // dependency env propagation, which only spans a single `playwright test`
+        // invocation. A run that executes a spec WITHOUT its setup project in the
+        // same invocation -- the flakiness validate loop and the nightly fix
+        // agent's verification loop both pass --no-deps -- sees them unset. Say so
+        // here: leaving the non-null assertions in place meant `undefined` reached
+        // apiRequestContext.post(), whose "First argument must be either URL
+        // string or Request" names neither the variable nor the cause.
+        const missing = [
+            'ZEEBE_API_CLIENT_ID',
+            'ZEEBE_API_CLIENT_SECRET',
+            'ZEEBE_API_AUTH_URL',
+            'ZEEBE_API_URL',
+            'ZEEBE_API_TOKEN_AUDIENCE',
+        ].filter((key) => !process.env[key]);
+        if (missing.length > 0) {
+            throw new Error(`Default-cluster credentials not found: ${missing.join(', ')} unset. ` +
+                'They are set by the test-setup project and only propagate to runs ' +
+                'that include it; provision an API client first (see ' +
+                'ensureDefaultClusterApiCredentials in pages/<version>/' +
+                'UtilitiesPage.ts).');
+        }
         return {
             clientId: process.env.ZEEBE_API_CLIENT_ID,
             clientSecret: process.env.ZEEBE_API_CLIENT_SECRET,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/e2e-test-suite",
-  "version": "0.0.1157",
+  "version": "0.0.1159",
   "description": "End-to-end test helpers for Camunda 8",
   "repository": {
     "type": "git",