@camunda/e2e-test-suite 0.0.1156 → 0.0.1158

package/dist/pages/8.7/PlayPage.js

@@ -4,6 +4,12 @@ exports.PlayPage = void 0;
 const test_1 = require("@playwright/test");
 const clickLocatorWithRetry_1 = require("../../utils/assertionHelpers/clickLocatorWithRetry");
 const maxWaitTimeSeconds = 180000;
+// The instance-details wait gets its own, larger budget: the old code spent
+// two separate 180s assertions with a page reload between them, so shrinking
+// the total to one 180s pass would have cut the time the step is allowed to
+// take. Keep the generous end-to-end budget (the test is test.slow(), i.e. 36
+// minutes) while polling inside it.
+const instanceDetailsTimeout = 300000;
 class PlayPage {
     page;
     diagram;
@@ -122,44 +128,72 @@ class PlayPage {
         }
     }
     async waitForInstanceDetailsToBeLoaded() {
-        const maxRetries = 2;
-        let attempts = 0;
-        while (attempts < maxRetries) {
-            try {
-                await (0, test_1.expect)(this.page.getByText(/process instance key|instance key/i).first()).toBeVisible({ timeout: maxWaitTimeSeconds });
-                await (0, test_1.expect)(this.page
-                    .getByText(/This process instance has no variables|No variables/i)
-                    .first()).toBeVisible({ timeout: maxWaitTimeSeconds });
-                return;
-            }
-            catch (error) {
-                if (attempts >= maxRetries - 1)
-                    throw error;
-                await this.page.reload();
-                // A reload drops the Modeler back on the Implement tab (the same
-                // trap clickStartInstanceButton's catch block already handles), so
-                // the retry would otherwise wait out its whole 180s budget against
-                // DOM that can never hold the instance details -- which is why the
-                // nightly still failed on "process instance key" despite this loop.
-                // Re-open Play first.
-                if (await this.playTab.isVisible({ timeout: 30000 }).catch(() => false)) {
-                    await this.playTab.click();
-                }
-                // The details panel only renders once an instance exists. The one way
-                // it never rendered is that the start click resolved against a
-                // re-laid-out (briefly detached) overlay and was silently lost --
-                // clickLocatorWithRetry only retries a click that *throws*. Re-issue
-                // the start so the retry has an instance to show; if one is already
-                // running the assertions below simply pass on it.
-                const startTrigger = this.configureTestPanelStartButton
-                    .or(this.startInstanceOverlayButton)
-                    .first();
-                if (await startTrigger.isVisible({ timeout: 30000 }).catch(() => false)) {
-                    await this.clickStartInstanceButton();
+        const instanceKeyHeader = this.page
+            .getByText(/process instance key|instance key/i)
+            .first();
+        const noVariablesMessage = this.page
+            .getByText(/This process instance has no variables|No variables/i)
+            .first();
+        // A Start trigger that is STILL on screen is positive proof that no
+        // instance was ever created: camunda-hub test-studio's ConfigureTestCaseStep
+        // returns null as soon as `processInstanceKey !== undefined`, while
+        // InstanceHeader returns null for as long as it is undefined -- the panel
+        // and the header are mutually exclusive. So the recovery here is to
+        // re-issue the start click, not to reload: `clickLocatorWithRetry` only
+        // retries a click that *throws*, so a click that resolved against a
+        // re-laid-out overlay is lost silently and the sole symptom is this
+        // locator timing out with "element(s) not found" -- exactly the nightly
+        // failure. Re-clicking cannot pile up requests because the product
+        // disables the button while a start is in flight (`isStartingInstance`).
+        //
+        // The previous recovery called `page.reload()` first, which is the very
+        // trap the surrounding comments document: a reload resets test-mode state
+        // and drops the Modeler back on the Implement tab, so the configure panel
+        // needs the whole setup chain (checkExistingDeployment -> deploy step ->
+        // configure step) to re-run before a Start button exists again. The 30s
+        // probe that followed regularly expired before that, no start was
+        // re-issued, and the second attempt then waited out its full budget
+        // against DOM that could never hold the instance details.
+        const startTrigger = this.configureTestPanelStartButton
+            .or(this.startInstanceOverlayButton)
+            .first();
+        // A start the backend rejects raises a notification instead of creating an
+        // instance (camunda-hub test-studio `useStartInstance` -> `notify.error`
+        // with REQUEST_FAILURE / MISSING_PERMISSIONS). Name it in the failure
+        // message so the next occurrence is diagnosable from the report alone
+        // instead of reporting a bare "element(s) not found".
+        const startErrorNotification = this.page
+            .getByText(/Unable to process request|Missing permissions/i)
+            .first();
+        // Grace period before the first re-click, so we never fire a second start
+        // during the brief window where the first one is already in flight but the
+        // panel has not unmounted yet.
+        const recoveryGraceMs = 30000;
+        const startedAt = Date.now();
+        await (0, test_1.expect)(async () => {
+            const hasInstance = await instanceKeyHeader
+                .isVisible()
+                .catch(() => false);
+            if (!hasInstance && Date.now() - startedAt > recoveryGraceMs) {
+                const canRestart = (await startTrigger.isVisible().catch(() => false)) &&
+                    (await startTrigger.isEnabled().catch(() => false));
+                if (canRestart) {
+                    await startTrigger.click({ timeout: 30000 });
                 }
-                attempts++;
             }
-        }
+            const reportedError = (await startErrorNotification
+                .isVisible()
+                .catch(() => false))
+                ? await startErrorNotification.innerText()
+                : undefined;
+            await (0, test_1.expect)(instanceKeyHeader, reportedError === undefined
+                ? 'Play never rendered the process instance header'
+                : `Play reported: ${reportedError}`).toBeVisible({ timeout: 15000 });
+            await (0, test_1.expect)(noVariablesMessage).toBeVisible({ timeout: 15000 });
+        }).toPass({
+            timeout: instanceDetailsTimeout,
+            intervals: [2000, 5000, 10000],
+        });
     }
     async waitForNextElementToBeActive(historyItem) {
         // Same lost-click hazard waitForProcessToBeCompleted documents for the

package/dist/pages/SM-8.10/NavigationPage.js

@@ -56,10 +56,15 @@ class NavigationPage {
         // deleted -- the logo is its own anchor (aria-label="Camunda logo", with
         // an aria-hidden svg) and "Tasklist" moved into the breadcrumb nav, so
         // the legacy shell's combined "Camunda logo Tasklist" name no longer
-        // exists. Match either shell so the banner resolves on both.
+        // exists. Match either shell so the banner resolves on both, and scope
+        // the generic logo-link fallback to Tasklist's orchestration href so it
+        // stays aligned with overridden context paths too.
         this.tasklistPageBanner = page
             .getByRole('navigation', { name: 'Camunda context' })
             .getByRole('link', { name: 'Tasklist', exact: true })
+            .or(page
+            .getByRole('link', { name: 'Camunda logo', exact: true })
+            .and(page.locator(`[href$="${NORMALIZED_ORCHESTRATION_CONTEXT_PATH}/tasklist"]`)))
             .or(page.getByRole('link', { name: 'Camunda logo Tasklist' }))
             .first();
         this.optimizePageBanner = page.getByRole('link', {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/e2e-test-suite",
-  "version": "0.0.1156",
+  "version": "0.0.1158",
   "description": "End-to-end test helpers for Camunda 8",
   "repository": {
     "type": "git",