@camunda/e2e-test-suite 0.0.1031 → 0.0.1032

package/dist/pages/8.8/ModelerHomePage.d.ts

@@ -32,6 +32,7 @@ declare class ModelerHomePage {
     readonly formNameBreadcrumb: (formName: string) => Locator;
     readonly buttonSkipCustomization: Locator;
     constructor(page: Page);
+    dismissBlockingDialog(): Promise<void>;
     dismissOverlays(): Promise<void>;
     clickCreateNewProjectButton(): Promise<void>;
     enterNewProjectName(name: string): Promise<void>;

package/dist/pages/8.8/ModelerHomePage.js

@@ -96,7 +96,19 @@ class ModelerHomePage {
         this.uploadFilesButton = page.getByRole('menuitem', { name: 'Upload files' });
         this.messageBanner = page.locator('[data-test="close-top-banner"]');
         this.dialog = page.getByRole('dialog');
-        this.closeButton = page.getByRole('button', { name: 'Got it - Dismiss' });
+        // Both announcement modals hub stacks over the projects list dismiss
+        // through a "Got it…" footer button: the What's New modal's reads
+        // "Got it - Dismiss", and the migration notice ("Your projects have a new
+        // structure") reads just "Got it".
+        //
+        // Matched as a visible button rather than by role/name: the What's New
+        // modal stays mounted with `open={false}` after it is closed, so its
+        // dismiss button remains in the DOM but hidden, and a role/name match
+        // would resolve both and fail strict mode -- reporting "nothing to
+        // dismiss" while the migration notice is still covering the projects list.
+        this.closeButton = page
+            .locator('button:visible', { hasText: /^Got it/ })
+            .first();
         this.optionsButton = page.getByRole('button', { name: 'Options' });
         this.formNameBreadcrumb = (formName) => page.locator('button[data-test="breadcrumb-form"]', {
             hasText: formName,
@@ -105,7 +117,39 @@ class ModelerHomePage {
             name: 'Skip customization',
         });
     }
+    // An announcement dialog renders over the projects list and swallows every
+    // click on it: Playwright reports the project link as visible, enabled and
+    // stable, then times out with the modal overlay "intercepts pointer events".
+    // Pressing Escape blindly does not help -- Carbon only closes the dialog when
+    // focus is inside it, and focus sits on the body after a page load -- so
+    // close it via its own dismiss button and confirm it is gone.
+    //
+    // The dialog is mounted a beat after the projects list, so let the page
+    // settle before looking for it, and re-probe after each close: hub can stack
+    // the What's New modal and the migration notice, and closing one reveals the
+    // next.
+    async dismissBlockingDialog() {
+        await this.page
+            .waitForLoadState('networkidle', { timeout: 15000 })
+            .catch(() => false);
+        for (let attempt = 0; attempt < 3; attempt++) {
+            const isOpen = await this.closeButton
+                .waitFor({ state: 'visible', timeout: 10000 })
+                .then(() => true)
+                .catch(() => false);
+            if (!isOpen)
+                return;
+            await this.closeButton.click({ timeout: 5000 }).catch(() => { });
+            await this.closeButton
+                .waitFor({ state: 'hidden', timeout: 5000 })
+                .catch(() => false);
+        }
+    }
     async dismissOverlays() {
+        // Before the generic pass: clickMessageBanner and the loop below resolve
+        // `.or(...).first()` unions in DOM order, where the top banner comes first,
+        // so on their own they close the banner and leave the dialog open.
+        await this.dismissBlockingDialog();
         for (const locator of [
             this.closeButton,
             this.page.getByRole('button', { name: 'Close' }).first(),
@@ -147,6 +191,11 @@ class ModelerHomePage {
             if (await committedProjectName.first().isVisible()) {
                 return;
             }
+            // The rename runs on a freshly created project, which is exactly when an
+            // announcement dialog mounts on top of it: it takes focus, the inline
+            // editor unmounts, and the click below then waits out its whole timeout
+            // on an element that never comes back.
+            await this.dismissOverlays();
             await this.projectNameInput.first().click({ timeout: 15000 });
             await this.projectNameInput.first().fill(name);
             // Confirm the value actually landed in the edit field before committing;
@@ -397,12 +446,17 @@ class ModelerHomePage {
                 .catch(() => { });
         }
     }
+    // An announcement dialog covering the Modeler header makes every click on the
+    // org button bounce off the modal layer ("intercepts pointer events") until
+    // the timeout, so dismiss overlays before each attempt.
     async clickOpenOrganizationsButton() {
-        await (0, sleep_1.sleep)(5000);
-        await (0, test_1.expect)(this.openOrganizationsButton).toBeVisible({
-            timeout: 10000,
+        await (0, clickLocatorWithRetry_1.clickLocatorWithRetry)(this.page, this.openOrganizationsButton, {
+            preAction: async () => {
+                await this.dismissOverlays();
+            },
+            totalTimeout: 120000,
+            visibilityTimeout: 30000,
         });
-        await this.openOrganizationsButton.click({ timeout: 30000 });
     }
     async createForm(formName) {
         const maxRetries = 3;
@@ -429,24 +483,19 @@ class ModelerHomePage {
     async clickCrossComponentProjectFolder() {
         await (0, clickLocatorWithRetry_1.clickLocatorWithRetry)(this.page, this.crossComponentProjectFolder, {
             visibilityTimeout: 60000,
-            totalTimeout: 180000,
+            // Widened from 180s: dismissing the announcement dialog costs up to ~25s
+            // of settle-and-probe per attempt, which at 180s left room for barely one
+            // retry after an intercepted click had already burnt its 60s.
+            totalTimeout: 240000,
             maxRetries: 5,
             preAction: async () => {
-                // A Carbon modal (`.cds--modal.is-visible`) sometimes covers the
-                // project folder and intercepts pointer events; clickMessageBanner
-                // only handles a single banner/close button so it doesn't dismiss
-                // the modal. Escape it explicitly first — same pattern 8.7 already
-                // uses for the same symptom.
-                try {
-                    const blockingModal = this.page.locator('.cds--modal.is-visible');
-                    if ((await blockingModal.count()) > 0) {
-                        await this.page.keyboard.press('Escape');
-                        await (0, sleep_1.sleep)(1000);
-                    }
-                }
-                catch {
-                    // No blocking modal to dismiss
-                }
+                // Dismiss the dialog BEFORE the banner: the Modeler home page can
+                // stack both at once, and clickMessageBanner resolves an
+                // `.or(...).first()` union in DOM order — the top banner comes first,
+                // so on its own it closes the banner and leaves the dialog open. The
+                // previous press-Escape-on-any-visible-modal handling could not close
+                // it at all: the migration notice ignores Escape.
+                await this.dismissBlockingDialog();
                 await this.clickMessageBanner();
             },
             postAction: async () => {

package/dist/pages/8.9/ModelerHomePage.d.ts

@@ -31,6 +31,7 @@ declare class ModelerHomePage {
     readonly optionsButton: Locator;
     readonly formNameBreadcrumb: (formName: string) => Locator;
     constructor(page: Page);
+    dismissBlockingDialog(): Promise<void>;
     dismissOverlays(): Promise<void>;
     clickCreateNewProjectButton(): Promise<void>;
     enterNewProjectName(name: string): Promise<void>;

package/dist/pages/8.9/ModelerHomePage.js

@@ -100,13 +100,58 @@ class ModelerHomePage {
         this.uploadFilesButton = page.getByRole('menuitem', { name: 'Upload files' });
         this.messageBanner = page.locator('[data-test="close-top-banner"]');
         this.dialog = page.getByRole('dialog');
-        this.closeButton = page.getByRole('button', { name: 'Got it - Dismiss' });
+        // Both announcement modals hub stacks over the projects list dismiss
+        // through a "Got it…" footer button: the What's New modal's reads
+        // "Got it - Dismiss", and the migration notice ("Your projects have a new
+        // structure") reads just "Got it".
+        //
+        // Matched as a visible button rather than by role/name: the What's New
+        // modal stays mounted with `open={false}` after it is closed, so its
+        // dismiss button remains in the DOM but hidden, and a role/name match
+        // would resolve both and fail strict mode -- reporting "nothing to
+        // dismiss" while the migration notice is still covering the projects list.
+        this.closeButton = page
+            .locator('button:visible', { hasText: /^Got it/ })
+            .first();
         this.optionsButton = page.getByRole('button', { name: 'Options' });
         this.formNameBreadcrumb = (formName) => page.locator('button[data-test="breadcrumb-form"]', {
             hasText: formName,
         });
     }
+    // An announcement dialog renders over the projects list and swallows every
+    // click on it: Playwright reports the project link as visible, enabled and
+    // stable, then times out with the modal overlay "intercepts pointer events".
+    // Pressing Escape blindly does not help -- Carbon only closes the dialog when
+    // focus is inside it, and focus sits on the body after a page load -- so
+    // close it via its own dismiss button and confirm it is gone.
+    //
+    // The dialog is mounted a beat after the projects list, so let the page
+    // settle before looking for it, and re-probe after each close: hub can stack
+    // the What's New modal and the migration notice, and closing one reveals the
+    // next.
+    async dismissBlockingDialog() {
+        await this.page
+            .waitForLoadState('networkidle', { timeout: 15000 })
+            .catch(() => false);
+        for (let attempt = 0; attempt < 3; attempt++) {
+            const isOpen = await this.closeButton
+                .waitFor({ state: 'visible', timeout: 10000 })
+                .then(() => true)
+                .catch(() => false);
+            if (!isOpen)
+                return;
+            await this.closeButton.click({ timeout: 5000 }).catch(() => { });
+            await this.closeButton
+                .waitFor({ state: 'hidden', timeout: 5000 })
+                .catch(() => false);
+        }
+    }
     async dismissOverlays() {
+        // Before the generic pass: the loop below closes whichever overlay it finds
+        // and moves on, so a single pass leaves a stacked announcement dialog open,
+        // and every caller that relies on dismissOverlays() to clear the page then
+        // clicks into it.
+        await this.dismissBlockingDialog();
         for (const locator of [
             this.closeButton,
             this.page.getByRole('button', { name: 'Close' }).first(),
@@ -141,6 +186,11 @@ class ModelerHomePage {
             if (await this.page.getByTitle(name, { exact: true }).isVisible()) {
                 return;
             }
+            // The rename runs on a freshly created project, which is exactly when an
+            // announcement dialog mounts on top of it: it takes focus, the inline
+            // editor unmounts, and the click below then waits out its whole timeout
+            // on an element that never comes back.
+            await this.dismissBlockingDialog();
             await this.projectNameInput.click({ timeout: 60000 });
             await this.projectNameInput.fill(name);
             await this.projectNameInput.press('Enter');
@@ -342,12 +392,18 @@ class ModelerHomePage {
             await this.page.getByText('Home', { exact: true }).first().click();
         }
     }
+    // An announcement dialog covering the Modeler header makes every click on the
+    // org button bounce off the modal layer ("intercepts pointer events") until
+    // the timeout, so dismiss it before each attempt instead of waiting out a
+    // fixed sleep and hoping the header is clear.
     async clickOpenOrganizationsButton() {
-        await (0, sleep_1.sleep)(5000);
-        await (0, test_1.expect)(this.openOrganizationsButton).toBeVisible({
-            timeout: 10000,
+        await (0, clickLocatorWithRetry_1.clickLocatorWithRetry)(this.page, this.openOrganizationsButton, {
+            preAction: async () => {
+                await this.dismissBlockingDialog();
+            },
+            totalTimeout: 120000,
+            visibilityTimeout: 30000,
         });
-        await this.openOrganizationsButton.click({ timeout: 30000 });
     }
     async createForm(formName) {
         await this.clickDiagramTypeDropdown();
@@ -361,26 +417,19 @@ class ModelerHomePage {
     async clickCrossComponentProjectFolder() {
         await (0, clickLocatorWithRetry_1.clickLocatorWithRetry)(this.page, this.crossComponentProjectFolder, {
             visibilityTimeout: 60000,
-            totalTimeout: 180000,
+            // Widened from 180s: dismissing the announcement dialog costs up to ~25s
+            // of settle-and-probe per attempt, which at 180s left room for barely one
+            // retry after an intercepted click had already burnt its 60s.
+            totalTimeout: 240000,
             maxRetries: 5,
             preAction: async () => {
-                // A Carbon modal (`.cds--modal.is-visible`) sometimes covers the
-                // project folder and intercepts pointer events. Escape it explicitly
-                // first — same pattern 8.7 already uses for the same symptom.
-                try {
-                    const blockingModal = this.page.locator('.cds--modal.is-visible');
-                    if ((await blockingModal.count()) > 0) {
-                        await this.page.keyboard.press('Escape');
-                        await (0, sleep_1.sleep)(1000);
-                    }
-                }
-                catch {
-                    // No blocking modal to dismiss
-                }
                 // dismissOverlays, not clickMessageBanner: the latter resolves
                 // `messageBanner.or(closeButton).first()`, so with a top banner on
                 // screen it always picks the banner and leaves any dialog in place.
-                // dismissOverlays walks every overlay control in turn instead.
+                // dismissOverlays closes the announcement dialog first, then walks
+                // every other overlay control in turn. The previous
+                // press-Escape-on-any-visible-modal handling could not close the
+                // migration notice at all: it ignores Escape.
                 await this.dismissOverlays();
             },
             postAction: async () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/e2e-test-suite",
-  "version": "0.0.1031",
+  "version": "0.0.1032",
   "description": "End-to-end test helpers for Camunda 8",
   "repository": {
     "type": "git",