@camunda/e2e-test-suite 0.0.1021 → 0.0.1022

package/dist/pages/8.7/ClusterSecretsPage.d.ts

@@ -16,6 +16,7 @@ declare class ClusterSecretsPage {
     readonly confirmDeleteInput: Locator;
     constructor(page: Page);
     deleteConnectorSecretsIfExist(): Promise<void>;
+    private dismissOpenModal;
     clickCreateNewSecretButton(clusterName: string): Promise<void>;
     clickClusterBanner(): Promise<void>;
     clickCluster(name: string): Promise<void>;

package/dist/pages/8.7/ClusterSecretsPage.js

@@ -38,14 +38,25 @@ class ClusterSecretsPage {
             name: 'Delete',
             exact: true,
         });
-        this.deleteConnectorSecretSubButton = page.getByRole('button', {
-            name: 'danger Delete',
-        });
+        // The confirmation modal's destructive action is a plain "Delete" button
+        // (Console renders Carbon's ModalFooter danger button, whose accessible
+        // name is just its label). The old 'danger Delete' name came from a Carbon
+        // version that prefixed danger buttons with a visually-hidden kind label;
+        // it matches nothing today, so the click timed out and left the modal open
+        // on top of the page. Scoped to the dialog so it cannot collide with the
+        // row-level Delete control behind it.
+        this.deleteConnectorSecretSubButton = page
+            .getByRole('dialog')
+            .getByRole('button', { name: 'Delete', exact: true });
         this.dialog = page.getByRole('dialog');
         this.clusterBanner = this.page
             .getByRole('banner')
             .getByRole('link', { name: 'Clusters' });
-        this.clusterLink = (name) => page.getByRole('link', { name: name });
+        // exact: true because console-user-flows.spec.ts creates a second cluster
+        // called "UI Test Cluster" in the same org -- a substring match on
+        // "Test Cluster" then resolves to both links and fails on strict mode.
+        // ClusterPage's own cluster locators already match exactly.
+        this.clusterLink = (name) => page.getByRole('link', { name: name, exact: true });
         this.clusterSecretTab = this.page.getByRole('tab', {
             name: 'Connector Secrets',
         });
@@ -95,13 +106,39 @@ class ClusterSecretsPage {
                     break;
                 }
             }
-            await (0, test_1.expect)(this.optionsButton).not.toBeVisible({
-                timeout: 30000,
-            });
+            // Console auto-provisions CAMUNDA_PROVIDED_LLM_* secrets whose Delete
+            // menu item is disabled, so the table is never empty once the sweep is
+            // done. A page-wide not.toBeVisible() therefore matched three Options
+            // buttons at once (strict mode violation) while asserting something that
+            // is no longer true. The post-condition this helper actually owns is
+            // that nothing *deletable* is left behind.
+            const deletableSecretRows = this.page
+                .getByRole('row')
+                .filter({ has: this.page.getByRole('cell', { name: 'Options' }) })
+                .filter({ hasNotText: 'CAMUNDA_PROVIDED_' });
+            await (0, test_1.expect)(deletableSecretRows).toHaveCount(0, { timeout: 30000 });
         }
         catch (error) {
             console.error('Error during Connector Secrets deletion: ', error);
+            // A half-completed delete leaves Carbon's confirmation modal on screen,
+            // where its overlay swallows pointer events for every later click -- the
+            // next "Create new secret" click then burns its whole timeout against
+            // the overlay instead of the button. Cleanup must never hand the page
+            // back with a modal still open.
+            await this.dismissOpenModal();
+        }
+    }
+    // Closes whichever Carbon modal is currently on screen, and waits for it to
+    // actually leave the DOM rather than assuming a fixed delay.
+    async dismissOpenModal() {
+        const openModal = this.page.locator('.cds--modal.is-visible');
+        if ((await openModal.count().catch(() => 0)) === 0) {
+            return;
         }
+        await this.page.keyboard.press('Escape').catch(() => { });
+        await (0, test_1.expect)(openModal)
+            .toHaveCount(0, { timeout: 10000 })
+            .catch(() => { });
     }
     async clickCreateNewSecretButton(clusterName) {
         try {
@@ -118,16 +155,7 @@ class ClusterSecretsPage {
         }
     }
     async clickClusterBanner() {
-        try {
-            const blockingModal = this.page.locator('.cds--modal.is-visible');
-            if ((await blockingModal.count()) > 0) {
-                await this.page.keyboard.press('Escape');
-                await (0, sleep_1.sleep)(1000);
-            }
-        }
-        catch (_e) {
-            // no blocking modal to dismiss
-        }
+        await this.dismissOpenModal();
         await (0, test_1.expect)(this.clusterBanner).toBeVisible({ timeout: 30000 });
         await this.clusterBanner.click({ timeout: 60000 });
     }

package/dist/pages/8.7/UtilitiesPage.js

@@ -89,8 +89,14 @@ async function modelRestConnector(modelerCreatePage, connectorSettingsPage, proc
     username: '',
     password: '',
 }) {
+    // 120s to match every other properties-panel wait in the 8.7 suite
+    // (modelJobWorkerDiagram, clickDiagramBreadcrumb and the specs' own waits all
+    // allow 90-200s). 30s was the lone outlier here and the bpmn-js properties
+    // panel regularly needs longer than that to mount on a freshly created
+    // diagram, which failed the REST connector flows before a single element was
+    // modelled.
     await (0, test_1.expect)(modelerCreatePage.generalPanel).toBeVisible({
-        timeout: 30000,
+        timeout: 120000,
     });
     await modelerCreatePage.enterDiagramName(processName);
     await (0, sleep_1.sleep)(10000);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camunda/e2e-test-suite",
-  "version": "0.0.1021",
+  "version": "0.0.1022",
   "description": "End-to-end test helpers for Camunda 8",
   "repository": {
     "type": "git",