@camstack/server 1.2.74 → 1.2.75

package/dist/agent/builtins-seed.js

@@ -0,0 +1,84 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.seedBuiltinsFromClosure = seedBuiltinsFromClosure;
+/**
+ * Self-heal the agent's builtins package before the infra scan.
+ *
+ * `bootCoreAddons` scans `config.addonsDir` and nothing else, the image seed
+ * ships no `@camstack/system`, and the running closure's copy is NOT loaded
+ * as an addon — so an agent whose `/data/addons/@camstack/system` is missing
+ * (greenfield container, an operator cleanup, a failed deploy) boots with
+ * zero infrastructure. Before D87 that produced a silently gutted node; with
+ * the D87 guard it produces a crash-loop. Both are wrong answers to a
+ * question the node can answer itself: the closure it is RUNNING carries the
+ * exact builtins package it needs.
+ *
+ * The copy is files-list shaped — `package.json` + `dist` — and NEVER
+ * `node_modules`: a nested `node_modules/@camstack/*` carries its own
+ * `package.json`s, the addon scan discovers those too, and the same addon
+ * initializing twice is a boot abort (measured live 2026-08-08, twice, two
+ * different vehicles).
+ */
+const fs = __importStar(require("node:fs"));
+const path = __importStar(require("node:path"));
+function seedBuiltinsFromClosure(addonsDir, log = console.log, resolveClosurePkg = () => require.resolve('@camstack/system/package.json')) {
+    const target = path.join(addonsDir, '@camstack', 'system');
+    if (fs.existsSync(path.join(target, 'package.json')))
+        return 'present';
+    let closurePkgJson;
+    try {
+        closurePkgJson = resolveClosurePkg();
+    }
+    catch {
+        log('[Agent] builtins seed: @camstack/system not resolvable from the closure — cannot self-heal');
+        return 'unavailable';
+    }
+    const closureRoot = path.dirname(closurePkgJson);
+    const closureDist = path.join(closureRoot, 'dist');
+    if (!fs.existsSync(closureDist)) {
+        log(`[Agent] builtins seed: closure copy at ${closureRoot} has no dist — cannot self-heal`);
+        return 'unavailable';
+    }
+    fs.mkdirSync(target, { recursive: true });
+    fs.copyFileSync(closurePkgJson, path.join(target, 'package.json'));
+    fs.cpSync(closureDist, path.join(target, 'dist'), {
+        recursive: true,
+        filter: (src) => !src.split(path.sep).includes('node_modules'),
+    });
+    log(`[Agent] builtins seed: @camstack/system was missing under ${addonsDir} — ` +
+        `seeded package.json + dist from the running closure (${closureRoot})`);
+    return 'seeded';
+}

package/dist/agent/infra-boot-plan.js

@@ -0,0 +1,45 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.planInfraBoot = planInfraBoot;
+exports.planToResolutions = planToResolutions;
+/**
+ * `log-destination` prefers `hub-forwarder` (ships agent logs to the hub)
+ * over a local winston — mirrors the historical inline choice.
+ */
+function pickCandidate(capName, candidates) {
+    if (capName === 'log-destination') {
+        return candidates.find((a) => a.id === 'hub-forwarder') ?? candidates[0];
+    }
+    return candidates[0];
+}
+function planInfraBoot(addons, infraList) {
+    const initialized = new Set();
+    const steps = [];
+    for (const infra of infraList) {
+        const candidates = addons.filter((a) => a.capabilities.includes(infra.name));
+        const chosen = pickCandidate(infra.name, candidates);
+        if (!chosen) {
+            steps.push({
+                capName: infra.name,
+                required: infra.required,
+                addonId: null,
+                initialize: false,
+            });
+            continue;
+        }
+        const first = !initialized.has(chosen.id);
+        if (first)
+            initialized.add(chosen.id);
+        steps.push({
+            capName: infra.name,
+            required: infra.required,
+            addonId: chosen.id,
+            initialize: first,
+        });
+    }
+    return steps;
+}
+/** Project a plan onto the guard's resolution shape. */
+function planToResolutions(steps) {
+    return steps.map((s) => ({ name: s.capName, required: s.required, addonId: s.addonId }));
+}

package/dist/agent/main.js

@@ -46,6 +46,8 @@ const agent_config_js_1 = require("./agent-config.js");
 const agent_update_service_js_1 = require("./agent-update-service.js");
 const server_management_provider_js_1 = require("../api/core/server-management.provider.js");
 const infra_boot_guard_js_1 = require("./infra-boot-guard.js");
+const infra_boot_plan_js_1 = require("./infra-boot-plan.js");
+const builtins_seed_js_1 = require("./builtins-seed.js");
 const agent_service_js_1 = require("./agent-service.js");
 const agent_group_runner_js_1 = require("./agent-group-runner.js");
 const register_agent_cap_dispatch_js_1 = require("./register-agent-cap-dispatch.js");
@@ -767,6 +769,10 @@ async function startAgent(configPath) {
 // Core infra addons to load on agent — all infra including log-destination (hub-forwarder)
 const AGENT_INFRA = system_1.INFRA_CAPABILITIES;
 async function bootCoreAddons(broker, config, registry, loadedAddons, loggerFactory) {
+    // Self-heal FIRST: a missing builtins package is answerable from the
+    // running closure (see `builtins-seed.ts`) — without this, the D87 guard
+    // below turns a recoverable gap into a crash-loop.
+    (0, builtins_seed_js_1.seedBuiltinsFromClosure)(config.addonsDir);
     // Scan every installed addon package — infra providers may live outside
     // `@camstack/system` (e.g. `@camstack/addon-platform-probe-native`).
     const packageDirs = resolveAddonPackageDirs(config.addonsDir);
@@ -784,30 +790,39 @@ async function bootCoreAddons(broker, config, registry, loadedAddons, loggerFact
             console.warn(`[Agent] Failed to scan ${dir}: ${(0, types_2.errMsg)(err)}`);
         }
     }
-    // Every infra capability and the addon that will serve it — collected as we
-    // go so `assertRequiredInfraResolved` can name ALL missing required caps in
-    // one throw once the pass is done (see `infra-boot-guard.ts`).
-    const resolutions = [];
-    for (const infra of AGENT_INFRA) {
-        const candidates = loader.listAddons().filter((a) => a.declaration.capabilities?.some((c) => {
-            const capName = typeof c === 'string' ? c : c.name;
-            return capName === infra.name;
-        }));
-        // For log-destination, prefer hub-forwarder over winston-logging
-        const addon = infra.name === 'log-destination'
-            ? (candidates.find((a) => a.declaration.id === 'hub-forwarder') ?? candidates[0])
-            : candidates[0];
-        if (!addon) {
+    // Resolution is per-CAPABILITY (the guard names every missing required
+    // cap), initialization is per-ADDON: since D44 one addon legitimately
+    // serves several infra caps (`storage-orchestrator` owns both `storage`
+    // and `settings-store`), and initializing it once per capability
+    // re-registers the same provider — a boot abort by the registry's own
+    // double-registration error. That combination took both agents down on
+    // 2026-08-08 the moment D87 promoted infra failures to fatal. The plan
+    // makes the dedupe explicit and testable (see `infra-boot-plan.ts`).
+    const byId = new Map(loader.listAddons().map((a) => [a.declaration.id, a]));
+    const plan = (0, infra_boot_plan_js_1.planInfraBoot)(loader.listAddons().map((a) => ({
+        id: a.declaration.id,
+        capabilities: (a.declaration.capabilities ?? []).map((c) => typeof c === 'string' ? c : c.name),
+    })), AGENT_INFRA);
+    const resolutions = (0, infra_boot_plan_js_1.planToResolutions)(plan);
+    for (const step of plan) {
+        if (step.addonId === null) {
             // Say it per-capability (an OPTIONAL miss is the only thing this line
-            // will ever report once the guard below is in place), then record the
-            // miss so the required ones abort boot together rather than one at a
-            // time.
-            console.error(`[Agent] Infrastructure addon for "${infra.name}" not found`);
-            resolutions.push({ name: infra.name, required: infra.required, addonId: null });
+            // will ever report given the guard below); the required ones abort
+            // boot together after the pass.
+            console.error(`[Agent] Infrastructure addon for "${step.capName}" not found`);
             continue;
         }
+        if (!step.initialize) {
+            // Served by an addon an earlier capability already booted — the
+            // entry exists so a deployment missing it fails loudly, not to boot
+            // the addon twice.
+            console.log(`[Agent] Infra capability "${step.capName}" served by already-booted "${step.addonId}"`);
+            continue;
+        }
+        const addon = byId.get(step.addonId);
+        if (!addon)
+            continue;
         const addonId = addon.declaration.id;
-        resolutions.push({ name: infra.name, required: infra.required, addonId });
         try {
             const instance = new addon.addonClass();
             // Seed ctx.kernel.storage from whatever storage provider is already
@@ -845,7 +860,7 @@ async function bootCoreAddons(broker, config, registry, loadedAddons, loggerFact
         catch (err) {
             const msg = (0, types_2.errMsg)(err);
             console.error(`[Agent] Failed to initialize core addon "${addonId}": ${msg}`);
-            if (infra.required) {
+            if (step.required) {
                 throw new Error(`Required infrastructure addon "${addonId}" failed: ${msg}`, { cause: err });
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camstack/server",
-  "version": "1.2.74",
+  "version": "1.2.75",
   "private": false,
   "files": [
     "dist",