@camstack/server 1.2.16 → 1.2.17

package/dist/core/addon/addon-registry.service.js

@@ -34,6 +34,7 @@ var __importStar = (this && this.__importStar) || (function () {
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.AddonRegistryService = void 0;
+exports.shouldEvictMissingOnDisk = shouldEvictMissingOnDisk;
 exports.shouldEmitProviderRegisteredReady = shouldEmitProviderRegisteredReady;
 /* eslint-disable @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access -- pre-existing lint debt across this 2200-line orchestration class. The flagged sites (StorageService.setLocationManager / setSettingsBackend, LoggingService.addDestination, RouteRegistry, etc.) are typed as `unknown` by their owning services to break circular construction-order dependencies; runtime contracts are validated structurally. Tracked separately; do not amend in unrelated edits. */
 const os = __importStar(require("node:os"));
@@ -55,6 +56,20 @@ const addon_settings_provider_js_1 = require("./addon-settings-provider.js");
 const addon_call_gateway_js_1 = require("./addon-call-gateway.js");
 const system_6 = require("@camstack/system");
 const types_2 = require("@camstack/types");
+/**
+ * Decide whether an in-memory addon entry should be evicted because it is no
+ * longer on disk (the uninstall path in `loadNewAddons`).
+ *
+ * A `@camstack/system` builtin is NEVER evicted here: the fresh loader scans
+ * `addonsDir` only (no `['@camstack/system']` closure include), so builtins
+ * are never in `onDiskIds`, and their lifecycle is the server closure
+ * (single-copy model), not the data/addons uninstall path. Omitting this guard
+ * let a deploy of an unrelated addon silently unregister loki-logging on the
+ * live hub.
+ */
+function shouldEvictMissingOnDisk(entry, id, onDiskIds) {
+    return (entry.source === 'installed' && entry.packageName !== '@camstack/system' && !onDiskIds.has(id));
+}
 /**
  * Type predicate: true when an `ISettingsBackend` also satisfies the
  * sync `ISettingsStore` contract (system/addon/device key-value ops)
@@ -2098,11 +2113,10 @@ class AddonRegistryService {
         // D5: every non-core addon lives in its own runner subprocess. The
         // uninstall consolidation is "stop the runner"; the runner exits and
         // re-handshakes the hub WITHOUT the removed addon (D3 machinery).
-        // Only `@camstack/system` builtins — which have no runner — take the
-        // in-process `shutdown()` + disposer-drain path.
+        // `@camstack/system` builtins are excluded — see `shouldEvictMissingOnDisk`.
         const onDiskIds = new Set(freshLoader.listAddons().map((a) => a.declaration.id));
         for (const [id, entry] of this.addonEntries) {
-            if (entry.source === 'installed' && !onDiskIds.has(id)) {
+            if (shouldEvictMissingOnDisk(entry, id, onDiskIds)) {
                 // Unregister capabilities before stopping the addon.
                 for (const cap of entry.declaredCapabilities) {
                     this.capabilityRegistry.unregisterProvider(cap.name, id);
@@ -2130,7 +2144,9 @@ class AddonRegistryService {
                     }
                 }
                 else if (entry.initialized) {
-                    // `@camstack/system` builtin — reload model is in-process.
+                    // Defensive fallback: a non-forked installed addon (every
+                    // non-`@camstack/system` addon forks, and builtins are excluded
+                    // above, so this is not normally reached). Shut it down in-process.
                     try {
                         await entry.addon.shutdown();
                     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camstack/server",
-  "version": "1.2.16",
+  "version": "1.2.17",
   "private": false,
   "files": [
     "dist",
@@ -40,7 +40,7 @@
     "@camstack/addon-notifiers": "1.2.6",
     "@camstack/addon-pipeline": "1.2.13",
     "@camstack/addon-pipeline-orchestrator": "1.2.10",
-    "@camstack/addon-post-analysis": "1.2.11",
+    "@camstack/addon-post-analysis": "1.2.12",
     "@camstack/sdk": "1.2.5",
     "@camstack/shm-ring": "1.1.5",
     "@camstack/system": "1.2.17",