@camstack/server 0.2.2 → 1.0.1

package/src/__tests__/moleculer/uds-unowned-call.spec.ts

@@ -1,383 +0,0 @@
-/**
- * F0 (slice-5 outbound) — hub-side `onUnownedCall` wiring.
- *
- * When a forked hub child issues `ctx.api.<cap>.<method>` for a cap NO local
- * sibling owns, the hub's `LocalChildRegistry` must route it via the parent's
- * `onUnownedCall` handler and return the result over UDS — instead of falling
- * through `UDS_NO_ROUTE` to the child's own broker (which F1+F2 removes).
- *
- * The hub wires the handler in `onModuleInit` as:
- *   createParentUnownedCallHandler({ getResolver: () => this.resolver, broker: this.broker, logger })
- *
- * This test stands up the REAL production handler against:
- *   - a REAL `CapRouteResolver` configured with a hub-in-process provider, to
- *     prove the resolver-first branch resolves a hub cap, AND
- *   - a broker fake exposing a `$`-infra core service (`$core-caps`), to prove
- *     the broker-fallback branch reaches a core service the resolver can't see.
- *
- * We do NOT boot the full MoleculerService (it requires a real broker + DI
- * graph); instead we exercise the exact handler the hub constructs, with the
- * same resolver shape the hub injects, so both branches are covered.
- */
-import { describe, it, expect, vi } from 'vitest'
-import {
-  createParentUnownedCallHandler,
-  CapRouteResolver,
-  CapRouteError,
-  HubNodeRegistry,
-} from '@camstack/kernel'
-import type {
-  NodeCapAuthority,
-  InProcessProviderLookup,
-  CapRouteResolverDeps,
-  NodeNativeCapEntry,
-  HubLocalChildDispatcher,
-  CapCallInput,
-} from '@camstack/kernel'
-import type { ServiceBroker } from 'moleculer'
-
-// A node authority that knows nothing — the only routable thing is the
-// hub-in-process provider injected via inProcessProviders.
-const emptyNodeAuthority: NodeCapAuthority = {
-  nodeKnowsCap: () => false,
-  nodeIsAgent: () => false,
-  nodeOnline: () => false,
-  listNodeIds: () => [],
-  getAddonId: () => null,
-  getAgentChildId: () => null,
-  isNativeCap: () => false,
-}
-
-/**
- * Broker fake exposing the hub's `$core-caps` core service (the bridge for
- * `system`/`addons`/`capabilities`/`nodes` routers) so the broker-fallback
- * branch resolves it. `$core-caps` is NOT a CapabilityRegistry provider, so
- * the resolver returns `no-provider` for it and the fallback runs.
- */
-function hubBrokerFake(): ServiceBroker {
-  const services = [{ name: '$core-caps', nodeID: 'hub', actions: { 'system.info': {} } }]
-  const broker = {
-    nodeID: 'hub',
-    call: vi.fn(async (action: string, params: unknown) => {
-      if (action === '$core-caps.system.info') return { uptimeSec: 99, params }
-      throw Object.assign(new Error(`Service not found: ${action}`), { type: 'SERVICE_NOT_FOUND' })
-    }),
-    waitForServices: vi.fn(async () => undefined),
-    registry: { getServiceList: () => services },
-  }
-  return broker as unknown as ServiceBroker
-}
-
-/**
- * Minimal `HubNodeRegistry`-shaped fake exposing only the lookup the unowned
- * handler uses: `listNativeCapEntriesForDevice`. The handler depends solely on
- * this method, so we don't need the full registry to exercise its routing.
- */
-function nodeRegistryFake(
-  byDevice: Record<number, readonly NodeNativeCapEntry[]> = {},
-): HubNodeRegistry {
-  const fake = {
-    listNativeCapEntriesForDevice: (deviceId: number): readonly NodeNativeCapEntry[] =>
-      byDevice[deviceId] ?? [],
-  }
-  return fake as unknown as HubNodeRegistry
-}
-
-/**
- * Hub-local UDS dispatcher fake (LocalChildRegistry surface). `resolveChildId`
- * returns the configured childId on a (capName, deviceId) match else null;
- * `callCapOnChild` records the call and echoes a sentinel result.
- */
-function localDispatcherFake(owner?: { capName: string; deviceId: number; childId: string }): {
-  dispatcher: HubLocalChildDispatcher
-  resolveChildId: ReturnType<typeof vi.fn>
-  callCapOnChild: ReturnType<typeof vi.fn>
-} {
-  const resolveChildId = vi.fn((capName: string, deviceId?: number): string | null =>
-    owner !== undefined && capName === owner.capName && deviceId === owner.deviceId
-      ? owner.childId
-      : null,
-  )
-  const callCapOnChild = vi.fn(async (childId: string, input: CapCallInput) => ({
-    routedOverUds: childId,
-    capName: input.capName,
-  }))
-  const dispatcher: HubLocalChildDispatcher = { resolveChildId, callCapOnChild }
-  return { dispatcher, resolveChildId, callCapOnChild }
-}
-
-describe('hub onUnownedCall wiring (F0)', () => {
-  it('resolver-first: resolves a hub-in-process cap through the real CapRouteResolver', async () => {
-    const broker = hubBrokerFake()
-
-    // Hub-in-process provider for `settings-store`.
-    const settingsStore = { get: async (params: unknown) => ({ value: 'hub-resolved', params }) }
-    const inProcessProviders: InProcessProviderLookup = (capName) =>
-      capName === 'settings-store'
-        ? {
-            invoke: (method, args) =>
-              Promise.resolve(
-                (settingsStore as Record<string, (a: unknown) => unknown>)[method](args),
-              ),
-          }
-        : null
-
-    const resolverDeps: CapRouteResolverDeps = {
-      hubNodeId: 'hub',
-      broker,
-      hubLocalRegistry: null,
-      nodeAuthority: emptyNodeAuthority,
-      inProcessProviders,
-    }
-    const resolver = new CapRouteResolver(resolverDeps)
-
-    const handler = createParentUnownedCallHandler({
-      getResolver: () => resolver,
-      broker,
-      nodeRegistry: nodeRegistryFake(),
-    })
-
-    const result = await handler({ capName: 'settings-store', method: 'get', args: { key: 'k' } })
-    expect(result).toEqual({ value: 'hub-resolved', params: { key: 'k' } })
-    // Resolver served it — broker untouched.
-    expect(broker.call as ReturnType<typeof vi.fn>).not.toHaveBeenCalled()
-  })
-
-  it('broker-fallback: a `$`-infra core service (`$core-caps.system.info`) routes via the broker', async () => {
-    const broker = hubBrokerFake()
-
-    // No in-process providers and no known nodes → the resolver returns
-    // no-provider for `system`, exactly as it does live for the core routers.
-    const resolver = new CapRouteResolver({
-      hubNodeId: 'hub',
-      broker,
-      hubLocalRegistry: null,
-      nodeAuthority: emptyNodeAuthority,
-      inProcessProviders: () => null,
-    })
-
-    const handler = createParentUnownedCallHandler({
-      getResolver: () => resolver,
-      broker,
-      nodeRegistry: nodeRegistryFake(),
-    })
-
-    const result = await handler({ capName: 'system', method: 'info', args: undefined })
-    expect(result).toEqual({ uptimeSec: 99, params: undefined })
-    expect(broker.call).toHaveBeenCalledWith('$core-caps.system.info', undefined, undefined)
-  })
-
-  it('pre-init safety: getResolver returns null before onModuleInit → broker fallback still works', async () => {
-    const broker = hubBrokerFake()
-    // Mirrors the window before `this.resolver` is constructed: getResolver
-    // returns null, so the handler goes straight to the broker fallback.
-    const handler = createParentUnownedCallHandler({
-      getResolver: () => null,
-      broker,
-      nodeRegistry: nodeRegistryFake(),
-    })
-
-    const result = await handler({ capName: 'system', method: 'info', args: undefined })
-    expect(result).toEqual({ uptimeSec: 99, params: undefined })
-  })
-
-  it('deviceId-aware resolver: derives deviceId from args and routes via the resolver (no broker fallback)', async () => {
-    const broker = hubBrokerFake()
-
-    // A resolver-shaped fake that resolves a route ONLY when invoked with a
-    // deviceId — mirroring the real resolver routing a device-scoped native cap
-    // to its owning provider. Without a deviceId it returns no-provider.
-    let resolvedWithDeviceId: number | undefined
-    const resolver = {
-      resolveCapRoute: (capName: string, opts: { deviceId?: number }) => {
-        if (opts.deviceId === undefined) {
-          throw new CapRouteError(capName, undefined, { reason: 'no-provider', rejected: [] })
-        }
-        resolvedWithDeviceId = opts.deviceId
-        return { kind: 'hub-in-process', capName, deviceId: opts.deviceId }
-      },
-      dispatch: async () => ({ catalog: ['stream-a'] }),
-    }
-
-    const handler = createParentUnownedCallHandler({
-      getResolver: () => resolver as unknown as CapRouteResolver,
-      broker,
-      nodeRegistry: nodeRegistryFake(),
-    })
-
-    // deviceId lives ONLY in args, NOT top-level — the handler must derive it.
-    const result = await handler({
-      capName: 'stream-catalog',
-      method: 'getCatalog',
-      args: { deviceId: 7 },
-    })
-    expect(result).toEqual({ catalog: ['stream-a'] })
-    expect(resolvedWithDeviceId).toBe(7)
-    // Resolver served it via the derived deviceId — broker untouched.
-    expect(broker.call).not.toHaveBeenCalled()
-  })
-
-  it('pinned broker fallback: resolver finds nothing → call is pinned to the owning node', async () => {
-    const broker = hubBrokerFake()
-
-    // Resolver always returns no-provider for this device-scoped cap.
-    const resolver = {
-      resolveCapRoute: (capName: string) => {
-        throw new CapRouteError(capName, undefined, { reason: 'no-provider', rejected: [] })
-      },
-      dispatch: async () => {
-        throw new Error('dispatch should not be reached')
-      },
-    }
-
-    const owner: NodeNativeCapEntry = {
-      nodeId: 'agent',
-      addonId: 'reolink',
-      capName: 'stream-catalog',
-      deviceId: 7,
-    }
-    const handler = createParentUnownedCallHandler({
-      getResolver: () => resolver as unknown as CapRouteResolver,
-      broker,
-      nodeRegistry: nodeRegistryFake({ 7: [owner] }),
-    })
-
-    await handler({ capName: 'stream-catalog', method: 'getCatalog', args: { deviceId: 7 } }).catch(
-      () => undefined,
-    )
-
-    // The broker call is pinned to the owning node via call-opts `{ nodeID }`.
-    const callArgs = (broker.call as ReturnType<typeof vi.fn>).mock.calls[0]
-    expect(callArgs[2]).toEqual({ nodeID: 'agent' })
-  })
-
-  it('back-compat: no resolvable device-owner → broker call stays UNPINNED (load-balanced)', async () => {
-    const broker = hubBrokerFake()
-
-    const resolver = {
-      resolveCapRoute: (capName: string) => {
-        throw new CapRouteError(capName, undefined, { reason: 'no-provider', rejected: [] })
-      },
-      dispatch: async () => {
-        throw new Error('dispatch should not be reached')
-      },
-    }
-
-    const handler = createParentUnownedCallHandler({
-      getResolver: () => resolver as unknown as CapRouteResolver,
-      broker,
-      nodeRegistry: nodeRegistryFake(), // no owners for any device
-    })
-
-    const result = await handler({ capName: 'system', method: 'info', args: undefined })
-    expect(result).toEqual({ uptimeSec: 99, params: undefined })
-    // Unpinned: third arg (call-opts) is undefined — today's behavior preserved.
-    const callArgs = (broker.call as ReturnType<typeof vi.fn>).mock.calls[0]
-    expect(callArgs[2]).toBeUndefined()
-  })
-
-  it('hub-local owner: device-native cap owned by a hub-local UDS child routes over UDS (broker untouched)', async () => {
-    const broker = hubBrokerFake()
-    // Resolver misses the device-scoped native cap (mirrors live behavior).
-    const resolver = {
-      resolveCapRoute: (capName: string) => {
-        throw new CapRouteError(capName, undefined, { reason: 'no-provider', rejected: [] })
-      },
-      dispatch: async () => {
-        throw new Error('dispatch should not be reached')
-      },
-    }
-    const { dispatcher, resolveChildId, callCapOnChild } = localDispatcherFake({
-      capName: 'stream-catalog',
-      deviceId: 7,
-      childId: 'child-reolink',
-    })
-
-    const handler = createParentUnownedCallHandler({
-      getResolver: () => resolver as unknown as CapRouteResolver,
-      broker,
-      nodeRegistry: nodeRegistryFake(), // empty — hub-local child is NOT in HubNodeRegistry
-      getLocalDispatcher: () => dispatcher,
-    })
-
-    const result = await handler({
-      capName: 'stream-catalog',
-      method: 'getCatalog',
-      args: { deviceId: 7 },
-    })
-    expect(result).toEqual({ routedOverUds: 'child-reolink', capName: 'stream-catalog' })
-    expect(resolveChildId).toHaveBeenCalledWith('stream-catalog', 7)
-    expect(callCapOnChild).toHaveBeenCalledWith('child-reolink', {
-      capName: 'stream-catalog',
-      method: 'getCatalog',
-      args: { deviceId: 7 },
-      deviceId: 7,
-    })
-    expect(broker.call).not.toHaveBeenCalled()
-  })
-
-  it('remote owner: hub-local dispatcher misses → pinned broker call', async () => {
-    const broker = hubBrokerFake()
-    const resolver = {
-      resolveCapRoute: (capName: string) => {
-        throw new CapRouteError(capName, undefined, { reason: 'no-provider', rejected: [] })
-      },
-      dispatch: async () => {
-        throw new Error('dispatch should not be reached')
-      },
-    }
-    const { dispatcher, callCapOnChild } = localDispatcherFake() // no local owner
-    const owner: NodeNativeCapEntry = {
-      nodeId: 'agent',
-      addonId: 'reolink',
-      capName: 'stream-catalog',
-      deviceId: 7,
-    }
-
-    const handler = createParentUnownedCallHandler({
-      getResolver: () => resolver as unknown as CapRouteResolver,
-      broker,
-      nodeRegistry: nodeRegistryFake({ 7: [owner] }),
-      getLocalDispatcher: () => dispatcher,
-    })
-
-    await handler({ capName: 'stream-catalog', method: 'getCatalog', args: { deviceId: 7 } }).catch(
-      () => undefined,
-    )
-
-    expect(callCapOnChild).not.toHaveBeenCalled()
-    const callArgs = (broker.call as ReturnType<typeof vi.fn>).mock.calls[0]
-    expect(callArgs[2]).toEqual({ nodeID: 'agent' })
-  })
-
-  it('no local dispatcher (getter returns null): behaves as before — HubNodeRegistry → broker', async () => {
-    const broker = hubBrokerFake()
-    const resolver = {
-      resolveCapRoute: (capName: string) => {
-        throw new CapRouteError(capName, undefined, { reason: 'no-provider', rejected: [] })
-      },
-      dispatch: async () => {
-        throw new Error('dispatch should not be reached')
-      },
-    }
-    const owner: NodeNativeCapEntry = {
-      nodeId: 'agent',
-      addonId: 'reolink',
-      capName: 'stream-catalog',
-      deviceId: 7,
-    }
-
-    const handler = createParentUnownedCallHandler({
-      getResolver: () => resolver as unknown as CapRouteResolver,
-      broker,
-      nodeRegistry: nodeRegistryFake({ 7: [owner] }),
-      getLocalDispatcher: () => null,
-    })
-
-    await handler({ capName: 'stream-catalog', method: 'getCatalog', args: { deviceId: 7 } }).catch(
-      () => undefined,
-    )
-    const callArgs = (broker.call as ReturnType<typeof vi.fn>).mock.calls[0]
-    expect(callArgs[2]).toEqual({ nodeID: 'agent' })
-  })
-})

package/src/__tests__/moleculer-register-node-idempotency.spec.ts

@@ -1,273 +0,0 @@
-/**
- * MoleculerService.applyNodeManifest re-handshake idempotency (D3).
- *
- * Pre-existing bug: `applyNodeManifest` ran on EVERY `$hub.registerNode`
- * and called `registry.registerProvider(cap, key, proxy)` unconditionally
- * for every cap in the manifest. The D3 protocol legitimately re-handshakes
- * (a node sends its COMPLETE manifest again — e.g. the post-device-restore
- * `nativeCaps` re-handshake). `CapabilityRegistry.registerProvider` throws
- * on a duplicate `(cap, addonId)` pair (the guard is CORRECT — it catches an
- * addon double-`initialize()`), so the second handshake threw, the
- * registering node's retry loop retried forever, and the cluster entered a
- * registration storm.
- *
- * The fix makes `applyNodeManifest` diff-based: it honours the CLAUDE.md
- * invariant "`registerNode` replaces the node's entire cap set atomically".
- * A re-handshake with the SAME manifest is a no-op; a re-handshake that
- * drops a cap unregisters exactly that cap; a re-handshake that adds a cap
- * registers only the new one. No throw, no churn.
- *
- * These specs drive the genuine `MoleculerService` registration path twice
- * for the same `nodeId` against a REAL `CapabilityRegistry` (with its real
- * duplicate guard) and assert idempotency.
- */
-import { describe, it, expect, beforeEach } from 'vitest'
-import { z } from 'zod'
-import { CapabilityRegistry } from '@camstack/kernel'
-import type { RegisterNodeParams } from '@camstack/kernel'
-import type { CapabilityDefinition, IScopedLogger, SystemEvent } from '@camstack/types'
-import { MoleculerService } from '../core/moleculer/moleculer.service.js'
-import type { EventBusService } from '../core/events/event-bus.service.js'
-import type { ConfigService } from '../core/config/config.service.js'
-import type { LoggingService } from '../core/logging/logging.service.js'
-import type { CapabilityService } from '../core/capability/capability.service.js'
-import type { StreamProbeService } from '../core/streaming/stream-probe.service.js'
-
-/**
- * Test-only view of `MoleculerService` exposing:
- *  - the genuine private registration entrypoint `onRegisterNode` — the
- *    same closure the `$hub.registerNode` Moleculer action invokes in
- *    production. Driving it directly exercises the real
- *    `nodeRegistry.registerNode` + `applyNodeManifest` path without
- *    standing up a TCP broker.
- *  - the public `createCapabilityProxy` method used to assert whether a
- *    dropped capability's call-routing entry was correctly removed from
- *    `nodeCallFns` after a reduced re-handshake.
- */
-interface RegisterNodeDriver {
-  onRegisterNode: (params: RegisterNodeParams) => void
-  createCapabilityProxy: (
-    capabilityName: string,
-    nodeId: string,
-  ) => Record<string, (params: unknown) => Promise<unknown>> | null
-}
-
-/** Build a harness whose declared caps are SINGLETON, for active-provider preference tests. */
-function createSingletonHarness(capNames: readonly string[]): Harness {
-  return createHarness(capNames, 'singleton')
-}
-
-/** A minimal real `CapabilityDefinition` so `getDefinition`/`expandCapMethods` resolve. */
-function makeCapDef(
-  name: string,
-  mode: 'collection' | 'singleton' = 'collection',
-): CapabilityDefinition {
-  return {
-    name,
-    scope: 'system',
-    mode,
-    methods: {
-      ping: {
-        input: z.object({}),
-        output: z.object({}),
-        kind: 'query',
-        auth: 'protected',
-      },
-    },
-  }
-}
-
-function makeLogger(): IScopedLogger {
-  const logger = {
-    info: () => undefined,
-    warn: () => undefined,
-    error: () => undefined,
-    debug: () => undefined,
-    trace: () => undefined,
-    fatal: () => undefined,
-    child: (() => logger) as IScopedLogger['child'],
-  }
-  return logger as unknown as IScopedLogger
-}
-
-interface Harness {
-  readonly driver: RegisterNodeDriver
-  readonly registry: CapabilityRegistry
-  readonly capNames: readonly string[]
-}
-
-/**
- * Build a real `MoleculerService` (constructor only — no broker start) wired
- * to a real `CapabilityRegistry` pre-declaring `capNames`. Returns the
- * service viewed through `RegisterNodeDriver` plus the registry to assert on.
- *
- * The broker is never started, so there is nothing to stop in teardown —
- * no `afterEach` teardown is needed.
- */
-function createHarness(
-  capNames: readonly string[],
-  mode: 'collection' | 'singleton' = 'collection',
-): Harness {
-  const registry = new CapabilityRegistry(makeLogger())
-  for (const name of capNames) {
-    registry.declareCapability(makeCapDef(name, mode))
-  }
-  // Boot-complete state — `getAllProviders` returns [] until `ready()`.
-  registry.ready()
-
-  const fakeEventBus = {
-    emit: (_event: SystemEvent) => undefined,
-    // `ReadinessRegistry` (built in the MoleculerService constructor)
-    // subscribes to `system.ready-state` + `agent.offline`. A no-op
-    // subscription returning an unsubscribe fn keeps the constructor happy.
-    subscribe: () => () => undefined,
-    getRecent: () => [],
-  } as unknown as EventBusService
-
-  const fakeConfig = {
-    get: () => undefined,
-    getAddonConfig: () => ({}),
-  } as unknown as ConfigService
-
-  const fakeLogging = {
-    createLogger: () => makeLogger(),
-    writeFromWorker: () => undefined,
-  } as unknown as LoggingService
-
-  const fakeCapability = {
-    getRegistry: () => registry,
-  } as unknown as CapabilityService
-
-  const fakeStreamProbe = {} as unknown as StreamProbeService
-
-  const service = new MoleculerService(
-    fakeEventBus,
-    fakeConfig,
-    fakeLogging,
-    fakeCapability,
-    fakeStreamProbe,
-  )
-
-  return {
-    driver: service as unknown as RegisterNodeDriver,
-    registry,
-    capNames,
-  }
-}
-
-/** Provider count for a cap on the registry — counts every registered key. */
-function providerCount(registry: CapabilityRegistry, capName: string): number {
-  return registry.getAllProviders(capName).length
-}
-
-describe('MoleculerService.applyNodeManifest — re-handshake idempotency', () => {
-  let harness: Harness
-
-  beforeEach(() => {
-    harness = createHarness(['cap-alpha', 'cap-beta'])
-  })
-
-  it('a re-handshake with the IDENTICAL manifest does not throw and leaves each provider registered exactly once', () => {
-    const manifest: RegisterNodeParams = {
-      nodeId: 'hub/reolink',
-      addons: [{ addonId: 'reolink', capabilities: ['cap-alpha', 'cap-beta'] }],
-    }
-
-    // First handshake.
-    harness.driver.onRegisterNode(manifest)
-    expect(providerCount(harness.registry, 'cap-alpha')).toBe(1)
-    expect(providerCount(harness.registry, 'cap-beta')).toBe(1)
-
-    // Re-handshake — the documented post-device-restore re-handshake.
-    // BEFORE the fix this threw `provider already registered for capability`.
-    expect(() => harness.driver.onRegisterNode(manifest)).not.toThrow()
-
-    // No duplicate, no loss — exactly one provider per cap.
-    expect(providerCount(harness.registry, 'cap-alpha')).toBe(1)
-    expect(providerCount(harness.registry, 'cap-beta')).toBe(1)
-    expect(harness.registry.getProviderByAddon('cap-alpha', 'reolink')).not.toBeNull()
-    expect(harness.registry.getProviderByAddon('cap-beta', 'reolink')).not.toBeNull()
-  })
-
-  it('three handshakes survive without throwing (registration storm regression guard)', () => {
-    const manifest: RegisterNodeParams = {
-      nodeId: 'hub/reolink',
-      addons: [{ addonId: 'reolink', capabilities: ['cap-alpha', 'cap-beta'] }],
-    }
-
-    expect(() => {
-      harness.driver.onRegisterNode(manifest)
-      harness.driver.onRegisterNode(manifest)
-      harness.driver.onRegisterNode(manifest)
-    }).not.toThrow()
-
-    expect(providerCount(harness.registry, 'cap-alpha')).toBe(1)
-    expect(providerCount(harness.registry, 'cap-beta')).toBe(1)
-  })
-
-  it('a re-handshake that DROPS one capability unregisters that provider while the others remain', () => {
-    const fullManifest: RegisterNodeParams = {
-      nodeId: 'hub/reolink',
-      addons: [{ addonId: 'reolink', capabilities: ['cap-alpha', 'cap-beta'] }],
-    }
-    const reducedManifest: RegisterNodeParams = {
-      nodeId: 'hub/reolink',
-      addons: [{ addonId: 'reolink', capabilities: ['cap-alpha'] }],
-    }
-
-    // First: full manifest — both caps registered.
-    harness.driver.onRegisterNode(fullManifest)
-    expect(providerCount(harness.registry, 'cap-alpha')).toBe(1)
-    expect(providerCount(harness.registry, 'cap-beta')).toBe(1)
-
-    // Second: identical full manifest — still idempotent, no throw.
-    expect(() => harness.driver.onRegisterNode(fullManifest)).not.toThrow()
-    expect(providerCount(harness.registry, 'cap-alpha')).toBe(1)
-    expect(providerCount(harness.registry, 'cap-beta')).toBe(1)
-
-    // Third: reduced manifest — cap-beta dropped, cap-alpha kept.
-    expect(() => harness.driver.onRegisterNode(reducedManifest)).not.toThrow()
-    expect(providerCount(harness.registry, 'cap-alpha')).toBe(1)
-    expect(providerCount(harness.registry, 'cap-beta')).toBe(0)
-    expect(harness.registry.getProviderByAddon('cap-alpha', 'reolink')).not.toBeNull()
-    expect(harness.registry.getProviderByAddon('cap-beta', 'reolink')).toBeNull()
-
-    // Verify that the call-routing entry for the dropped cap was removed
-    // from `nodeCallFns`. `createCapabilityProxy` is the public seam that
-    // delegates to `findCallFn` internally — a null return means no entry
-    // exists for that (nodeId, cap) pair, confirming the delete ran.
-    expect(harness.driver.createCapabilityProxy('cap-beta', 'hub/reolink')).toBeNull()
-    // The still-present cap must remain routable.
-    expect(harness.driver.createCapabilityProxy('cap-alpha', 'hub/reolink')).not.toBeNull()
-  })
-})
-
-describe('MoleculerService.applyNodeManifest — singleton local-first preference (UDS regression)', () => {
-  // A `placement: 'any-node'` singleton (e.g. `pipeline-executor`) can register
-  // on BOTH the hub-local forked child AND a remote agent. The hub must resolve
-  // its OWN local provider (reachable over UDS) — never the agent's proxy, whose
-  // callFn routes over Moleculer to a UDS-only agent runner that no longer hosts
-  // the service ("not found on <agent>"). First-registered-wins picked the agent.
-  const LOCAL = 'hub/detection-pipeline'
-  const REMOTE = 'dev-agent-0/detection-pipeline'
-  const singleton: (nodeId: string) => RegisterNodeParams = (nodeId) => ({
-    nodeId,
-    addons: [{ addonId: 'detection-pipeline', capabilities: ['pipeline-executor'] }],
-  })
-
-  it('prefers the hub-local provider when the REMOTE one registered first', () => {
-    const { driver, registry } = createSingletonHarness(['pipeline-executor'])
-    driver.onRegisterNode(singleton(REMOTE)) // agent first → would win under first-wins
-    driver.onRegisterNode(singleton(LOCAL)) // hub-local second
-    // Active provider must be the hub-local key (bare addonId, no '@').
-    expect(registry.getSingletonAddonId('pipeline-executor')).toBe('detection-pipeline')
-    expect(registry.getSingletonAddonId('pipeline-executor')).not.toContain('@')
-  })
-
-  it('keeps the hub-local provider active when a REMOTE one registers afterwards', () => {
-    const { driver, registry } = createSingletonHarness(['pipeline-executor'])
-    driver.onRegisterNode(singleton(LOCAL)) // hub-local first
-    driver.onRegisterNode(singleton(REMOTE)) // agent second must NOT steal active
-    expect(registry.getSingletonAddonId('pipeline-executor')).toBe('detection-pipeline')
-  })
-})