@camstack/server 0.1.8 → 0.2.1

package/src/core/addon/addon-package.service.ts

@@ -18,7 +18,7 @@ import type {
   PackageVersionInfo,
   AutoUpdateChannel,
 } from '@camstack/types'
-import { EventCategory , errMsg } from '@camstack/types'
+import { EventCategory, errMsg } from '@camstack/types'
 import {
   AddonInstaller,
   detectWorkspacePackagesDir,
@@ -74,7 +74,9 @@ function readJsonObject(filePath: string): Record<string, unknown> | null {
     if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) {
       return { ...parsed }
     }
-  } catch { /* ignore */ }
+  } catch {
+    /* ignore */
+  }
   return null
 }
 
@@ -239,9 +241,13 @@ export class AddonPackageService {
   /** Install an addon from npm registry */
   async installFromNpm(name: string, version?: string): Promise<{ name: string; version: string }> {
     this.requireInstaller()
-    this.logger.info(`installFromNpm: ${name}@${version ?? 'latest'}`, { meta: { addonsDir: this.installer!['addonsDir'] as string } })
+    this.logger.info(`installFromNpm: ${name}@${version ?? 'latest'}`, {
+      meta: { addonsDir: this.installer!['addonsDir'] as string },
+    })
     const result = await this.installer!.installFromNpm(name, version)
-    this.logger.info('installFromNpm result', { meta: { name: result.name, version: result.version } })
+    this.logger.info('installFromNpm result', {
+      meta: { name: result.name, version: result.version },
+    })
     return result
   }
 
@@ -249,7 +255,9 @@ export class AddonPackageService {
   async installFromWorkspace(name: string): Promise<{ name: string; version: string }> {
     this.requireInstaller()
     const result = await this.installer!.install(name)
-    this.logger.info('Installed from workspace', { meta: { name: result.name, version: result.version } })
+    this.logger.info('Installed from workspace', {
+      meta: { name: result.name, version: result.version },
+    })
     return result
   }
 
@@ -264,14 +272,18 @@ export class AddonPackageService {
     try {
       fs.writeFileSync(path.join(targetDir, '.install-source'), 'upload')
     } catch (err) {
-      this.logger.debug('Non-fatal: failed to write .install-source marker', { meta: { error: errMsg(err) } })
+      this.logger.debug('Non-fatal: failed to write .install-source marker', {
+        meta: { error: errMsg(err) },
+      })
     }
     this.installer!.manifest.upsert(result.name, {
       version: result.version,
       source: 'upload',
     })
 
-    this.logger.info('Installed from upload', { meta: { name: result.name, version: result.version } })
+    this.logger.info('Installed from upload', {
+      meta: { name: result.name, version: result.version },
+    })
     return result
   }
 
@@ -359,7 +371,9 @@ export class AddonPackageService {
 
     try {
       const installResult = await this.installFromNpm(packageName, version)
-      this.logger.info('npm install complete', { meta: { name: installResult.name, version: installResult.version } })
+      this.logger.info('npm install complete', {
+        meta: { name: installResult.name, version: installResult.version },
+      })
     } catch (err) {
       const msg = errMsg(err)
       this.logger.error('npm install failed', { meta: { packageName, error: msg } })
@@ -412,7 +426,9 @@ export class AddonPackageService {
 
     try {
       const result = await this.installFromWorkspace(packageName)
-      this.logger.info('Workspace install complete', { meta: { name: result.name, version: result.version } })
+      this.logger.info('Workspace install complete', {
+        meta: { name: result.name, version: result.version },
+      })
     } catch (err) {
       const msg = errMsg(err)
       this.logger.error('Workspace install failed', { meta: { error: msg } })
@@ -422,7 +438,11 @@ export class AddonPackageService {
 
     try {
       await this.reloadPackages()
-    } catch (err) { this.logger.warn('Non-fatal: failed to reload packages after workspace install', { meta: { error: errMsg(err) } }) }
+    } catch (err) {
+      this.logger.warn('Non-fatal: failed to reload packages after workspace install', {
+        meta: { error: errMsg(err) },
+      })
+    }
 
     let loaded: string[] = []
     let failed: string[] = []
@@ -468,8 +488,16 @@ export class AddonPackageService {
       throw new Error(`Uninstall failed: ${msg}`, { cause: err })
     }
 
-    await this.reloadPackages().catch((err) => { this.logger.warn('Non-fatal: failed to reload packages after uninstall', { meta: { error: errMsg(err) } }) })
-    await this.addonRegistry.loadNewAddons().catch((err) => { this.logger.warn('Non-fatal: failed to load new addons after uninstall', { meta: { error: errMsg(err) } }) })
+    await this.reloadPackages().catch((err) => {
+      this.logger.warn('Non-fatal: failed to reload packages after uninstall', {
+        meta: { error: errMsg(err) },
+      })
+    })
+    await this.addonRegistry.loadNewAddons().catch((err) => {
+      this.logger.warn('Non-fatal: failed to load new addons after uninstall', {
+        meta: { error: errMsg(err) },
+      })
+    })
 
     this.toastService.broadcast({
       title: 'Addon Uninstalled',
@@ -516,7 +544,9 @@ export class AddonPackageService {
           installed: installed.has(name),
         })
       }
-    } catch (err) { this.logger.warn('Failed to read workspace directory', { meta: { error: errMsg(err) } }) }
+    } catch (err) {
+      this.logger.warn('Failed to read workspace directory', { meta: { error: errMsg(err) } })
+    }
 
     return results
   }
@@ -528,7 +558,9 @@ export class AddonPackageService {
   /** List all installed addon packages */
   listInstalled(): InstalledPackage[] {
     if (!this.installer) {
-      throw new Error('AddonInstaller is not available — cannot list installed packages. Ensure @camstack/kernel is installed and the addons directory is accessible')
+      throw new Error(
+        'AddonInstaller is not available — cannot list installed packages. Ensure @camstack/kernel is installed and the addons directory is accessible',
+      )
     }
     return this.installer.listInstalled()
   }
@@ -597,7 +629,16 @@ export class AddonPackageService {
     const addonUpdates = await this.checkAddonPackageUpdates()
     updates.push(...addonUpdates)
 
-    this.logger.info('Found package updates', { meta: { count: updates.length, updates: updates.map((u) => ({ name: u.name, currentVersion: u.currentVersion, latestVersion: u.latestVersion })) } })
+    this.logger.info('Found package updates', {
+      meta: {
+        count: updates.length,
+        updates: updates.map((u) => ({
+          name: u.name,
+          currentVersion: u.currentVersion,
+          latestVersion: u.latestVersion,
+        })),
+      },
+    })
 
     this.cachedUpdates = {
       updates,
@@ -730,7 +771,9 @@ export class AddonPackageService {
       })
 
       if (!response.ok) {
-        this.logger.debug('Registry returned non-ok status', { meta: { name, status: response.status } })
+        this.logger.debug('Registry returned non-ok status', {
+          meta: { name, status: response.status },
+        })
         return []
       }
 
@@ -748,17 +791,15 @@ export class AddonPackageService {
         tagsByVersion.set(verStr, [...existing, tag])
       }
 
-      const result: PackageVersionInfo[] = Object.entries(versions).map(
-        ([ver, rawMeta]) => {
-          const meta = asRecord(rawMeta)
-          return {
-            version: ver,
-            publishedAt: asString(time[ver]),
-            deprecated: typeof meta['deprecated'] === 'string' ? meta['deprecated'] : undefined,
-            distTags: tagsByVersion.get(ver) ?? [],
-          }
-        },
-      )
+      const result: PackageVersionInfo[] = Object.entries(versions).map(([ver, rawMeta]) => {
+        const meta = asRecord(rawMeta)
+        return {
+          version: ver,
+          publishedAt: asString(time[ver]),
+          deprecated: typeof meta['deprecated'] === 'string' ? meta['deprecated'] : undefined,
+          distTags: tagsByVersion.get(ver) ?? [],
+        }
+      })
 
       // Sort by published date descending (newest first)
       result.sort((a, b) => {
@@ -844,7 +885,9 @@ export class AddonPackageService {
         // Emit addon.updated lifecycle event
         this.addonRegistry.emitUpdateEvent(name, previousVersion, updatedVersion)
 
-        this.logger.info('Addon package updated, triggering hot-reload', { meta: { name, updatedVersion } })
+        this.logger.info('Addon package updated, triggering hot-reload', {
+          meta: { name, updatedVersion },
+        })
         const addonId = this.extractAddonId(name)
         if (addonId) {
           try {
@@ -857,10 +900,10 @@ export class AddonPackageService {
             }
           } catch (reloadError: unknown) {
             const msg = errMsg(reloadError)
-            this.logger.warn(
-              'Hot-reload failed for addon — backup retained for rollback',
-              { tags: { addonId }, meta: { error: msg, backupDir: result.backupDir } },
-            )
+            this.logger.warn('Hot-reload failed for addon — backup retained for rollback', {
+              tags: { addonId },
+              meta: { error: msg, backupDir: result.backupDir },
+            })
           }
         }
 
@@ -887,7 +930,9 @@ export class AddonPackageService {
       // Invalidate cache after update
       this.cachedUpdates = null
 
-      this.logger.info('Core package updated -- restart required', { meta: { name, updatedVersion } })
+      this.logger.info('Core package updated -- restart required', {
+        meta: { name, updatedVersion },
+      })
       this.sendUpdateNotification(name, updatedVersion)
       return { success: true, version: updatedVersion, requiresRestart: true }
     } catch (error: unknown) {
@@ -921,9 +966,12 @@ export class AddonPackageService {
       writePendingRestart(this.resolveDataDir(), payload)
     } catch (err) {
       // Marker write failure shouldn't block the restart — log + continue.
-      this.logger.warn('Failed to write restart marker; restart will proceed without completion toast', {
-        meta: { error: errMsg(err) },
-      })
+      this.logger.warn(
+        'Failed to write restart marker; restart will proceed without completion toast',
+        {
+          meta: { error: errMsg(err) },
+        },
+      )
     }
 
     this.eventBusService.emit({
@@ -954,28 +1002,37 @@ export class AddonPackageService {
    * snapshot returns in roughly the slowest individual lookup, not
    * the sum.
    */
-  async listFrameworkPackages(): Promise<readonly {
-    packageName: string
-    currentVersion: string
-    latestVersion: string | null
-    hasUpdate: boolean
-    description?: string
-  }[]> {
+  async listFrameworkPackages(): Promise<
+    readonly {
+      packageName: string
+      currentVersion: string
+      latestVersion: string | null
+      hasUpdate: boolean
+      description?: string
+    }[]
+  > {
     const registry = process.env['CAMSTACK_NPM_REGISTRY']
 
     const rows = await Promise.all(
       FRAMEWORK_PACKAGE_ALLOWLIST.map(async (packageName) => {
         const manifest = readResolvedPackageManifest(packageName)
-        const currentVersion = manifest !== null && typeof manifest['version'] === 'string'
-          ? manifest['version']
-          : 'unknown'
-        const description = manifest !== null && typeof manifest['description'] === 'string'
-          ? manifest['description']
-          : undefined
+        const currentVersion =
+          manifest !== null && typeof manifest['version'] === 'string'
+            ? manifest['version']
+            : 'unknown'
+        const description =
+          manifest !== null && typeof manifest['description'] === 'string'
+            ? manifest['description']
+            : undefined
 
         let latestVersion: string | null = null
         try {
-          const args = ['view', `${packageName}@latest`, 'version', ...buildNpmRegistryArgs(registry)]
+          const args = [
+            'view',
+            `${packageName}@latest`,
+            'version',
+            ...buildNpmRegistryArgs(registry),
+          ]
           const { stdout } = await execFileAsync('npm', args, { timeout: 15_000 })
           const trimmed = stdout.trim()
           latestVersion = trimmed.length > 0 ? trimmed : null
@@ -985,9 +1042,8 @@ export class AddonPackageService {
           })
         }
 
-        const hasUpdate = latestVersion !== null
-          && currentVersion !== 'unknown'
-          && latestVersion !== currentVersion
+        const hasUpdate =
+          latestVersion !== null && currentVersion !== 'unknown' && latestVersion !== currentVersion
 
         return {
           packageName,
@@ -1038,11 +1094,16 @@ export class AddonPackageService {
 
     const appRoot = resolveFrameworkPackageAppRoot(packageName, this.logger)
     const fromManifest = readResolvedPackageManifest(packageName)
-    const fromVersion = fromManifest !== null && typeof fromManifest['version'] === 'string'
-      ? fromManifest['version']
-      : 'unknown'
+    const fromVersion =
+      fromManifest !== null && typeof fromManifest['version'] === 'string'
+        ? fromManifest['version']
+        : 'unknown'
     const requestedVersion = input.version ?? 'latest'
-    const toVersion = await resolveNpmVersion(packageName, requestedVersion, process.env['CAMSTACK_NPM_REGISTRY'])
+    const toVersion = await resolveNpmVersion(
+      packageName,
+      requestedVersion,
+      process.env['CAMSTACK_NPM_REGISTRY'],
+    )
     const spec = `${packageName}@${toVersion}`
 
     this.logger.info('updateFrameworkPackage: installing', {
@@ -1050,7 +1111,14 @@ export class AddonPackageService {
     })
 
     const registry = process.env['CAMSTACK_NPM_REGISTRY']
-    const args = ['install', '--prefix', appRoot, spec, '--no-save', ...buildNpmRegistryArgs(registry)]
+    const args = [
+      'install',
+      '--prefix',
+      appRoot,
+      spec,
+      '--no-save',
+      ...buildNpmRegistryArgs(registry),
+    ]
     await execFileAsync('npm', args, { timeout: 180_000 })
 
     if (input.deferRestart === true) {
@@ -1140,7 +1208,10 @@ export class AddonPackageService {
   }
 
   /** Set global auto-update settings and restart the timer */
-  async setAutoUpdateSettings(channel: 'off' | 'latest' | 'beta', intervalSeconds?: number): Promise<void> {
+  async setAutoUpdateSettings(
+    channel: 'off' | 'latest' | 'beta',
+    intervalSeconds?: number,
+  ): Promise<void> {
     this.autoUpdateConfig = {
       ...this.autoUpdateConfig,
       global: {
@@ -1158,7 +1229,10 @@ export class AddonPackageService {
   }
 
   /** Set per-addon auto-update override */
-  async setAddonAutoUpdate(addonId: string, channel: 'off' | 'latest' | 'beta' | 'inherit'): Promise<void> {
+  async setAddonAutoUpdate(
+    addonId: string,
+    channel: 'off' | 'latest' | 'beta' | 'inherit',
+  ): Promise<void> {
     const newOverrides = { ...this.autoUpdateConfig.overrides }
     if (channel === 'inherit') {
       delete newOverrides[addonId]
@@ -1183,10 +1257,12 @@ export class AddonPackageService {
     }
 
     const intervalMs = this.autoUpdateConfig.global.intervalSeconds * 1000
-    this.logger.info(
-      'Auto-update scheduled',
-      { meta: { intervalSeconds: this.autoUpdateConfig.global.intervalSeconds, channel: this.autoUpdateConfig.global.channel } },
-    )
+    this.logger.info('Auto-update scheduled', {
+      meta: {
+        intervalSeconds: this.autoUpdateConfig.global.intervalSeconds,
+        channel: this.autoUpdateConfig.global.channel,
+      },
+    })
 
     this.autoUpdateTimer = setInterval(() => {
       this.runAutoUpdate().catch((err) => {
@@ -1226,23 +1302,25 @@ export class AddonPackageService {
         const distTags = asRecord(data['dist-tags'])
 
         // Determine target version based on channel
-        const targetVersion = effectiveChannel === 'beta'
-          ? asString(distTags['beta']) || asString(distTags['latest'])
-          : asString(distTags['latest'])
+        const targetVersion =
+          effectiveChannel === 'beta'
+            ? asString(distTags['beta']) || asString(distTags['latest'])
+            : asString(distTags['latest'])
 
         if (!targetVersion || targetVersion === pkg.version) continue
 
-        this.logger.info(
-          'Auto-updating package',
-          { meta: { name: pkg.name, currentVersion: pkg.version, targetVersion, channel: effectiveChannel } },
-        )
+        this.logger.info('Auto-updating package', {
+          meta: {
+            name: pkg.name,
+            currentVersion: pkg.version,
+            targetVersion,
+            channel: effectiveChannel,
+          },
+        })
         await this.updatePackage(pkg.name, targetVersion)
         updatedCount++
       } catch (err) {
-        this.logger.warn(
-          'Auto-update failed',
-          { meta: { name: pkg.name, error: errMsg(err) } },
-        )
+        this.logger.warn('Auto-update failed', { meta: { name: pkg.name, error: errMsg(err) } })
       }
     }
 
@@ -1271,7 +1349,8 @@ export class AddonPackageService {
           return {
             global: {
               channel: validChannel,
-              intervalSeconds: typeof global['intervalSeconds'] === 'number' ? global['intervalSeconds'] : 3600,
+              intervalSeconds:
+                typeof global['intervalSeconds'] === 'number' ? global['intervalSeconds'] : 3600,
             },
             overrides: Object.fromEntries(
               Object.entries(asRecord(raw['overrides'])).map(([k, v]) => {
@@ -1285,7 +1364,9 @@ export class AddonPackageService {
         }
       }
     } catch (err) {
-      this.logger.debug('Corrupt auto-update config, falling back to defaults', { meta: { error: errMsg(err) } })
+      this.logger.debug('Corrupt auto-update config, falling back to defaults', {
+        meta: { error: errMsg(err) },
+      })
     }
     return { global: { channel: 'off', intervalSeconds: 21600 }, overrides: {} }
   }
@@ -1380,7 +1461,9 @@ export class AddonPackageService {
         }
       } catch (error: unknown) {
         const msg = errMsg(error)
-        this.logger.debug('Failed to check updates for addon', { meta: { pkgJsonPath, error: msg } })
+        this.logger.debug('Failed to check updates for addon', {
+          meta: { pkgJsonPath, error: msg },
+        })
       }
     }
 
@@ -1417,7 +1500,9 @@ export class AddonPackageService {
         signal: AbortSignal.timeout(AddonPackageService.REGISTRY_TIMEOUT_MS),
       })
       if (!response.ok) {
-        this.logger.debug('Registry returned non-ok status', { meta: { packageName, status: response.status } })
+        this.logger.debug('Registry returned non-ok status', {
+          meta: { packageName, status: response.status },
+        })
         return null
       }
       const data = await fetchJsonObject(response)
@@ -1432,11 +1517,15 @@ export class AddonPackageService {
 
   /** Fetch npm search results for camstack addon packages (cached 5 min) */
   private async fetchSearchFromNpm(): Promise<readonly NpmSearchResult[]> {
-    if (this.searchCache && Date.now() - this.searchCache.timestamp < AddonPackageService.SEARCH_CACHE_TTL_MS) {
+    if (
+      this.searchCache &&
+      Date.now() - this.searchCache.timestamp < AddonPackageService.SEARCH_CACHE_TTL_MS
+    ) {
       return this.searchCache.results
     }
 
-    const url = 'https://registry.npmjs.org/-/v1/search?text=keywords:camstack+keywords:addon&size=250'
+    const url =
+      'https://registry.npmjs.org/-/v1/search?text=keywords:camstack+keywords:addon&size=250'
 
     try {
       const response = await fetch(url, {
@@ -1497,7 +1586,9 @@ export class AddonPackageService {
         if (v) return v
       }
     } catch (err) {
-      this.logger.debug('Version lookup via fs failed, trying require.resolve', { meta: { packageName, error: errMsg(err) } })
+      this.logger.debug('Version lookup via fs failed, trying require.resolve', {
+        meta: { packageName, error: errMsg(err) },
+      })
     }
 
     try {
@@ -1505,7 +1596,9 @@ export class AddonPackageService {
       const pkgJson = readJsonObject(pkgJsonPath)
       return asString(pkgJson?.['version'], '0.0.0')
     } catch (err) {
-      this.logger.debug('Could not resolve version, returning 0.0.0', { meta: { packageName, error: errMsg(err) } })
+      this.logger.debug('Could not resolve version, returning 0.0.0', {
+        meta: { packageName, error: errMsg(err) },
+      })
       return '0.0.0'
     }
   }
@@ -1535,7 +1628,6 @@ export class AddonPackageService {
     return path.resolve(dataPath, 'addons')
   }
 
-
   /** Throw if installer was not initialised */
   private requireInstaller(): void {
     if (!this.installer) {
@@ -1606,10 +1698,7 @@ function buildNpmRegistryArgs(registry: string | undefined): readonly string[] {
  * `npm install --prefix` side-effects into an isolated temp dir instead of
  * the workspace's `server/backend/node_modules/`. Never set in production.
  */
-function resolveFrameworkPackageAppRoot(
-  packageName: string,
-  logger: IScopedLogger,
-): string {
+function resolveFrameworkPackageAppRoot(packageName: string, logger: IScopedLogger): string {
   const override = process.env['CAMSTACK_FRAMEWORK_APP_ROOT_OVERRIDE']
   if (override !== undefined && override.length > 0) {
     return override
@@ -1675,7 +1764,12 @@ async function resolveNpmVersion(
   versionSpec: string,
   registry: string | undefined,
 ): Promise<string> {
-  const args = ['view', `${packageName}@${versionSpec}`, 'version', ...buildNpmRegistryArgs(registry)]
+  const args = [
+    'view',
+    `${packageName}@${versionSpec}`,
+    'version',
+    ...buildNpmRegistryArgs(registry),
+  ]
   try {
     const { stdout } = await execFileAsync('npm', args, { timeout: 30_000 })
     const trimmed = stdout.trim()