@camstack/addon-terminal 0.1.156 → 0.1.157

package/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.1.157] - 2026-10-31
+
+### Changed
+
+- Deleting a terminal whose node left the cluster now completes instead of hanging
+
 ## [0.1.156] - 2026-10-30
 
 ### Changed

package/dist/addon.js

@@ -97868,6 +97868,8 @@ var SNAPSHOT_SETTLE_MAX_PULLS = 20;
 var CLOSE_RETRY_BASE_MS = 50;
 var CLOSE_RETRY_MAX_MS = 1e3;
 var CLOSE_ATTEMPTS_PER_PASS = 3;
+/** How long a delete/edit waits for a node to acknowledge a camera close. */
+var CLOSE_INSTANCE_MAX_WAIT_MS = 5e3;
 function relayKey(instanceId) {
 	return instanceId;
 }
@@ -98222,18 +98224,43 @@ var TerminalCameraRelay = class {
 			if (state.clients === 0 && state.leases === 0) await this.closeState(state);
 		}
 	}
-	/** Stop a withdrawn/offline camera's relay, including active HTTP readers. */
-	async closeInstance(instanceId) {
+	/**
+	* Stop a withdrawn/offline camera's relay, including active HTTP readers.
+	*
+	* The remote close/open is addressed to the instance's node. A node that
+	* left the cluster never answers, so the wait is bounded: the retrying
+	* cleanup keeps running in the background, but a caller (a delete, an edit)
+	* is never held hostage by a node that cannot reply.
+	*/
+	async closeInstance(instanceId, maxWaitMs = CLOSE_INSTANCE_MAX_WAIT_MS) {
 		const state = this.states.get(relayKey(instanceId));
 		if (!state) return;
 		for (const response of state.responses) response.destroy();
 		state.responses.clear();
 		state.clients = 0;
 		state.leases = 0;
-		await this.closeState(state);
-		if (state.openPromise) {
-			await state.openPromise.catch(() => {});
+		const closing = (async () => {
 			await this.closeState(state);
+			if (state.openPromise) {
+				await state.openPromise.catch(() => {});
+				await this.closeState(state);
+			}
+		})();
+		let timer;
+		const bound = new Promise((resolve) => {
+			timer = setTimeout(() => resolve("timeout"), maxWaitMs);
+		});
+		const outcome = await Promise.race([closing.then(() => "closed"), bound]);
+		if (timer) clearTimeout(timer);
+		if (outcome === "timeout") {
+			closing.catch(() => {});
+			this.logger.warn("terminal camera close still pending — node did not answer; continuing", {
+				...this.tagsFor(instanceId),
+				meta: {
+					nodeId: state.nodeId,
+					waitedMs: maxWaitMs
+				}
+			});
 		}
 	}
 	async dispose() {
@@ -99547,11 +99574,17 @@ var TerminalAddon = class extends BaseAddon {
 			} });
 		});
 		this.terminalCameraTombstones.add(instance.cameraStableId);
-		await this.cameraRelay?.closeInstance(instance.id);
 		await this.updateGlobalSettings({
 			terminalInstances: this.config.terminalInstances.filter((candidate) => candidate.id !== instanceId),
 			terminalCameraTombstones: [...new Set([...this.config.terminalCameraTombstones, instance.cameraStableId])]
 		});
+		await this.cameraRelay?.closeInstance(instance.id).catch((error) => {
+			this.ctx.logger.warn("could not close the deleted Terminal instance session", { meta: {
+				instanceId: instance.id,
+				nodeId: instance.nodeId,
+				error: error instanceof Error ? error.message : String(error)
+			} });
+		});
 	}
 	async setTerminalInstanceEnabled(instanceId, enabled) {
 		const instance = await this.instanceMutationQueue.run(() => this.setTerminalInstanceEnabledUnlocked(instanceId, enabled));

package/dist/addon.mjs

@@ -97845,6 +97845,8 @@ var SNAPSHOT_SETTLE_MAX_PULLS = 20;
 var CLOSE_RETRY_BASE_MS = 50;
 var CLOSE_RETRY_MAX_MS = 1e3;
 var CLOSE_ATTEMPTS_PER_PASS = 3;
+/** How long a delete/edit waits for a node to acknowledge a camera close. */
+var CLOSE_INSTANCE_MAX_WAIT_MS = 5e3;
 function relayKey(instanceId) {
 	return instanceId;
 }
@@ -98199,18 +98201,43 @@ var TerminalCameraRelay = class {
 			if (state.clients === 0 && state.leases === 0) await this.closeState(state);
 		}
 	}
-	/** Stop a withdrawn/offline camera's relay, including active HTTP readers. */
-	async closeInstance(instanceId) {
+	/**
+	* Stop a withdrawn/offline camera's relay, including active HTTP readers.
+	*
+	* The remote close/open is addressed to the instance's node. A node that
+	* left the cluster never answers, so the wait is bounded: the retrying
+	* cleanup keeps running in the background, but a caller (a delete, an edit)
+	* is never held hostage by a node that cannot reply.
+	*/
+	async closeInstance(instanceId, maxWaitMs = CLOSE_INSTANCE_MAX_WAIT_MS) {
 		const state = this.states.get(relayKey(instanceId));
 		if (!state) return;
 		for (const response of state.responses) response.destroy();
 		state.responses.clear();
 		state.clients = 0;
 		state.leases = 0;
-		await this.closeState(state);
-		if (state.openPromise) {
-			await state.openPromise.catch(() => {});
+		const closing = (async () => {
 			await this.closeState(state);
+			if (state.openPromise) {
+				await state.openPromise.catch(() => {});
+				await this.closeState(state);
+			}
+		})();
+		let timer;
+		const bound = new Promise((resolve) => {
+			timer = setTimeout(() => resolve("timeout"), maxWaitMs);
+		});
+		const outcome = await Promise.race([closing.then(() => "closed"), bound]);
+		if (timer) clearTimeout(timer);
+		if (outcome === "timeout") {
+			closing.catch(() => {});
+			this.logger.warn("terminal camera close still pending — node did not answer; continuing", {
+				...this.tagsFor(instanceId),
+				meta: {
+					nodeId: state.nodeId,
+					waitedMs: maxWaitMs
+				}
+			});
 		}
 	}
 	async dispose() {
@@ -99524,11 +99551,17 @@ var TerminalAddon = class extends BaseAddon {
 			} });
 		});
 		this.terminalCameraTombstones.add(instance.cameraStableId);
-		await this.cameraRelay?.closeInstance(instance.id);
 		await this.updateGlobalSettings({
 			terminalInstances: this.config.terminalInstances.filter((candidate) => candidate.id !== instanceId),
 			terminalCameraTombstones: [...new Set([...this.config.terminalCameraTombstones, instance.cameraStableId])]
 		});
+		await this.cameraRelay?.closeInstance(instance.id).catch((error) => {
+			this.ctx.logger.warn("could not close the deleted Terminal instance session", { meta: {
+				instanceId: instance.id,
+				nodeId: instance.nodeId,
+				error: error instanceof Error ? error.message : String(error)
+			} });
+		});
 	}
 	async setTerminalInstanceEnabled(instanceId, enabled) {
 		const instance = await this.instanceMutationQueue.run(() => this.setTerminalInstanceEnabledUnlocked(instanceId, enabled));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camstack/addon-terminal",
-  "version": "0.1.156",
+  "version": "0.1.157",
   "description": "Interactive terminal sessions (pty + xterm) as a CamStack addon",
   "keywords": [
     "camstack",