@camstack/addon-provider-unifi 0.2.152 → 0.2.153

package/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.153] - 2026-11-01
+
+### Changed
+
+- An integration deleted while its provider was down now has its orphan devices removed after two concordant reads of the integration list
+
 ## [0.2.152] - 2026-11-01
 
 ### Changed

package/dist/addon.js

@@ -94497,6 +94497,88 @@ DEFAULT_NATIVE_LEASE_SETTINGS.activityMs;
 DEFAULT_NATIVE_LEASE_SETTINGS.tileBudgetMb;
 DEFAULT_NATIVE_LEASE_SETTINGS.sceneBudgetMb;
 DEFAULT_NATIVE_LEASE_SETTINGS.admission;
+/**
+* Closes the gap D49 leaves: an integration deleted while its provider was down never emits an
+* event the provider sees. An integration id absent from an ANSWERED list is only a suspect; its
+* devices go (through the provider's own removeDevices) when a SECOND answered read, at least
+* `minIntervalMs` later, still lacks it. A read that threw changes nothing; reappearing clears.
+*/
+var OrphanIntegrationSweep = class {
+	#logger;
+	#minIntervalMs;
+	#now;
+	#suspects = /* @__PURE__ */ new Map();
+	constructor(options) {
+		this.#logger = options.logger;
+		this.#minIntervalMs = options.minIntervalMs ?? 6e4;
+		this.#now = options.now ?? Date.now;
+	}
+	get minIntervalMs() {
+		return this.#minIntervalMs;
+	}
+	async sweep(input) {
+		if (input.listedIds === null) return {
+			newSuspects: 0,
+			removed: []
+		};
+		const listed = new Set(input.listedIds);
+		const owners = new Set(input.ownerIds);
+		const now = this.#now();
+		let newSuspects = 0;
+		const removed = [];
+		for (const id of [...this.#suspects.keys()]) if (listed.has(id) || !owners.has(id)) {
+			this.#suspects.delete(id);
+			this.#logger.info("Orphan integration suspect cleared", { meta: {
+				integrationId: id,
+				reason: listed.has(id) ? "listed again" : "owns no devices"
+			} });
+		}
+		for (const id of owners) {
+			if (listed.has(id)) continue;
+			const since = this.#suspects.get(id);
+			if (since === void 0) {
+				this.#suspects.set(id, now);
+				newSuspects += 1;
+				this.#logger.info("Integration owns devices but is absent from the list — suspect", { meta: {
+					integrationId: id,
+					minIntervalMs: this.#minIntervalMs
+				} });
+				continue;
+			}
+			if (now - since < this.#minIntervalMs) continue;
+			try {
+				const count = await input.removeDevices(id);
+				this.#suspects.delete(id);
+				removed.push(id);
+				this.#logger.warn("Orphan integration devices removed — absent from two answered lists", { meta: {
+					integrationId: id,
+					removed: count,
+					firstMissingAt: since
+				} });
+			} catch (err) {
+				this.#logger.warn("Orphan integration device removal failed — kept as suspect", { meta: {
+					integrationId: id,
+					error: errMsg(err)
+				} });
+			}
+		}
+		return {
+			newSuspects,
+			removed
+		};
+	}
+};
+/** The integration ids that own top-level devices of one provider (a config that cannot be read is skipped). */
+async function collectOwnerIntegrationIds(input) {
+	const ids = /* @__PURE__ */ new Set();
+	for (const d of input.reg.getAllForAddon(input.addonId)) {
+		if (d.parentDeviceId !== null) continue;
+		const cfg = await input.devices.loadConfig(d.id).catch(() => ({}));
+		const owner = input.ownerOf(cfg);
+		if (owner !== null) ids.add(owner);
+	}
+	return [...ids];
+}
 String.raw`(?<=^|["'(\s>,\[{])`;
 var MB = 1024 * 1024;
 1024 * MB, 3072 * MB;
@@ -96001,8 +96083,14 @@ async function reconcileInfraFeatures(input) {
 */
 var UnifiReconciler = class {
 	#deps;
+	#sweep;
+	#rerun = null;
 	constructor(deps) {
 		this.#deps = deps;
+		this.#sweep = new OrphanIntegrationSweep({
+			logger: deps.logger,
+			...deps.sweepOptions
+		});
 	}
 	/** Upsert a client per usable enabled integration; drop the CLIENT (never devices) of one the list answered is gone. */
 	async reconcile() {
@@ -96025,6 +96113,37 @@ var UnifiReconciler = class {
 		}
 		const enabledIds = new Set(enabled.map((i) => i.id));
 		for (const id of clients.list()) if (!enabledIds.has(id)) await clients.remove(id);
+		await this.#sweepOrphans(all.map((i) => i.id));
+	}
+	/** Stop the scheduled second read (addon stop). */
+	dispose() {
+		if (this.#rerun !== null) clearTimeout(this.#rerun);
+		this.#rerun = null;
+	}
+	/**
+	* An integration deleted while this addon was down emits nothing it sees: its id owns devices
+	* yet is absent from the ANSWERED list. Removal needs a second answered read later, so one
+	* re-run is scheduled when a suspect appears (bounded: one timer, no retry loop).
+	*/
+	async #sweepOrphans(listedIds) {
+		const { ownerIntegrationIds, removeDevices, logger } = this.#deps;
+		if (ownerIntegrationIds === void 0) return;
+		try {
+			const ownerIds = await ownerIntegrationIds();
+			if ((await this.#sweep.sweep({
+				ownerIds,
+				listedIds,
+				removeDevices
+			})).newSuspects > 0 && this.#rerun === null) {
+				this.#rerun = setTimeout(() => {
+					this.#rerun = null;
+					this.reconcile();
+				}, this.#sweep.minIntervalMs + 1e3);
+				this.#rerun.unref();
+			}
+		} catch (err) {
+			logger.warn("Orphan integration sweep failed — devices left as they are", { meta: { error: errMsg(err) } });
+		}
 	}
 	/** An explicit lifecycle event: only `deleted` / `disabled` of a named integration remove devices. */
 	async onLifecycle(kind, integrationId) {
@@ -96150,6 +96269,7 @@ var UnifiProviderAddon = class extends BaseDeviceProvider {
 			this.ctx.logger.warn("UniFi shutdown error", { meta: { error: errMsg(err) } });
 		}
 		this.clients = null;
+		this.integrationReconciler?.dispose();
 		this.integrationReconciler = null;
 		unifiControllers.clear();
 		await super.onShutdown();
@@ -96184,7 +96304,8 @@ var UnifiProviderAddon = class extends BaseDeviceProvider {
 				await reg.upsert(integration.id, integration.name, read.connection, read.credentialsLocked);
 				return true;
 			},
-			removeDevices: (integrationId) => this.cascadeRemoveDevicesForIntegration(integrationId)
+			removeDevices: (integrationId) => this.cascadeRemoveDevicesForIntegration(integrationId),
+			ownerIntegrationIds: () => this.ownerIntegrationIds()
 		});
 		return this.integrationReconciler;
 	}
@@ -96203,6 +96324,21 @@ var UnifiProviderAddon = class extends BaseDeviceProvider {
 		this.ctx.eventBus.subscribe({ category: EventCategory.IntegrationDisabled }, on("disabled"));
 		this.ctx.eventBus.subscribe({ category: EventCategory.IntegrationDeleted }, on("deleted"));
 	}
+	/** The integrations that own devices here, for the orphan sweep. */
+	async ownerIntegrationIds() {
+		const reg = this.ctx.kernel.deviceRegistry;
+		const devices = this.ctx.kernel.devices;
+		if (!reg || !devices) return [];
+		return await collectOwnerIntegrationIds({
+			reg,
+			devices,
+			addonId: this.addonId,
+			ownerOf: (cfg) => {
+				const owner = cfg["integrationId"];
+				return cfg["system"] === "unifi" && typeof owner === "string" ? owner : null;
+			}
+		});
+	}
 	async cascadeRemoveDevicesForIntegration(integrationId) {
 		const reg = this.ctx.kernel.deviceRegistry;
 		const devices = this.ctx.kernel.devices;

package/dist/addon.mjs

@@ -94496,6 +94496,88 @@ DEFAULT_NATIVE_LEASE_SETTINGS.activityMs;
 DEFAULT_NATIVE_LEASE_SETTINGS.tileBudgetMb;
 DEFAULT_NATIVE_LEASE_SETTINGS.sceneBudgetMb;
 DEFAULT_NATIVE_LEASE_SETTINGS.admission;
+/**
+* Closes the gap D49 leaves: an integration deleted while its provider was down never emits an
+* event the provider sees. An integration id absent from an ANSWERED list is only a suspect; its
+* devices go (through the provider's own removeDevices) when a SECOND answered read, at least
+* `minIntervalMs` later, still lacks it. A read that threw changes nothing; reappearing clears.
+*/
+var OrphanIntegrationSweep = class {
+	#logger;
+	#minIntervalMs;
+	#now;
+	#suspects = /* @__PURE__ */ new Map();
+	constructor(options) {
+		this.#logger = options.logger;
+		this.#minIntervalMs = options.minIntervalMs ?? 6e4;
+		this.#now = options.now ?? Date.now;
+	}
+	get minIntervalMs() {
+		return this.#minIntervalMs;
+	}
+	async sweep(input) {
+		if (input.listedIds === null) return {
+			newSuspects: 0,
+			removed: []
+		};
+		const listed = new Set(input.listedIds);
+		const owners = new Set(input.ownerIds);
+		const now = this.#now();
+		let newSuspects = 0;
+		const removed = [];
+		for (const id of [...this.#suspects.keys()]) if (listed.has(id) || !owners.has(id)) {
+			this.#suspects.delete(id);
+			this.#logger.info("Orphan integration suspect cleared", { meta: {
+				integrationId: id,
+				reason: listed.has(id) ? "listed again" : "owns no devices"
+			} });
+		}
+		for (const id of owners) {
+			if (listed.has(id)) continue;
+			const since = this.#suspects.get(id);
+			if (since === void 0) {
+				this.#suspects.set(id, now);
+				newSuspects += 1;
+				this.#logger.info("Integration owns devices but is absent from the list — suspect", { meta: {
+					integrationId: id,
+					minIntervalMs: this.#minIntervalMs
+				} });
+				continue;
+			}
+			if (now - since < this.#minIntervalMs) continue;
+			try {
+				const count = await input.removeDevices(id);
+				this.#suspects.delete(id);
+				removed.push(id);
+				this.#logger.warn("Orphan integration devices removed — absent from two answered lists", { meta: {
+					integrationId: id,
+					removed: count,
+					firstMissingAt: since
+				} });
+			} catch (err) {
+				this.#logger.warn("Orphan integration device removal failed — kept as suspect", { meta: {
+					integrationId: id,
+					error: errMsg(err)
+				} });
+			}
+		}
+		return {
+			newSuspects,
+			removed
+		};
+	}
+};
+/** The integration ids that own top-level devices of one provider (a config that cannot be read is skipped). */
+async function collectOwnerIntegrationIds(input) {
+	const ids = /* @__PURE__ */ new Set();
+	for (const d of input.reg.getAllForAddon(input.addonId)) {
+		if (d.parentDeviceId !== null) continue;
+		const cfg = await input.devices.loadConfig(d.id).catch(() => ({}));
+		const owner = input.ownerOf(cfg);
+		if (owner !== null) ids.add(owner);
+	}
+	return [...ids];
+}
 String.raw`(?<=^|["'(\s>,\[{])`;
 var MB = 1024 * 1024;
 1024 * MB, 3072 * MB;
@@ -96000,8 +96082,14 @@ async function reconcileInfraFeatures(input) {
 */
 var UnifiReconciler = class {
 	#deps;
+	#sweep;
+	#rerun = null;
 	constructor(deps) {
 		this.#deps = deps;
+		this.#sweep = new OrphanIntegrationSweep({
+			logger: deps.logger,
+			...deps.sweepOptions
+		});
 	}
 	/** Upsert a client per usable enabled integration; drop the CLIENT (never devices) of one the list answered is gone. */
 	async reconcile() {
@@ -96024,6 +96112,37 @@ var UnifiReconciler = class {
 		}
 		const enabledIds = new Set(enabled.map((i) => i.id));
 		for (const id of clients.list()) if (!enabledIds.has(id)) await clients.remove(id);
+		await this.#sweepOrphans(all.map((i) => i.id));
+	}
+	/** Stop the scheduled second read (addon stop). */
+	dispose() {
+		if (this.#rerun !== null) clearTimeout(this.#rerun);
+		this.#rerun = null;
+	}
+	/**
+	* An integration deleted while this addon was down emits nothing it sees: its id owns devices
+	* yet is absent from the ANSWERED list. Removal needs a second answered read later, so one
+	* re-run is scheduled when a suspect appears (bounded: one timer, no retry loop).
+	*/
+	async #sweepOrphans(listedIds) {
+		const { ownerIntegrationIds, removeDevices, logger } = this.#deps;
+		if (ownerIntegrationIds === void 0) return;
+		try {
+			const ownerIds = await ownerIntegrationIds();
+			if ((await this.#sweep.sweep({
+				ownerIds,
+				listedIds,
+				removeDevices
+			})).newSuspects > 0 && this.#rerun === null) {
+				this.#rerun = setTimeout(() => {
+					this.#rerun = null;
+					this.reconcile();
+				}, this.#sweep.minIntervalMs + 1e3);
+				this.#rerun.unref();
+			}
+		} catch (err) {
+			logger.warn("Orphan integration sweep failed — devices left as they are", { meta: { error: errMsg(err) } });
+		}
 	}
 	/** An explicit lifecycle event: only `deleted` / `disabled` of a named integration remove devices. */
 	async onLifecycle(kind, integrationId) {
@@ -96149,6 +96268,7 @@ var UnifiProviderAddon = class extends BaseDeviceProvider {
 			this.ctx.logger.warn("UniFi shutdown error", { meta: { error: errMsg(err) } });
 		}
 		this.clients = null;
+		this.integrationReconciler?.dispose();
 		this.integrationReconciler = null;
 		unifiControllers.clear();
 		await super.onShutdown();
@@ -96183,7 +96303,8 @@ var UnifiProviderAddon = class extends BaseDeviceProvider {
 				await reg.upsert(integration.id, integration.name, read.connection, read.credentialsLocked);
 				return true;
 			},
-			removeDevices: (integrationId) => this.cascadeRemoveDevicesForIntegration(integrationId)
+			removeDevices: (integrationId) => this.cascadeRemoveDevicesForIntegration(integrationId),
+			ownerIntegrationIds: () => this.ownerIntegrationIds()
 		});
 		return this.integrationReconciler;
 	}
@@ -96202,6 +96323,21 @@ var UnifiProviderAddon = class extends BaseDeviceProvider {
 		this.ctx.eventBus.subscribe({ category: EventCategory.IntegrationDisabled }, on("disabled"));
 		this.ctx.eventBus.subscribe({ category: EventCategory.IntegrationDeleted }, on("deleted"));
 	}
+	/** The integrations that own devices here, for the orphan sweep. */
+	async ownerIntegrationIds() {
+		const reg = this.ctx.kernel.deviceRegistry;
+		const devices = this.ctx.kernel.devices;
+		if (!reg || !devices) return [];
+		return await collectOwnerIntegrationIds({
+			reg,
+			devices,
+			addonId: this.addonId,
+			ownerOf: (cfg) => {
+				const owner = cfg["integrationId"];
+				return cfg["system"] === "unifi" && typeof owner === "string" ? owner : null;
+			}
+		});
+	}
 	async cascadeRemoveDevicesForIntegration(integrationId) {
 		const reg = this.ctx.kernel.deviceRegistry;
 		const devices = this.ctx.kernel.devices;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camstack/addon-provider-unifi",
-  "version": "0.2.152",
+  "version": "0.2.153",
   "description": "UniFi Network controller device-provider addon for CamStack — local-controller infra switches/APs (as containers) + network-client presence. No cameras.",
   "keywords": [
     "camstack",
@@ -59,7 +59,7 @@
       }
     ],
     "requires": {
-      "server": ">=1.2.719"
+      "server": ">=1.2.722"
     }
   },
   "files": [