@camstack/addon-provider-amcrest 0.2.75 → 0.2.77

package/dist/addon.js

@@ -33873,6 +33873,53 @@ var BaseDeviceProvider = class extends BaseAddon {
 		const ids = [...this._permanentRestoreFailures.keys()].join(", ");
 		return `${this._permanentRestoreFailures.size} device(s) permanently failed restore (deviceIds: ${ids}) — restart the ${this.providerName} provider to retry`;
 	}
+	/**
+	* A top-level persisted row with NO configuration is a leftover, not a
+	* device — quarantine it instead of dialling it.
+	*
+	* Device 614 was deleted, resurrected as a config-less shell by a write
+	* already in flight (D376), and then dialled at every single boot: eight
+	* `Failed to restore device — bounded retry scheduled` lines in one day,
+	* each one the same Zod refusal on `host` and `password`. The bound was
+	* real, but it is a bound PER PROCESS, and the runner restarts — so nothing
+	* about the row ever stopped costing attempts and log lines.
+	*
+	* No retry can add a configuration that is not there. The row is reported
+	* once, with its `deviceId`, and set aside.
+	*
+	* Top-level only: an accessory child legitimately carries an empty blob (it
+	* lives off its parent), and a hub-adopted child with an emptied blob is
+	* repaired by `healSavedConfig` from its parent instead. Providers that
+	* genuinely create configuration-free top-level devices turn this off.
+	*/
+	quarantineConfiglessTopLevelRestores = true;
+	isUnrestorableShell(saved) {
+		if (!this.quarantineConfiglessTopLevelRestores) return false;
+		if (saved.parentDeviceId !== null) return false;
+		const config = saved.config;
+		if (config === void 0) return false;
+		return Object.keys(config).length === 0;
+	}
+	quarantineShell(saved) {
+		this._permanentRestoreFailures.set(saved.id, {
+			deviceId: saved.id,
+			stableId: saved.stableId,
+			type: saved.type,
+			attempts: 0,
+			lastError: "persisted row has no configuration",
+			failedAt: Date.now()
+		});
+		this.ctx.logger.error("Persisted device row has NO configuration — quarantined: not restored, not retried. Remove it (deviceManager.removeDevice) or re-add the device.", {
+			tags: {
+				deviceId: saved.id,
+				stableId: saved.stableId
+			},
+			meta: {
+				type: saved.type,
+				provider: this.providerName
+			}
+		});
+	}
 	cancelRestoreRetries() {
 		this._restoreRetryScheduler?.cancel();
 		this._restoreRetryScheduler = null;
@@ -34057,6 +34104,10 @@ var BaseDeviceProvider = class extends BaseAddon {
 				});
 				return;
 			}
+			if (this.isUnrestorableShell(saved)) {
+				this.quarantineShell(saved);
+				return;
+			}
 			try {
 				await attemptRestore(saved);
 			} catch (err) {

package/dist/addon.mjs

@@ -33874,6 +33874,53 @@ var BaseDeviceProvider = class extends BaseAddon {
 		const ids = [...this._permanentRestoreFailures.keys()].join(", ");
 		return `${this._permanentRestoreFailures.size} device(s) permanently failed restore (deviceIds: ${ids}) — restart the ${this.providerName} provider to retry`;
 	}
+	/**
+	* A top-level persisted row with NO configuration is a leftover, not a
+	* device — quarantine it instead of dialling it.
+	*
+	* Device 614 was deleted, resurrected as a config-less shell by a write
+	* already in flight (D376), and then dialled at every single boot: eight
+	* `Failed to restore device — bounded retry scheduled` lines in one day,
+	* each one the same Zod refusal on `host` and `password`. The bound was
+	* real, but it is a bound PER PROCESS, and the runner restarts — so nothing
+	* about the row ever stopped costing attempts and log lines.
+	*
+	* No retry can add a configuration that is not there. The row is reported
+	* once, with its `deviceId`, and set aside.
+	*
+	* Top-level only: an accessory child legitimately carries an empty blob (it
+	* lives off its parent), and a hub-adopted child with an emptied blob is
+	* repaired by `healSavedConfig` from its parent instead. Providers that
+	* genuinely create configuration-free top-level devices turn this off.
+	*/
+	quarantineConfiglessTopLevelRestores = true;
+	isUnrestorableShell(saved) {
+		if (!this.quarantineConfiglessTopLevelRestores) return false;
+		if (saved.parentDeviceId !== null) return false;
+		const config = saved.config;
+		if (config === void 0) return false;
+		return Object.keys(config).length === 0;
+	}
+	quarantineShell(saved) {
+		this._permanentRestoreFailures.set(saved.id, {
+			deviceId: saved.id,
+			stableId: saved.stableId,
+			type: saved.type,
+			attempts: 0,
+			lastError: "persisted row has no configuration",
+			failedAt: Date.now()
+		});
+		this.ctx.logger.error("Persisted device row has NO configuration — quarantined: not restored, not retried. Remove it (deviceManager.removeDevice) or re-add the device.", {
+			tags: {
+				deviceId: saved.id,
+				stableId: saved.stableId
+			},
+			meta: {
+				type: saved.type,
+				provider: this.providerName
+			}
+		});
+	}
 	cancelRestoreRetries() {
 		this._restoreRetryScheduler?.cancel();
 		this._restoreRetryScheduler = null;
@@ -34058,6 +34105,10 @@ var BaseDeviceProvider = class extends BaseAddon {
 				});
 				return;
 			}
+			if (this.isUnrestorableShell(saved)) {
+				this.quarantineShell(saved);
+				return;
+			}
 			try {
 				await attemptRestore(saved);
 			} catch (err) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@camstack/addon-provider-amcrest",
-  "version": "0.2.75",
+  "version": "0.2.77",
   "description": "Amcrest/Dahua camera device provider addon for CamStack — Dahua CGI over HTTP(S) with digest auth (snapshot, RTSP catalog, PTZ, image/day-night config)",
   "keywords": [
     "camstack",